naver_map 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0a9753ab46ddc8aa9f771d61493d727e50574428
-  data.tar.gz: a5b3378f7419ba62087b63980d4bcbdb4269995d
+  metadata.gz: 5d8d9f1c46030d5b2509621c5c4b7c1d11e395c5
+  data.tar.gz: 93c0795ddd0944b81bff9211e659266533bb22ab
 SHA512:
-  metadata.gz: b11c4a1313fbdffead9dc0c4d6672f84dead2e7d4a3c2fd7062992c367b4634c11b140187f0e6a3b03a7dc777066577655f1a0933c8928dc8f3e256d035b089f
-  data.tar.gz: '0389957419970006b5f7f165694409e7fca6d89e0b7b0a0d4409d9b2605c0e511535d4b84f89ace7ce2746cc2cad8196ea4d53618979057bbc4fee272b0d4464'
+  metadata.gz: ab76059381cac9f5a6e736f87f87964827e9ce5471f4cc6829dbd25b2facafd01b63e3ab1de3394c5feb5ca395f5f05a95806efccc25ef6a67a6df6b1ffa1594
+  data.tar.gz: 3d93fe65eb61a0a258f2bf670178fb7194a0e2ea2c2c2ac8e127c2cf199250dec4acdcb6b2cd14be9ffd5550054e11b153c97632ae857edfdc9243fedb7d05b6

data/.gitignore

@@ -61,6 +61,7 @@ build-iPhoneSimulator/
 .idea/dictionaries
 .idea/vcs.xml
 .idea/jsLibraryMappings.xml
+.idea/.rakeTasks
 
 # Sensitive or high-churn files:
 .idea/dataSources.ids
@@ -98,4 +99,7 @@ crashlytics-build.properties
 fabric.properties
 
 icon.png
-test/
+
+# ctags
+tags
+.tags

data/.ruby-version

@@ -0,0 +1 @@
+2.3.1

data/.travis.yml

@@ -0,0 +1,4 @@
+language: ruby
+bundler_args: --jobs=2
+script: bundle exec rake test
+cache: bundler

data/Gemfile

@@ -3,5 +3,9 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in naver_map.gemspec
 gemspec
 
-gem 'rest-client', '2.0.0'
-gem 'rspec'
+gem 'rest-client', '~> 2.0.0'
+gem 'minitest', '~> 5.8.3'
+
+group :development, :test do
+  gem 'rake', '~> 11.2.2'
+end

data/Gemfile.lock

@@ -1,13 +1,11 @@
 PATH
   remote: .
   specs:
-    naver_map (0.1.0)
-      rest-client (~> 2.0.0, >= 2.0.0)
+    naver_map (0.1.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    diff-lcs (1.2.5)
     domain_name (0.5.20161021)
       unf (>= 0.0.5, < 1.0.0)
     http-cookie (1.0.3)
@@ -15,25 +13,13 @@ GEM
     mime-types (3.1)
       mime-types-data (~> 3.2015)
     mime-types-data (3.2016.0521)
+    minitest (5.8.3)
     netrc (0.11.0)
-    rake (10.4.2)
+    rake (11.2.2)
     rest-client (2.0.0)
       http-cookie (>= 1.0.2, < 2.0)
       mime-types (>= 1.16, < 4.0)
       netrc (~> 0.8)
-    rspec (3.5.0)
-      rspec-core (~> 3.5.0)
-      rspec-expectations (~> 3.5.0)
-      rspec-mocks (~> 3.5.0)
-    rspec-core (3.5.4)
-      rspec-support (~> 3.5.0)
-    rspec-expectations (3.5.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-mocks (3.5.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-support (3.5.0)
     unf (0.1.4)
       unf_ext
     unf_ext (0.0.7.2)
@@ -43,10 +29,10 @@ PLATFORMS
 
 DEPENDENCIES
   bundler (~> 1.13)
+  minitest (~> 5.8.3)
   naver_map!
-  rake (~> 10.0)
-  rest-client (= 2.0.0)
-  rspec
+  rake (~> 11.2.2)
+  rest-client (~> 2.0.0)
 
 BUNDLED WITH
    1.13.6

data/README.md

@@ -1,5 +1,8 @@
 # NaverMap
 
+[![Gem Version](https://badge.fury.io/rb/naver_map.svg)](https://badge.fury.io/rb/naver_map)
+[![Build Status](https://travis-ci.org/say8425/naver_map_ruby.svg?branch=master)](https://travis-ci.org/say8425/naver_map_ruby)
+
 This is ruby gem for using Naver Map API.
 
 ## Installation
@@ -28,13 +31,20 @@ city_hall = NaverMap.new('input your client id', 'input your client secret')
 
 First you need to confirm your Naver API client id and client secret key. You can confirm it at [Naver Developer Application page](https://developers.naver.com/appinfo).
 Then you can initialize `naver_map` with your client id and client secret key.
+
+### Get coordinates with address 
  
 ```ruby
 city_hall.address_to_coordinates('서울특별시 중구 세종대로 110 서울특별시청')
 => [{:x=>126.9783882, :y=>37.5666103}] 
 ```
 
-Current version of naver_map gem can only show coordinates through address.
+You can get coordinates with your inputting address. This return is array, cuz coordinates can be multiplle value.
+But we are plan to when return is single value then make return is not array.
+
+### Getting address with coordinates
+
+
 
 ## Contributing
 

data/Rakefile

@@ -1,2 +1,5 @@
 require "bundler/gem_tasks"
-task :default => :spec
+task :default => :test
+task :test do
+  Dir.glob('./test/*_test.rb').each { |file| require file}
+end

data/lib/naver_map.rb

@@ -5,36 +5,43 @@ require 'json'
 class NaverMap
   attr_accessor :client_id, :client_secret
 
+  GEOCODE_REQUEST_URL = 'https://openapi.naver.com/v1/map/geocode'.freeze
+  REVERSE_GEOCODE_URL = 'https://openapi.naver.com/v1/map/reversegeocode'.freeze
+
   def initialize(client_id, client_secret)
     @client_id = client_id
     @client_secret = client_secret
   end
 
   def address_to_coordinates(address)
-    begin
-      url = 'https://openapi.naver.com/v1/map/geocode'
-      response = RestClient.get(url, params: { query: address }, 'X-Naver-Client-Id': @client_id,
-                                'X-Naver-Client-Secret': @client_secret)
-      result = JSON.parse(response.body, symbolize_names: true)[:result]
-      result[:items].map do |element| element[:point] end
-    rescue RestClient::ExceptionWithResponse => err
-      err.response.body
-    end
+    response = query(GEOCODE_REQUEST_URL, address)
+    get_result(response.body)[:items].map { |element| element[:point] }
   end
 
-
-  def query(address)
-    begin
-      url = 'https://openapi.naver.com/v1/map/geocode'
-      response = RestClient.get(url, params: { query: address }, 'X-Naver-Client-Id': @client_id,
-                                'X-Naver-Client-Secret': @client_secret)
-      JSON.parse(response.body, symbolize_names: true)[:result]
-    rescue RestClient::ExceptionWithResponse => err
-      err.response.body
-    end
+  def coordinates_to_address(axis_x, axis_y)
+    response = query(REVERSE_GEOCODE_URL, axis_x, axis_y)
+    get_result(response.body)[:items].map { |element| element[:address] }
   end
 
   def to_s
-    "Client ID: #{@client_id}, Client Secret: #{@client_secret}"
+    "Client ID: #{client_id}, Client Secret: #{client_secret}"
+  end
+
+  private
+
+  def get_result(body)
+    JSON.parse(body, symbolize_names: true)[:result]
+  end
+
+  def request_to_naver(url, *params)
+    RestClient.get(url, params: { query: params.join(',') },
+                   'X-Naver-Client-Id': client_id,
+                   'X-Naver-Client-Secret': client_secret)
+  end
+
+  def query(url, *params)
+    request_to_naver(url, params)
+  rescue RestClient::ExceptionWithResponse => err
+    err.response.body
   end
-end
+end

data/lib/naver_map/version.rb

@@ -1,3 +1,3 @@
 class NaverMap
-  VERSION = '0.1.1'
+  VERSION = '0.2.0'
 end

data/naver_map.gemspec

@@ -32,7 +32,4 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler", "~> 1.13"
-  spec.add_development_dependency "rake", "~> 10.0"
-
-  spec.add_dependency "rest-client", "~> 2.0.0", ">=2.0.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: naver_map
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Penguin
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-11-03 00:00:00.000000000 Z
+date: 2016-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -24,40 +24,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.13'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.0'
-- !ruby/object:Gem::Dependency
-  name: rest-client
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 2.0.0
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.0.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 2.0.0
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.0.0
 description: |-
   Naver support map API. But we don't have any ruby gem for this API.
                           So You can use it with this gem comfortable.
@@ -70,6 +36,8 @@ files:
 - ".idea/encodings.xml"
 - ".idea/misc.xml"
 - ".idea/modules.xml"
+- ".ruby-version"
+- ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
 - Gemfile.lock