natural_born_slugger 0.2.6 → 0.2.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3a99cb7ed1ade9fca52412d4eeab883b445246d1
-  data.tar.gz: 67ca1e0caaa35375ac69e62ce53da0a15aedbbc5
+  metadata.gz: 712e46ba34e1b21b65631322811981931c7e7256
+  data.tar.gz: ae7612996c63070c01f7daaa6ddd9ea4ff00c9c0
 SHA512:
-  metadata.gz: ad9335f5efd6b0c7cd207d578ed00b29e9bb44892231daa9d608f527285e2bf0b6694a350b59feb5b41de9b495293a7d9fc48fe4aad18bd6a71b1253afa869d3
-  data.tar.gz: 6eb45a73640ca09d73a0d24401cf7e55d3a6bbf145487528eaf283c754228a101e9a905e5c3b584928b342d789f8ff1874839c7124e0fb14b6031b08e4eb7e6b
+  metadata.gz: d3b830832ce523e5a201caa51cf3cfb23ae594ce382ce74ac7eda00b8f765f6df7432813301ed034b7fb44e69aafb1c73989c8a606a6eccf3fcac37b29193d8e
+  data.tar.gz: 0a0038a32ab4f63e6167d6e6d3b8de45706a8667fdbf9b2c73b5bca95fe5c51447d52d45a11d83b3ad04307071f925a9856ea9fc34d981594011cfcfff55b379

data/.gitignore

@@ -3,7 +3,6 @@
 .bundle
 .config
 .yardoc
-Gemfile.lock
 InstalledFiles
 _yardoc
 builds

data/Gemfile.lock

@@ -0,0 +1,53 @@
+PATH
+  remote: .
+  specs:
+    natural_born_slugger (0.2.6)
+      activesupport (>= 3.1)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activesupport (4.0.0)
+      i18n (~> 0.6, >= 0.6.4)
+      minitest (~> 4.2)
+      multi_json (~> 1.3)
+      thread_safe (~> 0.1)
+      tzinfo (~> 0.3.37)
+    atomic (1.1.13)
+    coderay (1.0.9)
+    diff-lcs (1.2.4)
+    i18n (0.6.5)
+    method_source (0.8.2)
+    minitest (4.7.5)
+    multi_json (1.7.9)
+    pry (0.9.12.2)
+      coderay (~> 1.0.5)
+      method_source (~> 0.8)
+      slop (~> 3.4)
+    rake (10.1.0)
+    redcarpet (2.3.0)
+    rspec (2.14.1)
+      rspec-core (~> 2.14.0)
+      rspec-expectations (~> 2.14.0)
+      rspec-mocks (~> 2.14.0)
+    rspec-core (2.14.5)
+    rspec-expectations (2.14.2)
+      diff-lcs (>= 1.1.3, < 2.0)
+    rspec-mocks (2.14.3)
+    slop (3.4.6)
+    thread_safe (0.1.2)
+      atomic
+    tzinfo (0.3.37)
+    yard (0.8.7)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  bundler (~> 1.3)
+  natural_born_slugger!
+  pry
+  rake (~> 10.0)
+  redcarpet (~> 2.2)
+  rspec (~> 2.13)
+  yard (~> 0.8)

data/lib/natural_born_slugger/attribute_composer.rb

@@ -90,20 +90,28 @@ module NaturalBornSlugger
       klass.composite_attributes ||= {}
       klass.composite_attributes[@name] = self
 
-      # Define instance attribute getter: calls setter
-      klass.send :define_method, @name do
-        name = __method__.to_s
-        composer = self.class.composite_attributes[name]
-        old_value = self.instance_variable_get("@#{name}")
-        new_value = composer.evaluate(self)
+      klass.send :define_method, "update_#{@name}".to_sym do
+        name = __method__.to_s.gsub 'update_', ''
+        new_value = self.class.composite_attributes[name].evaluate(self)
         if self.respond_to? "#{name}=".to_sym
           new_value = self.send "#{name}=".to_sym, new_value
         end
         self.instance_variable_set("@#{name}", new_value)
-        composer.callback(self, old_value, new_value)
+        #TODO: What is the fate of callbacks? Should the feature be removed? Potential race condition if the value was mutated by the callback
+        #composer.callback(self, old_value, new_value)
         new_value
       end
 
+      # Define instance attribute getter: calls setter
+      klass.send :define_method, @name do
+        name = __method__.to_s
+        if frozen?
+          self.instance_variable_get("@#{name}")
+        else
+          self.send "update_#{name}".to_sym
+        end
+      end
+
     end
 
   end

data/lib/natural_born_slugger/version.rb

@@ -1,3 +1,3 @@
 module NaturalBornSlugger
-  VERSION = "0.2.6"
+  VERSION = "0.2.7"
 end

data/spec/natural_born_slugger/attribute_builder_spec.rb

@@ -56,7 +56,24 @@ describe NaturalBornSlugger::AttributeComposer do
 
 
   context 'instance methods' do
-
+    context '#add_to' do
+      subject (:target) { FreezableObject.new }
+      describe 'an object with a composite attribute' do
+        it 'should have a method named after the composite attribute' do
+          target.respond_to?(:natural_key).should be_true
+        end
+        it 'should have a method used to update the attribute' do
+          target.respond_to?(:update_natural_key).should be_true
+        end
+      end
+      describe 'a frozen object' do
+        it 'should not auto update composite attributes' do
+          target.freeze
+          expect { target }.not_to receive(:update_natural_key)
+          target.natural_key
+        end
+      end
+    end
     describe '#compose_attribute' do
 
     end
@@ -67,4 +84,7 @@ describe NaturalBornSlugger::AttributeComposer do
 
   end
 
+
+
+
 end

data/spec/support/example.rb

@@ -34,3 +34,10 @@ class ExampleGrandChild
     'grandchild method'
   end
 end
+
+class FreezableObject
+  include NaturalBornSlugger
+  attr_accessor :name
+  has_natural_key name: :dashify
+
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: natural_born_slugger
 version: !ruby/object:Gem::Version
-  version: 0.2.6
+  version: 0.2.7
 platform: ruby
 authors:
 - Christopher Keele
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-10 00:00:00.000000000 Z
+date: 2013-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -119,6 +119,7 @@ files:
 - .gitignore
 - .rspec
 - Gemfile
+- Gemfile.lock
 - LICENSE.md
 - README.md
 - Rakefile
@@ -170,3 +171,4 @@ test_files:
 - spec/natural_born_slugger_spec.rb
 - spec/spec_helper.rb
 - spec/support/example.rb
+has_rdoc: