natives 0.5.2 → 0.5.3

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MjdhYzVkMjU3YmYzMDRmNzIwMWMyOGVmNTZhYjM3ZGQ4ODdhNmQ5MA==
+    NGJiYWNiZGIzY2JkMjQzNzQyNmY0NDdmYjQ5M2Y0YWNhMjVlNTJjNg==
   data.tar.gz: !binary |-
-    MmVhMGEzZjVkOGU2ODJmZTExOTU3ODlmZWI3MDhjZGFmZTUwZDAzMg==
+    MmExZGFlMGEzNjcxNTlkNDAxNjc1Y2ZkMzk0ZTk0NzFiY2FmOTZjNw==
 SHA512:
   metadata.gz: !binary |-
-    ZmY3ZmJjMmYzYjU2OWMzNjhhMjE3NWU3MTU2Y2NmOTlmNDUzNmJhNWFlMGNj
-    Y2ZkNzU2NmIxOGE3MjgzMjhlYTg1OTkxMzhkY2I0ZDc4MzI1ZGJiYTgzNzkx
-    ZmU0YTZlMDE1NGJiNjljOWVmMzkwNDNhNWY4MDdlOWNhOGMxNTU=
+    NDJiMTNiZjg0MWRmNWJmMjc0YTkyMWE2ZDdmOTM1YmExYzU0ZGJhMTAzOWM3
+    NjQyYTE1OWRkN2NjZGMxNTU0NWY4MzA1NDQ4MGQ1OTNlYzliNTFmMzAwNjk4
+    MTBjNjcyZjVhZmVjNzI3ZTdkOTE1Yzk3MWM4NWJlNDczNzg5Mzg=
   data.tar.gz: !binary |-
-    NGM0Zjc0OTQzNTFhMzlhZDQ3YzVjZjEyNDMxNjY4ODAzMWQ4ZWE4YmRjMDIz
-    YWE5ZjNmMmQ0MzE5ZTJjNjIyMjkyYzE2NjkyMTIzOGZiYjc2MzEzZGFmNWQ2
-    OGZkNmNmYTg0OGJhZWNkYTUwNGRmOTYzNmU5Njc4ZTNjMzEzN2Y=
+    Nzg0ZjBmYjZmYjJiMzAwODUzNTZmODk1ZWIyN2M4MWI3NmVhODMyM2Y5YjZh
+    NjJhNTBkYjBhNzExMDlkOGMwMzEyNTljZGIzNDIyMTQ0MTQ3ZWI4ZjU0MzVm
+    MWQyZjc5MzY3OWVkMTExMTA2ZTY2Mjc5YjJiYjc1NjU1YzAwMmY=

data/Gemfile

@@ -2,6 +2,7 @@ source "http://rubygems.org"
 # Add dependencies required to use your gem here.
 gem "ohai"
 gem "thor"
+gem "bundler"
 
 # Add dependencies to develop your gem here.
 # Include everything needed to run rake, tests, features, etc.

data/VERSION

@@ -1 +1 @@
-0.5.2
+0.5.3

data/lib/natives/gemfile_viewer.rb

@@ -1,38 +1,16 @@
+require 'bundler'
+
 module Natives
   class GemfileViewer
     def initialize(gemfile_path)
       @gemfile_path = gemfile_path
+      @lockfile_path = "#{gemfile_path}.lock"
     end
 
     def gem_names
-      extract_gem_names(bundle_list(@gemfile_path))
+      lockfile = Bundler::LockfileParser.new(Bundler.read_file(@lockfile_path))
+      lockfile.specs.map(&:name)
     end
 
-    protected
-
-    def bundle_list(gemfile_path)
-      # after trial-and-error, these steps work best:
-      # 1. cd to dir containing the gemfile
-      # 2. bundle list
-      dir = File.expand_path(File.dirname(@gemfile_path))
-      filename = File.basename(@gemfile_path)
-      output = %x{cd '#{dir}' && BUNDLE_GEMFILE=#{filename} bundle list 2>&1}
-      successful_run = ($?.exitstatus == 0)
-
-      unless successful_run
-        raise "Cannot list gems in gemfile #{@gemfile_path.inspect}: #{output}"
-      end
-
-      output
-    end
-
-    def extract_gem_names(output)
-      lines = output.split("\n")
-      lines.shift # remove first line
-      lines.map do |line|
-        _, name, _ = line.split(" ")
-        name
-      end
-    end
   end
 end

data/natives.gemspec

@@ -2,15 +2,15 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: natives 0.5.2 ruby lib
+# stub: natives 0.5.3 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "natives"
-  s.version = "0.5.2"
+  s.version = "0.5.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Huiming Teo"]
-  s.date = "2013-11-09"
+  s.date = "2013-11-11"
   s.description = "Lookup native package dependencies required by gems on your machine."
   s.email = "teohuiming@gmail.com"
   s.executables = ["natives"]
@@ -53,6 +53,9 @@ Gem::Specification.new do |s|
     "natives.gemspec",
     "spec/fixtures/Gemfile.empty",
     "spec/fixtures/Gemfile.empty.lock",
+    "spec/fixtures/Gemfile.no_lockfile",
+    "spec/fixtures/Gemfile.with_lockfile",
+    "spec/fixtures/Gemfile.with_lockfile.lock",
     "spec/fixtures/dir_with_matching_files/invalid1.yml",
     "spec/fixtures/dir_with_matching_files/not_matching.json",
     "spec/fixtures/dir_with_matching_files/valid1.yaml",
@@ -83,6 +86,7 @@ Gem::Specification.new do |s|
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
       s.add_runtime_dependency(%q<ohai>, [">= 0"])
       s.add_runtime_dependency(%q<thor>, [">= 0"])
+      s.add_runtime_dependency(%q<bundler>, [">= 0"])
       s.add_development_dependency(%q<rspec>, [">= 0"])
       s.add_development_dependency(%q<yard>, [">= 0"])
       s.add_development_dependency(%q<rdoc>, [">= 0"])
@@ -93,6 +97,7 @@ Gem::Specification.new do |s|
     else
       s.add_dependency(%q<ohai>, [">= 0"])
       s.add_dependency(%q<thor>, [">= 0"])
+      s.add_dependency(%q<bundler>, [">= 0"])
       s.add_dependency(%q<rspec>, [">= 0"])
       s.add_dependency(%q<yard>, [">= 0"])
       s.add_dependency(%q<rdoc>, [">= 0"])
@@ -104,6 +109,7 @@ Gem::Specification.new do |s|
   else
     s.add_dependency(%q<ohai>, [">= 0"])
     s.add_dependency(%q<thor>, [">= 0"])
+    s.add_dependency(%q<bundler>, [">= 0"])
     s.add_dependency(%q<rspec>, [">= 0"])
     s.add_dependency(%q<yard>, [">= 0"])
     s.add_dependency(%q<rdoc>, [">= 0"])

data/spec/fixtures/Gemfile.no_lockfile

@@ -0,0 +1,5 @@
+source "http://rubygems.org"
+
+gem "bundler"
+gem "curb"
+

data/spec/fixtures/Gemfile.with_lockfile

@@ -0,0 +1,4 @@
+source "http://rubygems.org"
+
+gem "bundler"
+gem "curb"

data/spec/fixtures/Gemfile.with_lockfile.lock

@@ -0,0 +1,11 @@
+GEM
+  remote: http://rubygems.org/
+  specs:
+    curb (0.8.5)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  bundler
+  curb

data/spec/natives/gemfile_viewer_spec.rb

@@ -4,9 +4,16 @@ require 'natives/gemfile_viewer'
 describe Natives::GemfileViewer do
   describe "#packages" do
     it "list all gems specified in gemfile" do
-      gemfile_path = File.join(fixture_path, "Gemfile.empty")
+      gemfile_path = File.join(fixture_path, "Gemfile.with_lockfile")
       gemfile = Natives::GemfileViewer.new(gemfile_path)
-      expect(gemfile.gem_names).to eq(['bundler'])
+      expect(gemfile.gem_names).to eq(['curb'])
+      # not sure why 'bundler' gem is always excluded from the list
+    end
+
+    it "raises error when gemfile does not have lockfile" do
+      gemfile_path = File.join(fixture_path, "Gemfile.no_lockfile")
+      gemfile = Natives::GemfileViewer.new(gemfile_path)
+      expect { gemfile.gem_names }.to raise_error
     end
 
     it "raises error when failed to list gems in gemfile" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: natives
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.5.3
 platform: ruby
 authors:
 - Huiming Teo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-09 00:00:00.000000000 Z
+date: 2013-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ohai
@@ -38,6 +38,20 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -179,6 +193,9 @@ files:
 - natives.gemspec
 - spec/fixtures/Gemfile.empty
 - spec/fixtures/Gemfile.empty.lock
+- spec/fixtures/Gemfile.no_lockfile
+- spec/fixtures/Gemfile.with_lockfile
+- spec/fixtures/Gemfile.with_lockfile.lock
 - spec/fixtures/dir_with_matching_files/invalid1.yml
 - spec/fixtures/dir_with_matching_files/not_matching.json
 - spec/fixtures/dir_with_matching_files/valid1.yaml