national_bank_of_romania 0.0.1 → 0.0.2

data/CHANGELOG.md

@@ -1,3 +1,8 @@
 ## v0.0.1
 
 * initial release
+
+## v0.0.2
+
+* Added support for exchanging all currencies between them
+

data/README.md

@@ -1,5 +1,4 @@
-# NationalBankOfRomania
-
+# NationalBankOfRomania [![Gem Version](https://badge.fury.io/rb/national_bank_of_romania.png)](http://badge.fury.io/rb/national_bank_of_romania) [![Code Climate](https://codeclimate.com/badge.png)](https://codeclimate.com/github/suciuvlad/national-bank-of-romania) [![Build Status](https://travis-ci.org/suciuvlad/national-bank-of-romania.png?branch=master)](https://travis-ci.org/suciuvlad/national-bank-of-romania)
 
 This gem provides the ability to download the exchange rates from the National Bank of Romania and it is compatible with the [money gem](https://github.com/RubyMoney/money/).
 

data/Rakefile

@@ -1 +1,5 @@
 require "bundler/gem_tasks"
+require 'rspec/core/rake_task'
+
+task :default => :spec
+RSpec::Core::RakeTask.new

data/lib/bank.rb

@@ -22,10 +22,37 @@ module NationalBankOfRomania
       @last_updated = Time.now
     end
 
-    def exchange(cents, from_currency, other_currency)
+    def exchange_with(from, to_currency)
+      return from if same_currency?(from.currency, to_currency)
+
+      unless rate = get_rate(from.currency, to_currency)
+        from_base_rate = BigDecimal.new(get_rate("RON", from.currency).to_s)
+        to_base_rate = BigDecimal.new(get_rate("RON", to_currency).to_s)
+
+        rate = from_base_rate / to_base_rate
+      end
+      _to_currency_  = Money::Currency.wrap(to_currency)
+
+      fractional = BigDecimal.new(from.fractional.to_s) /
+        (BigDecimal.new(from.currency.subunit_to_unit.to_s) /
+         BigDecimal.new(_to_currency_.subunit_to_unit.to_s))
+
+      ex = fractional * BigDecimal.new(rate.to_s)
+      ex = ex.to_f
+      ex = if block_given?
+              yield ex
+            elsif @rounding_method
+              @rounding_method.call(ex)
+            else
+              ex.to_s.to_i
+            end
+      Money.new(ex, _to_currency_)
+    end
+
+    def exchange(cents, from_currency, to_currency)
       from_currency = Money.new(cents, from_currency)
-      other_currency = Money::Currency.wrap(other_currency)
-      exchange_with(from_currency, other_currency)
+      to_currency = Money::Currency.wrap(to_currency)
+      exchange_with(from_currency, to_currency)
     end
 
     def parser

data/lib/national_bank_of_romania/version.rb

@@ -1,3 +1,3 @@
 module NationalBankOfRomania
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/bank_spec.rb

@@ -50,13 +50,47 @@ describe "Bank" do
     bank2.should_not eq(bank3)
   end
 
-  it "should return the correct exchange rates using exchange" do
-    @bank.update_rates(@feed)
+  context "#exchange" do
+    it "calls 'exchange_with' with the correct params" do
+      @bank.update_rates(@feed)
+
+      from = Money.new(100, "RON")
+      to = Money::Currency.wrap("USD")
+      money = double(:fractional => 324, :currency => "USD")
+
+      @bank.should_receive(:exchange_with).with(from, to).and_return(money)
+      @bank.exchange(100, "RON", "USD")
+    end
+
+    it "exchanges currencies based on the base currency" do
+      @bank.update_rates(@feed)
+
+      @bank.exchange(100, "EGP", "MDL").to_f.should ===
+        @exchange_rates["mixed_currencies"]["EGP_TO_MDL"]
+      @bank.exchange(100, "EUR", "USD").to_f.should ===
+        @exchange_rates["mixed_currencies"]["EUR_TO_USD"]
+    end
+  end
+
+  context "#exchange_with" do
+    it "returns the same currency if the to_currency is the same" do
+      @bank.update_rates(@feed)
+      m1 = Money.new(1000, "RON")
+
+      @bank.exchange_with(m1, "RON").should == m1
+    end
 
-    NationalBankOfRomania::Bank::CURRENCIES.each do |currency|
-      subunit = Money::Currency.wrap(currency).subunit_to_unit.to_s.scan(/0/).count
-      value = BigDecimal.new(@exchange_rates["currencies"][currency].to_s).truncate(subunit.to_i).to_f
-      @bank.exchange(100, "RON", currency).to_f.should == value
+    it "returns the correct exchange rates" do
+      @bank.update_rates(@feed)
+      NationalBankOfRomania::Bank::CURRENCIES.each do |currency|
+        m1 = Money.new(100, "RON")
+        subunit = Money::Currency.wrap(currency).subunit_to_unit
+          .to_s.scan(/0/).count
+        value = BigDecimal.new(@exchange_rates["currencies"][currency].to_s)
+          .truncate(subunit.to_i).to_f
+
+        @bank.exchange_with(m1, currency).to_f.should == value
+      end
     end
   end
 

data/spec/fixtures/exchange_rates.yml

@@ -29,3 +29,6 @@ currencies:
   XAU: 175.6294
   XDR: 4.9900
   ZAR: 0.3697
+mixed_currencies:
+  EGP_TO_MDL: 1.83
+  EUR_TO_USD: 1.33

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: national_bank_of_romania
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-20 00:00:00.000000000 Z
+date: 2013-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri