nasl-pedant 0.1.0 → 0.1.1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MzAxNGZlNTBhZWE1ODNkNTYyNjgxZmYxM2Y2NGNkYTgyMjhjMDY0ZQ==
+    NGNlMmFiYThiNDA5OGE3MmUyZDcwMTM3ZGMxODdhN2ZlYzliMDQzNQ==
   data.tar.gz: !binary |-
-    ODlhZTc4MGMxMjdlZGYzYzBiYWY4NDYzMzUzNGNmMGNlODU2ZDhlOQ==
+    MTY1NDYwOTM2NTQ3ZDZlZGFjNjVlODY4YTUzY2QzMmZkYzRkN2ExMA==
 SHA512:
   metadata.gz: !binary |-
-    N2E5MGRlNzE4MTk0ZWM1ODU2NTMwYWVlZTRlYjEwMDBjMDViM2ZjMjhiMTJh
-    YTQzYTRhODE1NTQwNzJhOWI2ZWY5MzUxZjJkNmZkMjQwNTZkOTc5ODMwZDE4
-    ZTYwMzUzOGE2ZTI5ODE3YTg1NmIzMjc1MGMzNzZkMjBlYTQzMzc=
+    YWYyMjg0MjExZTIyMzliNjQ5MzI1YWRjOWZhNDdlNjhiMjA3ZTUxNDE4OThh
+    ODIxM2QxODk5MThkODI5YWY0NGM2Njg1OWI3ZTkyOGRjNDY3YmU0NjA4YmI1
+    ZWQwMGRkNmI0ODI4ZTA0ZDlmMTNlMTk4MTcyNGRiMTdkM2JjNTM=
   data.tar.gz: !binary |-
-    ZGE5MDdjNGNmMjk0ZjI2YWVkNzViY2U2MzU4MGQ4NTdkN2YyNjk0OWJmYzE0
-    N2ZjOWY0ZTVhZDgxOGRlYmFkNmJiN2Y4MDMwMjY1MjM3YmVlMDI1ZmUxOTE0
-    MzA5MjkzMTM3YjlmZDUzN2Q5MTNlOWE3N2FjMzI2NzFhOGZhYmY=
+    ZGM1ZjYxZGUwMWE4M2I0ODQ5NGUyODFlNGM0NTc3ODZjMGE1NTAzYTQ1Nzgz
+    MDg2MWYzZDk3OGY1YWUxOTUyNjllODYwM2Q0NDZjMGRmZTkwMWI0MjUzNmNm
+    OWRmODZjMTY3YmEzYjQwOTBiMDY0YzE2YzA4YzdlOGQ0MjBiNGI=

data/Gemfile

@@ -1,4 +1,4 @@
-source 'http://rubygems.org'
+source 'https://rubygems.org'
 
 # Specify your gem's dependencies in pedant.gemspec
 gemspec

data/README.md

@@ -1,6 +1,9 @@
 Pedant, a static analysis tool for NASL
 =======================================
 
+[![Gem Version](http://img.shields.io/gem/v/nasl-pedant.svg?style=flat-square)](https://rubygems.org/gems/nasl-pedant)
+
+
 Installing
 ----------
 If you have Ruby 1.9.3+ and Rubygems installed, you can simply do:
@@ -13,6 +16,32 @@ To check a script, run this: `pedant check scriptname.nasl`.  You can check
 
 See a `[WARN]` but there's no explanation of the problem? Try adding `-v`.
 
+Development
+-----------
+
+This project uses [Bundler](http://bundler.io/).
+
+If you have a brand-new Debian machine, do this as root:
+
+    apt-get install ruby-dev rubygems git
+    gem install bundler
+
+As your regular user:
+
+    git clone https://github.com/tenable/pedant
+    cd pedant
+    bundle install --path vendor/bundle
+    bundle exec rake tests
+
+All the tests should pass!
+
+To run the Pedant command line, do `bundle exec ./bin/pedant`, which should give
+a help message.
+
+If you get an error like this, try prefixing your command with `bundle exec`:
+
+    /usr/lib/ruby/2.x.x/rubygems/core_ext/kernel_require.rb:NN:in `require': cannot load such file -- libname (LoadError)
+
 Bugs
 ----
 

data/lib/pedant/checks/arity_of_builtins.rb

@@ -82,8 +82,6 @@ module Pedant
           report(:error, call.args[0].context(call))
         elsif call.args.length > 1
           report(:error, call.args[1].context(call))
-        else
-          raise "hello"
         end
       end
     end

data/lib/pedant/checks/conditional_contains_assignment.rb

@@ -32,7 +32,7 @@ module Pedant
 
     def check(file, tree)
       def walk(node, root)
-        # Assignments of literals are the most likely to be bugs (determined empiracally).
+        # Assignments of literals are the most likely to be bugs (determined empirically).
         literals = [
           Nasl::String,
           Nasl::Integer,

data/lib/pedant/checks/script_category.rb

@@ -85,6 +85,7 @@ module Pedant
         "ACT_GATHER_INFO",
         "ACT_ATTACK",
         "ACT_MIXED",
+        "ACT_MIXED_ATTACK",
         "ACT_DESTRUCTIVE_ATTACK",
         "ACT_COMPLIANCE_CHECK",
         "ACT_PATCH_SETUP",

data/lib/pedant/cli.rb

@@ -45,10 +45,6 @@ module Pedant
         opts.separator ""
         opts.separator "Global settings:"
 
-        opts.on('-v', '--verbose', 'Output more information, use multiple time to increase verbosity.') do
-          options[:verbosity] += 1
-        end
-
         opts.separator ""
         opts.separator "Common operations:"
 
@@ -62,6 +58,13 @@ module Pedant
           exit 1
         end
 
+        opts.on('-v') do
+          puts "The -v argument now comes after the `check` subcommand. Like so:"
+          puts "  pedant check -v file.nasl"
+          puts "For the version, do -V or --version."
+          exit 1
+        end
+
         opts.on('-V', '--version', 'Display the version of Pedant.') do
           puts "#{Pedant::VERSION}"
           exit

data/lib/pedant/commands/check.rb

@@ -93,6 +93,10 @@ module Pedant
         opts.on('-q', '--quiet', "Only speak up when something should be fixed.") do
           options[:quiet] = true
         end
+
+        opts.on('-v', '--verbose', 'Output more information, use multiple time to increase verbosity.') do
+          options[:verbosity] += 1
+        end
       end
 
       # Load all of the checks.

data/lib/pedant/version.rb

@@ -1,3 +1,3 @@
 module Pedant
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 end

data/test/unit/checks/test_nonsense_comparison.rb

@@ -59,7 +59,7 @@ class TestNonsenseComparison < Test::Unit::TestCase
     )
   end
 
-  def test_isnull_literal_string
+  def test_isnull_literal_integer
     check(
       :fail,
       :CheckNonsenseComparison,

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nasl-pedant
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Mak Kolybabi
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-11 00:00:00.000000000 Z
+date: 2016-02-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -167,3 +167,4 @@ test_files:
 - test/unit/checks/test_plugin_type_not_specified.rb
 - test/unit/checks/test_script_family_not_specified.rb
 - test/unit/checks/test_uses_octal_integers.rb
+has_rdoc: