nasa_apod 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 61d6d9f7704b23273d740a7209453dd814a39fb1
-  data.tar.gz: 5ec5a5f6460072032eb478590625e3cc07ac1741
+  metadata.gz: 4a5c206c98802c6546d13356b644f9802efb0795
+  data.tar.gz: e22c31e2744cd6b994ee40cac8c8830ce0ffb818
 SHA512:
-  metadata.gz: d7316997ecbc3a6f01ea70a0189de1983c19cae7155a484788d7c9357a96e57080b4b85016a595078df363364dc130e835a9efe135354c25e5630d345f30ba75
-  data.tar.gz: b6d01c6d16305eeb275b5241fde5a0a8f1b2b39c40732b2635f74f7fa228227345c03278e09cc5125d004963649e78f3aa8b521ae9da9c5853db9585c2d04bdc
+  metadata.gz: 0c310ebf2e1cdd57a47d0ff7544f977f68b1bedef5429d9602ba4f5e842e362fa085820318d4b387c6d863362e7e3cc8666ccb6c24bb1c5132e493ce50574485
+  data.tar.gz: a8ad78d0ffce3e94f96e3cc9ee0161cf600d8f1690fda3199bafaf5a1d9bef0f804e0e7610fa05eb4937db6c33a433b95c7b6a0817c46ae1546d9dd762fe3f66

data/README.md

@@ -48,11 +48,11 @@ result.url #=> "http://apod.nasa.gov/apod/image/1506/CeresMountain_Dawn_1041.jpg
 
 Note: Sometimes result.url will return a video url. You should build logic to handle both media_type: 'image' and media_type: 'video'.
 
-If the media_type: 'video', you can use video_thumbnail_url to get a jpg thumbnail of the video.
+If the media_type: 'video', you can use thumbnail_url to get a jpg thumbnail of the video.
 
 ```
 result = client.search
-result.video_thumbnail_url #=> 'http://img.youtube.com/vi/3LdZ_NftIh8/sddefault.jpg' 
+result.thumbnail_url #=> 'http://img.youtube.com/vi/3LdZ_NftIh8/sddefault.jpg' 
 ```
 
 Get HD image URL:

data/lib/nasa_apod/search_results.rb

@@ -2,7 +2,7 @@ module NasaApod
  
   class SearchResults
     attr_accessor :url, :media_type, :title, :explanation, :hd_url, :date, :copyright
-    attr_reader :video_thumbnail_url
+    attr_reader :thumbnail_url
 
     def initialize(attributes={})
       @url = attributes["url"]
@@ -14,9 +14,11 @@ module NasaApod
       @copyright = attributes["copyright"]
     end
 
-    def video_thumbnail_url
+    def thumbnail_url
       if @media_type == 'video'
         "http://img.youtube.com/vi/#{youtube_id}/sddefault.jpg"
+      else
+        url
       end
     end
 

data/lib/nasa_apod/version.rb

@@ -1,3 +1,3 @@
 module NasaApod
-  VERSION = "1.2.0"
+  VERSION = "1.2.1"
 end

data/spec/nasa_apod_spec.rb

@@ -76,8 +76,8 @@ module NasaApod
       end
     end
 
-    context 'when media_type is video' do
-      describe "#video_thumbnail_url" do
+    describe "#thumbnail_url" do
+      context 'when media_type is video' do
         let(:result) { SearchResults.new(attributes) }
         let(:attributes) {{"url" =>  "https://www.youtube.com/embed/3LdZ_NftIh8?rel=0",
                         "media_type" =>  "video",
@@ -87,7 +87,20 @@ module NasaApod
                         }}
 
         it 'returns a image url' do
-          expect(result.video_thumbnail_url).to eq('http://img.youtube.com/vi/3LdZ_NftIh8/sddefault.jpg')
+          expect(result.thumbnail_url).to eq('http://img.youtube.com/vi/3LdZ_NftIh8/sddefault.jpg')
+        end
+      end
+      context 'when media_type is image' do
+        let(:result) { SearchResults.new(attributes) }
+        let(:attributes) {{"url" =>  "http://img.youtube.com/vi/3LdZ_NftIh8/sddefault.jpg",
+                        "media_type" =>  "image",
+                        "title" =>  "Test title",
+                        "explanation" => "Test explanation",
+                        "date" => "1995-06-16"
+                        }}
+
+        it 'returns a image url' do
+          expect(result.thumbnail_url).to eq('http://img.youtube.com/vi/3LdZ_NftIh8/sddefault.jpg')
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nasa_apod
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Gabe Dominguez