nas-yahoo_stock 1.0.7 → 1.0.8

data/History.txt

@@ -91,4 +91,8 @@ Major changes in the public API. Check the README.rdoc file and individual class
 
 === 1.0.7 2010-11-14
 
-* Some refactoring after the addition of dividend option to the history
+* Some refactoring after the addition of dividend option to the history
+
+=== 1.0.8 2011-05-25
+
+* Parse csv data correctly using CSV gem instead to reinventing the wheel

data/README.rdoc

@@ -100,6 +100,13 @@ For details : http://nasir.wordpress.com/2009/10/28/ruby-gem-for-finance-data
 	history.results(:to_xml).output
 	history.results.store('filename')
 
+* History results include 7 values for each day, i.e. date itself, Open, High, Low, Close, Volume and Adj.
+
+* To get comma separated values with line breaks including header use:
+
+  history.values_with_header
+  (writing this to a file will give a CSV)
+
 ==Docs
 
 http://rdoc.info/projects/nas/yahoo_stock
@@ -115,6 +122,7 @@ Cucumber Test html output is logged in log/features.html
 ==Thanks
 
 * Thanks to {Ryan Sandridge}[http://github.com/dissolved] for adding the dividend query option.
+* Thanks to {Justin Campbell} [https://github.com/JustinCampbell] for refactoring CSV parsing.
 
 
 == LICENSE:

data/lib/yahoo_stock.rb

@@ -2,6 +2,7 @@ $:.unshift(File.dirname(__FILE__)) unless
   $:.include?(File.dirname(__FILE__)) || $:.include?(File.expand_path(File.dirname(__FILE__)))
 
 require 'date'
+require 'csv'
 require 'yahoo_stock/base.rb'
 require 'yahoo_stock/interface.rb'
 require 'yahoo_stock/history.rb'

data/lib/yahoo_stock/result/array_format.rb

@@ -15,11 +15,7 @@ module YahooStock
       end
       
       def output
-        # Some inconsistency happens hence remove quotes
-        val = @data.gsub(/\"/,'').split(/\r\n|\n/)
-        new_val = []
-        val.each {|v| new_val << v.split(',')}
-        return new_val
+        CSV.parse @data
       end
       
     end

data/spec/yahoo_stock/result/array_format_spec.rb

@@ -3,36 +3,12 @@ require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
 describe YahooStock::Result::ArrayFormat do
   
   describe "output" do
-    before(:each) do
-      @data = "asdf\"sdf,as,f\" asf s"
-      @array_format = YahooStock::Result::ArrayFormat.new(@data)
-    end
-    
-    it "should remove all double quotes from the data string" do
-      @data.should_receive(:gsub).with(/\"/,'').and_return('a string')
-      @array_format.output
-    end
-    
-    it "should create array element for each line by splitting it for the line break" do
-      string = "asdfsdf,as,f asf s"
-      @data.stub!(:gsub).and_return(string)
-      string.should_receive(:split).with(/\r\n|\n/).and_return([])
-      @array_format.output
-    end
-    
-    it "should create a sub array for each line by splitting them for each comma" do
-      string = "asdfsdf,as,f asf s"
-      @data.stub!(:gsub).and_return(string)
-      string.stub!(:split).with(/\r\n|\n/).and_return([string])
-      string.should_receive(:split).with(',').and_return([])
-      @array_format.output
-    end
     
     it "should return an array for each line and each line with an array of csv" do
       string = "asdfsdf,as,f asf s\r\n23,sdf,2332,sdf"
-      @data.stub!(:gsub).and_return(string)
-      @array_format.output.should eql([['asdfsdf','as','f asf s'],['23','sdf' ,'2332', 'sdf']])
+      YahooStock::Result::ArrayFormat.new(string).output.should eql([['asdfsdf','as','f asf s'],['23','sdf' ,'2332', 'sdf']])
     end
+    
   end
   
 end

data/spec/yahoo_stock/result/hash_format_spec.rb

@@ -31,13 +31,22 @@ describe YahooStock::Result::HashFormat do
     end
     
     it "should have the data as an array of hashes with the same keys key1 and key2" do
-      data = "da,ta\nda,ta\r\nda,ta"
+      data = "da,ta\nda,ta\nda,ta"
       hash_format = YahooStock::Result::HashFormat.new(data){['key1', 'key2']}
       hash_format.output.should eql([{:key1 => 'da',:key2 => 'ta'},
                                      {:key1 => 'da',:key2 => 'ta'},
                                      {:key1 => 'da',:key2 => 'ta'}
                                     ])
     end
+    
+    it "should properly parse data with commas" do
+      data = "da,\"t,a\"\nda,\"t,a\"\nda,\"t,a\""
+      hash_format = YahooStock::Result::HashFormat.new(data){['key1', 'key2']}
+      hash_format.output.should eql([{:key1 => 'da',:key2 => 't,a'},
+                                     {:key1 => 'da',:key2 => 't,a'},
+                                     {:key1 => 'da',:key2 => 't,a'}
+                                    ])
+    end
   end
   
   describe "keys" do

metadata

@@ -1,13 +1,8 @@
 --- !ruby/object:Gem::Specification 
 name: nas-yahoo_stock
 version: !ruby/object:Gem::Version 
-  hash: 25
-  prerelease: false
-  segments: 
-  - 1
-  - 0
-  - 7
-  version: 1.0.7
+  prerelease: 
+  version: 1.0.8
 platform: ruby
 authors: 
 - Nasir Jamal
@@ -15,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-11-14 00:00:00 +00:00
+date: 2011-05-25 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -26,11 +21,6 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 15
-        segments: 
-        - 2
-        - 1
-        - 2
         version: 2.1.2
   type: :runtime
   version_requirements: *id001
@@ -93,24 +83,17 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 31
-      segments: 
-      - 1
-      - 8
       version: "1.8"
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
       version: "0"
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.7
+rubygems_version: 1.6.2
 signing_key: 
 specification_version: 2
 summary: Yahoo Stock is a Ruby library for extracting information about stocks from yahoo finance.