narrative 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4be14aa29aa4368e0cd86bfce8682eb9e01bf261
-  data.tar.gz: 107c00177921a2d3ea4d96059bb15cf9110363fe
+  metadata.gz: b71ff082b5a80892b4c77691c0b434703c50e884
+  data.tar.gz: f6a1ec6fa9b164d800d3b67900305d99e42f588d
 SHA512:
-  metadata.gz: 1cfb7f996f64b1a7a8b37628a4325e962ee3b44614585fd5def54e7f66522f2b2b49210ba82df718dccfe14231731d6a8b52d6bb3bd0b43a4d30d85206d85832
-  data.tar.gz: 7a6ae0d04bb3e8d0130ba937ca7c28b0c1a63d606daf73bc91691805eec2f1bd2fcd169e08f72ee18979abf7383b15cfd68fe21cc13e5ac725d856f40cb8e220
+  metadata.gz: e839c91bd4310fd209cfaa56a5af781f4208ba076a5c0e7b66e9fa601d5c3522e422a5919ae5bfd46cc16acbd05b32b7d6664e31f19ab649907d3ff962d0fafe
+  data.tar.gz: 8406e009e03aa09a616eeda6771f83b411fdc5f179ab6bd831dbbcd0904297ae5dce191465be69e287e3f79598d3cb5f5520e55509f53aa8566f456c6ff8abd5

data/README.md

@@ -1,10 +1,9 @@
 [![Build Status](https://travis-ci.org/esminc/narrative.svg?branch=master)](https://travis-ci.org/esminc/narrative)
 [![Code Climate](https://codeclimate.com/github/esminc/narrative.png)](https://codeclimate.com/github/esminc/narrative)
-[![PullReview stats](https://www.pullreview.com/github/esminc/narrative/badges/master.svg?)](https://www.pullreview.com/github/esminc/narrative/reviews/master)
 
 # Narrative
 
-TODO: Write a gem description
+A simple implementation of DCI.
 
 ## Installation
 

data/lib/narrative.rb

@@ -1,5 +1,4 @@
-require 'narrative/context'
-require 'narrative/context/teller'
+require 'narrative/scene'
 
 module Narrative
 end

data/lib/narrative/role_definition.rb

@@ -1,35 +1,27 @@
 module Narrative
-  module Context
-    class RoleDefinition
-      attr_reader :name
+  class RoleDefinition
+    attr_reader :name
 
-      def initialize(name, partners, &responsibilities)
-        @name = name
-        @partners = partners
-        @responsibilities = responsibilities
-      end
-
-      def cast!(actors)
-        actor = actor!(actors)
-        relationship!(actor, actors)
+    def initialize(name, partners, &responsibilities)
+      @name = name
+      @partners = partners
+      @responsibilities = responsibilities
+    end
 
-        actor
-      end
+    def cast!(actors)
+      role = Module.new(&@responsibilities)
+      acquaint! role, actors.slice(*@partners)
 
-      private
+      actors[@name].extend(role)
+    end
 
-      def actor!(actors)
-        actor = actors[@name]
-        actor.instance_eval(&@responsibilities)
-        actor
-      end
+    private
 
-      def relationship!(actor, actors)
-        klass = class << actor; self end
-        actors.slice(*@partners).each do |role_name, partner|
-          klass.instance_eval do
-            define_method(role_name) { partner }
-          end
+    def acquaint!(role_module, partners)
+      role_module.instance_eval do
+        partners.each do |role_name, partner|
+          define_method(role_name) { partner }
+          private role_name
         end
       end
     end

data/lib/narrative/{context.rb → scene.rb}

@@ -2,11 +2,11 @@ require 'active_support'
 require_relative 'role_definition'
 
 module Narrative
-  module Context
+  module Scene
     extend ActiveSupport::Concern
 
     included do
-      cattr_reader(:roles) { [] }
+      private(*cattr_accessor(:roles) { [] })
     end
 
     module ClassMethods
@@ -14,6 +14,13 @@ module Narrative
         roles << RoleDefinition.new(name, partners, &block)
         define_method(name.to_sym) { @actors[name] }
       end
+
+      def principal(name, partners: [], &block)
+        raise 'principal is defined twice' if method_defined?(:principal)
+
+        role name, partners: partners, &block
+        alias_method :principal, name
+      end
     end
 
     def initialize(data)
@@ -23,12 +30,13 @@ module Narrative
     end
 
     def perform(&block)
-      block.call @actors.slice(*block.parameters.map(&:last))
+      block.call principal
     end
 
     private
 
     def validate!(data)
+      raise 'principal definition is required' unless self.class.method_defined?(:principal)
       raise 'data and role definition did not same' if data.keys.to_set != roles.map(&:name).to_set
       raise 'data did not allow to contain nil' if data.values.include?(nil)
     end

data/lib/narrative/version.rb

@@ -1,3 +1,3 @@
 module Narrative
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

data/spec/lib/narrative/{context_spec.rb → scene_spec.rb}

@@ -1,17 +1,23 @@
 require 'spec_helper'
 
-describe Narrative::Context do
-  describe '.role' do
-    class ProjectContext
-      include Narrative::Context
+describe Narrative::Scene do
+  class ProjectContext
+    include Narrative::Scene
+
+    principal :programmer do
+      def coding; end
+    end
 
-      role :programmer do; end
+    role :tester do
+      def report_bug; end
     end
+  end
 
+  describe '.role' do
     class AnotherProjectContext
-      include Narrative::Context
+      include Narrative::Scene
 
-      role :product_owner do; end
+      principal :product_owner do; end
     end
 
     subject { ProjectContext.roles.map(&:name) }
@@ -21,18 +27,6 @@ describe Narrative::Context do
   end
 
   describe 'cast roles to data' do
-    class ProjectContext
-      include Narrative::Context
-
-      role :programmer do
-        def coding; end
-      end
-
-      role :tester do
-        def report_bug; end
-      end
-    end
-
     let(:data) { {programmer: 'alice', tester: 'bob' } }
 
     subject { ProjectContext.new(data) }
@@ -57,15 +51,20 @@ describe Narrative::Context do
 
   describe 'can refer to other roles' do
     class BugfixContext
-      include Narrative::Context
+      include Narrative::Scene
 
       role :programmer do
         def correct!(code)
+          add_unit_test_for code
           code.modified!
         end
+
+        private
+
+        def add_unit_test_for(code); end
       end
 
-      role :tester, partners: [:programmer] do
+      principal :tester, partners: [:programmer] do
         def report_bug(code)
           programmer.correct!(code)
         end
@@ -76,7 +75,7 @@ describe Narrative::Context do
       code = double('defected code')
       allow(code).to receive(:modified!)
 
-      BugfixContext.new(programmer: 'alice', tester: 'bob').perform do |programmer:, tester:|
+      BugfixContext.new(programmer: 'alice', tester: 'bob').perform do |tester|
         tester.report_bug(code)
       end
 
@@ -85,25 +84,13 @@ describe Narrative::Context do
   end
 
   describe '#perform' do
-    class ProjectContext
-      include Narrative::Context
-
-      role :programmer do
-        def coding; end
-      end
-
-      role :tester do
-        def report_bug; end
-      end
-    end
-
     specify do
       called = false
-      context = ProjectContext.new({programmer: 'alice', tester: 'bob'})
+      alice = 'alice'
+      context = ProjectContext.new({programmer: alice, tester: 'bob'})
 
-      context.perform do |programmer:, tester:|
-        expect(programmer).to eq(context.programmer)
-        expect(tester).to eq(context.tester)
+      context.perform do |programmer|
+        expect(programmer).to be(alice)
 
         called = true
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: narrative
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Takuya Watanabe
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-18 00:00:00.000000000 Z
+date: 2014-05-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -41,13 +41,11 @@ files:
 - README.md
 - Rakefile
 - lib/narrative.rb
-- lib/narrative/context.rb
-- lib/narrative/context/teller.rb
 - lib/narrative/role_definition.rb
+- lib/narrative/scene.rb
 - lib/narrative/version.rb
 - narrative.gemspec
-- spec/lib/narrative/context/teller_spec.rb
-- spec/lib/narrative/context_spec.rb
+- spec/lib/narrative/scene_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/esminc/narrative
 licenses:
@@ -74,6 +72,5 @@ signing_key:
 specification_version: 4
 summary: a simple implementation of DCI.
 test_files:
-- spec/lib/narrative/context/teller_spec.rb
-- spec/lib/narrative/context_spec.rb
+- spec/lib/narrative/scene_spec.rb
 - spec/spec_helper.rb

data/lib/narrative/context/teller.rb

@@ -1,19 +0,0 @@
-require 'active_support/core_ext/string/inflections'
-
-module Narrative
-  module Context
-    module Teller
-      def with_context(context_name, data, &block)
-        context_for(context_name, data).perform(&block)
-      end
-
-      private
-
-      def context_for(name, data)
-        context_names = name.split << 'context'
-        context_class = context_names.map(&:capitalize).join.constantize
-        context_class.new(data)
-      end
-    end
-  end
-end

data/spec/lib/narrative/context/teller_spec.rb

@@ -1,40 +0,0 @@
-require 'spec_helper'
-
-describe Narrative::Context::Teller do
-  describe '#with_context' do
-    class RefactorContext
-      include Narrative::Context
-
-      role :programmer do
-        def refactor!(code)
-          code.thrown_away!
-        end
-      end
-    end
-
-    class ContextConsumer
-      include Narrative::Context::Teller
-
-      attr_accessor :code
-
-      def initialize(code)
-        self.code = code
-      end
-
-      def consume
-        with_context 'refactor', programmer: 'alice' do |programmer:|
-          programmer.refactor! code
-        end
-      end
-    end
-
-    specify do
-      code = double('code')
-      allow(code).to receive(:thrown_away!)
-
-      ContextConsumer.new(code).consume
-
-      expect(code).to have_received(:thrown_away!).once
-    end
-  end
-end