naranya_ecm-sdk 0.0.55 → 0.0.56

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 58bd05cc77acbb5e43a11da7b770c5f66c8013ee
-  data.tar.gz: 5b605e6c8ce4031b87dbadceea3119fa0528e5cd
+  metadata.gz: 45b1ec3ac06a57187117d0560b8c75d690b560b2
+  data.tar.gz: 66800e1d77798cef6882095e533d3000756bfefc
 SHA512:
-  metadata.gz: 2f27e2e72787e058795fd7d08f8dec8817f2f88dda2e16ef0cec79ea64d13e0fa0076d36d0d5c36b51c5c7febc0e1492950777b9f6f2c6416ba37ece8e6eb222
-  data.tar.gz: e1f98cf8d19e35b9bb07ad31e358550f346eb352deb7cc71e92643a2e611b5cf09ceaae3a0e344e3e3a8bd5bfe29684a05d20a94cb2bd018edf44617c1ab412c
+  metadata.gz: 8351e4377ec531396d6ba809244b16fa3d49fd16121317ccdf0227d60d55ddecf668b8fb20beac2839c3541c3e90520a67dba7cbf05e75a1a0e3b60d0a1a4542
+  data.tar.gz: e3a9cec8672c353cd0798a877ca381eeb92dcbb807e89eeba12e5d5a5f0e6502c7249fdc9d3131d3c241a1a52cc2a8e1112b9ef10dd341b910f433dd84a66663

data/lib/naranya_ecm-sdk/version.rb

@@ -1,3 +1,3 @@
 module NaranyaEcm
-  VERSION = "0.0.55"
+  VERSION = "0.0.56"
 end

data/lib/naranya_ecm/rest/errors.rb

@@ -1,3 +1,5 @@
+require 'cgi'
+
 module NaranyaEcm::Rest
   # = REST Errors
   #
@@ -8,6 +10,32 @@ module NaranyaEcm::Rest
 
     def initialize(given_response, msg = "")
       @response = given_response
+
+      # Generate a default message if we got a blank message:
+      if msg.blank?
+        response_env = given_response.env
+        msg = response_env.method.upcase.to_s
+        msg += " '#{response_env.url.to_s}'"
+        msg += " failed (HTTP #{response_env.status})"
+      end
+
+      # Record custom attributes in NewRelic:
+      if ::NContent::SDK.config.new_relic_agent_available?
+        ncontent_url = given_response.env.url
+
+        # Parsear el query string a hash:
+        ncontent_request_params = CGI.parse ncontent_url.query.to_s
+
+        # Agregar al hash de ncontent_request_params el request_body como hash:
+        if given_response.env.request_headers['Content-Type'] == 'application/json' && given_response.env[:request_body].present?
+          ncontent_request_params.merge! ActiveSupport::JSON.decode(given_response.env[:request_body])
+        end
+
+        ::NewRelic::Agent.add_custom_attributes \
+          ncontent_url: ncontent_url.to_s.split('?').first,
+          request_params: ncontent_request_params
+      end
+
       super(msg)
     end
 
@@ -22,7 +50,7 @@ module NaranyaEcm::Rest
       else RemoteFailed
       end
 
-      klass.new response, "Server responded with code #{response.status}. Message: '#{message}'"
+      klass.new response
     end
 
     ##
@@ -102,15 +130,6 @@ module NaranyaEcm::Rest
   end
 
   class RemoteFailed < RestError
-    def initialize(given_response, msg = "")
-      response_env = given_response.env
-
-      # Override the message:
-      msg = "Request '#{response_env.method.upcase} #{response_env.url.path}' failed with HTTP status #{response_env.status}."
-      msg += " Request-Body: #{response_env[:request_body]}" if response_env[:request_body].present?
-      msg += " Response-Body: #{given_response.body.inspect}" if given_response.respond_to?(:body) && given_response.body.present?
-      super(given_response, msg)
-    end
   end
 
 end

data/lib/ncontent-sdk.rb

@@ -49,37 +49,7 @@ module NContent
     def self.cache
       @@cache ||= ActiveSupport::Cache.lookup_store *config.cache
     end
-
-    def self.api_client
-      @@api_client ||= begin
-        require 'oauth2'
-        require 'ncontent/sdk/faraday_middleware'
-
-        OAuth2::Client.new(config.api_key, config.api_secret, site: config.api_host) do |faraday|
-          ### Oauth2 Client (Faraday) builder:
-
-          faraday.request :url_encoded # them posts...
-
-          faraday.response :logger, NContent::SDK.logger
-
-          # faraday.use NContent::SDK::FaradayMiddleware::ResponseParser
-          faraday.use NContent::SDK::FaradayMiddleware::RESTAPICallBenchmark
-
-          if defined?(Patron)
-            faraday.adapter :patron # Prefer patron if exists
-          else
-            faraday.adapter Faraday.default_adapter  # make requests with Net::HTTP
-          end
-        end
-      end
-    end
-
-    def self.api_client_token
-      @@api_client_token ||= begin
-
-      end
-    end
-
+    
   end
 
 end

data/lib/ncontent/sdk/rest_client.rb

@@ -1,7 +1,5 @@
 require 'oauth2'
 require 'ncontent/sdk/faraday_middleware'
-require 'singleton'
-require 'cgi'
 
 module NContent
 
@@ -51,29 +49,7 @@ module NContent
             # Build the error that will be raised:
             error_to_raise = NaranyaEcm::Rest::RestError.build_from_failed_response(error_response)
 
-            # Send unhandled errors to NewRelic:
-            if error_to_raise.is_a?(NaranyaEcm::Rest::RemoteFailed) && config.new_relic_agent_available?
-
-              ncontent_url = error_response.env.url
-
-              # Parsear el query string a hash:
-              ncontent_request_params = CGI.parse ncontent_url.query.to_s
-
-              # Agregar al hash de ncontent_request_params el request_body como hash:
-              if error_response.env.request_headers['Content-Type'] == 'application/json' && error_response.env[:request_body].present?
-                ncontent_request_params.merge! ActiveSupport::JSON.decode(error_response.env[:request_body])
-              end
-
-              ::NewRelic::Agent.notice_error(
-                error_to_raise,
-                uri: ncontent_url.to_s.split('?').first, # The URL without query string
-                metric: "Custom/NContent::SDK::RESTClient/#{verb}",
-                request_params: ncontent_request_params
-              )
-            end
-
             raise error_to_raise
-
           end
         end
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: naranya_ecm-sdk
 version: !ruby/object:Gem::Version
-  version: 0.0.55
+  version: 0.0.56
 platform: ruby
 authors:
 - Roberto Quintanilla
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2015-05-21 00:00:00.000000000 Z
+date: 2015-05-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport