namo 0.29.0 → 0.30.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5e56f3159063720b0e933e9c346ddad824831a51dac7a576da6d0cf841fd28ea
-  data.tar.gz: 8aee98bb89f8c7ab978c0ce459cc90c8259123123c13f5158a3e16dbb93922c7
+  metadata.gz: e6f9ea9ed29bd86c309865e0c49d03122b7fa50460e34fd7a42a9a273bb220c0
+  data.tar.gz: 99d5e8191c3458b498c6fe297c2af8b94d8bb73aced942d9f3da67af94ace454
 SHA512:
-  metadata.gz: 16e3d16921ee88ae7d5d76c79227efb035128ac46f17d93fa61c7445434bb1c475c597ff7e2478fe19bbaf8f53b73ed366fee5ed1e514ad99a423a030db0d46c
-  data.tar.gz: 7e0045e6e6a842be576e171c9c31bde901f7ade581e5dce694e853a868f832c358e5eb7329ce9fc14efdc13a20663f4877135895f99328d646bb8717d177a2af
+  metadata.gz: 9e4aca2b13be76dc10a2fcf3eb7122045e600b1ed2410c2f6e82554c7dfc679249bf714fc52939fd4ee058fa6925b1958935bd91281dbf67f48634aec4cd4ea9
+  data.tar.gz: d3432cb0f092521adb1e2f60dccbc5b37aff2e4f91511189300b0693d374124e76cf1fde57d64709606ea504aae5db85d9c47e7aba99efcfdfa68b6fcbc38eef

data/CHANGELOG

@@ -2,6 +2,18 @@
 
 ## 20260715
 
+0.30.0: Assemble Collection objects in a single pass when doing Namo::Enumerable#group_by.
+
+Appending one member per group re-materialised Collection#<<'s @data = detail.data over all members-so-far g times; group_by now appends all the members in one << operation and materialises once, causing it be performed in O(rows) instead of O(rows·groups).
+
+1. ~ Namo::Enumerable#group_by: map the groups to members, then append them all in one collection << members, rather than << per group — each of which rebuilt @data over every member-so-far.
+2. ~ test/namo_test.rb: + a single-pass assembly pin under #group_by — the assembly materialises the detail once whatever the number of groups (not once per group).
+3. ~ ROADMAP.md: + the 0.30.0 entry; current-state bumped to 0.30.0.
+4. ~ docs/: regenerate the print-ready PDFs.
+5. ~ Namo::VERSION: /0.29.0/0.30.0/
+
+## 20260715
+
 0.29.0: Per access indexed materialisation.
 
 Materialise each column once per top-level access, collapsing an O(n²) parent-scanning formula to O(n), with no value retained across accesses.

data/lib/Namo/Enumerable.rb

@@ -72,10 +72,12 @@ class Namo
     def group_by(dimension)
       collection = Collection.new
       source = derived_dimensions.include?(dimension) ? self[*data_dimensions, dimension] : self
-      source.data.group_by{|row_data| row_data[dimension]}.each do |value, rows|
-        collection << self.class.new(rows, formulae: source.formulae.dup, name: value)
-      end
-      collection
+      members = (
+        source.data.group_by{|row_data| row_data[dimension]}.map do |value, rows|
+          self.class.new(rows, formulae: source.formulae.dup, name: value)
+        end
+      )
+      collection << members
     end
   end
 end

data/lib/Namo/VERSION.rb

@@ -2,5 +2,5 @@
 # Namo::VERSION
 
 class Namo
-  VERSION = '0.29.0'
+  VERSION = '0.30.0'
 end

data/test/namo_test.rb

@@ -3198,5 +3198,27 @@ describe Namo do
         _(collection.detail.values(:close)).must_equal [42.5, 43.0, 118.3, 100.0]
       end
     end
+
+    context "single-pass assembly" do
+      # Collection#<< rebuilds @data = detail.data over all members-so-far on every
+      # append, so appending one member per group re-materialised the data g times
+      # (O(rows·groups)). group_by now hands all members to a single <<: one
+      # materialisation whatever the number of groups.
+      def detail_calls_assembling(namo, dimension)
+        calls = 0
+        tracer = TracePoint.new(:call) do |tp|
+          calls += 1 if tp.method_id == :detail && tp.defined_class == Namo::Collection
+        end
+        tracer.enable{namo.group_by(dimension)}
+        calls
+      end
+
+      it "materialises the assembled data once, whatever the number of groups" do
+        few = Namo.new((1..3).map{|i| {symbol: "S#{i}", close: i.to_f}})
+        many = Namo.new((1..30).map{|i| {symbol: "S#{i}", close: i.to_f}})
+        _(detail_calls_assembling(few, :symbol)).must_equal 1
+        _(detail_calls_assembling(many, :symbol)).must_equal 1
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: namo
 version: !ruby/object:Gem::Version
-  version: 0.29.0
+  version: 0.30.0
 platform: ruby
 authors:
 - thoran