named_parameter 0.0.1 → 0.0.2

data/{README → README.md}

@@ -1,4 +1,4 @@
-# Named Parameter `v0.0.1`
+# Named Parameter `v0.0.2`
 
 ## Description
 That you ever dream with named parameter in Ruby? Well, you doesn't have to pray to
@@ -6,9 +6,12 @@ Ruby's 2.0 have this, just install this gem and have fun!
 
 ## How it works
 Just extend the module NamedParameter in your class/module and use the method 'named'
-before define your method, when you call it, use a hash that's key is the parameter
-name. See this example:
+before define your method, when you call it, use a hash with parameters name as keys.
+See this example:
 
+    require 'rubygems'
+    require 'named_parameter'
+     
     class People
       extend NamedParameter
       
@@ -21,6 +24,9 @@ name. See this example:
 
 Or maybe you want to define an optional parameter, no problem!
 
+    require 'rubygems'
+    require 'named_parameter'
+     
     class People
       extend NamedParameter
       
@@ -33,6 +39,9 @@ Or maybe you want to define an optional parameter, no problem!
 
 Multiple arguments? Of course!
 
+    require 'rubygems'
+    require 'named_parameter'
+     
     class Point
       extend NamedParameter
       

data/Rakefile

@@ -14,7 +14,7 @@ require 'rake'
 require 'jeweler'
 Jeweler::Tasks.new do |gem|
   # gem is a Gem::Specification... see http://docs.rubygems.org/read/chapter/20 for more options
-  gem.version = "0.0.1"
+  gem.version = "0.0.2"
   gem.name = "named_parameter"
   gem.homepage = "http://github.com/hugolnx/named_parameter"
   gem.license = "MIT"

data/lib/named_parameter/errors/not_hash.rb

@@ -0,0 +1,28 @@
+module NamedParameter::Errors
+  class NotHash
+    def self.all_when(named_method,options)
+      args = options[:called_with]
+      if args.is_a? Hash
+        []
+      else
+        error = NamedParameter::Error.new(named_method,args,caller)
+        [NotHash.new(error)]
+      end
+    end
+
+    def initialize(error)
+      @error = error
+    end
+
+    def raise_args
+      [error_message,@error.backtrace]
+    end
+
+  private
+    def error_message
+      msg = "expected a Hash but #{@error.argument_name.inspect} received by named method '#{@error.named_method.method.name}'"
+      p msg
+      msg
+    end
+  end
+end

data/lib/named_parameter/errors.rb

@@ -1,2 +1,3 @@
 require 'named_parameter/errors/undefined_parameters'
 require 'named_parameter/errors/required_parameters'
+require 'named_parameter/errors/not_hash'

data/lib/named_parameter/named_method.rb

@@ -15,10 +15,14 @@ module NamedParameter
 
     def errors_when_called_with(args={})
       errors = []
-      errors += Errors::UndefinedParameters.all_when self, 
-                                                    :called_with => args
-      errors += Errors::RequiredParameters.all_when self, 
-                                                    :called_with => args
+      errors += Errors::NotHash.all_when self, 
+                                         :called_with => args
+      if errors.empty?
+        errors += Errors::UndefinedParameters.all_when self, 
+                                                      :called_with => args
+        errors += Errors::RequiredParameters.all_when self, 
+                                                      :called_with => args
+      end
       errors
     end
 

data/named_parameter.gemspec

@@ -5,24 +5,25 @@
 
 Gem::Specification.new do |s|
   s.name = %q{named_parameter}
-  s.version = "0.0.1"
+  s.version = "0.0.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Hugo Roque (a.k.a HugoLnx)"]
-  s.date = %q{2011-05-12}
+  s.date = %q{2011-05-13}
   s.description = %q{Allows named parameter in ruby}
   s.email = %q{hugolnx@gmail.com}
   s.extra_rdoc_files = [
-    "README"
+    "README.md"
   ]
   s.files = [
     "Gemfile",
-    "README",
+    "README.md",
     "Rakefile",
     "lib/.named_parameter.rb.swo",
     "lib/named_parameter.rb",
     "lib/named_parameter/error.rb",
     "lib/named_parameter/errors.rb",
+    "lib/named_parameter/errors/not_hash.rb",
     "lib/named_parameter/errors/required_parameters.rb",
     "lib/named_parameter/errors/undefined_parameters.rb",
     "lib/named_parameter/named_method.rb",
@@ -32,10 +33,9 @@ Gem::Specification.new do |s|
     "named_parameter.gemspec",
     "spec/features/collective_named_methods_feature_spec.rb",
     "spec/features/individual_named_method_feature_spec.rb",
-    "spec/interfaces/errors_interface.rb",
     "spec/spec_helper.rb",
-    "spec/support/interface_helper.rb",
     "spec/unit/error_spec.rb",
+    "spec/unit/errors/not_hash_spec.rb",
     "spec/unit/errors/required_parameters_spec.rb",
     "spec/unit/errors/undefined_parameters_spec.rb",
     "spec/unit/named_method_spec.rb",

data/spec/features/individual_named_method_feature_spec.rb

@@ -126,6 +126,27 @@ describe "individual named method feature" do
         lambda {People.new.say}.should raise_error ArgumentError, /'phrase'[\w\s]*'say'/
       end
     end
+
+    describe 'ArgumentError when given a non Hash argument' do
+      specify %q{
+        class People
+          extend NamedParameter
+          named def say(phrase)
+          end
+        end
+
+        People.new.say
+          #=> ArgumentError
+      } do
+        class People
+          extend NamedParameter
+          named def say(phrase)
+          end
+        end
+
+        lambda {People.new.say("non Hash argument")}.should raise_error ArgumentError, /"non Hash argument"[\w\s]*'say'/
+      end
+    end
   end
 
   describe "no named method" do

data/spec/unit/errors/not_hash_spec.rb

@@ -0,0 +1,121 @@
+require 'spec_helper'
+
+module NamedParameter::Errors
+  describe NotHash do
+    describe '#initialize(error)' do
+      describe 'initialize instance variables' do
+        specify '@error its equal to error' do
+          specific_error = NotHash.new :error
+          specific_error.instance_variable_get(:@error).should be == :error
+        end
+      end
+    end
+
+    describe '#raise_args' do
+      before :each do
+        # prevention from dependencies
+        @error = stub(:error).as_null_object
+        @error.stub_chain('named_method.method.name')
+      end
+
+      let :instance do
+        NotHash.new @error
+      end
+
+      describe 'return' do
+        let :the_return do
+          instance.raise_args
+        end
+
+        it 'is an array of 2 elements' do
+          the_return.should be_an Array
+          the_return.should have(2).elements
+        end
+
+
+        describe 'first element' do
+          let :first_element do
+            the_return.first
+          end
+
+          it 'is a String of the error message' do
+            first_element.should be_a String
+          end
+
+          it 'include the name of argument envolved in the error' do
+            @error.stub :argument_name => 'arg_name'
+            first_element.should include 'arg_name'
+          end
+
+          it 'include the name of method envolved in the error' do
+            @error.stub_chain('named_method.method.name').and_return('method_name')
+            first_element.should include 'method_name'
+          end
+        end
+
+
+        describe 'second element' do
+          let :second_element do
+            the_return[1]
+          end
+
+          it 'is an Array of backtrace' do
+            backtrace = [:backtrace]
+            @error.stub(:backtrace).and_return(backtrace)
+            second_element.should be == backtrace
+          end
+        end
+      end
+
+
+
+      describe 'integrations' do
+        after :each do
+          instance.raise_args
+        end
+
+        specify '@error.argument_name' do
+          @error.should_receive :argument_name
+        end
+
+        specify '@error.named_method' do
+          @error.should_receive :named_method
+        end
+      end
+    end
+
+    describe '.all_when(named_method,{called_with:arg})' do
+      describe 'return' do
+        before :each do
+          @named_method = stub(:named_method, 
+                               :parameters => [[:req,:param1]],
+                               :required_parameters => [:param1],
+                               :have_a_parameter_like? => false)
+          @args = {:arg_name => :value}
+        end
+
+        let :the_return do
+          NotHash.all_when(@named_method,:called_with => @args)
+        end
+        
+        it 'is an Array' do
+          the_return.should be_an Array
+        end
+
+        context 'given passed something that not a Hash as argument' do
+          it 'have one element' do
+            @args = "not a hash"
+            the_return.should have(1).element
+          end
+        end
+
+        context 'given passed a Hash' do
+          it 'is empty' do
+            @args = {:param1 => 'value1'}
+            the_return.should be_empty
+          end
+        end
+      end
+    end
+  end
+end

data/spec/unit/named_method_spec.rb

@@ -56,6 +56,7 @@ module NamedParameter
       before :each do
         Errors::RequiredParameters.stub!(:all_when).and_return([])
         Errors::UndefinedParameters.stub!(:all_when).and_return([])
+        Errors::NotHash.stub!(:all_when).and_return([])
         method = @instance.method(:method1)
         @named_method = NamedMethod.new(method)
       end
@@ -72,6 +73,12 @@ module NamedParameter
                                     .and_return([])
           @named_method.errors_when_called_with(:args)
         end
+
+        it "Errors::NotHash.all_when(method,{called_with:args})" do
+          Errors::NotHash.should_receive(:all_when)
+                         .and_return([])
+          @named_method.errors_when_called_with(:args)
+        end
       end
     end
   end

metadata

@@ -2,7 +2,7 @@
 name: named_parameter
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors: 
 - Hugo Roque (a.k.a HugoLnx)
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-05-12 00:00:00 -03:00
+date: 2011-05-13 00:00:00 -03:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -42,15 +42,16 @@ executables: []
 extensions: []
 
 extra_rdoc_files: 
-- README
+- README.md
 files: 
 - Gemfile
-- README
+- README.md
 - Rakefile
 - lib/.named_parameter.rb.swo
 - lib/named_parameter.rb
 - lib/named_parameter/error.rb
 - lib/named_parameter/errors.rb
+- lib/named_parameter/errors/not_hash.rb
 - lib/named_parameter/errors/required_parameters.rb
 - lib/named_parameter/errors/undefined_parameters.rb
 - lib/named_parameter/named_method.rb
@@ -60,10 +61,9 @@ files:
 - named_parameter.gemspec
 - spec/features/collective_named_methods_feature_spec.rb
 - spec/features/individual_named_method_feature_spec.rb
-- spec/interfaces/errors_interface.rb
 - spec/spec_helper.rb
-- spec/support/interface_helper.rb
 - spec/unit/error_spec.rb
+- spec/unit/errors/not_hash_spec.rb
 - spec/unit/errors/required_parameters_spec.rb
 - spec/unit/errors/undefined_parameters_spec.rb
 - spec/unit/named_method_spec.rb
@@ -82,7 +82,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 270356975
+      hash: 215367841
       segments: 
       - 0
       version: "0"

data/spec/interfaces/errors_interface.rb

@@ -1,9 +0,0 @@
-specify ".new(error)" do
-  described_class.should respond_to(:new)
-                        .with(1)
-end
-
-specify ".match?(method,arg)" do
-  described_class.should respond_to(:match?)
-                        .with(2)
-end

data/spec/support/interface_helper.rb

@@ -1,17 +0,0 @@
-here = File.dirname(__FILE__)
-
-interfaces_paths = Dir[File.join(here,'../interfaces/*_interface.rb')]
-
-interfaces_paths.each do |interface_path|
-  interface_filename = File.basename(interface_path)[/^[^.]+/]
-  method_name = "respect_#{interface_filename}"
-  context_description = method_name.gsub(/_./){|a| a.sub('_',' ').upcase}
-
-  RSpec::Core::ExampleGroup.singleton_class.instance_eval do
-    define_method method_name do
-      context context_description  do
-        eval File.read(interface_path)
-      end
-    end
-  end
-end