named_accessors 1.0 → 1.1

data/CHANGELOG.md

@@ -1,3 +1,7 @@
 ## v1.0
 
-* initial release
+* initial release
+
+## v1.1
+
+* allow to specify reader/writer name with named_accessor

data/README.md

@@ -4,6 +4,12 @@ You ever wanted to create attr_accessor with specified name? Now You can!
 
 ## Installation
 
+```ruby
+gem 'named_accessors'
+```
+
+or 
+
 ```ruby
 gem 'named_accessors', git: 'git@github.com:zlw/named_accessors.git'
 ```
@@ -23,6 +29,10 @@ class Post
   named_accessor :title, as: :fancy_title
   named_writer :content, as: :post_content
   named_reader :created_at, as: :when_was_it_created?
+
+  named_accessor :foo, reader: :foobar, writer: :foobaz
+  named_accessor :foo, as: :bar, reader: :foobar
+  named_accessor :foo, as: :bar, writer: :foobar
 end
 
 post = Post.new('Lorem ispum')

data/lib/named_accessors/named_accessor.rb

@@ -1,8 +1,10 @@
 module NamedAccessors
   module NamedAccessor
     def named_accessor(name, options={})
-      named_writer(name, options)
-      named_reader(name, options)
+      reader, writer = extract_accessor_options(options)
+
+      named_reader(name, reader)
+      named_writer(name, writer)
     end
   end
 end

data/lib/named_accessors/utilities.rb

@@ -16,5 +16,15 @@ module NamedAccessors
     def instance_variable_name(name)
       :"@#{name}"
     end
+
+    def extract_accessor_options(options)
+      [extract_option(options, :reader), extract_option(options, :writer)]
+    end
+
+    def extract_option(options, type)
+      option = options.fetch(type, nil)
+
+      option ? options.merge(as: option) : options
+    end
   end
 end

data/lib/named_accessors/version.rb

@@ -1,3 +1,3 @@
 module NamedAccessors
-  VERSION = "1.0"
+  VERSION = "1.1"
 end

data/spec/named_accessors/named_accessor_module_spec.rb

@@ -31,4 +31,46 @@ describe Object do
       klass.send(:instance_variable_name, :foobar).should == :'@foobar'
     end
   end
+
+  context '#extract_option' do
+    it 'should return changed `as` option to reader' do
+      klass.send(:extract_option, {as: :foo, reader: :foobar}, :reader)[:as].should == :foobar
+    end
+
+    it 'should return not changed `as` options if reader is not given' do
+      klass.send(:extract_option, {as: :foo}, :reader)[:as].should == :foo
+    end
+
+    it 'should return changed `as` option to writer' do
+      klass.send(:extract_option, {as: :foo, writer: :foobar}, :writer)[:as].should == :foobar
+    end
+
+    it 'should return not changed `as` option if writer is not given' do
+      klass.send(:extract_option, {as: :foo}, :writer)[:as].should == :foo
+    end
+  end
+
+  context '#extract_accessor_options' do
+    it 'should return array of option hashes' do
+      klass.send(:extract_accessor_options, {as: :foo}).should == [{as: :foo}, {as: :foo}]
+    end
+
+    it 'should return array of option hashes with changed reader' do
+      options = klass.send(:extract_accessor_options, {as: :foo, reader: :foobar})
+
+      reader, writer = options
+
+      reader[:as].should == :foobar
+      writer[:as].should == :foo
+    end
+
+    it 'should return array of option hashes with changed writer' do
+      options = klass.send(:extract_accessor_options, {as: :foo, writer: :foobar})
+
+      reader, writer = options
+
+      reader[:as].should == :foo
+      writer[:as].should == :foobar
+    end
+  end
 end

data/spec/named_accessors/named_accessors_spec.rb

@@ -1,44 +1,61 @@
 require 'spec_helper'
 
-class Post
-  def initialize(title)
-    @title, @content, @created_at = title, '', 'Today'
-  end
-
-  named_accessor :title, as: :fancy_title
-  named_writer :content, as: :post_content
-  named_reader :created_at, as: :when_was_it_created?
-end
-
 describe Object do
   let(:post) { Post.new('foobar') }
+  let(:klass) { Object }
 
-  context "#named_reader" do
-    it "should respond to getter method with specified name" do
-      post.should respond_to(:when_was_it_created?)
+  context '#named_reader' do
+    it 'should respond to getter method with specified name' do
+      klass.named_reader(:created_at, as: :when_was_it_created?)
+      klass.should respond_to :when_was_it_created?
     end
 
     it 'should return value of instance variable' do
-      post.when_was_it_created?.should == 'Today'
+      klass.instance_variable_set(:'@created_at', 'Today')
+      klass.when_was_it_created?.should == 'Today'
     end
   end
 
-  context '#named_writer' do
+  context '#named_writed' do
     it 'should respond to setter method with specified name' do
-      post.should respond_to(:post_content=)
+      klass.named_writer(:content, as: :post_content)
+      klass.should respond_to :post_content=
     end
 
-    it "should set value to instance method" do
-      content = 'barbaz'
-      post.post_content = content
-      post.instance_variable_get(:"@content").should == content
+    it 'should set value to instance method' do
+      klass.post_content = 'Lorem ipsum'
+      klass.instance_variable_get(:'@content').should == 'Lorem ipsum'
     end
   end
 
   context '#named_accessor' do
-    it "should respond to both getter and setter" do
-      post.should respond_to(:fancy_title)
-      post.should respond_to(:fancy_title=)
+    it 'should respond to both reader and writer' do
+      klass.named_accessor :title, as: :fancy_title
+      klass.should respond_to :fancy_title, :fancy_title=
+    end
+
+    it 'should respond to changed writer name' do
+      klass.named_accessor :foo, as: :foobar, writer: :bar
+      klass.should respond_to :foobar
+      klass.should respond_to :bar=
+    end
+
+    it 'should respond to changed reader name' do
+      klass.named_accessor :foo, as: :foobaz, reader: :baz
+      klass.should respond_to :foobaz=
+      klass.should respond_to :baz
+    end
+
+    it 'should respond to changed both reader and writer' do
+      klass.named_accessor :foo, as: :dummy, reader: :one, writer: :two
+      klass.should respond_to :one
+      klass.should respond_to :two=
+    end
+
+    it 'shoud respond to changed both reader and writer when `as` option is not given' do
+      klass.named_accessor :foo, reader: :reader, writer: :writer
+      klass.should respond_to :reader
+      klass.should respond_to :writer=
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: named_accessors
 version: !ruby/object:Gem::Version
-  version: '1.0'
+  version: '1.1'
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-15 00:00:00.000000000 Z
+date: 2012-02-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70111683845780 !ruby/object:Gem::Requirement
+  requirement: &70118597470420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70111683845780
+  version_requirements: *70118597470420
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70111683845300 !ruby/object:Gem::Requirement
+  requirement: &70118597469940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,7 +32,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70111683845300
+  version_requirements: *70118597469940
 description: Create attr_accessor (attr_reader/attr_writer) with specified name
 email:
 - zlw.zalewski@gmail.com
@@ -67,12 +67,18 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -3223851256822058182
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -3223851256822058182
 requirements: []
 rubyforge_project: named_accessors
 rubygems_version: 1.8.15