name_of_person 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 361510fe7cb6b267e3a9d5e2b58e62b17a1a1330fb8ec833c5f6b9b744ad3811
-  data.tar.gz: a520d4f0283d4333607491548e03aa7509921008210385ba67c594bb6b47ad58
+  metadata.gz: c68f3b0e0e4361dc4dd4d5214d1f896cee83276ba8b4654cacba1782766e50a3
+  data.tar.gz: 9d232052de3441c9201f48905d89d81d06560e9fc99ae2788c451b62a7b943ac
 SHA512:
-  metadata.gz: 4a828efd10ce8133325a60ca4bdbc643b3736f84c9acc1e8738d612223ffaef082e425b9478c1cb152197db7a0128754cfbc493783832859bcb1f544a4c0f6ce
-  data.tar.gz: c98b44e5420cadd80d7a2d997a1493e99ebed9b81f73bc2d6b2302ff9e47dca6d072b9a59804417f1acd1a5b44da243fd8c176f8f4d35ad27a5c7aa0669cc2f5
+  metadata.gz: 1895f409c69ac9131f7c949d8ef5d480f6a413b88d5afa91503930d98f6582680e54e27ce212d98dbb97bb16c4c08d11a26e90845ef0828b127b190bfaaf0bec
+  data.tar.gz: 3683027336a25105aa4c22638b532eebbfe311ada04e47569c303649e505fc25b3d6a29752a3911cb071f4839791b36e5f182b67d03cb2800e9dd1ad50e0d652

data/Gemfile.lock

@@ -1,38 +1,36 @@
 PATH
   remote: .
   specs:
-    name_of_person (1.1.1)
+    name_of_person (1.1.2)
       activesupport (>= 5.2.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (5.2.1)
-      activesupport (= 5.2.1)
-    activesupport (5.2.1)
+    activemodel (7.0.7.2)
+      activesupport (= 7.0.7.2)
+    activesupport (7.0.7.2)
       concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 0.7, < 2)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-    byebug (10.0.2)
-    concurrent-ruby (1.0.5)
-    i18n (1.1.0)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+    byebug (11.1.3)
+    concurrent-ruby (1.2.2)
+    i18n (1.14.1)
+      concurrent-ruby (~> 1.0)
+    minitest (5.19.0)
+    rake (13.0.6)
+    tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    minitest (5.11.3)
-    rake (12.3.1)
-    thread_safe (0.3.6)
-    tzinfo (1.2.5)
-      thread_safe (~> 0.1)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   activemodel (>= 5.2.0)
-  bundler (~> 1.15)
   byebug
   name_of_person!
   rake
 
 BUNDLED WITH
-   1.17.2
+   2.4.18

data/README.md

@@ -22,6 +22,12 @@ person.name.abbreviated # => "D. Heinemeier Hansson"
 person.name.sorted      # => "Heinemeier Hansson, David"
 person.name.mentionable # => "davidh"
 person.name.possessive  # => "David Heinemeier Hansson's"
+person.name.possessive(:first)  # => "David's"
+person.name.possessive(:last)  # => "Hansson's"
+person.name.possessive(:initials)  # => "DHH's"
+person.name.possessive(:sorted)  # => "Heinemeier Hansson, David's"
+person.name.possessive(:abbreviated)  # => "D. Heinemeier Hansson's"
+
 
 # Use directly
 name = NameOfPerson::PersonName.full("David Heinemeier Hansson")
@@ -43,9 +49,9 @@ require 'active_record'
 require 'active_model'
 ```
 
-## Maintenance Expectations
+## No further development is going to happen
 
-This library is an extraction from Basecamp that's been sufficient in almost unaltered form for over 10 years. While contributions are always welcome, do not expect a lot of feature evolution beyond the basics. Feel free to fork this library if you'd like to add large upgrades like titulations or different accommodations for other languages.
+This gem is essentially frozen, as the developers have decided to only deal with full names going forward in their applications. Feel free to fork this work, brand it under a new name, and continue development.
 
 ## License
 

data/lib/name_of_person/assignable_name.rb

@@ -10,7 +10,7 @@ module NameOfPerson
 
     # Returns a PersonName object created from the first_name and last_name attributes.
     def name
-      NameOfPerson::PersonName.new(first_name, last_name) if first_name
+      NameOfPerson::PersonName.new(first_name, last_name) if first_name.present?
     end
   end
 end

data/lib/name_of_person/loaders/active_model_has_person_name.rb

@@ -1,3 +1,9 @@
-if defined?(ActiveModel)
-  ActiveModel::Model.send :include, NameOfPerson::HasPersonName
+if ActiveSupport.gem_version < "7.1.0.alpha"
+  if defined?(ActiveModel)
+    ActiveModel::Model.send :include, NameOfPerson::HasPersonName
+  end
+else
+  ActiveSupport.on_load(:active_model) do
+    include NameOfPerson::HasPersonName
+  end
 end

data/lib/name_of_person/loaders/active_record_has_person_name.rb

@@ -1,3 +1,3 @@
-if defined?(ActiveRecord)
-  ActiveRecord::Base.send :include, NameOfPerson::HasPersonName
+ActiveSupport.on_load(:active_record) do
+  include NameOfPerson::HasPersonName
 end

data/lib/name_of_person/person_name.rb

@@ -1,3 +1,4 @@
+require 'active_support'
 require 'active_support/core_ext/string'
 
 module NameOfPerson
@@ -36,13 +37,21 @@ module NameOfPerson
     end
 
     # Returns full name with with trailing 's or ' if name ends in s.
-    def possessive
-      @possessive ||= "#{self}'#{"s" unless end_with?("s")}"
+    def possessive(method = :full)
+      whitelist = %i[full first last abbreviated sorted initials]
+
+      unless whitelist.include?(method.to_sym)
+        raise ArgumentError, 'Please provide a valid method'
+      end
+
+      name = public_send(method)
+
+      @possessive ||= "#{name}'#{'s' unless name.downcase.end_with?('s')}"
     end
 
     # Returns just the initials.
     def initials
-      @initials ||= remove(/(\(|\[).*(\)|\])/).scan(/([[:word:]])[[:word:]]+/i).join
+      @initials ||= remove(/(\(|\[).*(\)|\])/).scan(/([[:word:]])[[:word:]]*/i).join
     end
 
     # Returns a mentionable version of the familiar name

data/name_of_person.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name     = 'name_of_person'
-  s.version  = '1.1.1'
+  s.version  = '1.1.2'
   s.authors  = 'David Heinemeier Hansson'
   s.email    = 'david@basecamp.com'
   s.summary  = 'Presenting names of people in full, familiar, abbreviated, and initialized forms (but without titulation etc)'
@@ -12,7 +12,6 @@ Gem::Specification.new do |s|
   s.add_dependency 'activesupport', '>= 5.2.0'
 
   s.add_development_dependency 'activemodel', '>= 5.2.0'
-  s.add_development_dependency 'bundler', '~> 1.15'
 
   s.files      = `git ls-files`.split("\n")
   s.test_files = `git ls-files -- test/*`.split("\n")

data/test/person_name_test.rb

@@ -56,6 +56,32 @@ class PersonNameTest < ActiveSupport::TestCase
     assert_equal "Foo Bars'", PersonName.new('Foo', 'Bars').possessive
   end
 
+  test "possessive first" do
+    assert_equal "#{@name.first}'s", @name.possessive(:first)
+  end
+
+  test "possessive last" do
+    assert_equal "#{@name.last}'s", @name.possessive(:last)
+  end
+
+  test "possessive sorted" do
+    assert_equal "#{@name.sorted}'s", @name.possessive(:sorted)
+  end
+
+  test "possessive initials" do
+    assert_equal "#{@name.initials}'s", @name.possessive(:initials)
+  end
+  
+  test "possessive abbreviated" do
+    assert_equal "#{@name.abbreviated}'s", @name.possessive(:abbreviated)
+  end
+
+  test "possessive with invalid arguments" do
+    assert_raise ArgumentError do
+      @name.possessive(:not_allowed)
+    end
+  end
+
   test "initials" do
     name = PersonName.full('David Heinemeier Hansson')
     assert_equal 'DHH', name.initials
@@ -86,6 +112,11 @@ class PersonNameTest < ActiveSupport::TestCase
     assert_equal 'CM', name.initials
   end
 
+  test "initials single letter" do
+    name = PersonName.full('C')
+    assert_equal 'C', name.initials
+  end
+
   test "from full name" do
     name = PersonName.full('Will St. Clair')
     assert_equal 'Will', name.first

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: name_of_person
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - David Heinemeier Hansson
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-04-25 00:00:00.000000000 Z
+date: 2023-09-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -38,21 +38,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 5.2.0
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.15'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.15'
-description: 
+description:
 email: david@basecamp.com
 executables: []
 extensions: []
@@ -77,7 +63,7 @@ homepage: https://github.com/basecamp/name_of_person
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -92,8 +78,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.4.18
+signing_key:
 specification_version: 4
 summary: Presenting names of people in full, familiar, abbreviated, and initialized
   forms (but without titulation etc)