name_of_person 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6e75bed8c641e0f6361203d37e575fd793e9a13ecb8cc1a2447b6c8b81e01a2c
-  data.tar.gz: 245209ff20495805ecd4cba96d532a77dfe41abf303d4aa5e3bb5362e5fb1998
+  metadata.gz: 361510fe7cb6b267e3a9d5e2b58e62b17a1a1330fb8ec833c5f6b9b744ad3811
+  data.tar.gz: a520d4f0283d4333607491548e03aa7509921008210385ba67c594bb6b47ad58
 SHA512:
-  metadata.gz: 444b437c826b0a5daeb4409b3ea4c9e71303c1c1ad00ac7e690581f20b84c6a02de625062b12f8356fd5f433fa8cd40b980fa848bb0afe59f18f95a41fb1e89b
-  data.tar.gz: a7de5f58c5f30780d6883f5f8a6a32b0eaee3ab514406446d85f6205449fbbf69703922e318c04def9cbe075229b553cf37834b3809218534b7eb000f058d9e1
+  metadata.gz: 4a828efd10ce8133325a60ca4bdbc643b3736f84c9acc1e8738d612223ffaef082e425b9478c1cb152197db7a0128754cfbc493783832859bcb1f544a4c0f6ce
+  data.tar.gz: c98b44e5420cadd80d7a2d997a1493e99ebed9b81f73bc2d6b2302ff9e47dca6d072b9a59804417f1acd1a5b44da243fd8c176f8f4d35ad27a5c7aa0669cc2f5

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    name_of_person (1.1.0)
+    name_of_person (1.1.1)
       activesupport (>= 5.2.0)
 
 GEM

data/README.md

@@ -28,10 +28,25 @@ name = NameOfPerson::PersonName.full("David Heinemeier Hansson")
 name.first # => "David"
 ```
 
+## Installation
+
+```ruby
+# Gemfile
+gem 'name_of_person'
+```
+
+If you are using this outside of Rails, make sure `ActiveRecord` and/or `ActiveModel` are manually required.
+
+```ruby
+require 'active_record'
+# and/or
+require 'active_model'
+```
+
 ## Maintenance Expectations
 
 This library is an extraction from Basecamp that's been sufficient in almost unaltered form for over 10 years. While contributions are always welcome, do not expect a lot of feature evolution beyond the basics. Feel free to fork this library if you'd like to add large upgrades like titulations or different accommodations for other languages.
 
 ## License
 
-Name of Person is released under the [MIT License](https://opensource.org/licenses/MIT).
+Name of Person is released under the [MIT License](https://opensource.org/licenses/MIT).

data/lib/name_of_person.rb

@@ -1,5 +1,6 @@
 module NameOfPerson
 end
 
+require 'name_of_person/has_person_name'
 require 'name_of_person/loaders/active_model_has_person_name'
 require 'name_of_person/loaders/active_record_has_person_name'

data/lib/name_of_person/loaders/active_model_has_person_name.rb

@@ -1,9 +1,3 @@
-begin
-  require 'active_model'
-  require 'name_of_person/has_person_name'
-
-  require 'active_model/model'
+if defined?(ActiveModel)
   ActiveModel::Model.send :include, NameOfPerson::HasPersonName
-rescue LoadError
-  # Active Model won't be auto-configured with has_person_name
 end

data/lib/name_of_person/loaders/active_record_has_person_name.rb

@@ -1,8 +1,3 @@
-begin
-  require 'active_record'
-  require 'name_of_person/has_person_name'
-
+if defined?(ActiveRecord)
   ActiveRecord::Base.send :include, NameOfPerson::HasPersonName
-rescue LoadError
-  # Active Record won't be auto-configured with has_person_name
 end

data/lib/name_of_person/person_name.rb

@@ -42,7 +42,7 @@ module NameOfPerson
 
     # Returns just the initials.
     def initials
-      @initials ||= scan(/(\S)\S+/).join
+      @initials ||= remove(/(\(|\[).*(\)|\])/).scan(/([[:word:]])[[:word:]]+/i).join
     end
 
     # Returns a mentionable version of the familiar name

data/name_of_person.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name     = 'name_of_person'
-  s.version  = '1.1.0'
+  s.version  = '1.1.1'
   s.authors  = 'David Heinemeier Hansson'
   s.email    = 'david@basecamp.com'
   s.summary  = 'Presenting names of people in full, familiar, abbreviated, and initialized forms (but without titulation etc)'

data/test/has_person_name_test.rb

@@ -1,7 +1,8 @@
 require 'active_support'
 require 'active_support/testing/autorun'
 
-require 'name_of_person/loaders/active_model_has_person_name'
+require 'active_model'
+require 'name_of_person'
 
 class ModelPerson
   include ActiveModel::Model

data/test/person_name_test.rb

@@ -71,6 +71,21 @@ class PersonNameTest < ActiveSupport::TestCase
     assert_equal 'D', name.initials
   end
 
+  test "initials skip anything inside parenthesis" do
+    name = PersonName.full('Conor Muirhead (Basecamp)')
+    assert_equal 'CM', name.initials
+  end
+
+  test "initials skip anything inside brackets" do
+    name = PersonName.full('Conor Muirhead [Basecamp]')
+    assert_equal 'CM', name.initials
+  end
+
+  test "initials skip non-word characters" do
+    name = PersonName.full('Conor Muirhead !')
+    assert_equal 'CM', name.initials
+  end
+
   test "from full name" do
     name = PersonName.full('Will St. Clair')
     assert_equal 'Will', name.first

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: name_of_person
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-08 00:00:00.000000000 Z
+date: 2019-04-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -92,8 +92,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Presenting names of people in full, familiar, abbreviated, and initialized