name_of_person 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b03a84a4207dc1c212ede9e467ece80d14b4d73b889ad93c9665e177c1a744c0
-  data.tar.gz: 8e8420b6460848be39581db10a64b8b2a7dfa4504ad5b355cfae98cfda5366d8
+  metadata.gz: 6e75bed8c641e0f6361203d37e575fd793e9a13ecb8cc1a2447b6c8b81e01a2c
+  data.tar.gz: 245209ff20495805ecd4cba96d532a77dfe41abf303d4aa5e3bb5362e5fb1998
 SHA512:
-  metadata.gz: 3f0be6604bb1a94775c009cbba1bb34d6369747cdd9466b35ae24385da15bbbcf4f00605913456b9360464dc26ffd8779183c1506567dc8a9eb3ee7becf28060
-  data.tar.gz: e31dc4fb63ae0dc3387d343842b6e5aae1348863fc6b6c82ce8770247157ef95ff47bed6dfca50c6d6d32d7f80666f7014108560fc687c09d063451002de36e6
+  metadata.gz: 444b437c826b0a5daeb4409b3ea4c9e71303c1c1ad00ac7e690581f20b84c6a02de625062b12f8356fd5f433fa8cd40b980fa848bb0afe59f18f95a41fb1e89b
+  data.tar.gz: a7de5f58c5f30780d6883f5f8a6a32b0eaee3ab514406446d85f6205449fbbf69703922e318c04def9cbe075229b553cf37834b3809218534b7eb000f058d9e1

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    name_of_person (0.1.0)
+    name_of_person (1.1.0)
       activesupport (>= 5.2.0)
 
 GEM
@@ -35,4 +35,4 @@ DEPENDENCIES
   rake
 
 BUNDLED WITH
-   1.16.3
+   1.17.2

data/README.md

@@ -30,7 +30,7 @@ name.first # => "David"
 
 ## Maintenance Expectations
 
-This library is an extraction from Basecamp that's been sufficient in almost unaltered form for over 10 years. While contributions are always welcome, do not expect a lot of feature evolution beyond the basics. Feel free to fork this library if you'd like to add large upgrades like titulations or different accomodations for other languages.
+This library is an extraction from Basecamp that's been sufficient in almost unaltered form for over 10 years. While contributions are always welcome, do not expect a lot of feature evolution beyond the basics. Feel free to fork this library if you'd like to add large upgrades like titulations or different accommodations for other languages.
 
 ## License
 

data/lib/name_of_person/assignable_name.rb

@@ -5,7 +5,7 @@ module NameOfPerson
     # Assigns first_name and last_name attributes as extracted from a supplied full name.
     def name=(name)
       full_name = NameOfPerson::PersonName.full(name)
-      self.first_name, self.last_name = full_name.try(:first), full_name.try(:last)
+      self.first_name, self.last_name = full_name&.first, full_name&.last
     end
 
     # Returns a PersonName object created from the first_name and last_name attributes.

data/lib/name_of_person/person_name.rb

@@ -5,7 +5,7 @@ module NameOfPerson
     attr_reader :first, :last
 
     def self.full(full_name)
-      first, last = full_name.to_s.strip.split(/\s+/, 2)
+      first, last = full_name.to_s.squish.split(/\s/, 2)
       new(first, last) if first.present?
     end
 
@@ -42,7 +42,7 @@ module NameOfPerson
 
     # Returns just the initials.
     def initials
-      @initials ||= scan(/\b(\S)\S*/).join
+      @initials ||= scan(/(\S)\S+/).join
     end
 
     # Returns a mentionable version of the familiar name

data/name_of_person.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name     = 'name_of_person'
-  s.version  = '1.0.0'
+  s.version  = '1.1.0'
   s.authors  = 'David Heinemeier Hansson'
   s.email    = 'david@basecamp.com'
   s.summary  = 'Presenting names of people in full, familiar, abbreviated, and initialized forms (but without titulation etc)'

data/test/person_name_test.rb

@@ -56,6 +56,21 @@ class PersonNameTest < ActiveSupport::TestCase
     assert_equal "Foo Bars'", PersonName.new('Foo', 'Bars').possessive
   end
 
+  test "initials" do
+    name = PersonName.full('David Heinemeier Hansson')
+    assert_equal 'DHH', name.initials
+  end
+
+  test "initials (full name with spaces)" do
+    name = PersonName.full('  David    Heinemeier   Hansson  ')
+    assert_equal 'DHH', name.initials
+  end
+
+  test "initials for just a first name" do
+    name = PersonName.full('David')
+    assert_equal 'D', name.initials
+  end
+
   test "from full name" do
     name = PersonName.full('Will St. Clair')
     assert_equal 'Will', name.first
@@ -69,6 +84,34 @@ class PersonNameTest < ActiveSupport::TestCase
     assert_nil PersonName.full('')
   end
 
+  test "full name with spaces at the edges of the string" do
+    name = PersonName.full('  Will St. Clair ')
+    assert_equal 'Will', name.first
+    assert_equal 'St. Clair', name.last
+    assert_equal 'Will St. Clair', name.full
+  end
+
+  test "full name with spaces between first and last name" do
+    name = PersonName.full('Will   St. Clair')
+    assert_equal 'Will', name.first
+    assert_equal 'St. Clair', name.last
+    assert_equal 'Will St. Clair', name.full
+  end
+
+  test "full name with spaces between multiple last name words" do
+    name = PersonName.full('Will St.   Clair')
+    assert_equal 'Will', name.first
+    assert_equal 'St. Clair', name.last
+    assert_equal 'Will St. Clair', name.full
+  end
+
+  test "full name with spaces everywhere" do
+    name = PersonName.full('  Will     St.   Clair       ')
+    assert_equal 'Will', name.first
+    assert_equal 'St. Clair', name.last
+    assert_equal 'Will St. Clair', name.full
+  end
+
   test "blank last name behaves the same as nil" do
     name = PersonName.new('Baz', '')
     assert_equal @first.full, name.full
@@ -82,6 +125,11 @@ class PersonNameTest < ActiveSupport::TestCase
     assert_equal 'foob', @name.mentionable
   end
 
+  test "mentionable with first name" do
+    name = PersonName.full('Will')
+    assert_equal 'wil', name.mentionable
+  end
+
   test "mentionable with three names" do
     name = PersonName.full('Will St. Clair')
     assert_equal 'wills', name.mentionable

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: name_of_person
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-02 00:00:00.000000000 Z
+date: 2019-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport