name_checker 0.0.2 → 0.0.3

data/lib/name_checker/facebook_checker.rb

@@ -13,6 +13,13 @@ module NameChecker
       end
 
       res = get("/#{name}")
+    # So Facebook is bolloxed and sends back just the word 'false'
+    # as the (invalid) json for certain queries. This causes a
+    # MultiJson::DecodeError inside HTTParty which we need to catch.
+    # INFO: http://stackoverflow.com/q/7357493/574190
+    rescue MultiJson::DecodeError
+      Availability.new(@service_name, false)
+    else
       status = handle_response(res, name)
       Availability.new(@service_name, status)
     end

data/lib/name_checker/version.rb

@@ -1,3 +1,3 @@
 module NameChecker
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/fixtures/vcr_cassettes/facebook/false.yml

@@ -0,0 +1,42 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: https://graph.facebook.com/thirdone
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers: {}
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Access-Control-Allow-Origin:
+      - ! '*'
+      Cache-Control:
+      - private, no-cache, no-store, must-revalidate
+      Content-Type:
+      - text/javascript; charset=UTF-8
+      Etag:
+      - ! '"7cb6efb98ba5972a9b5090dc2e517fe14d12cb04"'
+      Expires:
+      - Sat, 01 Jan 2000 00:00:00 GMT
+      Pragma:
+      - no-cache
+      X-Fb-Rev:
+      - '581908'
+      X-Fb-Debug:
+      - TlKhe58LBPKAzFy6YD8wWR/U5Qs1lKEq4aL10EdLrCo=
+      Date:
+      - Thu, 28 Jun 2012 18:36:30 GMT
+      Connection:
+      - keep-alive
+      Content-Length:
+      - '5'
+    body:
+      encoding: US-ASCII
+      string: 'false'
+    http_version: 
+  recorded_at: Thu, 28 Jun 2012 18:36:30 GMT
+recorded_with: VCR 2.2.0

data/spec/name_checker/facebook_checker_spec.rb

@@ -16,6 +16,14 @@ describe NameChecker::FacebookChecker, "check" do
     end
   end
 
+  it "should return negative if facebook returns 'false'" do
+    VCR.use_cassette(fixture_path("false")) do
+      availability = subject.check("thirdone")
+      availability.should be_unavailable
+      availability.service.should == "facebook"
+    end
+  end
+
   it "should return positive the name is available" do
     VCR.use_cassette(fixture_path("available")) do
       availability = subject.check("sdfjksdh")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: name_checker
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-05-15 00:00:00.000000000 Z
+date: 2012-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70353667712220 !ruby/object:Gem::Requirement
+  requirement: &70267507510360 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70353667712220
+  version_requirements: *70267507510360
 - !ruby/object:Gem::Dependency
   name: vcr
-  requirement: &70353667727120 !ruby/object:Gem::Requirement
+  requirement: &70267507509900 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70353667727120
+  version_requirements: *70267507509900
 - !ruby/object:Gem::Dependency
   name: httparty
-  requirement: &70353667724720 !ruby/object:Gem::Requirement
+  requirement: &70267507509460 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70353667724720
+  version_requirements: *70267507509460
 - !ruby/object:Gem::Dependency
   name: whois
-  requirement: &70353667722700 !ruby/object:Gem::Requirement
+  requirement: &70267507509020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,7 +54,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70353667722700
+  version_requirements: *70267507509020
 description: ! '    NameChecker is a Ruby library for checking the availability of
   a word across various TLDs and social networks. It was created to power http://domiy.com.
 
@@ -84,6 +84,7 @@ files:
 - lib/name_checker/whois_checker.rb
 - name_checker.gemspec
 - spec/fixtures/vcr_cassettes/facebook/available.yml
+- spec/fixtures/vcr_cassettes/facebook/false.yml
 - spec/fixtures/vcr_cassettes/facebook/unavailable.yml
 - spec/fixtures/vcr_cassettes/facebook/weird_chars.yml
 - spec/fixtures/vcr_cassettes/robo_whois/available.yml
@@ -128,6 +129,7 @@ specification_version: 3
 summary: Check the availability of a name on various services.
 test_files:
 - spec/fixtures/vcr_cassettes/facebook/available.yml
+- spec/fixtures/vcr_cassettes/facebook/false.yml
 - spec/fixtures/vcr_cassettes/facebook/unavailable.yml
 - spec/fixtures/vcr_cassettes/facebook/weird_chars.yml
 - spec/fixtures/vcr_cassettes/robo_whois/available.yml