namba 1.2.0 → 1.3.0

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    namba (1.1.0)
+    namba (1.2.0)
       multi_json
 
 GEM

data/README.md

@@ -1,6 +1,7 @@
 ## The Namba Ruby gem
 
 [![Build Status](https://secure.travis-ci.org/ZeroOneStudio/namba.png)](http://travis-ci.org/ZeroOneStudio/namba)
+[![Code Climate](https://codeclimate.com/github/ZeroOneStudio/namba.png)](https://codeclimate.com/github/ZeroOneStudio/namba)
 
 A Ruby wrapper for the Namba API. The full API description is available [here][].
 
@@ -26,9 +27,9 @@ Or put to your `Gemfile`
 
     n = Namba.new()
 
-Use `:kz` locale if you want to access [namba.kz][] API. Default value is `:kg`
+Use `:net` locale if you want to access [namba.net][] API. Default value is `:kg`
 
-[namba.kz]: http://www.namba.kz
+[namba.net]: http://www.namba.net
 
 ## Methods spread on all Namba API
 
@@ -78,5 +79,7 @@ About `component_name` and `component_id` read more at [Namba Comments docs][]
 
 ## Licence
 
-MIT License Copyright (c) 2012 ZERO.ONE
+MIT License Copyright (c) 2012 [ZERO.ONE][]
+
+[ZERO.ONE]: http://www.zeroone.st
 

data/lib/namba/client.rb

@@ -7,8 +7,8 @@ module Namba
     include APIMethods
     attr_accessor *Config::VALID_KEYS
 
-    def initialize(opts = {})
-      opts = Namba::Config.options.merge(opts)
+    def initialize
+      opts = Namba::Config.options
       Config::VALID_KEYS.each do |key|
         instance_variable_set("@#{key}".to_sym, opts[key])
       end

data/lib/namba/config.rb

@@ -22,7 +22,7 @@ module Namba
         s.password = "" if s.password.nil? 
         s.locale = :kg if s.locale.nil? 
       end
-      raise ConfigurationError, "Available locales are only 'kg' and 'kz'" unless [:kg, :kz].include?(self.locale)
+      raise ConfigurationError, "Available locales are only 'kg' and 'net'" unless [:kg, :net].include?(self.locale)
     end
 
     def options

data/lib/namba/railtie.rb

@@ -1,7 +1,9 @@
+require 'namba/helpers/action_view_extension'
+
 module Namba
-  class Railtie < ::Rails::Railtie #:nodoc:
-    initializer 'namba' do |_app|
-      Namba::Hooks.init
+  class Railtie < Rails::Railtie
+    initializer "namba.action_view_extension" do
+      ActionView::Base.send :include, ActionViewExtension
     end
   end
 end

data/lib/namba/version.rb

@@ -1,3 +1,3 @@
 module Namba
-  VERSION = "1.2.0"
+  VERSION = "1.3.0"
 end

data/lib/namba.rb

@@ -1,6 +1,7 @@
 require "namba/version"
 require 'namba/client'
 require 'namba/config'
+require 'namba/railtie' if defined? Rails
 
 module Namba
   extend Config
@@ -8,8 +9,8 @@ module Namba
   class << self
 
     # Alias for Namba::Client.new()
-    def new(opts = {})
-      Namba::Client.new(opts)
+    def new
+      Namba::Client.new
     end
 
     # Alias for Namba::Config.configure 
@@ -18,13 +19,4 @@ module Namba
     end
 
   end
-end
-
-require 'namba/helpers/action_view_extension'
-require 'namba/hooks'
-
-# if not using Railtie, call `Namba::Hooks.init` directly
-if defined? Rails
-  require 'namba/railtie'
-  require 'namba/engine'
-end
+end  

data/spec/namba/action_view_extension_spec.rb

@@ -1,11 +1,13 @@
 require 'spec_helper'
-
+require 'namba/helpers/action_view_extension'
 
 describe Namba::ActionViewExtension do
 
-  it "should have :namba_comments and :namba_share methods" do
-    instance_methods = Namba::ActionViewExtension.instance_methods
-    instance_methods.should == [:namba_comments, :namba_share]
+  it "should have :namba_comments method" do
+    Namba::ActionViewExtension.method_defined?(:namba_comments).should == true
   end
 
+  it "should have :namba_share method" do
+    Namba::ActionViewExtension.method_defined?(:namba_share).should == true
+  end
 end

data/spec/namba/namba_spec.rb

@@ -14,14 +14,14 @@ describe Namba do
     Namba.configure do |config|
       config.username = "name"
       config.password = "secret"
-      config.locale = :kz
+      config.locale = :net
     end
 
     n = Namba.new()
 
     n.username.should == "name"    
     n.password.should == "secret"
-    n.locale.should == :kz
+    n.locale.should == :net
   end
 
   it "should set defaults when it is not set in configuration block" do
@@ -40,20 +40,20 @@ describe Namba do
       Namba.configure do |config|
         config.locale = :ru
       end 
-    }.should raise_error(Namba::ConfigurationError, "Available locales are only 'kg' and 'kz'")
+    }.to raise_error(Namba::ConfigurationError, "Available locales are only 'kg' and 'net'")
   end
   
   it "should raise Invalid Response Error when status code is not 200" do
     Namba.configure do |config|
       config.username = "name"
       config.password = "secret"
-      config.locale = :kz
+      config.locale = :net
     end
 
     n = Namba.new()
     
     expect {
       n.send(:get_response_from, "http://api.namba.#{n.locale}/404")
-    }.should raise_error(Namba::InvalidResponseError, "Invalid response from service")
+    }.to raise_error(Namba::InvalidResponseError, "Invalid response from service")
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: namba
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
   prerelease: 
 platform: ruby
 authors:
@@ -10,11 +10,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-09 00:00:00.000000000 Z
+date: 2013-02-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
-  requirement: &80940780 !ruby/object:Gem::Requirement
+  requirement: &84853350 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -22,10 +22,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *80940780
+  version_requirements: *84853350
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &80940510 !ruby/object:Gem::Requirement
+  requirement: &84853100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -33,10 +33,10 @@ dependencies:
         version: 2.7.0
   type: :development
   prerelease: false
-  version_requirements: *80940510
+  version_requirements: *84853100
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &80940240 !ruby/object:Gem::Requirement
+  requirement: &84852890 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -44,10 +44,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *80940240
+  version_requirements: *84852890
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &80939920 !ruby/object:Gem::Requirement
+  requirement: &84852660 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -55,10 +55,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *80939920
+  version_requirements: *84852660
 - !ruby/object:Gem::Dependency
   name: rack-test
-  requirement: &80939630 !ruby/object:Gem::Requirement
+  requirement: &84852450 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -66,7 +66,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *80939630
+  version_requirements: *84852450
 description: Ruby wrapper for Namba API
 email:
 - sergey.kishenin@gmail.com
@@ -88,10 +88,8 @@ files:
 - lib/namba/api_methods.rb
 - lib/namba/client.rb
 - lib/namba/config.rb
-- lib/namba/engine.rb
 - lib/namba/error.rb
 - lib/namba/helpers/action_view_extension.rb
-- lib/namba/hooks.rb
 - lib/namba/railtie.rb
 - lib/namba/version.rb
 - namba.gemspec

data/lib/namba/engine.rb

@@ -1,4 +0,0 @@
-module Namba 
-  class Engine < ::Rails::Engine 
-  end
-end

data/lib/namba/hooks.rb

@@ -1,9 +0,0 @@
-module Namba
-  class Hooks
-    def self.init
-      ActiveSupport.on_load(:action_view) do
-        ::ActionView::Base.send :include, Namba::ActionViewExtension
-      end
-    end
-  end
-end