nacha 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1411753b1afc7c81a9e3875ec1541986d8b461afd5d0daae835879d17776ea7c
-  data.tar.gz: 38fbcd4d7e222177dfc8bdce195991d13716ae669ca4649a7cf4e3428ab646d0
+  metadata.gz: 4ab30c59682e44d667d8341db3d7caa948d310231f18e7bd95ca4326294a64c5
+  data.tar.gz: 2b8302f2ef6dc7aaad982c1519be8e22d08dcecd559588968789745e9af0a706
 SHA512:
-  metadata.gz: 34e0fe3b791e0a47f9bef29898815b5d7fccac762ec21cbf227e3896a6dc8933d0a68349ff4cd661a65bff4f886b68fd22a31236dfdc6984d21c27b83d12d295
-  data.tar.gz: 2f53f2b8ed728dc2778a1c78461fefb8dd22ddd8fe5d8ccefad1deff50931924e11af55b4a5edcbe1880455de7019b3434a0a42ceff8c12f99a3d8bdc75ac14e
+  metadata.gz: 114c117d5945dc843efe761f5b665caaed444e452f45c1a248449c250cf56c8975b990199d29d546a2a83a9ed270330e4bba619de37ec51a691a31faadd98769
+  data.tar.gz: 717e8720c587b4860f6e9003c448632e77b32a35a98d9016c16232af26252ef70cf431f216aa465d746b39405063fb278f4daedc575bdecabb8453d7fb2bbd69

data/.ruby-version

@@ -1 +1 @@
-2.4
+3.4.4

data/Gemfile

@@ -2,8 +2,3 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in nacha.gemspec
 gemspec
-
-gem 'pry-byebug', group: %i[development test]
-gem 'pry-highlight', group: %i[development test]
-gem 'pry-remote', group: %i[development test]
-gem 'pry-stack_explorer', group: %i[development test]

data/README.md

@@ -30,11 +30,10 @@ Or install it yourself as:
 API may change at any time.   Pull requests welcomed
 
 
-`"101 124000054 1240000540907021214A094101ZIONS FIRST NATIONAL BAZIONS FIRST NATIONAL BA       1"`
 
 ```ruby
-    ach_records = Nacha.parse(ach_file)
-
+    ach_string = "101 124000054 1240000540907021214A094101ZIONS FIRST NATIONAL BAZIONS FIRST NATIONAL BA       1"
+    ach_records = Nacha::Parser.parse_string(ach_string)
     ach_records[0].class  # => Nacha::Record::FileHeaderRecord
 
     ach_records[0].to_json

data/bin/console

@@ -6,9 +6,6 @@ require "nacha"
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
 
-# (If you use this, don't forget to add pry to your Gemfile!)
-# require "pry"
-# Pry.start
 
 require "irb"
 IRB.start(__FILE__)

data/lib/nacha/ach_date.rb

@@ -4,14 +4,41 @@ require 'date'
 # A Date object to handle some of the Ach formatted dates
 
 class Nacha::AchDate < Date
-  def self.new(date_str)
-    if date_str.is_a? String
-      strptime(date_str, '%y%m%d')
-    elsif date_str.is_a? Date
-      date_str.dup
+  def self.new(*args)
+    year, month, day = nil
+
+    case args[0]
+    when String
+      date_str = args[0]
+      # Use Date.strptime to parse the string into a temporary Date object
+      temp_date = Date.strptime(date_str, '%y%m%d')
+      year, month, day = temp_date.year, temp_date.month, temp_date.day
+    when Date
+      original_date = args[0]
+      year, month, day = original_date.year, original_date.month, original_date.day
+    when Integer # If it's a year integer, assume (year, month, day) or single Julian day
+      # If 3 arguments (year, month, day) are provided like Date.new(2023, 10, 26)
+      if args.length == 3 && args.all? { |arg| arg.is_a?(Integer) }
+        year, month, day = args[0], args[1], args[2]
+      else
+        # Fallback for other Date.new arguments like (jd) - let super handle directly
+        return super(*args) # IMPORTANT: Call super to create the instance
+      end
     else
-      super(date_str)
+      # If it's none of the above, pass arguments directly to Date.new.
+      # This handles cases like Date.new(2459918) (Julian day) or other Date constructors.
+      return super(*args)
     end
+
+    # If year, month, day were successfully parsed, create a Nacha::AchDate instance
+    # by calling the parent's `new` with the explicit components.
+    # `super()` in this context will call `Date.new(year, month, day)` but for *your* class.
+    # This works because `Date.new` is designed to be effectively `allocate.initialize`.
+    super(year, month, day)
+
+  rescue ArgumentError => e
+    # Catch errors that might arise from strptime or invalid date components
+    raise ArgumentError, "Invalid date format for Nacha::AchDate: #{args.inspect}. Original error: #{e.message}"
   end
 
   def to_s

data/lib/nacha/field.rb

@@ -1,15 +1,15 @@
 # coding: utf-8
-require 'pry'
+# frozen_string_literal: true
+
 require 'bigdecimal'
 require 'nacha/numeric'
 require 'nacha/aba_number'
 require 'nacha/ach_date'
 
 class Nacha::Field
-
-  attr_accessor :inclusion, :contents, :position
-  attr_accessor :data, :name, :errors
-  attr_reader  :input_data
+  attr_accessor :inclusion, :position
+  attr_accessor :name, :errors
+  attr_reader :contents, :data, :input_data
   attr_reader :data_type
   attr_reader :validator
   attr_reader :justification
@@ -17,17 +17,17 @@ class Nacha::Field
   attr_reader :output_conversion
   attr_reader :json_output
 
-  def initialize opts = {}
+  def initialize(opts = {})
     @data_type = String
     @errors = []
-    @name = 'Unknown'.freeze
+    @name = 'Unknown'
     @justification = :ljust
-    @fill_character =  ' '.freeze
+    @fill_character = ' '
     @json_output = [:to_s]
     @output_conversion = [:to_s]
-    opts.each do |k,v|
+    opts.each do |k, v|
       setter = "#{k}="
-      if(respond_to?(setter))
+      if respond_to?(setter)
         send(setter, v) unless v.nil?
       end
     end
@@ -35,94 +35,92 @@ class Nacha::Field
 
   # CXXX Constant
   #
-  def contents= val
+  def contents=(val)
     @contents = val
     case @contents
-    when /\AC(.*)\z/  # Constant
-      @data = $1
+    when /\AC(.*)\z/ # Constant
+      @data = Regexp.last_match(1)
     when /Numeric/
       @data_type = Nacha::Numeric
       @justification = :rjust
       @json_output = [[:to_i]]
       @output_conversion = [:to_i]
-      @fill_character = '0'.freeze
+      @fill_character = '0'
     when /.?TTTTAAAAC/
       @data_type = Nacha::AbaNumber
       @validator = :valid?
       @justification = :rjust
       @output_conversion = [:to_s]
-      @fill_character = ' '.freeze
+      @fill_character = ' '
     when 'YYMMDD'
       @data_type = Nacha::AchDate
       @justification = :rjust
       @validator = :valid?
       @json_output = [[:iso8601]]
       @output_conversion = [:to_s]
-      @fill_character = ' '.freeze
+      @fill_character = ' '
     when 'Alphameric'
       @data_type = String
       @justification = :ljust
       @output_conversion = [:to_s]
-      @fill_character = ' '.freeze
-    when /\$+\¢\¢/
+      @fill_character = ' '
+    when /\$+\u00a2\u00a2/
       @data_type = Nacha::Numeric
       @justification = :rjust
-      @json_output = [[:to_i],[:/,100.0]]
+      @json_output = [[:to_i], [:/, 100.0]]
       @output_conversion = [:to_i]
-      @fill_character = '0'.freeze
+      @fill_character = '0'
     end
   end
 
-  def data= val
+  def data=(val)
     @data = @data_type.new(val)
     @input_data = val
   end
 
   def mandatory?
-    @inclusion == 'M'.freeze
+    @inclusion == 'M'
   end
 
   def required?
-    @inclusion == 'R'.freeze
+    @inclusion == 'R'
   end
 
   def optional?
-    @inclusion == 'O'.freeze
+    @inclusion == 'O'
   end
 
   def valid?
     @valid = inclusion && contents && position
-    if(@validator && @data)
-      @valid &&= @data.send(@validator)
-    end
+    @valid &&= @data.send(@validator) if @validator && @data
     @valid
   end
 
-  def add_error err_string
+  def add_error(err_string)
     errors << err_string
   end
 
-  def self.unpack_str(definition = {  })
-    if(definition[:contents] =~ /(Numeric|\$+\¢\¢)/)
-      'a'.freeze
+  def self.unpack_str(definition = {})
+    if definition[:contents] =~ /(Numeric|\$+\u00a2\u00a2)/
+      'a'
     else
-      'A'.freeze
+      'A'
     end + definition[:position].size.to_s
   end
 
   def to_ach
     str = to_s
     fill_char = @fill_character
-    fill_char = ' '.freeze unless str
-    str ||= ''.freeze
-    str.send(justification,position.count, fill_char)
+    fill_char = ' ' unless str
+    str ||= ''
+    str.send(justification, position.count, fill_char)
   end
 
   def to_json_output
-    if(@json_output)
-      @json_output.reduce(@data) { |output, operation|
+    if @json_output
+      @json_output.reduce(@data) do |output, operation|
         output = output.send(*operation) if output
-      }
+      end
     else
       to_s
     end
@@ -135,5 +133,4 @@ class Nacha::Field
   def raw
     @data
   end
-
 end

data/lib/nacha/numeric.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 class Nacha::Numeric
-  attr_accessor :value
-  def initialize(val = nil)
+  def initialize val = nil
     self.value = val
   end
 
@@ -20,7 +19,7 @@ class Nacha::Numeric
   def value=(val)
     if val.is_a?(String)
       @value = val.dup
-      if !val.strip.empty?
+      if(val.strip.length > 0)
         @value = BigDecimal(val.strip)
         @op_value = @value
       else
@@ -30,15 +29,13 @@ class Nacha::Numeric
       @value = BigDecimal(val)
       @op_value = @value
     end
-    @value
   end
 
   def to_s
     @value ? @value.to_s : nil
   end
 
-  def respond_to?(method_name, include_private = false)
-    puts "In respond_to? #{method_name}"
+  def respond_to_missing?(method_name, include_private = false)
     @op_value.respond_to? method_name
   end
 
@@ -47,14 +44,15 @@ class Nacha::Numeric
   # should be checked to see if the operation is valid for it, not
   # necessarily the potentially string @value
   def method_missing(method_name, *args, &block)
-    puts "In method_missing for #{method_name} value_class = #{@value.class}, op_value_class = #{@op_value.class}"
     if @op_value.respond_to? method_name
       old_op_value = @op_value.dup
       if /!\z/.match?(method_name.to_s)
+        # rubocop:disable GitlabSecurity/PublicSend
         @op_value.send(method_name, *args, &block)
         return_value = @op_value
       else
         return_value = @op_value.send(method_name, *args, &block)
+        # rubocop:enable GitlabSecurity/PublicSend
       end
       if old_op_value != return_value
         @value = return_value

data/lib/nacha/record/base.rb

@@ -7,23 +7,21 @@ require 'nacha/record/validations/field_validations'
 module Nacha
   module Record
     class Base
-      include FieldValidations
+      include Validations::FieldValidations
 
       attr_accessor :children, :parent, :fields
-      attr_reader :definition, :name
-      attr_reader :validations
-
-      @@unpack_str = nil
-      # @@matcher = nil
+      attr_reader :name, :validations
 
       def initialize(opts = {})
         @children = []
         create_fields_from_definition
         opts.each do |k, v|
           setter = "#{k}="
-          if respond_to?(setter)
-            send(setter, v) unless v.nil?
-          end
+          next unless respond_to? setter
+
+          # rubocop:disable GitlabSecurity/PublicSend
+          send(setter, v) unless v.nil?
+          # rubocop:enable GitlabSecurity/PublicSend
         end
       end
 
@@ -63,12 +61,12 @@ module Nacha
         definition[name] = { inclusion: inclusion,
                              contents: contents,
                              position: position,
-                             name: name }
+                             name: name}
         validation_method = "valid_#{name}".to_sym
-        if respond_to?(validation_method)
-          validations[name] ||= []
-          validations[name] << validation_method
-        end
+        return unless respond_to?(validation_method)
+
+        validations[name] ||= []
+        validations[name] << validation_method
       end
 
       def self.definition
@@ -79,8 +77,8 @@ module Nacha
         @validations ||= {}
       end
 
-      def self.nacha_record_name(record_name)
-        @nacha_record_name = record_name
+      class << self
+        attr_reader :nacha_record_name
       end
 
       def definition
@@ -89,23 +87,27 @@ module Nacha
 
       def validate
         self.class.definition.keys.map do |field|
-          if self.class.validations[field]
-            field_data = send(field)
-            send(self.class.validations[:field], field_data)
-          end
+          next unless self.class.validations[field]
+
+          # rubocop:disable GitlabSecurity/PublicSend
+          field_data = send(field)
+          send(self.class.validations[:field], field_data)
+          # rubocop:enable GitlabSecurity/PublicSend
         end
       end
 
       # look for invalid fields, if none, then return true
       def valid?
-        !self.class.definition.keys.map do |field_sym|
+        statuses = self.class.definition.keys.map do |field_sym|
+          # rubocop:disable GitlabSecurity/PublicSend
           field = send(field_sym)
-          next unless field.mandatory?
+          # rubocop:enable GitlabSecurity/PublicSend
+          next true unless field.mandatory?
 
           ## TODO: levels of validity with 'R' and 'O' fields
-
           field.valid?
-        end.detect { |valid| valid == false }
+        end
+        !statuses.detect { |valid| valid == false }
       end
 
       def debit?
@@ -146,6 +148,7 @@ module Nacha
 
       def respond_to?(method_name, include_private = false)
         field_name = method_name.to_s.gsub(/=$/, '').to_sym
+
         definition[field_name] || super
       end
 
@@ -155,7 +158,9 @@ module Nacha
         if @fields[field_name]
           if is_assignment
             # @fields[field_name].send(:data=,*args)
-            @fields[field_name].send(:data=, *args)
+            # rubocop:disable GitlabSecurity/PublicSend
+            @fields[field_name].public_send(:data=, *args)
+            # rubocop:enable GitlabSecurity/PublicSend
             @dirty = true
           else
             # @fields[field_name].data

data/lib/nacha/record/validations/field_validations.rb

@@ -3,29 +3,31 @@
 
 module Nacha
   module Record
-    module FieldValidations
-      def self.included(base)
-        base.extend ClassMethods
-      end
-      module ClassMethods
-        def check_field_error(field, message = nil, condition = nil)
-          (block_given? ? yield : condition) || (field.add_error("'#{field.data}' is invalid") && false)
+    module Validations
+      module FieldValidations
+        def self.included base
+          base.extend ClassMethods
         end
+        module ClassMethods
+          def check_field_error(field, message = nil, condition = nil)
+            (block_given? ? yield : condition) || (field.add_error("'#{field.data}' is invalid") && false)
+          end
 
-        def valid_service_class_code(field)
-          check_field_error(field) { SERVICE_CLASS_CODES.include? field.to_s }
-        end
+          def valid_service_class_code field
+            check_field_error(field) { SERVICE_CLASS_CODES.include? field.to_s }
+          end
 
-        def valid_standard_entry_class_code(field)
-          check_field_error(field) { STANDARD_ENTRY_CLASS_CODES.include? field.data }
-        end
+          def valid_standard_entry_class_code field
+            check_field_error(field) { STANDARD_ENTRY_CLASS_CODES.include? field.data }
+          end
 
-        def valid_transaction_code(field)
-          check_field_error(field) { TRANSACTION_CODES.include? field.to_s }
-        end
+          def valid_transaction_code field
+            check_field_error(field) { TRANSACTION_CODES.include? field.to_s }
+          end
 
-        def valid_receiving_dfi_identification(field)
-          check_field_error(field) { field.valid? }
+          def valid_receiving_dfi_identification field
+            check_field_error(field) { field.valid? }
+          end
         end
       end
     end

data/lib/nacha/record/validations/record_validations.rb

@@ -3,12 +3,13 @@
 
 module Nacha
   module Record
-    module RecordValidations
-      def self.included(base)
-        base.extend ClassMethods
-      end
-
-      module ClassMethods
+    module Validations
+      module RecordValidations
+        def self.included base
+          base.extend ClassMethods
+        end
+        module ClassMethods
+        end
       end
     end
   end

data/lib/nacha/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Nacha
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 end

data/lib/nacha.rb

@@ -7,11 +7,11 @@ require 'nacha/ach_date'
 require 'nacha/field'
 require 'nacha/numeric'
 
-Dir['lib/nacha/record/*.rb'].each do |file|
+Gem.find_files('nacha/record/*.rb').reject{|f| f =~ /\/spec\//}.each do |file|
   require File.expand_path(file)
 end
 
-Dir['lib/nacha/record/**/*.rb'].each do |file|
+Gem.find_files('nacha/record/**/*.rb').reject{|f| f =~ /\/spec\//}.each do |file|
   require File.expand_path(file)
 end
 
@@ -30,16 +30,26 @@ module Nacha
                                 48 49 55 56 82 84 86 88].freeze
 
   TRANSACTION_CODES = (CREDIT_TRANSACTION_CODES + DEBIT_TRANSACTION_CODES).freeze
-
-  def self.record_name(str)
-    underscore(str.to_s).split('/').last
-  end
-
-  def self.underscore(str)
-    str.gsub(/::/, '/')
-      .gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2')
-      .gsub(/([a-z\d])([A-Z])/, '\1_\2')
-      .tr('-', '_')
-      .downcase
+  class << self
+    def parse(object)
+      parser = Nacha::Parser.new
+      if object.is_a?(String)
+        parser.parse_string(object)
+      else
+        parser.parse_file(object)
+      end
+    end
+
+    def record_name(str)
+      underscore(str.to_s).split('/').last
+    end
+
+    def underscore(str)
+      str.gsub(/::/, '/').
+        gsub(/([A-Z]+)([A-Z][a-z])/,'\1_\2').
+        gsub(/([a-z\d])([A-Z])/,'\1_\2').
+        tr('-', '_').
+        downcase
+    end
   end
 end

data/nacha.gemspec

@@ -21,18 +21,16 @@ Gem::Specification.new do |spec|
   spec.bindir        = "exe"
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
+  spec.add_dependency 'bigdecimal'
 
   spec.add_development_dependency "bundler", "~> 2.0"
-  spec.add_development_dependency "byebug"
   spec.add_development_dependency "factory_bot"
   spec.add_development_dependency "gitlab-styles"
   spec.add_development_dependency "guard"
   spec.add_development_dependency "guard-rspec"
-  spec.add_development_dependency "pry", "~> 0.10"
-  spec.add_development_dependency "pry-doc", "~> 0.10"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency "rubocop", '~> 0.69.0'
-  spec.add_development_dependency 'rubocop-performance', '~> 1.1.0'
-  spec.add_development_dependency 'rubocop-rspec', '~> 1.22.1'
+  spec.add_development_dependency "rubocop"
+  spec.add_development_dependency 'rubocop-performance'
+  spec.add_development_dependency 'rubocop-rspec'
 end

metadata

@@ -1,42 +1,42 @@
 --- !ruby/object:Gem::Specification
 name: nacha
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - David H. Wilkins
 bindir: exe
 cert_chain: []
-date: 1980-01-02 00:00:00.000000000 Z
+date: 2025-06-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: bigdecimal
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
-  type: :development
+        version: '0'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: byebug
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: factory_bot
   requirement: !ruby/object:Gem::Requirement
@@ -93,34 +93,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.10'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.10'
-- !ruby/object:Gem::Dependency
-  name: pry-doc
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.10'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.10'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -153,44 +125,44 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.69.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.69.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.1.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.1.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.22.1
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.22.1
+        version: '0'
 description: Ruby parser for ACH files.
 email:
 - dwilkins@conecuh.com
@@ -298,7 +270,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.7
+rubygems_version: 3.6.3
 specification_version: 4
 summary: Ruby parser for ACH files.
 test_files: []