mysql_genius 0.7.1 → 0.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e6f79035cffd33253079d4365967dcca4ff97d1515e8e5960d23060b92052827
-  data.tar.gz: f8c05c7ab9c6408d1816e36eec7c95cf0796f37b7fba0344699e806576b9e340
+  metadata.gz: 1d2b3f6350a4c464b3ec546a5248a9b1db4dc933e80e2da26472012367740828
+  data.tar.gz: 13ffee6262a381bb970cf6f9e473c95e40161d191249228225b6960aec7c9313
 SHA512:
-  metadata.gz: 5a797a52e89c12e8a266ec70b4f9264e4270450000630824789f64a19b53f4f22b5483bdcef634a97f904f9b61f7b533559f1dfa1fd37ee4ee9711f650f143db
-  data.tar.gz: 9e46e3fafff0682dbeb29ffecc855f4d00d204efe8b15517ab2f05baaadf94da50836f12dfbd928f322a9df624d4f129442602f8f7074a043a8ce11896d5cd7a
+  metadata.gz: 350005c5824825d20f187099dab6f181eb476d1b99441fdf2101f09430b4bb23abff72bbbae487f9a58bca43de02a20213e508980dbb407577678c45bbdf3f08
+  data.tar.gz: c372b88067e33f91b89840e994733ffb5a810ac0bdf38a582e32e240126d026871babe689911a4655bf7a1ba1d0e7664e4f3c7185ba1a96472a6f65d349ecfec

data/.gitignore

@@ -15,3 +15,4 @@ Gemfile.lock
 *.gem
 docs/superpowers/
 /ralph
+.DS_Store

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## 0.7.2
+
+### Added
+- **Anthropic Messages API support** — `x-api-key` auth style with `anthropic-version` header, top-level `system` parameter, `content[0].text` response parsing.
+- **Configurable `max_tokens`** — new field on `Core::Ai::Config` (default 4096), sent to both OpenAI and Anthropic APIs.
+- **Copy response button** on all AI result sections (schema review, migration risk, optimization, describe query, rewrite, index advisor, root cause, anomaly detection).
+- **Dark mode contrast fixes** for AI result sections — proper CSS classes with dark-mode variants replace hardcoded light-mode inline styles.
+- **`capability?(:standalone_header)`** guard hides the dashboard header when rendered inside a layout that already provides one.
+
 ## 0.7.1
 
 Lockstep version bump with `mysql_genius-core 0.7.1` which fixes missing ERB templates in the gem package.

data/app/views/layouts/mysql_genius/application.html.erb

@@ -145,6 +145,17 @@
     code { font-size: 12px; word-break: break-all; background: #f0f1f3; padding: 2px 6px; border-radius: 3px; color: #24292f; }
     pre.mg-pre { background: #f4f4f4; padding: 10px; border-radius: 4px; overflow-x: auto; font-size: 12px; }
 
+    /* AI result sections */
+    .mg-ai-section { border-radius: 4px; border: 1px solid #dee2e6; border-left-width: 4px; margin-bottom: 12px; }
+    .mg-ai-section-header { padding: 8px 12px; border-bottom: 1px solid #dee2e6; font-size: 13px; }
+    .mg-ai-section-body { padding: 12px; font-size: 13px; }
+    .mg-ai-danger { border-left-color: #dc3545; background: #fff5f5; }
+    .mg-ai-danger .mg-ai-section-header { border-bottom-color: #f5c6cb; }
+    .mg-ai-warning { border-left-color: #ffc107; background: #fffbeb; }
+    .mg-ai-warning .mg-ai-section-header { border-bottom-color: #ffeeba; }
+    .mg-ai-info { border-left-color: #17a2b8; background: #f0f9ff; }
+    .mg-ai-info .mg-ai-section-header { border-bottom-color: #bee5eb; }
+
     /* Theme toggle */
     .mg-theme-toggle { background: none; border: 1px solid #ced4da; border-radius: 4px; padding: 4px 8px; cursor: pointer; font-size: 14px; line-height: 1; color: inherit; }
     .mg-theme-toggle:hover { background: #e9ecef; }
@@ -220,7 +231,13 @@
 
     /* Inline code */
     [data-theme="dark"] code { background: #21262d; color: #c9d1d9; }
+    [data-theme="dark"] pre { background: #161b22; color: #c9d1d9; border-color: #30363d; }
     [data-theme="dark"] pre.mg-pre { background: #161b22; color: #c9d1d9; }
+    [data-theme="dark"] .mg-card-body { color: #c9d1d9; }
+    [data-theme="dark"] .mg-card-body h1, [data-theme="dark"] .mg-card-body h2, [data-theme="dark"] .mg-card-body h3, [data-theme="dark"] .mg-card-body h4 { color: #c9d1d9; }
+    [data-theme="dark"] .mg-card-body p, [data-theme="dark"] .mg-card-body li, [data-theme="dark"] .mg-card-body td { color: #c9d1d9; }
+    [data-theme="dark"] .mg-card-body strong { color: #e6edf3; }
+    [data-theme="dark"] .mg-card-body a { color: #58a6ff; }
 
     /* Links */
     [data-theme="dark"] .mg-link { color: #58a6ff; }
@@ -234,6 +251,16 @@
     /* Checkboxes */
     [data-theme="dark"] .mg-check .type-hint { color: #484f58; }
 
+    /* AI result sections (dark) */
+    [data-theme="dark"] .mg-ai-section { border-color: #30363d; }
+    [data-theme="dark"] .mg-ai-danger { background: #2d0d0d; border-left-color: #f85149; }
+    [data-theme="dark"] .mg-ai-danger .mg-ai-section-header { border-bottom-color: #3d1414; color: #f85149; }
+    [data-theme="dark"] .mg-ai-warning { background: #2d2000; border-left-color: #d29922; }
+    [data-theme="dark"] .mg-ai-warning .mg-ai-section-header { border-bottom-color: #3d2e00; color: #d29922; }
+    [data-theme="dark"] .mg-ai-info { background: #0d2a3a; border-left-color: #58a6ff; }
+    [data-theme="dark"] .mg-ai-info .mg-ai-section-header { border-bottom-color: #0d3a5a; color: #58a6ff; }
+    [data-theme="dark"] .mg-ai-section-body { color: #c9d1d9; }
+
     /* Theme toggle (dark) */
     [data-theme="dark"] .mg-theme-toggle { border-color: #30363d; color: #c9d1d9; }
     [data-theme="dark"] .mg-theme-toggle:hover { background: #21262d; }

data/lib/mysql_genius/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MysqlGenius
-  VERSION = "0.7.1"
+  VERSION = "0.7.2"
 end

data/mysql_genius.gemspec

@@ -30,6 +30,6 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency("activerecord", ">= 6.0", "< 9")
-  spec.add_dependency("mysql_genius-core", "~> 0.7.0")
+  spec.add_dependency("mysql_genius-core", "~> 0.7.2")
   spec.add_dependency("railties", ">= 6.0", "< 9")
 end

data/ralph/prd.json

@@ -1,174 +1,149 @@
 {
   "project": "MysqlGenius",
-  "branchName": "ralph/query-detail-page",
-  "description": "Query Detail Page with Lightweight History - background stats collector, in-memory ring buffer, SVG time-series charts, and a dedicated query detail page accessible from the Query Stats tab",
+  "branchName": "ralph/sqlite-migration",
+  "description": "Replace in-memory StatsHistory and YAML ProfileManager with SQLite for persistent stats and clean profile CRUD in the desktop sidecar",
   "userStories": [
     {
       "id": "US-001",
-      "title": "Add StatsHistory ring buffer to core gem",
-      "description": "As a developer, I need a thread-safe in-memory ring buffer to store per-digest query stats snapshots.",
+      "title": "Add sqlite3 dependency and create Database class with schema",
+      "description": "As a developer, I need a Database class that manages a SQLite file with profiles, settings, and stats_snapshots tables.",
       "acceptanceCriteria": [
-        "Create gems/mysql_genius-core/lib/mysql_genius/core/analysis/stats_history.rb",
-        "StatsHistory.new(max_samples: 1440) initializes empty buffer",
-        "record(digest_text, {timestamp:, calls:, total_time_ms:, avg_time_ms:}) appends a snapshot",
-        "series_for(digest_text) returns ordered array oldest-to-newest",
-        "series_for returns empty array for unknown digests",
-        "Ring buffer drops oldest entry when max_samples reached",
-        "digests returns all known digest keys",
-        "clear empties all data",
-        "All operations are thread-safe via Mutex",
-        "Add require to gems/mysql_genius-core/lib/mysql_genius/core.rb",
-        "Create spec at gems/mysql_genius-core/spec/mysql_genius/core/analysis/stats_history_spec.rb with tests for all above",
-        "Core gem suite passes: (cd gems/mysql_genius-core && bundle exec rspec)",
+        "Add sqlite3 ~> 2.0 to gems/mysql_genius-desktop/mysql_genius-desktop.gemspec as runtime dependency",
+        "Run bundle install in gems/mysql_genius-desktop",
+        "Create gems/mysql_genius-desktop/lib/mysql_genius/desktop/database.rb",
+        "Database.new(path) creates the SQLite file if missing and runs CREATE TABLE IF NOT EXISTS for all 3 tables",
+        "profiles table: name TEXT PRIMARY KEY, host TEXT NOT NULL, port INTEGER DEFAULT 3306, username TEXT NOT NULL, password TEXT DEFAULT '', database_name TEXT NOT NULL, tls_mode TEXT DEFAULT 'preferred', created_at TEXT, updated_at TEXT",
+        "settings table: key TEXT PRIMARY KEY, value TEXT",
+        "stats_snapshots table: id INTEGER PRIMARY KEY AUTOINCREMENT, digest_text TEXT NOT NULL, timestamp TEXT NOT NULL, delta_calls INTEGER DEFAULT 0, delta_total_time_ms REAL DEFAULT 0, delta_avg_time_ms REAL DEFAULT 0",
+        "Index on stats_snapshots(digest_text, timestamp)",
+        "Profile CRUD: list_profiles returns array of hashes, find_profile(name) returns hash or nil, add_profile(attrs) inserts (raises on duplicate), update_profile(name, attrs) updates (raises if not found), delete_profile(name) deletes (raises if not found)",
+        "Settings: get_setting(key) returns string or nil, set_setting(key, value) upserts, get_ai_config returns hash of ai.* keys with prefix stripped, set_ai_config(hash) writes each key with ai. prefix",
+        "Stats: record_snapshot(digest_text, snapshot_hash) inserts + prunes rows older than 24 hours, series_for(digest_text) returns ordered array last 24hr, digests returns distinct digest_texts, clear deletes all",
+        "Create spec at gems/mysql_genius-desktop/spec/mysql_genius/desktop/database_spec.rb with tests for all CRUD operations using tmpdir",
+        "Desktop gem suite passes",
         "Typecheck passes"
       ],
       "priority": 1,
       "passes": true,
-      "notes": "Thread safety: wrap all reads and writes in a single Mutex. The critical section is microseconds (array append/slice). Use a Hash keyed by digest_text, each value is an Array acting as ring buffer."
+      "notes": "Use raw sqlite3 gem calls, no ORM. Thread safety: SQLite WAL mode handles concurrent reads. Error classes: Database::DuplicateProfileError, Database::ProfileNotFoundError. The spec should use Dir.mktmpdir for isolated DB files per test."
     },
     {
       "id": "US-002",
-      "title": "Add StatsCollector background sampler to core gem",
-      "description": "As a developer, I need a background thread that periodically samples performance_schema and computes delta snapshots.",
+      "title": "Create SqliteStatsHistory as drop-in replacement for StatsHistory",
+      "description": "As a developer, I need a SQLite-backed stats history with the same API as the in-memory StatsHistory so the StatsCollector works unchanged.",
       "acceptanceCriteria": [
-        "Create gems/mysql_genius-core/lib/mysql_genius/core/analysis/stats_collector.rb",
-        "initialize(connection_provider:, history:, interval: 60) accepts a callable for connection",
-        "start spawns a background Thread and returns self",
-        "stop signals the thread to exit and joins with 5s timeout",
-        "running? returns boolean",
-        "Each tick: queries performance_schema for top 50 digests by SUM_TIMER_WAIT",
-        "Computes deltas: delta_calls = current - previous, delta_total_time = current - previous",
-        "Records delta snapshot into the StatsHistory instance",
-        "Negative deltas (server restart) recorded as 0",
-        "If performance_schema is unavailable, logs warning and stops (no crash loop)",
-        "Add require to gems/mysql_genius-core/lib/mysql_genius/core.rb",
-        "Create spec at gems/mysql_genius-core/spec/mysql_genius/core/analysis/stats_collector_spec.rb",
-        "Core gem suite passes",
+        "Create gems/mysql_genius-desktop/lib/mysql_genius/desktop/sqlite_stats_history.rb",
+        "SqliteStatsHistory.new(database) takes a Database instance",
+        "record(digest_text, snapshot_hash) delegates to database.record_snapshot",
+        "series_for(digest_text) delegates to database.series_for, returns array of hashes with symbol keys (timestamp:, calls:, total_time_ms:, avg_time_ms:)",
+        "digests delegates to database.digests",
+        "clear delegates to database.clear",
+        "Same public API as MysqlGenius::Core::Analysis::StatsHistory (record, series_for, digests, clear)",
+        "Create spec at gems/mysql_genius-desktop/spec/mysql_genius/desktop/sqlite_stats_history_spec.rb",
+        "Desktop gem suite passes",
         "Typecheck passes"
       ],
       "priority": 2,
       "passes": true,
-      "notes": "The connection_provider is a callable (lambda/proc) that returns a Core::Connection. This lets Rails pass -> { ActiveRecordAdapter.new(ActiveRecord::Base.connection) } and the sidecar pass -> { session.checkout { |a| a } }. Use the same SQL shape as QueryStats#build_sql but hardcoded to top 50 by SUM_TIMER_WAIT. Store @previous hash of {digest => {calls:, total_time_ms:}} for delta computation."
+      "notes": "The StatsCollector passes snapshot hashes with string keys from its tick method. SqliteStatsHistory should accept both string and symbol keys. The series_for return format must match what the query_detail template JS expects: [{timestamp:, calls:, total_time_ms:, avg_time_ms:}]."
     },
     {
       "id": "US-003",
-      "title": "Add DIGEST hash to QueryStats return value",
-      "description": "As a developer, I need the DIGEST hex hash in QueryStats output so the detail page can use it as a URL key.",
+      "title": "Add first-boot YAML import logic to Launcher",
+      "description": "As a user, I want my existing YAML profiles and AI config automatically imported into SQLite on first boot.",
       "acceptanceCriteria": [
-        "Modify gems/mysql_genius-core/lib/mysql_genius/core/analysis/query_stats.rb",
-        "Add DIGEST column to the SELECT in build_sql",
-        "Add digest: row['DIGEST'] to the transform method return hash",
-        "Existing fields unchanged (backward compatible addition)",
-        "Update query_stats_spec to verify the new digest field is present",
-        "Core gem suite passes",
+        "Modify gems/mysql_genius-desktop/lib/mysql_genius/desktop/launcher.rb",
+        "After Config.load, create Database.new at ~/.config/mysql_genius/mysql_genius.db (create dir if needed)",
+        "If database.list_profiles is empty AND config.profiles is not empty, import each profile into SQLite",
+        "If database.get_setting('ai.endpoint') is nil AND config.ai.endpoint is present, import AI config into SQLite",
+        "Set App.set(:database, db)",
+        "Create SqliteStatsHistory.new(db) and pass to StatsCollector instead of StatsHistory.new",
+        "Add require statements for database and sqlite_stats_history to desktop.rb",
+        "Existing desktop specs still pass (rack_helper needs updating to inject a test Database)",
+        "Desktop gem suite passes",
         "Typecheck passes"
       ],
       "priority": 3,
       "passes": true,
-      "notes": "DIGEST is a 64-char hex string computed by MySQL. It's stable across identical query templates. The existing sql field continues to hold the truncated DIGEST_TEXT."
+      "notes": "The rack_helper.rb needs to create a tmpdir-based Database and set it on the App via App.set(:database, db). Ensure mkdir_p for ~/.config/mysql_genius/ before creating the DB. The import only runs when the DB is empty — deleting mysql_genius.db forces re-import on next boot."
     },
     {
       "id": "US-004",
-      "title": "Add query detail shared template with SVG charts",
-      "description": "As a user, I want to see a query's SQL, current stats, and time-series performance charts on a dedicated page.",
+      "title": "Rewire profile API routes to use Database",
+      "description": "As a user, I want the /connections page to read and write profiles from SQLite instead of YAML.",
       "acceptanceCriteria": [
-        "Create gems/mysql_genius-core/lib/mysql_genius/core/views/mysql_genius/queries/query_detail.html.erb",
-        "Template shows: full SQL in mg-sql-block styled container",
-        "Template shows: Explain button that fires POST /explain",
-        "Template shows: stats summary cards (Calls, Total Time, Avg Time, Max Time, Rows Examined, Rows Sent, First Seen, Last Seen)",
-        "Template shows: three SVG charts stacked vertically (Total Time ms, Average Time ms, Calls)",
-        "SVG charts drawn by a drawChart(containerId, data, label, color) JS function",
-        "Charts use polyline with translucent fill below the line",
-        "Charts have Y axis auto-scaled with 4-5 ticks, X axis with time labels every ~4 hours",
-        "Charts use #89CFF0 line color in light mode, #58a6ff in dark mode",
-        "Chart height is 200px, width responsive (100% of container)",
-        "Page loads data via fetch to GET /api/query_history/:digest on page load",
-        "All JS is inline in the template (no external dependencies)",
+        "Modify gems/mysql_genius-desktop/lib/mysql_genius/desktop/app.rb",
+        "GET /api/profiles reads from settings.database.list_profiles + settings.current_profile_name",
+        "POST /api/profiles calls settings.database.add_profile, returns updated list",
+        "PUT /api/profiles/:name calls settings.database.update_profile, returns updated list",
+        "DELETE /api/profiles/:name calls settings.database.delete_profile (rejects active profile), returns updated list",
+        "POST /api/test_connection unchanged (no storage involved)",
+        "POST /api/profiles/:name/connect reads profile from settings.database.find_profile",
+        "GET /api/ai_config reads from settings.database.get_ai_config",
+        "PUT /api/ai_config writes to settings.database.set_ai_config + reloads into running app",
+        "Remove require for profile_manager from app.rb",
+        "Update profiles_api_spec.rb to use Database instead of YAML tmpdir",
+        "Desktop gem suite passes",
         "Typecheck passes"
       ],
       "priority": 4,
       "passes": true,
-      "notes": "The template is standalone (not a tab partial). It will be rendered through each adapter's layout. The drawChart function creates an SVG element with: a viewBox for responsive scaling, a polyline for the data series, rect elements or text for axis labels. The Explain button reuses the existing POST /explain endpoint. Data fetched from /api/query_history/:digest returns {query: {...stats...}, history: [{timestamp, calls, total_time_ms, avg_time_ms}, ...]}."
+      "notes": "Error mapping: Database::DuplicateProfileError -> 409, Database::ProfileNotFoundError -> 404. The active-profile-delete check stays in the route handler (check settings.current_profile_name before calling delete). The connect route builds a MysqlConfig from the DB hash: Config::MysqlConfig.from_hash(profile_hash)."
     },
     {
       "id": "US-005",
-      "title": "Make Query Stats tab SQL cells clickable links",
-      "description": "As a user, I want to click a query in the stats table to see its detail page.",
+      "title": "Rewire SessionSwapper to use Database",
+      "description": "As a developer, I need SessionSwapper to look up profiles from SQLite instead of Config.",
       "acceptanceCriteria": [
-        "Modify gems/mysql_genius-core/lib/mysql_genius/core/views/mysql_genius/queries/dashboard.html.erb",
-        "In the loadQueryStats JS function, render SQL column as <a href='/queries/:digest'> link",
-        "Link uses the digest hex hash from the query_stats API response",
-        "Link styled with mg-link class or inline color to look clickable",
-        "Existing query stats table layout and sorting still work",
-        "Rails adapter suite passes: bundle exec rspec",
+        "Modify gems/mysql_genius-desktop/lib/mysql_genius/desktop/session_swapper.rb",
+        "Change initialize to accept (app_class, config, database) instead of (app_class, config)",
+        "switch_to looks up profile via @database.find_profile(name) instead of @config.profile_by_name(name)",
+        "Build MysqlConfig from the DB hash via Config::MysqlConfig.from_hash(profile)",
+        "Update all callers of SessionSwapper.new to pass the database",
+        "Update session_swapper_spec.rb",
+        "Desktop gem suite passes",
         "Typecheck passes"
       ],
       "priority": 5,
       "passes": true,
-      "notes": "The loadQueryStats function is in dashboard.html.erb's inline JS. It currently renders the SQL as plain text in a td. Change it to an anchor tag. The href should use path_for pattern but since this is in JS, just hardcode '/queries/' + digest (the sidecar's PATHS hash and Rails route both serve this path). Also update the dashboard overview's Top 5 Expensive Queries to be clickable."
+      "notes": "The profile hash from Database has string keys (host, port, etc). MysqlConfig.from_hash handles both string and symbol keys via transform_keys. The build_switch_config method still creates a Config.allocate with profiles array for ActiveSession compatibility."
     },
     {
       "id": "US-006",
-      "title": "Wire stats collector and detail routes into Rails adapter",
-      "description": "As a Rails developer, I want the stats collector to start on boot and the query detail page to be accessible.",
+      "title": "Delete ProfileManager and clean up",
+      "description": "As a developer, I want to remove the dead ProfileManager code now that Database handles everything.",
       "acceptanceCriteria": [
-        "Add stats_collection config option (default true) to lib/mysql_genius/configuration.rb",
-        "Add MysqlGenius.stats_history and MysqlGenius.stats_collector module-level accessors to lib/mysql_genius.rb",
-        "Add initializer in lib/mysql_genius/engine.rb that starts StatsCollector when enabled",
-        "Initializer creates StatsHistory, StatsCollector with ActiveRecordAdapter connection_provider, calls start",
-        "Registers at_exit to stop the collector",
-        "Add two routes to config/routes.rb: get 'queries/:digest' and get 'api/query_history/:digest'",
-        "Add query_detail action to QueriesController that renders the shared template",
-        "Add query_history action that returns JSON with current stats + history",
-        "query_history looks up the digest in performance_schema and gets history from MysqlGenius.stats_history",
-        "Add request spec for GET /queries/:digest (returns 200)",
-        "Add request spec for GET /api/query_history/:digest (returns JSON with query and history keys)",
-        "Rails adapter suite passes",
+        "Delete gems/mysql_genius-desktop/lib/mysql_genius/desktop/profile_manager.rb",
+        "Delete gems/mysql_genius-desktop/spec/mysql_genius/desktop/profile_manager_spec.rb",
+        "Remove require 'mysql_genius/desktop/profile_manager' from desktop.rb",
+        "Remove require 'mysql_genius/desktop/profile_manager' from app.rb if present",
+        "Grep the entire desktop gem for 'ProfileManager' references and remove any remaining",
+        "Desktop gem suite passes",
+        "All 3 rubocops pass",
         "Typecheck passes"
       ],
       "priority": 6,
       "passes": true,
-      "notes": "The connection_provider for Rails is -> { Core::Connection::ActiveRecordAdapter.new(ActiveRecord::Base.connection) }. The query_detail action just renders the template with an @digest instance variable. The query_history action queries performance_schema filtered by DIGEST = :digest for current stats, and calls MysqlGenius.stats_history.series_for(digest_text) for history. If stats_history is nil (collection disabled), return empty history array."
+      "notes": "Make sure no spec files reference ProfileManager. The Database class error classes (DuplicateProfileError, ProfileNotFoundError) replace ProfileManager's error classes — verify the route handlers rescue the correct class names."
     },
     {
       "id": "US-007",
-      "title": "Wire stats collector and detail routes into desktop sidecar",
-      "description": "As a sidecar user, I want the stats collector running and the query detail page accessible.",
-      "acceptanceCriteria": [
-        "Update gems/mysql_genius-desktop/lib/mysql_genius/desktop/launcher.rb to create StatsHistory + StatsCollector and set on App",
-        "Add App settings: :stats_history, :stats_collector",
-        "Collector uses connection_provider that checks out from the active session",
-        "Register at_exit to stop collector",
-        "Update SessionSwapper to stop old collector, clear history, start new collector on profile switch",
-        "Add GET /queries/:digest route to App (renders query_detail template through layout)",
-        "Add GET /api/query_history/:digest route to App (returns JSON)",
-        "Both new routes are under session-token auth",
-        "Add request spec for the two new routes",
-        "Desktop gem suite passes: (cd gems/mysql_genius-desktop && bundle exec rspec)",
-        "Typecheck passes"
-      ],
-      "priority": 7,
-      "passes": true,
-      "notes": "The connection_provider for the sidecar wraps session.checkout. On profile switch, SessionSwapper should: App.settings.stats_collector&.stop, App.settings.stats_history&.clear, then after swapping the session create a new collector with the new session and start it. The render_query_detail method follows the same pattern as render_dashboard (Tilt through layout)."
-    },
-    {
-      "id": "US-008",
       "title": "Full green sweep across all suites",
       "description": "As a developer, I need all test suites and linters passing before the PR.",
       "acceptanceCriteria": [
-        "Rails adapter rspec passes (78+ examples)",
-        "Core gem rspec passes (194+ examples plus new StatsHistory/StatsCollector/QueryStats specs)",
-        "Desktop gem rspec passes (154+ examples plus new route specs)",
+        "Rails adapter rspec passes (82+ examples)",
+        "Core gem rspec passes (215+ examples)",
+        "Desktop gem rspec passes (150+ examples)",
         "Rails adapter rubocop clean",
         "Core gem rubocop clean",
         "Desktop gem rubocop clean",
-        "git diff main -- .github/workflows/publish.yml is empty (untouched)",
-        "No version bumps committed (version bump is a separate release task)",
+        "No changes to mysql_genius-core or mysql_genius Rails adapter source files",
+        "publish.yml untouched",
         "Typecheck passes"
       ],
-      "priority": 8,
-      "passes": false,
-      "notes": "Run all six commands in order. If any fail, fix before proceeding. This is a verification step, not an implementation step."
+      "priority": 7,
+      "passes": true,
+      "notes": "Run all six commands. If any fail, fix before marking complete."
     }
   ]
 }

data/ralph/progress.txt

@@ -1,141 +1,138 @@
 # Ralph Progress Log
-Started: Sun Apr 12 13:52:29 CDT 2026
+Started: Sun Apr 12 23:47:10 CDT 2026
 ---
 
 ## Codebase Patterns
-- Core gem specs use `require "spec_helper"` (no Rails boot), FakeAdapter for connection stubs
-- Analysis classes follow `initialize(connection)` + `#call` pattern
-- Core gem has zero runtime dependencies — no Rails-specific code
-- Spec files mirror the lib directory structure: `lib/mysql_genius/core/analysis/foo.rb` → `spec/mysql_genius/core/analysis/foo_spec.rb`
-- RuboCop uses rubocop-shopify + rubocop-rspec; target Ruby 2.6
-- `Time#iso8601` requires `require 'time'` — use `strftime("%Y-%m-%dT%H:%M:%SZ")` in core gem instead
-- FakeAdapter stubs are searched with `find` (first match wins) — clear `@stubs` via `instance_variable_set(:@stubs, [])` before re-stubbing
-- Use `ConditionVariable` + `Mutex` for interruptible sleep in background threads (cleaner than polling loops)
-- Standalone templates (not partials) must duplicate JS helpers from dashboard since they run in a separate page scope
-- Shared templates use `path_for(:name)` for URLs and `@digest` instance var — adapters must set these before rendering
-- Desktop gem has NO ActiveSupport — never use `.squish` or other AS extensions; use plain string concatenation for SQL
-- Desktop `Core::Result#to_a` returns raw row arrays; use `to_hashes` to get `{column => value}` hashes
-- Desktop `rack_helper.rb` sets `@fake_adapter` via before block — specs using it must disable `RSpec/InstanceVariable`
-- Rails `ActiveRecord::Result` `to_a` returns hashes directly; for specs use `instance_double` with `to_a:` returning hash arrays
-- When adding new App settings to desktop, also reset them in `rack_helper.rb` after block and set in before block
-- `StatsCollector.new` spawns real threads — mock it in request specs via `allow(StatsCollector).to receive(:new)` in rack_helper
-- `path_for(:query_detail)` and `path_for(:query_history)` both need `@digest` to build a complete URL; both adapters handle this in their `path_for` implementation
-- Routes that need a dynamic segment (digest) use base-path + value pattern in desktop PATHS hash; Rails uses named route helpers with keyword arg
+- Desktop gem specs use `Dir.mktmpdir` for isolated file-based test fixtures (DB files, YAML configs)
+- Desktop gem rubocop config inherits from root `.rubocop.yml` via `inherit_from`
+- Desktop gem Gemfile.lock is not tracked in git (gem convention)
+- Use `results_as_hash = true` on SQLite3::Database to get hash-style row access
+- Desktop app settings are injected via `App.set(:key, value)` (Sinatra pattern)
+- Launcher private methods can be stubbed via `allow(launcher).to(receive(:method_name))` in RSpec
+- First-boot import logic: only runs when DB is empty (list_profiles.empty? / get_setting returns nil)
+- rack_helper.rb must set `App.set(:database, ...)` for request specs that depend on DB settings
+- Database returns `database_name` key; `MysqlConfig.from_hash` expects `database` — remap via `mysql_hash_from_profile`
+- Profile API response must be `{name:, mysql: {host:, port:, database:, ...}}` — use `format_profile` to reshape DB rows
 
 ---
 
 ## 2026-04-12 - US-001
-- Implemented `StatsHistory` ring buffer in `gems/mysql_genius-core/lib/mysql_genius/core/analysis/stats_history.rb`
-- Thread-safe via Mutex, supports record/series_for/digests/clear, drops oldest on cap
-- Added require to `gems/mysql_genius-core/lib/mysql_genius/core.rb`
-- Created spec at `gems/mysql_genius-core/spec/mysql_genius/core/analysis/stats_history_spec.rb` (9 examples)
-- Files changed: stats_history.rb (new), core.rb (require added), stats_history_spec.rb (new)
-- Core gem suite: 203 examples, 0 failures
-- RuboCop: clean
+- What was implemented:
+  - Added `sqlite3 ~> 2.0` runtime dependency to `mysql_genius-desktop.gemspec`
+  - Created `Database` class at `lib/mysql_genius/desktop/database.rb` with:
+    - SQLite WAL mode for concurrent reads
+    - 3 tables: profiles, settings, stats_snapshots
+    - Composite index on stats_snapshots(digest_text, timestamp)
+    - Full profile CRUD: list_profiles, find_profile, add_profile, update_profile, delete_profile
+    - Settings: get_setting, set_setting, get_ai_config, set_ai_config
+    - Stats: record_snapshot (with 24hr pruning), series_for, digests, clear
+    - Error classes: DuplicateProfileError, ProfileNotFoundError
+  - Created comprehensive spec at `spec/mysql_genius/desktop/database_spec.rb` (29 examples)
+- Files changed:
+  - `gems/mysql_genius-desktop/mysql_genius-desktop.gemspec` (added sqlite3 dep)
+  - `gems/mysql_genius-desktop/lib/mysql_genius/desktop/database.rb` (new)
+  - `gems/mysql_genius-desktop/spec/mysql_genius/desktop/database_spec.rb` (new)
 - **Learnings for future iterations:**
-  - The core gem spec suite runs fast (~0.06s) — safe to run full suite on each story
-  - FakeAdapter is only needed for connection-dependent classes; StatsHistory is pure Ruby
-  - Thread safety tests work well with 4 threads × 500 iterations pattern
+  - ISO 8601 timestamps have second precision — `sleep(0.01)` is not enough to test timestamp changes, need `sleep(1.1)`
+  - RSpec `let` is lazy — must reference the variable in the test body before asserting on side effects like file creation
+  - `Naming/AccessorMethodName` cop flags `get_`/`set_` prefixes — disable inline when API names are mandated by the PRD
+  - `add_profile` accepts both `database_name` and `database` keys for compatibility with existing config hash shapes
 ---
 
-## 2026-04-12 - US-002
-- Implemented `StatsCollector` background sampler in `gems/mysql_genius-core/lib/mysql_genius/core/analysis/stats_collector.rb`
-- Background thread queries performance_schema for top 50 digests by SUM_TIMER_WAIT
-- Computes per-interval deltas, clamps negatives to 0 (server restart handling)
-- Uses ConditionVariable for interruptible sleep (clean stop within 5s timeout)
-- connection_provider callable pattern: adapters supply their own connection strategy
-- Added require to `gems/mysql_genius-core/lib/mysql_genius/core.rb`
-- Created spec at `gems/mysql_genius-core/spec/mysql_genius/core/analysis/stats_collector_spec.rb` (12 examples)
-- Files changed: stats_collector.rb (new), core.rb (require added), stats_collector_spec.rb (new)
-- Core gem suite: 215 examples, 0 failures
-- RuboCop: clean
+## 2026-04-13 - US-003
+- What was implemented:
+  - Modified `launcher.rb` to create Database at `~/.config/mysql_genius/mysql_genius.db`
+  - Added first-boot YAML import: profiles imported when DB empty, AI config imported when endpoint missing
+  - Replaced `StatsHistory.new` with `SqliteStatsHistory.new(db)` for persistent stats
+  - Added `App.set(:database, db)` to wire Database into Sinatra settings
+  - Added `database` and `sqlite_stats_history` requires to `desktop.rb`
+  - Added `set :database, nil` to `app.rb` settings
+  - Updated `rack_helper.rb` to create tmpdir-based test Database for request specs
+  - Updated `launcher_spec.rb` to stub `open_database` and verify Database wiring
+- Files changed:
+  - `gems/mysql_genius-desktop/lib/mysql_genius/desktop/launcher.rb` (modified)
+  - `gems/mysql_genius-desktop/lib/mysql_genius/desktop/app.rb` (added database setting)
+  - `gems/mysql_genius-desktop/lib/mysql_genius/desktop.rb` (added requires)
+  - `gems/mysql_genius-desktop/spec/rack_helper.rb` (inject test Database)
+  - `gems/mysql_genius-desktop/spec/mysql_genius/desktop/launcher_spec.rb` (updated)
 - **Learnings for future iterations:**
-  - `Time#iso8601` is not available without `require 'time'` — use `strftime` in zero-dep core gem
-  - FakeAdapter stubs match first-registered-first-matched; clear `@stubs` array before re-stubbing between ticks
-  - Testing background threads: set `@running = true` in `start` (before thread spawn) to eliminate race; use `send(:tick)` to test delta logic directly without timing sensitivity
-  - SQL shape mirrors QueryStats#build_sql but selects only DIGEST_TEXT, COUNT_STAR, total_time_ms
+  - `open_database` extracted as private method so specs can stub it without touching filesystem
+  - Import logic checks DB emptiness, not config emptiness — deleting mysql_genius.db forces re-import
+  - Profile import maps `mysql.database` → `database_name` for Database schema compatibility
+  - rack_helper cleanup: must `FileUtils.remove_entry` tmpdir in after block to avoid leftover test DBs
 ---
 
-## 2026-04-12 - US-003
-- Added `DIGEST` column to `build_sql` SELECT and `digest:` key to `transform` return hash in QueryStats
-- Updated spec columns/rows fixtures to include DIGEST as first column, verified new field in assertions
-- Files changed: `gems/mysql_genius-core/lib/mysql_genius/core/analysis/query_stats.rb`, `gems/mysql_genius-core/spec/mysql_genius/core/analysis/query_stats_spec.rb`
-- Core gem suite: 215 examples, 0 failures
-- Rails adapter suite: 78 examples, 0 failures
-- RuboCop: clean
+## 2026-04-13 - US-004
+- What was implemented:
+  - Rewired all profile API routes (GET/POST/PUT/DELETE) in `app.rb` to use `Database` instead of `ProfileManager`
+  - Added `GET /api/ai_config` and `PUT /api/ai_config` routes backed by Database settings
+  - Removed `require 'mysql_genius/desktop/profile_manager'` from `app.rb`
+  - Added `switch_to_config(name, mysql_config)` to `SessionSwapper` for pre-built MysqlConfig objects
+  - Inlined `test_connection` logic in the route handler (was delegated to ProfileManager)
+  - Added private helpers: `format_profile`, `profile_attrs_from_request`, `update_attrs_from_request`, `mysql_hash_from_profile`, `build_minimal_config`, `reload_ai_config_from_database`
+  - Rewrote `profiles_api_spec.rb` to seed test data via `@test_database.add_profile` instead of YAML tmpdir
+  - Added specs for `GET /api/ai_config`, `PUT /api/ai_config`, and `POST /api/profiles/:name/connect` with unknown profile
+- Files changed:
+  - `gems/mysql_genius-desktop/lib/mysql_genius/desktop/app.rb` (rewired routes, removed ProfileManager require)
+  - `gems/mysql_genius-desktop/lib/mysql_genius/desktop/session_swapper.rb` (added switch_to_config method)
+  - `gems/mysql_genius-desktop/spec/requests/profiles_api_spec.rb` (rewrote for Database)
 - **Learnings for future iterations:**
-  - QueryStats spec uses positional arrays for row data — when adding a new column to the SELECT, prepend/insert it in ALL test row arrays (easy to miss the truncation test at the bottom)
-  - The `transform` method uses case-insensitive column access (`row["DIGEST"] || row["digest"]`) for MariaDB compatibility — follow this pattern for any new columns
+  - Database returns `database_name` key but `MysqlConfig.from_hash` expects `database` — need `mysql_hash_from_profile` helper to remap
+  - Profile API response format must be `{name:, mysql: {host:, port:, database:, ...}}` to match frontend expectations (connections.html.erb)
+  - `SessionSwapper.switch_to_config` allows callers that already have a MysqlConfig to skip the config lookup
+  - Active profile delete check stays in route handler, not in Database (Database.delete_profile has no concept of "active")
 ---
 
-## 2026-04-12 - US-004
-- Created standalone `query_detail.html.erb` shared template in core gem views
-- Template includes: full SQL display with syntax highlighting, Copy and EXPLAIN buttons
-- Stats summary cards: Calls, Total Time, Avg Time, Max Time, Rows Examined, Rows Sent, First Seen, Last Seen
-- Three SVG time-series charts: Total Time (ms), Average Time (ms), Calls
-- SVG charts use polyline with translucent fill, auto-scaled Y axis with nice tick values, responsive via viewBox
-- Light mode line color #89CFF0, dark mode #58a6ff (detected via data-theme attribute)
-- Data loaded via fetch to GET /api/query_history/:digest, EXPLAIN via POST /explain
-- All JS is inline (no external dependencies), replicates helper functions from dashboard (highlightSql, formatDuration, ajax, etc.)
-- Files changed: `gems/mysql_genius-core/lib/mysql_genius/core/views/mysql_genius/queries/query_detail.html.erb` (new)
-- Core gem suite: 215 examples, 0 failures
-- Rails adapter suite: 78 examples, 0 failures
-- RuboCop: clean
+## 2026-04-13 - US-005
+- What was implemented:
+  - Changed `SessionSwapper.initialize` to accept `(app_class, config, database)` instead of `(app_class, config)`
+  - Rewired `switch_to` to look up profiles via `@database.find_profile(name)` instead of `@config.profile_by_name(name)`
+  - Added `mysql_hash_from_profile` private helper to remap `database_name` → `database` for `MysqlConfig.from_hash`
+  - Changed `switch_to_config` to create `SqliteStatsHistory.new(@database)` instead of in-memory `StatsHistory.new`
+  - Updated the caller in `app.rb` connect route to pass `settings.database` as third arg
+  - Rewrote `session_swapper_spec.rb` to use a tmpdir-based Database instead of Config profile lookup
+- Files changed:
+  - `gems/mysql_genius-desktop/lib/mysql_genius/desktop/session_swapper.rb` (rewired to use Database)
+  - `gems/mysql_genius-desktop/lib/mysql_genius/desktop/app.rb` (updated SessionSwapper.new call)
+  - `gems/mysql_genius-desktop/spec/mysql_genius/desktop/session_swapper_spec.rb` (rewrote for Database)
 - **Learnings for future iterations:**
-  - Standalone templates (not tab partials) need their own copies of JS helper functions since they don't share the dashboard's IIFE scope
-  - The template uses `path_for(:root)` for the back link, `path_for(:explain)` for EXPLAIN, `path_for(:query_history)` for data — these routes must exist in both Rails adapter and sidecar
-  - SVG chart viewBox approach (800x200 with preserveAspectRatio="none") makes charts responsive without JS resize handlers
-  - Y-axis nice step calculation: ceil(rawStep/magnitude)*magnitude ensures clean round-number ticks
-  - The `@digest` instance variable must be set by the controller action before rendering this template
+  - `RSpec/MultipleMemoizedHelpers` max is 5 (subject excluded via AllowSubject). Inline tmpdir into `let(:database)` via `Dir.mktmpdir` to avoid extra helper
+  - `mysql_hash_from_profile` is duplicated between `app.rb` and `session_swapper.rb` — could be extracted to a shared module in US-006 cleanup if desired
+  - `switch_to_config` is still used by the connect route in `app.rb` which pre-builds the MysqlConfig — `switch_to` is for callers that only have a profile name
 ---
 
-## 2026-04-11 - US-005
-- Updated `dashboard.html.erb` to linkify SQL cells in both loadQueryStats and Top 5 Expensive Queries
-- Added `query_detail: '/queries/'` to ROUTES JS object (base path, digest appended via JS)
-- SQL cells now render `<a href="/queries/:digest" class="mg-link">` when digest is present; fallback to plain text if no digest
-- Files changed: `gems/mysql_genius-core/lib/mysql_genius/core/views/mysql_genius/queries/dashboard.html.erb`
-- Rails adapter suite: 78 examples, 0 failures
-- RuboCop: clean
+## 2026-04-13 - US-006
+- What was implemented:
+  - Deleted `profile_manager.rb` source file
+  - Deleted `profile_manager_spec.rb` spec file
+  - Removed `require "mysql_genius/desktop/profile_manager"` from `desktop.rb`
+  - Verified no remaining `ProfileManager` or `profile_manager` references in the desktop gem
+  - Confirmed route handlers already rescue `Database::DuplicateProfileError` / `Database::ProfileNotFoundError` (not ProfileManager versions)
+- Files changed:
+  - `gems/mysql_genius-desktop/lib/mysql_genius/desktop/profile_manager.rb` (deleted)
+  - `gems/mysql_genius-desktop/spec/mysql_genius/desktop/profile_manager_spec.rb` (deleted)
+  - `gems/mysql_genius-desktop/lib/mysql_genius/desktop.rb` (removed require line)
 - **Learnings for future iterations:**
-  - The ROUTES JS object uses hardcoded base paths (not server-rendered route helpers) for dynamic routes — append the value in JS
-  - `mg-link` class is defined in layout.html.erb (both adapters share the layout's CSS)
+  - US-004 already removed `profile_manager` require from `app.rb`, so only `desktop.rb` needed updating
+  - All error classes were already migrated to `Database::` namespace in US-001/US-004 — cleanup was straightforward
+  - 190 desktop specs pass, all 3 rubocops clean after removal
 ---
 
-## 2026-04-11 - US-006
-- Added `stats_collection` config option (default: true) to `lib/mysql_genius/configuration.rb`
-- Added `MysqlGenius.stats_history` and `MysqlGenius.stats_collector` module-level accessors to `lib/mysql_genius.rb`
-- Added `config.after_initialize` block in engine.rb that starts StatsCollector when `stats_collection` is enabled
-- Added routes: `get "queries/:digest"` and `get "api/query_history/:digest"` to `config/routes.rb`
-- Added `query_detail` and `query_history` actions to `QueriesController`
-- Updated `SharedViewHelpers#path_for` to auto-inject `@digest` for `:query_detail` and `:query_history` routes
-- Added private helpers `fetch_query_history_current`, `fetch_query_history_series`, `lookup_digest_text`
-- Added request specs in `spec/requests/mysql_genius/query_detail_spec.rb` (4 examples)
-- Files changed: configuration.rb, lib/mysql_genius.rb, engine.rb, config/routes.rb, queries_controller.rb, shared_view_helpers.rb, query_detail_spec.rb (new)
-- Rails adapter suite: 82 examples, 0 failures
-- RuboCop: clean
+## 2026-04-13 - US-007
+- What was implemented:
+  - Full green sweep: ran all 6 quality commands and verified all pass
+  - Rails adapter rspec: 82 examples, 0 failures
+  - Core gem rspec: 215 examples, 0 failures
+  - Desktop gem rspec: 190 examples, 0 failures
+  - Rails adapter rubocop: 152 files, no offenses
+  - Core gem rubocop: 64 files, no offenses
+  - Desktop gem rubocop: 48 files, no offenses
+  - Verified no changes to mysql_genius-core or mysql_genius Rails adapter source files
+  - Verified publish.yml untouched
+- Files changed:
+  - `ralph/prd.json` (marked US-007 passes: true)
+  - `ralph/progress.txt` (this entry)
 - **Learnings for future iterations:**
-  - `ActiveRecord::Result` `instance_double` — use `to_a:` returning hash arrays; use `result.to_a.first` not `result.first` (which needs Enumerable)
-  - Engine's `config.after_initialize` creates the collector in test env too, causing a benign "StatsCollector stopped" warning in tests — this is expected
-  - `path_for` needs to know about digest routes: use an allowlist `%i[query_detail query_history]` and conditionally pass `digest:` param
----
-
-## 2026-04-11 - US-007
-- Updated `Launcher#call` to create StatsHistory + StatsCollector, set on App, register collector in at_exit
-- Added `set :stats_history, nil` and `set :stats_collector, nil` to App settings
-- Updated App `path_for` helper to append `@digest` for `:query_detail` and `:query_history` routes
-- Added `GET /queries/:digest` and `GET /api/query_history/:digest` routes to App (under session-token auth)
-- Added `render_query_detail`, `fetch_query_history_current`, `fetch_query_history_series` private methods
-- Updated SessionSwapper to stop old collector, clear history, create new collector after session swap
-- Added `:root`, `:query_detail`, `:query_history` to desktop PATHS hash
-- Updated `rack_helper.rb` to reset stats settings and stub `StatsCollector.new` globally to prevent background threads in specs
-- Updated `session_swapper_spec.rb` to mock StatsCollector/StatsHistory and handle new `set` keys
-- Added `spec/requests/query_detail_spec.rb` for desktop (4 examples)
-- Files changed: app.rb, paths.rb, launcher.rb, session_swapper.rb, rack_helper.rb, session_swapper_spec.rb, query_detail_spec.rb (new)
-- Desktop suite: 158 examples, 0 failures (was 154)
-- RuboCop: clean
-- **Learnings for future iterations:**
-  - Desktop gem has NO ActiveSupport — never use `.squish`; use explicit string concatenation
-  - `Core::Result#to_a` returns raw row arrays (not hashes) — use `to_hashes` for hash access
-  - When new `SessionSwapper#switch_to` logic creates real background objects, existing integration tests can fail — mock the constructor in rack_helper to prevent threads
-  - Add `# rubocop:disable RSpec/InstanceVariable` at file top + `enable` at bottom when using `@fake_adapter` directly in specs
+  - All 487 examples across 3 suites (82 + 215 + 190) pass — the SQLite migration touched only the desktop gem
+  - The .DS_Store files appear as untracked — these should stay ignored (not committed)
 ---

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mysql_genius
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.7.2
 platform: ruby
 authors:
 - Antarr Byrd
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-04-12 00:00:00.000000000 Z
+date: 2026-04-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -36,14 +36,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.0
+        version: 0.7.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.0
+        version: 0.7.2
 - !ruby/object:Gem::Dependency
   name: railties
   requirement: !ruby/object:Gem::Requirement