mysql-statsd 3.0 → 3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 60c44d6868a4e8bb040d294554b41de7dd8587f2
-  data.tar.gz: 49adbedfb43619aaefe16dfe3c0709a31ab32ee8
+  metadata.gz: 33315d1d0830c9231d1e5a1caa378c571721035e
+  data.tar.gz: fc0648c6053c4b5e767f12926624b52cc0bf04d7
 SHA512:
-  metadata.gz: 6554affeb5a2beb1ad891a96e2b937b56b0bd6f348ce843b1350f6152261a8b8bddcfc860efaff0272cdbe12c651330b21c9d7eb7fef84b6603b6c4188fa5896
-  data.tar.gz: f6af0c38cf068ae98dab1cbcd74a61b24d9502d655acb609ec41082dd8068d1d508c739d1c868039f795536ecedb53a18a337543ff34437e97e9fb0e7a97b622
+  metadata.gz: 9e8adf89846ef5a0736a3abf97499d023bb219bb14d0767c72b3e84360c7f55130b31706061a1f677ec398a8254d6a0ee3f4e0eae5cfc4b3baa2b65a7e4f48cb
+  data.tar.gz: f723ab5dc4d0cecad9bd11238a5a4b9b24852bc8caf59c82fc09a7ae76102f67bb69a3ca0a93e21051dc2db7a161c52e75aa373a1e5b9335972f196b4d0c4866

data/lib/mysql-statsd.rb

@@ -28,10 +28,9 @@ module Mysql
       private
 
       def instrument_process_list
-        show("PROCESSLIST").each do |entry|
-          statsd.increment metric("Command", entry)
-          statsd.increment metric("State", entry)
-        end
+        @process_list = show "PROCESSLIST"
+        instrument_processes "State"
+        instrument_processes "Command"
       end
 
       def instrument_statuses
@@ -42,8 +41,8 @@ module Mysql
         mysql.query "SHOW #{term}"
       end
 
-      def metric(name, entry)
-        "#{name}.#{entry[name].gsub(" ", "_")}".downcase
+      def instrument_processes(metric_name)
+        @process_list.map { |row| row[metric_name] }.group_by(&:to_s).each { |metric, values| statsd.gauge "#{metric_name}.#{metric.gsub(" ", "_")}".downcase, values.count }
       end
     end
   end

data/lib/mysql-statsd/version.rb

@@ -1,5 +1,5 @@
 module Mysql
   module Statsd
-    VERSION = "3.0"
+    VERSION = "3.1"
   end
 end

data/spec/runner_spec.rb

@@ -34,9 +34,10 @@ describe Mysql::Statsd::Runner do
     end
 
     it "should instrument the process list" do
-      subject.mysql.stub(:query).with("SHOW PROCESSLIST").and_return [{'Command' => 'Jump', 'State' => 'Long Lived'}]
-      subject.statsd.should_receive(:increment).with('command.jump')
-      subject.statsd.should_receive(:increment).with('state.long_lived')
+      subject.mysql.stub(:query).with("SHOW PROCESSLIST").and_return [{'Command' => 'Jump', 'State' => 'Long Lived'}, {'Command' => 'Jump', 'State' => 'Long Dead'}]
+      subject.statsd.should_receive(:gauge).with('state.long_lived', 1)
+      subject.statsd.should_receive(:gauge).with('state.long_dead', 1)
+      subject.statsd.should_receive(:gauge).with('command.jump', 2)
       subject.run!
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mysql-statsd
 version: !ruby/object:Gem::Version
-  version: '3.0'
+  version: '3.1'
 platform: ruby
 authors:
 - Diego Carrion