myna_eventmachine 1.2 → 1.3

data/lib/myna/response.rb

@@ -120,19 +120,21 @@ module Response
 
   class Variant < Response
     def self.from_json(json)
-      variant = Variant.new(json['name'], json['views'], json['totalReward'], json['confidenceBound'])
+      variant = Variant.new(json['name'], json['views'], json['totalReward'], json['lowerConfidenceBound'], json['upperConfidenceBound'])
     end
 
     attr_reader :name
     attr_reader :views
     attr_reader :totalReward
-    attr_reader :confidenceBound
+    attr_reader :lowerConfidenceBound
+    attr_reader :upperConfidenceBound
 
-    def initialize(name, views, totalReward, confidenceBound)
+    def initialize(name, views, totalReward, lowerConfidenceBound, upperConfidenceBound)
       @name = name
       @views = views
       @totalReward = totalReward
-      @confidenceBound = confidenceBound
+      @lowerConfidenceBound = lowerConfidenceBound
+      @upperConfidenceBound = upperConfidenceBound
     end
   end
 end

data/lib/myna/version.rb

@@ -20,5 +20,5 @@
 #
 
 module Myna
-  VERSION = "1.2"
+  VERSION = "1.3"
 end

data/test/test_authorized.rb

@@ -93,12 +93,30 @@ describe Myna do
       info.name.must_equal "test"
       info.uuid.must_equal '45923780-80ed-47c6-aa46-15e2ae7a0e8c'
       info.variants.length.must_equal 2
+
+      v1 = nil
+      v2 = nil
       if info.variants[0].name == 'variant1'
         info.variants[1].name.must_equal 'variant2'
+        v1 = info.variants[0]
+        v2 = info.variants[1]
       else
         info.variants[0].name.must_equal 'variant2'
         info.variants[1].name.must_equal 'variant1'
+        v1 = info.variants[1]
+        v2 = info.variants[0]
+      end
+
+      # Check attributes are all present
+      def check_attributes(variant)
+        variant.views.must_be_kind_of Fixnum
+        variant.totalReward.must_be_kind_of Float
+        variant.upperConfidenceBound.must_be_kind_of Float
+        variant.lowerConfidenceBound.must_be_kind_of Float
       end
+
+      check_attributes(v1)
+      check_attributes(v2)
     end
   end
 end

data/test/test_response.rb

@@ -68,12 +68,14 @@ describe Response do
                   "name":"variant1",
                   "views":36,
                   "totalReward":1.0,
-                  "confidenceBound":0.252904521564191},
+                  "lowerConfidenceBound":0.252904521564191,
+                  "upperConfidenceBound":0.452904521564191},
                  {"typename":"variant",
                   "name":"variant2",
                   "views":9672,
                   "totalReward":0.0,
-                  "confidenceBound":0.015429423531830728}]}'
+                  "lowerConfidenceBound":0.015429423531830728,
+                  "upperConfidenceBound":0.03429423531830728}]}'
       ans = Response.parse(txt)
 
       ans.must_be_kind_of Response::Experiment
@@ -87,12 +89,14 @@ describe Response do
       v0.name.must_equal "variant1"
       v0.views.must_equal 36
       v0.totalReward.must_equal 1.0
-      v0.confidenceBound.must_equal 0.252904521564191
+      v0.lowerConfidenceBound.must_equal 0.252904521564191
+      v0.upperConfidenceBound.must_equal 0.452904521564191
 
       v1.name.must_equal "variant2"
       v1.views.must_equal 9672
       v1.totalReward.must_equal 0.0
-      v1.confidenceBound.must_equal 0.015429423531830728
+      v1.lowerConfidenceBound.must_equal 0.015429423531830728
+      v1.upperConfidenceBound.must_equal 0.03429423531830728
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: myna_eventmachine
 version: !ruby/object:Gem::Version
-  version: '1.2'
+  version: '1.3'
   prerelease: 
 platform: ruby
 authors:
@@ -52,7 +52,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.6
+rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
 summary: Ruby/EventMachine client library for Myna (http://www.mynaweb.com)