mymoip 0.4.1 → 0.5.0

data/CHANGELOG.md

@@ -1,16 +1,19 @@
-CHANGELOG
-=========
+# CHANGELOG
 
-0.4.1
------
+## 0.5.0
+* Breaking backward compatibility with exceptions raised. ArgumentError
+is not used anymore. New MyMoip::InvalidComission, MyMoip::InvalidCreditCard,
+MyMoip::InvalidInstruction and MyMoip::InvalidPayer exceptions inherited from
+MyMoip::Error.
+
+## 0.4.1
 
 * Simultaneous setters for sandbox and production token/keys.
 * DEPRECATE MyMoip.key and MyMoip.token methods over new environment specific setters.
 * Going alive instructions added to README file.
 * Add reference to new my_moip-rails gem.
 
-0.4.0
------
+## 0.4.0
 
 * Accept multiple receivers for each instruction.
     * Can set a fixed value (e.g. R$ 50,00).
@@ -18,13 +21,11 @@ CHANGELOG
     * Define which one will take the fees.
 * Accept payments to any MoIP users, even those without API keys.
 
-0.3.1
------
+## 0.3.1
 
 * Re-releasing 0.3.0 after some Rubygems issues.
 
-0.3.0
------
+## 0.3.0
 
 * Add dependency of active_model gem for validations.
 * Try always to store the plain value of attributes. While the previous version would require you to provide phones in the `"(51)93040-5060"` format, now works even with `"051930405060"`.
@@ -50,48 +51,40 @@ New validations:
     * Validate length of address_cep in 8 chars.
     * Validate length of address_phone (accepts 8 and 9 digit phones with its DDD code).
 
-0.2.6
------
+## 0.2.6
 
 * DEPRECATE owner_rg attribute of MyMoip::CreditCard; you should provide a owner_cpf from now on. Should explain issues with Visa's risk analysis.
 
-0.2.5
------
+## 0.2.5
 
 * Request's log messages moved to debug level.
 * Make CreditCard class accept string and symbol logos.
 * Create MyMoip::CreditCard::AVAILABLE_LOGOS constant.
 * Standardise Request#api_call parameters.
 
-0.2.4
------
+## 0.2.4
 
 * Fix American Express logo format expected by Moip.
 
-0.2.3
------
+## 0.2.3
 
 * Remove .rvmrc
 * CreditCardPayment's initialization can now receive a hash of options.
 * lib/requests folder created.
 * Requests has methods to return its response id.
 
-0.2.2
------
+## 0.2.2
 
 * Explicitly require order for Requests classes.
 
-0.2.1
------
+## 0.2.1
 
 * Bugfix related to explicitly require MyMoip class being needed.
 
-0.2.0
------
+## 0.2.0
 
 * Update production url from `https://desenvolvedor.moip.com.br` to `https://www.moip.com.br`.
 
-0.1.0
------
+## 0.1.0
 
 * First version of the gem.

data/VERSION

@@ -1 +1 @@
-0.4.1
+0.5.0

data/lib/mymoip/commission.rb

@@ -26,12 +26,12 @@ module MyMoip
       elsif percentage_value
         percentage_value * instruction.gross_amount
       else
-        raise ArgumentError, 'Cannot give gross_amount without fixed_value or percentage_value'
+        raise InvalidComission, 'Cannot give gross_amount without fixed_value or percentage_value.'
       end
     end
 
     def to_xml(root = nil)
-      raise ArgumentError, "Invalid params for Commission" if invalid?
+      raise InvalidComission if invalid?
 
       if root.nil?
         xml  = ""

data/lib/mymoip/credit_card_payment.rb

@@ -13,8 +13,8 @@ module MyMoip
     end
 
     def to_json(formatter = MyMoip::Formatter)
-      raise "No CreditCard provided" if credit_card.nil?
-      raise ArgumentError, 'Invalid credit card' if credit_card.invalid?
+      raise InvalidCreditCard, 'No credit card provided.' if credit_card.nil?
+      raise InvalidCreditCard if credit_card.invalid?
 
       json = {
         Forma:        "CartaoCredito",

data/lib/mymoip/exceptions.rb

@@ -0,0 +1,11 @@
+module MyMoip
+  class Error < StandardError; end
+
+  class InvalidComission < Error; end
+
+  class InvalidCreditCard < Error; end
+
+  class InvalidInstruction < Error; end
+
+  class InvalidPayer < Error; end
+end

data/lib/mymoip/instruction.rb

@@ -22,10 +22,10 @@ module MyMoip
     end
 
     def to_xml(root = nil)
-      raise ArgumentError, 'Invalid payer' if payer.invalid?
-      raise ArgumentError, 'Invalid params for instruction' if self.invalid?
+      raise InvalidPayer if payer.invalid?
+      raise InvalidInstruction if self.invalid?
       if invalid_commission = commissions.detect { |c| c.invalid? }
-        raise ArgumentError, "Invalid commission: #{invalid_commission}"
+        raise InvalidComission, invalid_commission
       end
 
       xml  = ""

data/mymoip.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "mymoip"
-  s.version = "0.4.1"
+  s.version = "0.5.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Irio Irineu Musskopf Junior"]
-  s.date = "2013-01-11"
+  s.date = "2013-02-19"
   s.description = "Provides a implementation of MoIP's transparent checkout."
   s.email = "irio.musskopf@caixadeideias.com.br"
   s.extra_rdoc_files = [
@@ -30,6 +30,7 @@ Gem::Specification.new do |s|
     "lib/mymoip/commission.rb",
     "lib/mymoip/credit_card.rb",
     "lib/mymoip/credit_card_payment.rb",
+    "lib/mymoip/exceptions.rb",
     "lib/mymoip/formatter.rb",
     "lib/mymoip/instruction.rb",
     "lib/mymoip/json_parser.rb",

data/test/test_commission.rb

@@ -90,7 +90,7 @@ class TestCommission < Test::Unit::TestCase
   def test_cannot_give_gross_amount_without_fixed_or_percentage_value_set
     instruction = stub(gross_amount: 200)
     subject = Fixture.commission(fixed_value: nil, percentage_value: nil)
-    assert_raise ArgumentError do
+    assert_raise MyMoip::InvalidComission do
       subject.gross_amount(instruction)
     end
   end
@@ -114,7 +114,7 @@ XML
   def test_xml_method_raises_exception_when_called_with_invalid_params
     subject = Fixture.commission
     subject.stubs(:invalid?).returns(true)
-    assert_raise ArgumentError do
+    assert_raise MyMoip::InvalidComission do
       subject.to_xml
     end
   end

data/test/test_credit_card_payment.rb

@@ -91,7 +91,7 @@ class TestCreditCardPayment < Test::Unit::TestCase
 
   def test_to_json_method_raises_an_exception_when_called_without_a_credit_card
     subject = MyMoip::CreditCardPayment.new(nil)
-    assert_raise RuntimeError do
+    assert_raise MyMoip::InvalidCreditCard do
       subject.to_json
     end
   end
@@ -107,7 +107,7 @@ class TestCreditCardPayment < Test::Unit::TestCase
   def test_to_json_method_raises_an_exception_when_called_with_a_invalid_credit_card
     subject = MyMoip::CreditCardPayment.new(Fixture.credit_card)
     MyMoip::CreditCard.any_instance.stubs(:invalid?).returns(true)
-    assert_raise ArgumentError do
+    assert_raise MyMoip::InvalidCreditCard do
       subject.to_json
     end
   end

data/test/test_instruction.rb

@@ -90,7 +90,7 @@ XML
     invalid_commission = Fixture.commission
     invalid_commission.stubs(:invalid?).returns(true)
     subject = Fixture.instruction(commissions: [Fixture.commission, invalid_commission])
-    assert_raise ArgumentError do
+    assert_raise MyMoip::InvalidComission do
       subject.to_xml
     end
   end
@@ -98,7 +98,7 @@ XML
   def test_to_xml_method_raises_exception_when_called_with_invalid_payer
     subject = Fixture.instruction
     MyMoip::Payer.any_instance.stubs(:invalid?).returns(true)
-    assert_raise ArgumentError do
+    assert_raise MyMoip::InvalidPayer do
       subject.to_xml
     end
   end
@@ -106,7 +106,7 @@ XML
   def test_to_xml_method_dont_raises_exception_when_called_with_valid_payer
     subject = Fixture.instruction
     MyMoip::Payer.any_instance.stubs(:invalid?).returns(false)
-    assert_nothing_raised ArgumentError do
+    assert_nothing_raised MyMoip::InvalidPayer do
       subject.to_xml
     end
   end
@@ -114,7 +114,7 @@ XML
   def test_to_xml_method_raises_exception_when_called_with_invalid_params
     subject = Fixture.instruction
     MyMoip::Instruction.any_instance.stubs(:invalid?).returns(true)
-    assert_raise ArgumentError do
+    assert_raise MyMoip::InvalidInstruction do
       subject.to_xml
     end
   end
@@ -122,7 +122,7 @@ XML
   def test_to_xml_method_dont_raises_exception_when_called_with_valid_params
     subject = Fixture.instruction
     MyMoip::Instruction.any_instance.stubs(:invalid?).returns(false)
-    assert_nothing_raised ArgumentError do
+    assert_nothing_raised MyMoip::InvalidInstruction do
       subject.to_xml
     end
   end

data/test/test_mymoip.rb

@@ -78,5 +78,4 @@ class TestMymoip < Test::Unit::TestCase
     MyMoip.logger = my_string = ""
     assert_equal my_string, MyMoip.logger
   end
-
 end

data/test/test_payment_request.rb

@@ -2,7 +2,6 @@
 require 'helper'
 
 class TestPaymentRequest < Test::Unit::TestCase
-
   def test_http_method_as_get
     assert_equal :get, MyMoip::PaymentRequest::HTTP_METHOD
   end
@@ -94,5 +93,4 @@ class TestPaymentRequest < Test::Unit::TestCase
     payment_request = MyMoip::PaymentRequest.new("your_own_id")
     assert_nil payment_request.code
   end
-
 end

data/test/test_request.rb

@@ -47,5 +47,4 @@ class TestRequest < Test::Unit::TestCase
 
     request.api_call(params, logger: logger)
   end
-
 end

data/test/test_transparent_request.rb

@@ -1,7 +1,6 @@
 require 'helper'
 
 class TestTransparentRequest < Test::Unit::TestCase
-
   def test_http_method_as_post
     assert_equal :post, MyMoip::TransparentRequest::HTTP_METHOD
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mymoip
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-11 00:00:00.000000000 Z
+date: 2013-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: builder
@@ -192,6 +192,7 @@ files:
 - lib/mymoip/commission.rb
 - lib/mymoip/credit_card.rb
 - lib/mymoip/credit_card_payment.rb
+- lib/mymoip/exceptions.rb
 - lib/mymoip/formatter.rb
 - lib/mymoip/instruction.rb
 - lib/mymoip/json_parser.rb
@@ -231,7 +232,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1074109935584115222
+      hash: -2331743994126201520
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: