mymoip 0.2.5 → 0.2.6

data/CHANGELOG.md

@@ -1,6 +1,9 @@
 CHANGELOG
 =========
 
+**0.2.6**
+* Deprecate owner_rg attribute of MyMoip::CreditCard; you should provide a owner_cpf from now on. Should explain issues with Visa's risk analysis.
+
 **0.2.5**
 * Request's log messages moved to debug level.
 * Make CreditCard class accept string and symbol logos.

data/README.md

@@ -72,7 +72,7 @@ credit_card = MyMoip::CreditCard.new(
   owner_name: "Juquinha da Rocha",
   owner_birthday: Date.new(1984, 11, 3),
   owner_phone: "(51)3040-5060",
-  owner_rg: "1010202030"
+  owner_cpf: "522.116.706-95"
 )
 
 credit_card_payment = MyMoip::CreditCardPayment.new(credit_card, installments: 1)

data/VERSION

@@ -1 +1 @@
-0.2.5
+0.2.6

data/lib/mymoip/credit_card.rb

@@ -1,7 +1,7 @@
 module MyMoip
   class CreditCard
     attr_accessor :logo, :card_number, :expiration_date, :security_code,
-                :owner_name, :owner_birthday, :owner_phone, :owner_rg
+                :owner_name, :owner_birthday, :owner_phone, :owner_cpf
 
     AVAILABLE_LOGOS = [
       :american_express, :diners, :hipercard, :mastercard, :visa
@@ -15,7 +15,14 @@ module MyMoip
       @owner_name      = params[:owner_name]      if params.has_key? :owner_name
       @owner_birthday  = params[:owner_birthday]  if params.has_key? :owner_birthday
       @owner_phone     = params[:owner_phone]     if params.has_key? :owner_phone
-      @owner_rg        = params[:owner_rg]        if params.has_key? :owner_rg
+      @owner_cpf       = params[:owner_cpf]       if params.has_key? :owner_cpf
+
+      self.owner_rg    = params[:owner_rg]        if params.has_key? :owner_rg
+    end
+
+    def owner_rg=(value)
+      warn "[DEPRECATION] `owner_rg` is deprecated. Please use `owner_cpf` instead."
+      self.owner_cpf = value
     end
   end
 end

data/lib/mymoip/credit_card_payment.rb

@@ -26,7 +26,7 @@ module MyMoip
             Nome:           credit_card.owner_name,
             DataNascimento: credit_card.owner_birthday.strftime("%d/%m/%Y"),
             Telefone:       credit_card.owner_phone,
-            Identidade:     credit_card.owner_rg
+            Identidade:     credit_card.owner_cpf
           }
         }
       }

data/lib/mymoip/request.rb

@@ -2,7 +2,7 @@ module MyMoip
   class Request
     include HTTParty
 
-    attr_reader :id, :data, :response
+    attr_reader :id, :response
 
     def initialize(id)
       @id = id

data/mymoip.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "mymoip"
-  s.version = "0.2.5"
+  s.version = "0.2.6"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Irio Irineu Musskopf Junior"]
-  s.date = "2012-10-28"
+  s.date = "2012-11-13"
   s.description = "Provides a implementation of MoIP's transparent checkout."
   s.email = "irio.musskopf@caixadeideias.com.br"
   s.extra_rdoc_files = [

data/test/fixtures/fixture.rb

@@ -34,7 +34,7 @@ class Fixture
       owner_name: "Juquinha da Rocha",
       owner_birthday: Date.new(1984, 11, 3),
       owner_phone: "(51)3040-5060",
-      owner_rg: "1010202030"
+      owner_cpf: "522.116.706-95"
     }.merge(params)
     MyMoip::CreditCard.new(params)
   end

data/test/fixtures/vcr_cassettes/payment_request.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: https://YOUR_MOIP_TOKEN:YOUR_MOIP_KEY@desenvolvedor.moip.com.br/sandbox/rest/pagamento?callback=?&pagamentoWidget=%7B%22pagamentoWidget%22:%7B%22referer%22:%22http://localhost/default%22,%22token%22:%22M2F021Z2U1O0C1X761K1S1N8C5D0J1V1S0O0F0Y0Q0B0V0A1J1O0C2P6Z965%22,%22dadosPagamento%22:%7B%22Forma%22:%22CartaoCredito%22,%22Parcelas%22:1,%22CartaoCredito%22:%7B%22Numero%22:%224916654211627608%22,%22Expiracao%22:%2206/15%22,%22CodigoSeguranca%22:%22000%22,%22Portador%22:%7B%22Nome%22:%22Juquinha%20da%20Rocha%22,%22DataNascimento%22:%2203/11/1984%22,%22Telefone%22:%22(51)3040-5060%22,%22Identidade%22:%221010202030%22%7D%7D,%22Instituicao%22:%22Visa%22,%22Recebimento%22:%22AVista%22%7D%7D%7D
+    uri: https://YOUR_MOIP_TOKEN:YOUR_MOIP_KEY@desenvolvedor.moip.com.br/sandbox/rest/pagamento?callback=?&pagamentoWidget=%7B%22pagamentoWidget%22:%7B%22referer%22:%22http://localhost/default%22,%22token%22:%22D2O0U1W2K1P1D1R2C2E3H0N3L5X3A2E4E3X0X030T090T0A1D1V2T8X500E3%22,%22dadosPagamento%22:%7B%22Forma%22:%22CartaoCredito%22,%22Parcelas%22:1,%22CartaoCredito%22:%7B%22Numero%22:%224916654211627608%22,%22Expiracao%22:%2206/15%22,%22CodigoSeguranca%22:%22000%22,%22Portador%22:%7B%22Nome%22:%22Juquinha%20da%20Rocha%22,%22DataNascimento%22:%2203/11/1984%22,%22Telefone%22:%22(51)3040-5060%22,%22Identidade%22:%22522.116.706-95%22%7D%7D,%22Instituicao%22:%22Visa%22,%22Recebimento%22:%22AVista%22%7D%7D%7D
     body:
       encoding: US-ASCII
       string: ''
@@ -13,11 +13,11 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Wed, 17 Oct 2012 18:23:26 GMT
+      - Tue, 13 Nov 2012 01:03:56 GMT
       Server:
       - Apache/2.2.23 (CentOS)
       Content-Length:
-      - '271'
+      - '272'
       Vary:
       - Accept-Encoding
       Content-Type:
@@ -29,9 +29,9 @@ http_interactions:
         b3JubyI6IiIsIlRheGFNb0lQIjoiMTUuMTkiLCJTdGF0dXNQYWdhbWVudG8i
         OiJTdWNlc3NvIiwiQ2xhc3NpZmljYWNhbyI6eyJDb2RpZ28iOjk5OSwiRGVz
         Y3JpY2FvIjoiTsOjbyBzdXBvcnRhZG8gbm8gYW1iaWVudGUgU2FuZGJveCJ9
-        LCJDb2RpZ29Nb0lQIjo5NTY5NSwiTWVuc2FnZW0iOiJSZXF1aXNpw6fDo28g
-        cHJvY2Vzc2FkYSBjb20gc3VjZXNzbyIsIlRvdGFsUGFnbyI6IjIwMC4wMCJ9
-        KQ==
+        LCJDb2RpZ29Nb0lQIjoxMDI1OTYsIk1lbnNhZ2VtIjoiUmVxdWlzacOnw6Nv
+        IHByb2Nlc3NhZGEgY29tIHN1Y2Vzc28iLCJUb3RhbFBhZ28iOiIyMDAuMDAi
+        fSk=
     http_version:
-  recorded_at: Wed, 17 Oct 2012 18:21:35 GMT
+  recorded_at: Tue, 13 Nov 2012 01:01:06 GMT
 recorded_with: VCR 2.2.5

data/test/fixtures/vcr_cassettes/transparent_request.yml

@@ -6,7 +6,8 @@ http_interactions:
     body:
       encoding: US-ASCII
       string: <EnviarInstrucao><InstrucaoUnica TipoValidacao="Transparente"><Razao>some
-        payment_reason</Razao><Valores><Valor moeda="BRL">100.00</Valor><Valor moeda="BRL">200.00</Valor></Valores><IdProprio>your_own_instruction_id</IdProprio><Pagador><Nome>Juquinha da Rocha</Nome><Email>juquinha@rocha.com</Email><IdPagador>your_own_payer_id</IdPagador><EnderecoCobranca><Logradouro>Felipe
+        payment_reason</Razao><Valores><Valor moeda="BRL">100.00</Valor><Valor moeda="BRL">200.00</Valor></Valores><IdProprio>my_new_instruction_id</IdProprio><Pagador><Nome>Juquinha
+        da Rocha</Nome><Email>juquinha@rocha.com</Email><IdPagador>your_own_payer_id</IdPagador><EnderecoCobranca><Logradouro>Felipe
         Neri</Logradouro><Numero>406</Numero><Complemento>Sala 501</Complemento><Bairro>Auxiliadora</Bairro><Cidade>Porto
         Alegre</Cidade><Estado>RS</Estado><Pais>BRA</Pais><CEP>90440-150</CEP><TelefoneFixo>(51)3040-5060</TelefoneFixo></EnderecoCobranca></Pagador></InstrucaoUnica></EnviarInstrucao>
     headers: {}
@@ -16,7 +17,7 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Wed, 17 Oct 2012 14:18:49 GMT
+      - Tue, 13 Nov 2012 01:03:52 GMT
       Server:
       - Apache/2.2.23 (CentOS)
       Content-Length:
@@ -27,7 +28,7 @@ http_interactions:
       - text/xml;charset=UTF-8
     body:
       encoding: US-ASCII
-      string: <ns1:EnviarInstrucaoUnicaResponse xmlns:ns1="http://www.moip.com.br/ws/alpha/"><Resposta><ID>201210171118501100000001102691</ID><Status>Sucesso</Status><Token>M2F021Z2U1O0C1X761K1S1N8C5D0J1V1S0O0F0Y0Q0B0V0A1J1O0C2P6Z965</Token></Resposta></ns1:EnviarInstrucaoUnicaResponse>
+      string: <ns1:EnviarInstrucaoUnicaResponse xmlns:ns1="http://www.moip.com.br/ws/alpha/"><Resposta><ID>201210171118501100000001102691</ID><Status>Sucesso</Status><Token>D2O0U1W2K1P1D1R2C2E3H0N3L5X3A2E4E3X0X030T090T0A1D1V2T8X500E3</Token></Resposta></ns1:EnviarInstrucaoUnicaResponse>
     http_version:
-  recorded_at: Wed, 17 Oct 2012 14:16:59 GMT
+  recorded_at: Tue, 13 Nov 2012 01:01:02 GMT
 recorded_with: VCR 2.2.5

data/test/test_credit_card_payment.rb

@@ -49,7 +49,7 @@ class TestCreditCardPayment < Test::Unit::TestCase
     MyMoip::CreditCard.any_instance.stubs(:owner_birthday).returns(original_date)
     assert_equal original_date.strftime("%d/%m/%Y"), payment.to_json[:CartaoCredito][:Portador][:DataNascimento]
     assert_match /\A\(\d{2}\)\d{4,5}-\d{4}/, payment.to_json[:CartaoCredito][:Portador][:Telefone]
-    assert_match /\A\d+\z/, payment.to_json[:CartaoCredito][:Portador][:Identidade]
+    assert_match /\A\d{3}\.\d{3}\.\d{3}\-\d{2}\z/, payment.to_json[:CartaoCredito][:Portador][:Identidade]
   end
 
   def test_to_json_should_accept_any_creditcard_from_available_logos_constant

data/test/test_creditcard.rb

@@ -11,7 +11,7 @@ class TestCreditCard < Test::Unit::TestCase
       owner_name: "Juquinha da Rocha",
       owner_birthday: Date.new(1984, 11, 3),
       owner_phone: "(51)3040-5060",
-      owner_rg: "1010202030"
+      owner_cpf: "522.116.706-95"
     )
 
     assert_equal :visa, subject.logo
@@ -21,7 +21,17 @@ class TestCreditCard < Test::Unit::TestCase
     assert_equal "Juquinha da Rocha", subject.owner_name
     assert_equal Date.new(1984, 11, 3), subject.owner_birthday
     assert_equal "(51)3040-5060", subject.owner_phone
-    assert_equal "1010202030", subject.owner_rg
+    assert_equal "522.116.706-95", subject.owner_cpf
   end
 
+  def test_warns_about_owner_rg_attribute_deprecation_on_initialization
+    MyMoip::CreditCard.any_instance.expects(:warn).with(regexp_matches(/is deprecated/))
+    subject = Fixture.credit_card(owner_rg: '1010202030')
+  end
+
+  def test_warns_about_owner_rg_attribute_deprecation_on_setter
+    subject = Fixture.credit_card
+    subject.expects(:warn).with(regexp_matches(/is deprecated/))
+    subject.owner_rg = '1010202030'
+  end
 end

data/test/test_payment_request.rb

@@ -81,7 +81,7 @@ class TestPaymentRequest < Test::Unit::TestCase
     VCR.use_cassette('payment_request') do
       payment_request.api_call(credit_card_payment, token: transparent_request.token)
     end
-    assert_equal 95695, payment_request.code
+    assert_equal 102596, payment_request.code
   end
 
   def test_code_method_should_return_nil_with_blank_response

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mymoip
 version: !ruby/object:Gem::Version
-  version: 0.2.5
+  version: 0.2.6
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-28 00:00:00.000000000 Z
+date: 2012-11-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: builder
@@ -209,7 +209,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -300341393790101532
+      hash: 1339834329601628158
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: