myjohndeere 0.0.11 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c1831ed7f9d5597914571ae4a25fd71625b9f99e
-  data.tar.gz: 4197edf1ab0d1da49e9701a068acd99c429f12a0
+  metadata.gz: 7e6813bb496ffe2d2a5d24c26c9255d554675184
+  data.tar.gz: 9da19d2acb3e3fdad3b8d08c138e333ee5019f69
 SHA512:
-  metadata.gz: 56e08d24d21555aa5172a6f375c7c94afc29270fbffa5365ec487fbb3dc49aa34ab919687f6d052986f5965166fa6795350c2c5fbae3d85401cc56e513da670f
-  data.tar.gz: a13f520f6b07bf56efc54be842b00008ae033c0d076e5ff589739be54f363688be1eada9f2d9a383bc2d75a4b1025cb2f4d0acdf27ef4a396d3c8c9426f6faed
+  metadata.gz: 3c0d1f7ffd65f2b0c3f1b806d1282f2df3c84c807a4d2ab2c6689af54eaecab6c3cb901d5d5826f227e730bd812bbb2885a73c54fe369eb5ef5d4c73c5f09a35
+  data.tar.gz: 39b995dbdcbfa0af60fd5a2d0cc3b9ce6d6a97c1a7c616f4b79f15ed5d3e38a474a7c2ebf39b09cb5087b3f1b149134a6171a59c68c3aebe5e22e5605e397a40

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    myjohndeere (0.0.11)
+    myjohndeere (0.1.0)
       oauth (>= 0.5.3)
 
 GEM

data/README.md

@@ -2,6 +2,16 @@
 
 The MyJohnDeere Ruby library provides convenient access to the MyJohnDeere API from applications written in the Ruby language. It includes a pre-defined set of classes for API resources that are available currently from the API. You will need to get access by going to the [JohnDeere Developer page](https://developer.deere.com/#!welcome). The interface utilizes OAUTH 1.0.
 
+## Installation
+
+You don't need this source code unless you want to modify the gem. If you just want to use the package, just run:
+
+`gem install myjohndeere`
+
+If you want to build the gem from source:
+
+`gem build myjohndeere.gemspec`
+
 ## Usage
 
 ### Configuration
@@ -82,13 +92,13 @@ end
 
 ## Listable Objects
 
-MyJohnDeere returns either pages of objects that will automatically be iterated through 10 at a time *or* you'll receive the entirety of the resource if you specify an etag token. **The default behavior is for pagination.**
+MyJohnDeere returns either pages of objects that will automatically be iterated through 10 at a time *or* you'll receive the entirety of the resource if you specify an ETAG token. **The default behavior is for pagination.**
 
 **If using the paginated approach**: Use `more_pages?` on the listable object to see if there are more pages to be acquired by using `next_page!`. This will modify the `.start` and `.count` values on the list object. These automatically increase with each `next_page`.
 
-**If using the etag approach**: The entirety of the data set will be returned to you and on the list object you'll want to call `list.etag` and store this locally. You can then use this on future requests to see if anything has changed from the original request.
+**If using the ETAG approach**: The entirety of the data set will be returned to you and on the list object you'll want to call `list.etag` and store this locally. You can then use this on future requests to see if anything has changed from the original request. To use it: `MyJohnDeere::Organization.list(access_token, etag: '')`
 
-If you for some reason specify both, the etag will be the assumed behavior.
+If you for some reason specify both, the ETAG will be the assumed behavior.
 
 The raw data can be acquired by using `.data` on a listable object.
 

data/lib/myjohndeere/boundary.rb

@@ -10,7 +10,6 @@ module MyJohnDeere
       super(json_object, access_token)
       self.field_id = field_id
       self.active = self.active.to_s.downcase == "true"
-      self.multipolygons = json_object["multipolygons"]
       # This doesn't exist currently, not sure why
       self.field_id ||= extract_link_with_rel_from_list("fields", /\/(\d+)\/(.+?)\/fields\Z/)
     end

data/lib/myjohndeere/rest_methods.rb

@@ -10,9 +10,14 @@ module MyJohnDeere
       def list(access_token, options = {})
         validate_access_token(access_token)
         options = {count: 10, start: 0, etag: nil}.merge(options)
+        if !options[:etag].nil? then
+          options.delete(:count)
+          options.delete(:start)
+        end
         options[:body] ||= {}
         # The count and start are in this list,so move them into the body
         SPECIAL_BODY_PARAMETERS.each do |sbp|
+          next if options[sbp].nil?
           options[:body][sbp] = options[sbp]
         end
 

data/lib/myjohndeere/version.rb

@@ -1,3 +1,3 @@
 module MyJohnDeere
-  VERSION = '0.0.11'
+  VERSION = '0.1.0'
 end

data/test/test_rest_methods.rb

@@ -25,6 +25,20 @@ class TestRestMethods < Minitest::Test
     end
   end
 
+  def test_deleted_object_with_etag
+    etag_val = "something"
+    new_etag = "something2"
+    stub_request(:get, /organizations\Z/).
+      with(headers: {MyJohnDeere::ETAG_HEADER_KEY => etag_val}).
+      to_return(status: 200, body: API_FIXTURES["deleted_organization"].to_json(),
+        headers: {MyJohnDeere::ETAG_HEADER_KEY=>new_etag})
+    
+    organizations = MyJohnDeere::Organization.list(default_access_token, etag: etag_val)
+
+    assert organizations.data.first.deleted
+    assert_equal new_etag, organizations.etag
+  end
+
   def test_list_with_etag
     stub_request(:get, /organizations/).
       with(headers: {MyJohnDeere::ETAG_HEADER_KEY => ""}).
@@ -49,8 +63,9 @@ class TestRestMethods < Minitest::Test
   end
 
   def test_list_with_body
-    stub_request(:get, /organizations;start=0;count=1/).
-      with(query: {embed: "boundaries"}).
+    stub_request(:get, /organizations/).
+      with(query: {embed: "boundaries"},
+        headers: {MyJohnDeere::ETAG_HEADER_KEY=>""}).
       to_return(status: 200, body: LIST_FIXTURE.to_json())
     organizations = MyJohnDeere::Organization.list(default_access_token, count: 1, etag: "", body: {embed: "boundaries"})
     assert_equal({:embed=>"boundaries"}, organizations.options[:body])

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: myjohndeere
 version: !ruby/object:Gem::Version
-  version: 0.0.11
+  version: 0.1.0
 platform: ruby
 authors:
 - Paul Susmarski