mygengo 1.4 → 1.5

data/lib/mygengo-ruby/api_handler.rb

@@ -61,7 +61,10 @@ module MyGengo
 		# <tt>endpoint</tt> - String/URL to request data from.
 		# <tt>params</tt> - Data necessary for request (keys, etc). Generally taken care of by the requesting instance.
 		def get_from_mygengo(endpoint, params = {})
-			# The first part of the object we're going to encode and use in our request to myGengo. The signing process
+			# Do this small check here...
+            is_delete = params.delete(:is_delete)
+            
+            # The first part of the object we're going to encode and use in our request to myGengo. The signing process
 			# is a little annoying at the moment, so bear with us...
 			query = {
 				:api_key => @opts[:public_key],
@@ -71,11 +74,20 @@ module MyGengo
 			endpoint << "?api_sig=" + signature_of(query[:ts])
 			endpoint << '&' + query.map { |k, v| "#{k}=#{urlencode(v)}" }.join('&')	
 
+            uri = "/v#{@opts[:api_version]}/" + endpoint
+            headers = {
+                'Accept' => 'application/json',
+                'User-Agent' => @opts[:user_agent]
+            }
+
+            if is_delete
+                req = Net::HTTP::Delete.new(uri, headers)
+            else
+                req = Net::HTTP::Get.new(uri, headers)
+            end
+
 			resp = Net::HTTP.start(@api_host, 80) do |http|
-				http.request(Net::HTTP::Get.new("/v#{@opts[:api_version]}/" + endpoint, {
-					'Accept' => 'application/json', 
-					'User-Agent' => @opts[:user_agent]
-				}))
+				http.request(req)
 			end
 
 			json = JSON.parse(resp.body)
@@ -179,7 +191,7 @@ module MyGengo
 		# <tt>id</tt> - The ID of a job to update.
 		# <tt>action</tt> - A hash describing the update to this job. See the examples for further documentation.
 		def updateTranslationJob(params = {})
-			self.send_to_mygengo('translate/job/:id'.gsub(':id', params.delete(:id)), params)
+			self.send_to_mygengo('translate/job/:id'.gsub(':id', params.delete(:id).to_s), params)
 		end
 
 		# Updates a group of already submitted jobs.
@@ -196,7 +208,7 @@ module MyGengo
 		# <tt>id</tt> - The ID of a job to check.
 		# <tt>pre_mt</tt> - Optional, get a machine translation if the human translation is not done.
 		def getTranslationJob(params = {})
-			self.get_from_mygengo('translate/job/:id'.gsub(':id', params.delete(:id)), params)
+			self.get_from_mygengo('translate/job/:id'.gsub(':id', params.delete(:id).to_s), params)
 		end
 
 		# Pulls down a list of recently submitted jobs, allows some filters.
@@ -216,7 +228,7 @@ module MyGengo
 		#
 		# <tt>id</tt> - Required, the ID of a job that you want the batch/group of.
 		def getTranslationJobBatch(params = {})
-			self.get_from_mygengo('translate/jobs/group/:group_id'.gsub(':group_id', params.delete(:group_id)), params)
+			self.get_from_mygengo('translate/jobs/group/:group_id'.gsub(':group_id', params.delete(:group_id).to_s), params)
 		end
 	
 		# Mirrors the bulk Translation call, but just returns an estimated cost.
@@ -230,7 +242,7 @@ module MyGengo
 		# <tt>id</tt> - The ID of the job you're commenting on.
 		# <tt>comment</tt> - The comment to put on the job.
 		def postTranslationJobComment(params = {})
-			self.send_to_mygengo('translate/job/:id/comment'.gsub(':id', params.delete(:id)), params)
+			self.send_to_mygengo('translate/job/:id/comment'.gsub(':id', params.delete(:id).to_s), params)
 		end
 
 		# Get all comments (the history) from a given job.
@@ -238,7 +250,7 @@ module MyGengo
 		# Options:
 		# <tt>id</tt> - The ID of the job to get comments for.
 		def getTranslationJobComments(params = {})
-			self.get_from_mygengo('translate/job/:id/comments'.gsub(':id', params.delete(:id)), params)
+			self.get_from_mygengo('translate/job/:id/comments'.gsub(':id', params.delete(:id).to_s), params)
 		end
 
 		# Returns the feedback you've submitted for a given job.
@@ -246,7 +258,7 @@ module MyGengo
 		# Options:
 		# <tt>id</tt> - The ID of the translation job you're retrieving comments from.
 		def getTranslationJobFeedback(params = {})
-			self.get_from_mygengo('translate/job/:id/feedback'.gsub(':id', params.delete(:id)), params)
+			self.get_from_mygengo('translate/job/:id/feedback'.gsub(':id', params.delete(:id).to_s), params)
 		end
 
 		# Gets a list of the revision resources for a job. Revisions are created each time a translator updates the text.
@@ -254,7 +266,7 @@ module MyGengo
 		# Options:
 		# <tt>id</tt> - The ID of the translation job you're getting revisions from.
 		def getTranslationJobRevisions(params = {})
-			self.get_from_mygengo('translate/job/:id/revisions'.gsub(':id', params.delete(:id)), params)
+			self.get_from_mygengo('translate/job/:id/revisions'.gsub(':id', params.delete(:id).to_s), params)
 		end
 
 		# Get a specific revision to a job.
@@ -263,7 +275,7 @@ module MyGengo
 		# <tt>id</tt> - The ID of the translation job you're getting revisions from.
 		# <tt>rev_id</tt> - The ID of the revision you're looking up.
 		def getTranslationJobRevision(params = {})
-			self.get_from_mygengo('translate/job/:id/revisions/:revision_id'.gsub(':id', params.delete(:id)).gsub(':rev_id', params.delete(:rev_id)), params)
+			self.get_from_mygengo('translate/job/:id/revisions/:revision_id'.gsub(':id', params.delete(:id).to_s).gsub(':revision_id', params.delete(:rev_id).to_s), params)
 		end
 
 		# Returns a preview image for a job.
@@ -271,7 +283,7 @@ module MyGengo
 		# Options:
 		# <tt>id</tt> - The ID of the job you want a preview image of.
 		def getTranslationJobPreviewImage(params = {})
-			self.get_from_mygengo('translate/job/:id/preview'.gsub(':id', params.delete(:id)), params)
+			self.get_from_mygengo('translate/job/:id/preview'.gsub(':id', params.delete(:id).to_s), params)
 		end
 
 		# Deletes a job.
@@ -279,7 +291,8 @@ module MyGengo
 		# Options:
 		# <tt>id</tt> - The ID of the job you want to delete.
 		def deleteTranslationJob(params = {})
-			self.send_to_mygengo('translate/job/:id'.gsub(':id', params.delete(:id)), params)
+            params[:is_delete] = true
+			self.get_from_mygengo('translate/job/:id'.gsub(':id', params.delete(:id).to_s), params)
 		end
 
 		# Deletes multiple jobs.
@@ -292,7 +305,8 @@ module MyGengo
 				params.delete(:ids)
 			end
 			
-			self.send_to_mygengo('translate/jobs', params)
+            params[:is_delete] = true
+			self.get_from_mygengo('translate/jobs', params)
 		end
 
 		# Gets information about currently supported language pairs.
@@ -300,7 +314,7 @@ module MyGengo
 		# Options:
 		# <tt>lc_src</tt> - Optional language code to filter on.
 		def getServiceLanguagePairs(params = {})
-			self.get_from_mygengo('translate/service/language_pairs', params)
+            self.get_from_mygengo('translate/service/language_pairs', params)
 		end
 
 		# Pulls down currently supported languages.

data/lib/mygengo.rb

@@ -11,6 +11,6 @@ module MyGengo
 		SANDBOX_API_HOST = 'api.sandbox.mygengo.com'
 
 		# Pretty self explanatory.
-		VERSION = '1.4'
+		VERSION = '1.5'
 	end
 end

metadata

@@ -2,7 +2,7 @@
 name: mygengo
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: "1.4"
+  version: "1.5"
 platform: ruby
 authors: 
 - Ryan McGrath <ryan@mygengo.com>
@@ -12,7 +12,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-08-17 00:00:00 +09:00
+date: 2011-08-17 00:00:00 -04:00
 default_executable: 
 dependencies: []