myfinance 1.6.3 → 1.6.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 781a84bd31389b8d69d873da030851965902aafa
-  data.tar.gz: 7c23572e2f4557a92249d1758cc38e304c9aa1b6
+  metadata.gz: 96cb950b2d9e9792d94d12ca1e1839084e39f7ce
+  data.tar.gz: d0fce854c096450de3358b2a84a418bcfa8b7004
 SHA512:
-  metadata.gz: 05112cd8549d2af448f1c8564bb616598384ff12e17570373318a43a2327b1a889fbb150cfb4dfc411b45be282eb666b5d3c0e205a29b8d2be7185836ef39bad
-  data.tar.gz: 56dc5b199580f075176b226e7467b8c1aa6974e2ce00c655aa07e070f4d16d9204b5a03a833c5110a4dc6e0172d0aa0fa6ada3841dda48220ee4d3ed15344775
+  metadata.gz: 898d79691eb444ff99029bc3cf607a9307500046cc5f45c58a82ec420957c22f5ae01280042088617e87322b201254a972e70d4dfc37bc2498e8a4e75ae90960
+  data.tar.gz: 105dbc69088d91a31a0ee814cfc795a90f5c6775aba78ebe39703bce1a8958901146b2e267c884fcd3624f7b72918da67106dc559a554298a48813ddc2de376f

data/CHANGELOG.md

@@ -1,4 +1,6 @@
 # Changelog
+## v1.6.4
+- Add headers information in RequestError object
 ## v1.6.3
 - Change `mime-types` dependency to allow a broader range of versions so as to continue supporting Rails 3
 ## v1.6.2

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    myfinance (1.6.1)
+    myfinance (1.6.4)
       mime-types (>= 1.16, < 3.0)
       multi_json (~> 1.11)
       require_all (~> 1.4.0)

data/lib/myfinance/exception.rb

@@ -1,11 +1,12 @@
 module Myfinance
   class Exception < StandardError
-    attr_accessor :code, :body
+    attr_accessor :code, :body, :headers
 
     def initialize(args = {})
       super(args[:message])
       @code     = args[:code]
       @body     = args[:body]
+      @headers  = args[:headers]
     end
   end
 end

data/lib/myfinance/response.rb

@@ -29,12 +29,12 @@ module Myfinance
     end
 
     def error!
-      error = RequestError.new(
+      raise RequestError.new(
         code:    code,
         message: request_error_message,
-        body:    parsed_body
+        body:    parsed_body,
+        headers: headers
       )
-      raise error
     end
 
     def request_error_message

data/lib/myfinance/version.rb

@@ -1,3 +1,3 @@
 module Myfinance
-  VERSION = "1.6.3".freeze
+  VERSION = "1.6.4".freeze
 end

data/spec/lib/myfinance/resources/attachment_spec.rb

@@ -89,7 +89,7 @@ describe Myfinance::Resources::Attachment, vcr: true do
       end
 
       it "adds information on request error object" do
-        expect(Myfinance::RequestError).to receive(:new).with(code: 422, message: "Unprocessable Entity", body: { "attachment" => ["não pode ser vazio."] }).and_call_original
+        expect(Myfinance::RequestError).to receive(:new).with(code: 422, message: "Unprocessable Entity", body: { "attachment" => ["não pode ser vazio."] }, headers: instance_of(Typhoeus::Response::Header)).and_call_original
         expect { subject }.to raise_error(Myfinance::RequestError)
       end
     end
@@ -102,7 +102,7 @@ describe Myfinance::Resources::Attachment, vcr: true do
       end
 
       it "adds information on request error object" do
-        expect(Myfinance::RequestError).to receive(:new).with(code: 403, message: "Forbidden", body: {"error" => "Você não tem permissão para acessar este recurso." }).and_call_original
+        expect(Myfinance::RequestError).to receive(:new).with(code: 403, message: "Forbidden", body: {"error" => "Você não tem permissão para acessar este recurso." }, headers: instance_of(Typhoeus::Response::Header)).and_call_original
         expect { subject }.to raise_error(Myfinance::RequestError)
       end
     end

data/spec/lib/myfinance/resources/payable_account_spec.rb

@@ -144,7 +144,7 @@ describe Myfinance::Resources::PayableAccount do
 
       it "adds information on request error object" do
         body = { "competency_month" => ["não pode ser vazio"], "due_date" => ["não é uma data válida"] }
-        expect(request_error).to receive(:new).with(code: 422, message: "", body: body).and_call_original
+        expect(request_error).to receive(:new).with(code: 422, message: "", body: body, headers: instance_of(Typhoeus::Response::Header)).and_call_original
         expect { subject }.to raise_error(request_error)
       end
     end
@@ -158,7 +158,7 @@ describe Myfinance::Resources::PayableAccount do
 
       it "adds information on request error object" do
         body = {"error" => "Você não tem permissão para acessar este recurso." }
-        expect(request_error).to receive(:new).with(code: 403, message: "Forbidden", body: body).and_call_original
+        expect(request_error).to receive(:new).with(code: 403, message: "Forbidden", body: body, headers: instance_of(Typhoeus::Response::Header)).and_call_original
         expect { subject }.to raise_error(request_error)
       end
     end

data/spec/lib/myfinance/resources/receivable_account_spec.rb

@@ -11,7 +11,7 @@ describe Myfinance::Resources::ReceivableAccount do
     before :each do
       subject.build
     end
-    
+
     context "with pagination" do
       subject { client.receivable_accounts.find_all(entity_id, page) }
 
@@ -145,7 +145,7 @@ describe Myfinance::Resources::ReceivableAccount do
 
       it "adds information on request error object" do
         body = { "competency_month" => ["não pode ser vazio"], "due_date" => ["não é uma data válida"] }
-        expect(request_error).to receive(:new).with(code: 422, message: "", body: body).and_call_original
+        expect(request_error).to receive(:new).with(code: 422, message: "", body: body, headers: instance_of(Typhoeus::Response::Header)).and_call_original
         expect { subject }.to raise_error(request_error)
       end
     end
@@ -159,7 +159,7 @@ describe Myfinance::Resources::ReceivableAccount do
 
       it "adds information on request error object" do
         body = { "error" => "Você não tem permissão para acessar este recurso." }
-        expect(request_error).to receive(:new).with(code: 403, message: "Forbidden", body: body).and_call_original
+        expect(request_error).to receive(:new).with(code: 403, message: "Forbidden", body: body, headers: instance_of(Typhoeus::Response::Header)).and_call_original
         expect { subject }.to raise_error(request_error)
       end
     end

data/spec/lib/myfinance/response_spec.rb

@@ -29,7 +29,20 @@ describe Myfinance::Response do
     end
 
     context 'when not success neither timeout' do
-      let(:response) { double(success?: false, timed_out?: false, code: 301, status_message: 'Moved Permanently', body: '') }
+      let(:headers) do
+        {
+          "Date" => "Tue, 17 Apr 2018 15:47:10 GMT", "Expires" => "-1",
+          "Cache-Control"=>"private, max-age=0"
+        }
+      end
+
+      let(:response) do
+        double({
+          success?: false, timed_out?: false, code: 301,
+          status_message: 'Moved Permanently', body: '',
+          headers: headers
+        })
+      end
 
       it 'raises RequestError' do
         expect { subject.resolve! }.to raise_error do |error|
@@ -37,12 +50,13 @@ describe Myfinance::Response do
           expect(error.code).to eq(301)
           expect(error.message).to eq("Moved Permanently")
           expect(error.body).to eq({})
+          expect(error.headers).to eq(headers)
         end
       end
 
       context "when status_message is empty" do
         context "when body has an 'error' key" do
-          let(:response) { double(success?: false, timed_out?: false, code: 301, status_message: '', body: '{"error": "My custom error message"}') }
+          let(:response) { double(success?: false, timed_out?: false, code: 301, status_message: '', body: '{"error": "My custom error message"}', headers: {}) }
 
           it "raises RequestError with custom message" do
             expect { subject.resolve! }.to raise_error do |error|
@@ -55,7 +69,7 @@ describe Myfinance::Response do
         end
 
         context "when body has an 'error' key" do
-          let(:response) { double(success?: false, timed_out?: false, code: 301, status_message: '', body: '') }
+          let(:response) { double(success?: false, timed_out?: false, code: 301, status_message: '', body: '', headers: {}) }
 
           it "raises RequestError with empty message" do
             expect { subject.resolve! }.to raise_error do |error|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: myfinance
 version: !ruby/object:Gem::Version
-  version: 1.6.3
+  version: 1.6.4
 platform: ruby
 authors:
 - Eduardo Hertz
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-12 00:00:00.000000000 Z
+date: 2018-04-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: typhoeus
@@ -433,7 +433,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2.2
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: A Ruby client for the Myfinance REST API