myfinance 1.3.1 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 63cd8fdeb1a3544c1b83b7ef0e6fcbfb327ad653
-  data.tar.gz: 16823351a31b55b729ebe198e7fcfa964fd4d2f0
+  metadata.gz: d4e81004a6f6c7920181666ec4fd9bc3781dcdd9
+  data.tar.gz: 17a3994ee0f04f150d8cc87fd662c0bf6478d98f
 SHA512:
-  metadata.gz: b01cd38702ddb2ce63730244b1381641b8cbcaf5b6e5694baf5912f19056c21db3a221a25edee48e05dac2395533ea081563d00033672d481de4cb6fd2d1b921
-  data.tar.gz: a963cccfe0eb8c582accca87e810b049d4644f67ed24e8728df4c18a619364031112f8dee9744e22da458af3511303a12884d6aa430d28682c3bb2f82c2c3035
+  metadata.gz: 7c24b62f71ca61e76f3392eb32993df9858e1555afa9e01df758a6f547906719f309267d6ae34a845275d28060d16356a426eef0bfc5bebc08d6bd958fbfee85
+  data.tar.gz: a7ec2973ce7b53ae2a24e0a30a97172f3255006e84859cd56fb42af33f1eaa16481be032cde55053c1ce62a12eccd28b96252da4c25081b3483c8cc7cfca1b84

data/.rubocop.yml

@@ -43,3 +43,12 @@ Style/SpaceAroundEqualsInParameterDefault:
 Style/StringLiterals:
   StyleGuide: "https://github.com/bbatsov/ruby-style-guide#consistent-string-literals"
   EnforcedStyle: double_quotes
+Style/PercentLiteralDelimiters:
+  StyleGuide: "https://github.com/bbatsov/ruby-style-guide#percent-literal-braces"
+  PreferredDelimiters:
+    default: ()
+    '%i': '[]'
+    '%I': '[]'
+    '%r': '{}'
+    '%w': '[]'
+    '%W': '[]'

data/CHANGELOG.md

@@ -1,4 +1,19 @@
 # Changelog
+## v1.4.0
+### New attributes
+- `Sale` now has the following new attributes:
+  - `attachments_count`, reflecting the fact that `Sale` can now have attachments
+  - `ticket_amount`, amount needed to pay due to some kind of penalty
+  - `interest_amount`, interest amount
+  - `discount_amount`, amount that will be reduced because of a discount
+  - `total_amount`, equals nominal_amount + ticket_amount + interest_amount - discount_amount
+  - `api_related`, `true` if `Sale` was created by the API, `false` otherwise
+  - `tax_charges_attributes`, reflecting the fact that `Sale` can now have taxes
+### Attributes renamed
+- `Sale`:
+  - `liquidation_week_day` changed to `liquidation_weekday`, conforming to Rails' convention
+- `FinancialAccount`:
+  - `financial_account_taxes_attributes` was changed to `tax_charges_attributes`
 ## v1.3.1
 ### Fixes
 - Fix lib require to be relatively

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    myfinance (1.3.1)
+    myfinance (1.4.0)
       mime-types (~> 2.99)
       multi_json (~> 1.11)
       require_all (~> 1.4.0)

data/lib/myfinance/entities/financial_account.rb

@@ -22,7 +22,7 @@ module Myfinance
       end
       [:created_at, :updated_at].each { |k| attribute k, DateTime }
 
-      attribute :financial_account_taxes_attributes, Array[Hash]
+      attribute :tax_charges_attributes, Array[Hash]
       attribute :reconciliations, Hash[String => Array]
       attribute :links, Array[Hash[String => String]]
     end

data/lib/myfinance/entities/sale.rb

@@ -1,32 +1,40 @@
 module Myfinance
   module Entities
     class Sale < Base
-      attribute :id
-      attribute :nominal_amount
-      attribute :receivable_amount
-      attribute :fixed_fee_amount
-      attribute :fee_percentage
-      attribute :fee_percentage_amount
-      attribute :issuer
-      attribute :payment_method
-      attribute :status
-      attribute :summary
-      attribute :description
-      attribute :observation
+      attribute :api_related
+      attribute :attachments_count
       attribute :category_id
       attribute :classification_center_id
-      attribute :person_id
+      attribute :confirmed_at
+      attribute :created_at
+      attribute :custom_classifications
+      attribute :custom_classifications
       attribute :days_to_liquidation
-      attribute :sale_account_id
-      attribute :financial_account_id
-      attribute :liquidation_week_day
+      attribute :description
+      attribute :discount_amount
       attribute :estimated_liquidated_at
+      attribute :fee_percentage
+      attribute :fee_percentage_amount
+      attribute :financial_account_id
+      attribute :fixed_fee_amount
+      attribute :id
+      attribute :interest_amount
+      attribute :issuer
       attribute :liquidated_at
+      attribute :liquidation_weekday
+      attribute :nominal_amount
+      attribute :observation
       attribute :occurred_at
-      attribute :confirmed_at
-      attribute :created_at
+      attribute :payment_method
+      attribute :person_id
+      attribute :receivable_amount
+      attribute :sale_account_id
+      attribute :status
+      attribute :summary
+      attribute :tax_charges_attributes
+      attribute :ticket_amount
+      attribute :total_amount
       attribute :updated_at
-      attribute :custom_classifications
     end
   end
 end

data/lib/myfinance/version.rb

@@ -1,3 +1,3 @@
 module Myfinance
-  VERSION = "1.3.1".freeze
+  VERSION = "1.4.0".freeze
 end

data/spec/lib/myfinance/entities/payable_account_spec.rb

@@ -8,6 +8,6 @@ describe Myfinance::Entities::PayableAccount do
     :discount_amount, :total_amount, :description, :document, :document_emission_date, :observation, :remind,
     :reminded_at, :income_tax_relevant, :category_id, :classification_center_id, :expected_deposit_account_id,
     :recurrence_id, :person_id, :recurrent, :parcelled, :recurrence_period, :number_of_parcels, :current_parcel,
-    :competency_month, :financial_account_taxes_attributes, :reconciliations, :links, :created_at, :updated_at
+    :competency_month, :tax_charges_attributes, :reconciliations, :links, :created_at, :updated_at
   ]
 end

data/spec/lib/myfinance/entities/receivable_account_spec.rb

@@ -8,6 +8,6 @@ describe Myfinance::Entities::ReceivableAccount do
     :discount_amount, :total_amount, :description, :document, :document_emission_date, :observation, :remind,
     :reminded_at, :income_tax_relevant, :category_id, :classification_center_id, :expected_deposit_account_id,
     :recurrence_id, :person_id, :recurrent, :parcelled, :recurrence_period, :number_of_parcels, :current_parcel,
-    :competency_month, :financial_account_taxes_attributes, :reconciliations, :links, :created_at, :updated_at
+    :competency_month, :tax_charges_attributes, :reconciliations, :links, :created_at, :updated_at
   ]
 end

data/spec/lib/myfinance/entities/sale_spec.rb

@@ -2,31 +2,38 @@ require "spec_helper"
 
 describe Myfinance::Entities::Sale do
   it_behaves_like "entity_attributes", %i[
-    id
-    nominal_amount
-    receivable_amount
-    fixed_fee_amount
-    fee_percentage
-    fee_percentage_amount
-    issuer
-    payment_method
-    status
-    summary
-    description
-    observation
+    api_related
+    attachments_count
     category_id
     classification_center_id
-    person_id
+    confirmed_at
+    created_at
+    custom_classifications
     days_to_liquidation
-    sale_account_id
-    financial_account_id
-    liquidation_week_day
+    description
+    discount_amount
     estimated_liquidated_at
+    fee_percentage
+    fee_percentage_amount
+    financial_account_id
+    fixed_fee_amount
+    id
+    interest_amount
+    issuer
     liquidated_at
+    liquidation_weekday
+    nominal_amount
+    observation
     occurred_at
-    confirmed_at
-    created_at
+    payment_method
+    person_id
+    receivable_amount
+    sale_account_id
+    status
+    summary
+    tax_charges_attributes
+    ticket_amount
+    total_amount
     updated_at
-    custom_classifications
   ]
 end

data/spec/lib/myfinance/resources/payable_account_spec.rb

@@ -116,7 +116,7 @@ describe Myfinance::Resources::PayableAccount do
         expect(subject.number_of_parcels).to be_nil
         expect(subject.current_parcel).to be_nil
         expect(subject.competency_month).to eq("2015-08")
-        expect(subject.financial_account_taxes_attributes).to be_empty
+        expect(subject.tax_charges_attributes).to be_empty
       end
 
       context "when the payable_account has occurred_at value defined" do

data/spec/lib/myfinance/resources/receivable_account_spec.rb

@@ -117,7 +117,7 @@ describe Myfinance::Resources::ReceivableAccount do
         expect(subject.number_of_parcels).to be_nil
         expect(subject.current_parcel).to be_nil
         expect(subject.competency_month).to eq("2015-08")
-        expect(subject.financial_account_taxes_attributes).to be_empty
+        expect(subject.tax_charges_attributes).to be_empty
       end
 
       context "when the receivable_account has occurred_at value defined" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: myfinance
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.4.0
 platform: ruby
 authors:
 - Eduardo Hertz
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-19 00:00:00.000000000 Z
+date: 2017-07-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: typhoeus
@@ -413,7 +413,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: A Ruby client for the Myfinance REST API