myfinance 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fd16eafab7c1a94cdb638ad2e9efa9c942029289
-  data.tar.gz: b71308b1b0e4cd9629698d185cbd9ae7a70d242d
+  metadata.gz: e49d84feaf307f282f994b21f56cc226f43d8079
+  data.tar.gz: d2fcb49e144edf03733dfb3859b86e756d1534fa
 SHA512:
-  metadata.gz: c186bac4b437d5a1ace502f62985389aa0637cf9614886bc7805e5d6fc619f979e7c41e5810a63d2d113bb240b2ca3d2a88f4310aad64dd4a8b588ad882be856
-  data.tar.gz: 9eba0d8098e7be11dd9e2694d2f2e32a2c626987885437f41fdaad42b016d43bb4a4aa1a463f38fa3f856f471ac57d3106b163b35fede4d60d1a5261acfa140c
+  metadata.gz: 9baa5c658a1a964658141f2f4fcdbb69c82c404134162aaca037e423ef52df92d5369663f5af385378cf2ca766941d5a05f810b8b989c81f883cb70c64306c2f
+  data.tar.gz: b470d45735a4139faa9f98839e023984d69b25b1434604153d85bead8a26db9e61cb0a47dbde84871160fd809c76c15984935f2080fb8850da3783c946e00aff

data/.gitignore

@@ -6,7 +6,7 @@
 .DS_Store
 .envrc
 .env
-.ruby-version
+.ruby-*
 .rvmrc
 coverage
 InstalledFiles

data/CHANGELOG.md

@@ -2,28 +2,28 @@
 
 ## v1.2.0
 ### Endpoints improvements
-- The `#find_all` method of all endpoints that support filtering can now receive parameters to refine the results and paginate
+- The `#find_all` method of all endpoints that support filtering can now receive parameters to refine the results and paginate.
 ### Deprecations
 - No longer supports `#find_by`. Use `#find_all` instead, passing filters as a hash if needed.
 ### Fixes
-- Params encoding set to Rack
+- Params encoding set to Rack. This is necessary in order to fix an issue with Array parameters.
 
 ## v1.1.0
 
 ### New Endpoints
-- Add endpoint Deposit Accounts filtering
-- Add endpoint Entities filtering
+- Add endpoint Deposit Accounts filtering.
+- Add endpoint Entities filtering.
 
 ## v1.0.0
 
 ### New Endpoints
-- Add Bank Statements endpoints
-- Add Categories endpoints
-- Add Credit Cards endpoints
-- Add Credit Cards Transactions endpoints
-- Add Reconciles endpoints
-- More endpoints for Financial Accounts (`find_all`, `find`)
+- Add Bank Statements endpoints.
+- Add Categories endpoints.
+- Add Credit Cards endpoints.
+- Add Credit Cards Transactions endpoints.
+- Add Reconciles endpoints.
+- More endpoints for Financial Accounts (`find_all`, `find`).
 ### Improvements
-- Implement search by attributes in Categories
+- Implement search by attributes in Categories.
 ###  Deprecations
-- `FinancialAccount#destroy` and `#update` signatures are now `(entity_id, id, params)` instead of `(id, entity_id, params)`
+- `FinancialAccount#destroy` and `#update` signatures are now `(entity_id, id, params)` instead of `(id, entity_id, params)`.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    myfinance (1.2.0)
+    myfinance (1.2.1)
       mime-types (~> 2.99)
       multi_json (~> 1.11)
       typhoeus (~> 0.8)

data/lib/myfinance/resources/base.rb

@@ -16,7 +16,7 @@ module Myfinance
       end
 
       def query(params)
-        page = params.delete(:page)         
+        page = params.delete(:page)
         query = params.map { |key, value| "search[#{key}]=#{value}" }
         query << "page=#{page}" if page
         query

data/lib/myfinance/resources/classification_center.rb

@@ -88,6 +88,20 @@ module Myfinance
       def endpoint
         "/classification_centers"
       end
+
+      def build_search_endpoint(params)
+        query_string = query(params).join("&")
+        URI.encode("#{endpoint}?#{query_string}")
+      end
+
+      def query(params)
+        page = params.delete(:page)
+        per_page = params.delete(:per_page)
+        query = params.map { |key, value| "search[#{key}]=#{value}" }
+        query << "page=#{page}" if page
+        query << "per_page=#{per_page}" if per_page
+        query
+      end
     end
   end
 end

data/lib/myfinance/version.rb

@@ -1,3 +1,3 @@
 module Myfinance
-  VERSION = "1.2.0"
+  VERSION = "1.2.1"
 end

data/spec/lib/myfinance/resources/classification_center_spec.rb

@@ -57,6 +57,16 @@ describe Myfinance::Resources::ClassificationCenter, vcr: true do
           expect(url).to include("page=#{page}")
         end
       end
+
+      context "when per page" do
+        let(:search_params) { { per_page: 400, page: page, entity_id_equals: 3798, name_contains: "Centro" } }
+        subject { client.classification_centers.find_all(search_params) }
+
+        it "returns url" do
+          url = subject.response.request.base_url
+          expect(url).to include("per_page=#{400}")
+        end
+      end
     end
 
     context "when error" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: myfinance
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Eduardo Hertz
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-28 00:00:00.000000000 Z
+date: 2017-04-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: typhoeus
@@ -376,7 +376,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: A Ruby client for the Myfinance REST API