mycowriter 0.1.5 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 48618e785c70abb88fdb18febb2d72e7c63e94b0334d9d94df64b4fd6ec0108e
-  data.tar.gz: d79cbcd5f82772306c0266bab9b71893ed776bca32a05ad6b002354f014a4e2a
+  metadata.gz: 39c5a2d07b1a5b470a372a3164de8055d040d75a2dc0688b89ddc00312b182ac
+  data.tar.gz: 28b25751676dfd32ebd30605a7431a7a6572bbaa31fea296a2414372d8ce15fb
 SHA512:
-  metadata.gz: 24c7af5dbe629060fa01a551d0706ac07c04e6c74f762db1c3bc23d2db7674fdbc2c188a2b22cf7e13e48e2e9be28e854a0a47456221339eec7aeadad29551bb
-  data.tar.gz: bb074ee4851ad39e846aabff2d95a9f2021a80508b7a054193c2d685cbce29c2eb0291f6d853d7bb1cf4f57e0b6f0749871a1f6271b97060e8286488a5217244
+  metadata.gz: a5ba7679b9d27b760637e7becfa3bf91f1820d4fe29fb587b2e32f446bf734481778a5e837b0ed4e48797b2bd709dade21fe45d3f0b950862f0837e71d3b5af7
+  data.tar.gz: e2dfde5dd18f9d103e91a13a12436a09163653d1a600834802cbbb5ef7ac93f48571a5c6ac29b29a30f7904cd69ed9eb0112f7ab2b99bc6b2df598166733f387

data/CHANGELOG.md

@@ -5,6 +5,39 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.1.7] - 2026-02-21
+
+### Fixed
+- **CRITICAL:** Fixed SQL method compatibility - replaced deprecated `sanitize_sql_for_order` with `Arel.sql` + `sanitize_sql_array`
+- Resolves `NoMethodError: undefined method 'sanitize_sql_for_order'` error in Rails 8.0+
+- All ORDER BY clauses now use proper Rails SQL injection protection pattern
+
+### Added
+- Added `genus_name` parameter to species endpoint for inline autocomplete filtering
+- Species autocomplete now filters by preceding genus name (e.g., "Ganoderma sess" → only Ganoderma species)
+- Supports both mushroom form context (`mushroom_id` parameter) and inline text context (`genus_name` parameter)
+
+### Technical Details
+- Changed from `Model.connection.sanitize_sql_for_order([...])` to `Arel.sql(Model.sanitize_sql_array([...]))`
+- Applied fix to genera, species, and mb_lists fallback methods
+- Maintains backward compatibility - existing `mushroom_id` filtering still works
+- New `genus_name` parameter is optional and takes precedence over `mushroom_id` when both present
+
+## [0.1.6] - 2026-02-21
+
+### Fixed
+- **CRITICAL:** Fixed autocomplete result ranking to prioritize best matches over alphabetical order
+- Exact matches now appear first, then prefix matches, then substring matches
+- Example: typing "sess" now shows "sessile" at top of results instead of 12th position after alphabetical entries
+- Applied smart ranking to genera autocomplete, species autocomplete, and mb_lists fallback methods
+- Resolves issue where large genus datasets (e.g., 394 Ganoderma species) buried relevant matches deep in alphabetical lists
+
+### Technical Details
+- Replaced simple alphabetical `ORDER BY name` with CASE-based priority ranking
+- Priority order: 1=exact match, 2=prefix match, 3=substring match, within each group: alphabetical
+- Uses `sanitize_sql_for_order` for SQL injection protection
+- Maintains backward compatibility - same JSON API contract, no breaking changes
+
 ## [0.1.1] - 2025-02-20
 
 ### Changed

data/app/controllers/mycowriter/autocomplete_controller.rb

@@ -11,7 +11,14 @@ module Mycowriter
                     ::Genus
                       .where("name LIKE ?", "#{::Genus.sanitize_sql_like(query)}%")
                       .select(:id, :name)
-                      .order(:name)
+                      .order(
+                        Arel.sql(
+                          ::Genus.sanitize_sql_array([
+                            "CASE WHEN LOWER(name) = LOWER(?) THEN 1 ELSE 2 END, name",
+                            query
+                          ])
+                        )
+                      )
                       .limit(Mycowriter.results_limit)
                       .map { |g| { id: g.id, name: g.name } }
                   else
@@ -24,18 +31,23 @@ module Mycowriter
       render json: results
     end
 
-    # GET /mycowriter/autocomplete/species.json?q=placo&mushroom_id=1
+    # GET /mycowriter/autocomplete/species.json?q=placo&mushroom_id=1&genus_name=Ganoderma
     def species
       query = params[:q].to_s.strip
       mushroom_id = params[:mushroom_id]
+      genus_name = params[:genus_name]
 
       results = if query.length >= Mycowriter.min_characters
                   # Check if the host app has a Species model
                   if defined?(::Species)
                     scope = ::Species.where("name LIKE ?", "%#{::Species.sanitize_sql_like(query)}%")
 
-                    # Filter by selected genera for this mushroom
-                    if mushroom_id.present? && defined?(::Mushroom)
+                    # Filter by genus name (for inline autocomplete)
+                    if genus_name.present? && defined?(::Genus)
+                      genus = ::Genus.find_by(name: genus_name)
+                      scope = scope.where(genera_id: genus.id) if genus
+                    # OR filter by selected genera for this mushroom (for mushroom form)
+                    elsif mushroom_id.present? && defined?(::Mushroom)
                       mushroom = ::Mushroom.find_by(id: mushroom_id)
                       if mushroom && mushroom.respond_to?(:genera) && mushroom.genera.any?
                         genera_ids = mushroom.genera.pluck(:id)
@@ -44,10 +56,23 @@ module Mycowriter
                     end
 
                     # Use includes to eager load genera and avoid N+1 queries
+                    # Smart ranking: exact matches first, then prefix matches, then substring matches
                     species_results = scope
                       .includes(:genus)
                       .select(:id, :name, :genera_id)
-                      .order(:name)
+                      .order(
+                        Arel.sql(
+                          ::Species.sanitize_sql_array([
+                            "CASE
+                               WHEN LOWER(name) = LOWER(?) THEN 1
+                               WHEN LOWER(name) LIKE LOWER(?) THEN 2
+                               ELSE 3
+                             END, name",
+                            query,
+                            "#{query}%"
+                          ])
+                        )
+                      )
                       .limit(Mycowriter.results_limit)
 
                     species_results.map do |sp|
@@ -87,7 +112,19 @@ module Mycowriter
 
       scope
         .select(:id, :taxon_name)
-        .order(:taxon_name)
+        .order(
+          Arel.sql(
+            ::MbList.sanitize_sql_array([
+              "CASE
+                 WHEN LOWER(taxon_name) = LOWER(?) THEN 1
+                 WHEN LOWER(taxon_name) LIKE LOWER(?) THEN 2
+                 ELSE 3
+               END, taxon_name",
+              query,
+              "#{query}%"
+            ])
+          )
+        )
         .limit(Mycowriter.results_limit)
         .map { |m| { id: m.id, name: m.taxon_name } }
     end

data/lib/mycowriter/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Mycowriter
-  VERSION = "0.1.5"
+  VERSION = "0.1.7"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mycowriter
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.7
 platform: ruby
 authors:
 - Will Johnston