my_timeline-github 0.0.2 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 459fd302a5a573cadc74fbea8fcd6b679b29b76c
-  data.tar.gz: b83b3a73a416886141031e6ad3b78bea71c6ddf0
+  metadata.gz: 181521b70e1f562f7fa401a58369f5c2718e7020
+  data.tar.gz: e147aca2b3a1682fe3243532e7dd694919c2a9a2
 SHA512:
-  metadata.gz: df601e08ac424cfc4f45f6a5d36e9d8abcc393edbb368788ea0523705d83d5292f160ba730a30118e365dd0fa6fb576f41bb81359220aa2caed0b0b284754288
-  data.tar.gz: a85e4ccc67be66a9f51107816e5833c3fa20adfc91006f0a6b1134fb8f55cc75ce052af07304a2e994bcd8b2796ed9ac1e9012edb552f3913b62485d6169c3f9
+  metadata.gz: c5affa4a61418c5511d01fcfe5663f9aca81bb4b9f9af354e7bce0dc696eb7b6285c67e63c54f8a68dfa7ce1cdf5bfca5cb6038f2b132d4c82fc5c0acd12516a
+  data.tar.gz: ed19824ba501615e572796614b80ad3814fa4f9c69b94fcdf05dcf63909f24a6b157d978a297fca2daad6421190205d4a80f0afd21dd2e0d83adff90a4c3f3d8

data/CHANGELOG.markdown

@@ -1,3 +1,8 @@
+# 0.1.0
+  * Register settings through plugin registry
+  * Require my_timeline 0.1.0
+  * Slight refactoring
+
 # 0.0.2
   * Added Rails 4 compatibility
   * Require my_timeline 0.0.4

data/app/scrapers/my_timeline/github/fork_event_builder.rb

@@ -5,7 +5,18 @@ module MyTimeline
       def build_event
         return false if already_exists_in_db?
 
-        event = MyTimeline::Event.create(
+        event.linkable = fork_event
+        event.user = user if MyTimeline.user_class
+        event.save
+
+        fork_event.event = event
+        fork_event.save
+      end
+
+    private
+
+      def event
+        @event ||= MyTimeline::Event.create(
           happened_on:   github_event.created_at,
           original_id:   github_event.id,
           external_link: "https://www.github.com/#{user.settings(:github).user_name}/#{github_event.repo.name}",
@@ -14,19 +25,14 @@ module MyTimeline
           public:        1,
           description:   "Forked #{link_user_repo(github_event.repo.name)}"
         )
+      end
 
-        fork_event = MyTimeline::Github::ForkEvent.new(
+      def fork_event
+        @fork_event ||= MyTimeline::Github::ForkEvent.new(
          happened_on: github_event.created_at,
          original_id: github_event.id,
          repo:        github_event.repo.name
         )
-
-        event.linkable = fork_event
-        event.user = user if MyTimeline.user_class
-        event.save
-
-        fork_event.event = event
-        fork_event.save
       end
     end
   end

data/app/scrapers/my_timeline/github/pull_request_event_builder.rb

@@ -5,8 +5,19 @@ module MyTimeline
       def build_event
         return false if already_exists_in_db?
 
-        event = MyTimeline::Event.create(
-          happened_on:   github_event.created_at,
+        event.linkable = pull_request_event
+        event.user     = user if MyTimeline.user_class
+        event.save
+
+        pull_request_event.event = event
+        pull_request_event.save
+      end
+
+    private
+
+      def event
+        @event ||= MyTimeline::Event.create(
+          happened_on:   happened_on,
           original_id:   github_event.id,
           external_link: github_event.payload.pull_request.rels[:html].href,
           icon_name:     "github.png",
@@ -14,9 +25,11 @@ module MyTimeline
           public:        1,
           description:   "#{github_event.payload.action.capitalize} Pull Request #{link_pr} on #{link_user_repo(github_event.repo.name)}: #{github_event.payload.pull_request.title}"
         )
+      end
 
-        pull_request_event = MyTimeline::Github::PullRequestEvent.new(
-          happened_on:   github_event.created_at,
+      def pull_request_event
+        @pull_request_event ||= MyTimeline::Github::PullRequestEvent.new(
+          happened_on:   happened_on,
           title:         github_event.payload.pull_request.title,
           body:          github_event.payload.pull_request.body,
           url:           github_event.payload.pull_request.rels[:html].href,
@@ -26,16 +39,11 @@ module MyTimeline
           changed_files: github_event.payload.pull_request.changed_files,
           repo:          github_event.repo.name
         )
-
-        event.linkable = pull_request_event
-        event.user = user if MyTimeline.user_class
-        event.save
-
-        pull_request_event.event = event
-        pull_request_event.save
       end
 
-    private
+      def happened_on
+        github_event.created_at
+      end
 
       def link_pr
         "<a href=#{github_event.payload.pull_request.rels[:html].href}>##{github_event.payload.number}</a>"

data/lib/my_timeline/github/engine.rb

@@ -14,8 +14,7 @@ module MyTimeline
       end
 
       config.after_initialize do |app|
-        MyTimeline.config_object.key :github, defaults: {user_token: nil}
-        MyTimeline.register_plugin :github
+        MyTimeline.register_plugin :github, defaults: {user_token: nil}
       end
 
       rake_tasks do

data/lib/my_timeline/github/version.rb

@@ -1,5 +1,5 @@
 module MyTimeline
   module Github
-    VERSION = "0.0.2"
+    VERSION = "0.1.0"
   end
 end

data/my_timeline-github.gemspec

@@ -13,6 +13,6 @@ Gem::Specification.new do |s|
   s.license     = 'MIT'
   s.files       = `git ls-files`.split("\n")
 
-  s.add_runtime_dependency "my_timeline", '>= 0.0.4'
+  s.add_runtime_dependency "my_timeline", '>= 0.1.0'
   s.add_runtime_dependency "octokit"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: my_timeline-github
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.1.0
 platform: ruby
 authors:
 - Justin Aiken
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-10 00:00:00.000000000 Z
+date: 2014-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: my_timeline
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: 0.0.4
+        version: 0.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: 0.0.4
+        version: 0.1.0
 - !ruby/object:Gem::Dependency
   name: octokit
   requirement: !ruby/object:Gem::Requirement