my_target_api 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 35b5e8e2f9e33078a2823459568b54d17097d849
-  data.tar.gz: 4569d9039f9193f3bf00a8d6a29e86bca3202238
+  metadata.gz: 45922e11a54d1aa6abf0572f7c1384d4929fe6e7
+  data.tar.gz: c1e7eebe80e5d3a2ab853bf9dd2a590cdf0d3a42
 SHA512:
-  metadata.gz: d9e6bc0d5e187b837fdcbf9d41297bb94eef2bbd63cdc6c0cf3def44049e1923fb16142ad30742ac62e3e5f4198061de9dcae1741eb6bbfe64d413ee16b620aa
-  data.tar.gz: 0ae105819862e9b089fd8dfa04e164262fc565e0a6ad4c4d633e9963798a52b24ca79338760e39f162a17296f1224d50c8ad0bcc318118fab2355f7e48cdcb83
+  metadata.gz: 6825b4699c3a1dbf6d904cdd614fac88aa7ea475bda184d325c3a086bf9bd4e92395a4c20b47472dc0df676a9de7e337d09eca15dc8ccec25558ed6bb94fd79e
+  data.tar.gz: 7c59ffd02cb4cc2317a714bbb6e9b445f2d7e66ae6077482e4cc41b3c17fe2f930338ebc46b69ddcd64ba5b7c5fa1d7a06ec3009a1658e78e14b94531e3780ba

data/README.md

@@ -7,7 +7,7 @@
 Add this line to your application's Gemfile:
 
 ```
-gem 'my_target_api', '~> 1.1.0'
+gem 'my_target_api', '~> 1.1.1'
 ```
 
 Or install from command line:

data/lib/my_target_api/request.rb

@@ -8,10 +8,12 @@ class MyTargetApi
   class Request
 
     def initialize(options = {})
-      @logger = options[:logger]
+      @options = options
     end
 
     def get(url, params = {})
+      log_hash(method: 'Request#get', url: url, params: params)
+
       response = with_exception_handling do
         RestClient.get(url, headers(params).merge(query(params)))
       end
@@ -20,6 +22,8 @@ class MyTargetApi
     end
 
     def post(url, params = {})
+      log_hash(method: 'Request#post', url: url, params: params)
+
       response = with_exception_handling do
         RestClient.post(url, body_parameters(params), headers(params))
       end
@@ -28,6 +32,8 @@ class MyTargetApi
     end
 
     def delete(url, params = {})
+      log_hash(method: 'Request#delete', url: url, params: params)
+
       response = with_exception_handling do
         RestClient.delete(url, headers(params).merge(query(params)))
       end
@@ -36,6 +42,8 @@ class MyTargetApi
     end
 
     def upload(url, content, params = {})
+      log_hash(method: 'Request#upload', url: url, params: params, content: 'no logging')
+
       response = with_exception_handling do
         RestClient.post(url, content, headers(params).merge(query(params)))
       end
@@ -45,7 +53,7 @@ class MyTargetApi
 
     private
 
-    attr_reader :logger
+    attr_reader :options
 
     def body_parameters(params)
       result_params = params.dup
@@ -112,5 +120,17 @@ class MyTargetApi
       logger << log_message if logger
     end
 
+    def log_hash(hash)
+      return unless logger
+
+      logger << hash.map do |key, value|
+        "#{key}: #{value.is_a?(String) ? value : value.inspect}"
+      end.join("\n")
+    end
+
+    def logger
+      options[:logger]
+    end
+
   end
 end

data/lib/my_target_api/version.rb

@@ -2,6 +2,6 @@
 
 class MyTargetApi
 
-  VERSION = '1.1.0'
+  VERSION = '1.1.1'
 
 end

data/spec/request_spec.rb

@@ -11,6 +11,7 @@ describe MyTargetApi::Request do
     it { expect(request).to respond_to(:get) }
     it { expect(request).to respond_to(:post) }
     it { expect(request).to respond_to(:delete) }
+    it { expect(request).to respond_to(:upload) }
   end
 
   describe 'request something' do
@@ -60,4 +61,17 @@ describe MyTargetApi::Request do
         .to raise_error(MyTargetApi::RequestError, 'Unknown resource')
     end
   end
+
+  describe 'logs' do
+    let(:logger) { double('Logger double', '<<': nil) }
+    let(:request) { MyTargetApi::Request.new(logger: logger) }
+
+    it 'pass parameters by url in get' do
+      stub_request(:get, 'https://target.my.com/api/v1/request.json')
+        .to_return(body: '[]')
+
+      expect(logger).to(receive(:<<))
+      request.get('https://target.my.com/api/v1/request.json')
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: my_target_api
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - OneRetarget.com
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-08 00:00:00.000000000 Z
+date: 2018-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json