my_john_deere_api 2.3.0 → 2.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e4770ad629b97ce42d4a5482559e26506b78b67fcec897e6e08e849d9c38e6f7
-  data.tar.gz: af1b02dce372ce905933242226756e298553b75b6265ebb6f44d71916b20a5cd
+  metadata.gz: 8b7e56857d5db19f8704d06453efd6c258a59301fbfd046fa9fc6f97f7ae0ae6
+  data.tar.gz: a6c869c73bc36401c52334c207964b34b4753cedef3dcd227c6f7f3afa81a53b
 SHA512:
-  metadata.gz: 44005e84b7c7e80ba54498e9c77f6d00e9fea447fcdc67106b55fd49e1452fc88a43d37a599506c22819e7ad4f1a166562b22a7954a966ffaba1e23d697530be
-  data.tar.gz: 964b2f971c765d5c115e7cf4f73372de6c69c77d15b7134c2b4d6137394ad78090c279305b300157228ee35916bf767f9c15f28d239d95a8c5242ae9d6cc8261
+  metadata.gz: e8efc6cc4fc3e1609baff17d01c41c58d022dc1a5c144b012f2f4a813e059bdee5b4c6b648ceab217586176179e5e51a7e568ff52e250a7e1ed089f247131c4a
+  data.tar.gz: 82ad3bebb98fbd194cf6f5e2772203548c52be2f203e1cd6564562cc2d8c24045f45be8f9616243113f84537561f28b08798c556a17b8b32608e4e01b5fd913f

data/lib/my_john_deere_api/helpers/validate_contribution_definition.rb

@@ -0,0 +1,18 @@
+require 'uri'
+
+module MyJohnDeereApi
+  module Helpers::ValidateContributionDefinition
+    private
+
+    ##
+    # Raise an error if contribution_definition_id is missing
+
+    def validate_contribution_definition
+      if client.contribution_definition_id.nil?
+        raise MissingContributionDefinitionIdError
+      end
+
+      true
+    end
+  end
+end

data/lib/my_john_deere_api/helpers.rb

@@ -2,4 +2,5 @@ module MyJohnDeereApi::Helpers
   autoload :UriHelpers,        'my_john_deere_api/helpers/uri_helpers'
   autoload :CaseConversion, 'my_john_deere_api/helpers/case_conversion'
   autoload :EnvironmentHelper, 'my_john_deere_api/helpers/environment_helper'
+  autoload :ValidateContributionDefinition, 'my_john_deere_api/helpers/validate_contribution_definition'
 end

data/lib/my_john_deere_api/request/create/asset.rb

@@ -3,6 +3,7 @@ require 'json'
 module MyJohnDeereApi
   class Request::Create::Asset < Request::Create::Base
     include Validators::Asset
+    include Helpers::ValidateContributionDefinition
 
     private
 

data/lib/my_john_deere_api/request/create/base.rb

@@ -54,17 +54,6 @@ module MyJohnDeereApi
     def process_attributes
     end
 
-    ##
-    # Raise an error if contribution_definition_id is missing
-
-    def validate_contribution_definition
-      unless client.contribution_definition_id
-        raise MissingContributionDefinitionIdError
-      end
-
-      true
-    end
-
     ##
     # Headers for POST request
 

data/lib/my_john_deere_api/request/update/asset.rb

@@ -3,6 +3,7 @@ require 'json'
 module MyJohnDeereApi
   class Request::Update::Asset < Request::Update::Base
     include Validators::Asset
+    include Helpers::ValidateContributionDefinition
 
     private
 

data/lib/my_john_deere_api/request/update/base.rb

@@ -54,17 +54,6 @@ module MyJohnDeereApi
     def process_attributes
     end
 
-    ##
-    # Raise an error if contribution_definition_id is missing
-
-    def validate_contribution_definition
-      unless client.contribution_definition_id
-        raise MissingContributionDefinitionIdError
-      end
-
-      true
-    end
-
     ##
     # Headers for PUT request
 

data/lib/my_john_deere_api/version.rb

@@ -1,3 +1,3 @@
 module MyJohnDeereApi
-  VERSION='2.3.0'
+  VERSION='2.3.1'
 end

data/test/lib/my_john_deere_api/helpers/validate_contribution_definition_test.rb

@@ -0,0 +1,74 @@
+require 'support/helper'
+
+class ValidateContributionDefinitionHelperSample
+  include JD::Helpers::ValidateContributionDefinition
+
+  attr_reader :client
+
+  def initialize(client)
+    @client = client
+  end
+end
+
+describe 'Helpers::ValidateContributionDefinition' do
+  let(:object) { ValidateContributionDefinitionHelperSample.new(client) }
+
+  describe '#validate_contribution_definition' do
+    it 'returns true when contribution_definition_id is present' do
+      assert object.send(:validate_contribution_definition)
+    end
+
+    it 'raises an error when contribution_definition_id is missing' do
+      client.contribution_definition_id = nil
+
+      assert_raises(JD::MissingContributionDefinitionIdError) do
+        object.send(:validate_contribution_definition)
+      end
+    end
+  end
+
+  # describe '#uri_path' do
+  #   it 'extracts the path from the uri' do
+  #     path = object.send(:uri_path, 'https://example.com/turtles')
+  #     assert_equal '/turtles', path
+  #   end
+  #
+  #   it 'removes leading /platform from the path' do
+  #     path = object.send(:uri_path, 'https://example.com/platform/turtles')
+  #     assert_equal '/turtles', path
+  #   end
+  #
+  #   it 'preserves /platform in any other part of the path' do
+  #     path = object.send(:uri_path, 'https://example.com/platform/turtles/platform')
+  #     assert_equal '/turtles/platform', path
+  #   end
+  #
+  #   it 'is a private method' do
+  #     exception = assert_raises(NoMethodError) { object.uri_path('https://example.com/turtles')}
+  #     assert_includes exception.message, 'private method'
+  #   end
+  # end
+  #
+  # describe '#id_from_uri(uri, label)' do
+  #   it 'extracts the id immediately following a given label' do
+  #     uri = 'https://example.com/cows/123/pigs/456/turtles/789/birds/012'
+  #     assert_equal '789', object.send(:id_from_uri, uri, 'turtles')
+  #   end
+  #
+  #   it 'accepts a symbol for the label' do
+  #     uri = 'https://example.com/cows/123/pigs/456/turtles/789/birds/012'
+  #     assert_equal '789', object.send(:id_from_uri, uri, :turtles)
+  #   end
+  #
+  #   it 'is a private method' do
+  #     uri = 'https://example.com/cows/123/pigs/456/turtles/789/birds/012'
+  #
+  #     exception = assert_raises(NoMethodError) { object.id_from_uri(uri, 'turtles') }
+  #     assert_includes exception.message, 'private method'
+  #   end
+  # end
+  #
+  # it "preserves the public nature of the including class's other methods" do
+  #   assert_equal 'test', object.test
+  # end
+end

data/test/lib/my_john_deere_api/helpers_test.rb

@@ -13,5 +13,9 @@ describe 'MyJohnDeereApi::Helpers' do
     it 'loads Helpers::EnvironmentHelper' do
       assert JD::Helpers::EnvironmentHelper
     end
+
+    it 'loads Helpers::ValidateContributionDefinition' do
+      assert JD::Helpers::ValidateContributionDefinition
+    end
   end
 end

data/test/lib/my_john_deere_api/request/create/base_test.rb

@@ -26,20 +26,4 @@ describe 'MyJohnDeereApi::Request::Create::Base' do
       assert_equal expected, headers['Content-Type']
     end
   end
-
-  describe '#validate_contribution_definition' do
-    it 'does nothing when contribution_definition_id is present' do
-      object = klass.new(client, attributes)
-      assert object.send(:validate_contribution_definition)
-    end
-
-    it 'raises an error when contribution_definition_id is missing' do
-      client.contribution_definition_id = nil
-      object = klass.new(client, attributes)
-
-      assert_raises(JD::MissingContributionDefinitionIdError) do
-        object.send(:validate_contribution_definition)
-      end
-    end
-  end
 end

data/test/lib/my_john_deere_api/request/update/base_test.rb

@@ -57,20 +57,4 @@ describe 'MyJohnDeereApi::Request::Update::Base' do
       assert_equal expected, headers['Content-Type']
     end
   end
-
-  describe '#validate_contribution_definition' do
-    it 'does nothing when contribution_definition_id is present' do
-      object = klass.new(client, item, attributes)
-      assert object.send(:validate_contribution_definition)
-    end
-
-    it 'raises an error when contribution_definition_id is missing' do
-      client.contribution_definition_id = nil
-      object = klass.new(client, item, attributes)
-
-      assert_raises(JD::MissingContributionDefinitionIdError) do
-        object.send(:validate_contribution_definition)
-      end
-    end
-  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: my_john_deere_api
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.3.1
 platform: ruby
 authors:
 - Jaime Bellmyer
@@ -116,6 +116,7 @@ files:
 - lib/my_john_deere_api/helpers/case_conversion.rb
 - lib/my_john_deere_api/helpers/environment_helper.rb
 - lib/my_john_deere_api/helpers/uri_helpers.rb
+- lib/my_john_deere_api/helpers/validate_contribution_definition.rb
 - lib/my_john_deere_api/model.rb
 - lib/my_john_deere_api/model/asset.rb
 - lib/my_john_deere_api/model/asset_location.rb
@@ -166,6 +167,7 @@ files:
 - test/lib/my_john_deere_api/helpers/case_conversion_test.rb
 - test/lib/my_john_deere_api/helpers/environment_helper_test.rb
 - test/lib/my_john_deere_api/helpers/uri_helpers_test.rb
+- test/lib/my_john_deere_api/helpers/validate_contribution_definition_test.rb
 - test/lib/my_john_deere_api/helpers_test.rb
 - test/lib/my_john_deere_api/model/asset_location_test.rb
 - test/lib/my_john_deere_api/model/asset_test.rb