mutant 0.8.2 → 0.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f16485d23238c84b07b2e62df8a1c4af57badb14
-  data.tar.gz: e0b9ddb90dccee908622683295235e177d4d7dcf
+  metadata.gz: d31268248349a065fe46a960fe2a0d0ace09f0d8
+  data.tar.gz: c35d18b21c3761d28fece74e573ef7f6ab0dfd69
 SHA512:
-  metadata.gz: 992b3447fda4a045e9462f292f17da506141b386e9c494d94c13a6807450f9b73826f230e468a883f1177df70db409de9b400d107183d053444061c96ba7193f
-  data.tar.gz: 3c8319ee768ca67e2a0cd9fbf65c5a3652425f73ecc8206bdca143da85f6a16fbf875505f5f14f9038319b5e35615e6a4e8ec0bf5ad2620cca4ed1d8c6e57f0c
+  metadata.gz: 3aec0dac703c7e91f164c60baa26d941e9a2d2149bd4542fcaac33f8e4794d9431ce4e226a5af29b88ec13e77f1ab2e32b6c4431a2a514ea4f2e1cb4200ea3bd
+  data.tar.gz: 9fb92420b95b0ae6fd1df55941e3df971b89d80ff7bef55a06c9823d1c96d6b4d50aedb88814a1c308ca57f99aa30e8d12ddc6275a6036073c21ca16d6d74aa9

data/Changelog.md

@@ -1,14 +1,17 @@
+# v0.8.3 2015-09-01
+
+* Remove invalid mutation `super(...)` to `super`
+* Add mutation from `def foo(a = true); end` to `def foo(a = true); a = true; end` #419
+* Add mutation from `def foo; end` to `remove_method :foo` #413
+
 # v0.8.2 2015-08-11
 
 * Remove invalid mutation `foo or bar` to `!(foo or bar)` see #287
 * Add mutation from `#to_h` to `#to_hash` #218
-<<<<<<< 2914e9c8d906540edc1cc7d4bc6393f68db39b8d
-* Add mutation from `#defined?` to `true` / `false` #334
 * Add mutation from `super` to `super()` #309
-=======
 * Add mutation from `#defined?` to `true` / `false` #399
 * Reduce framed (multiline) progress reporter noise
->>>>>>> Reduce framed progress reporter noise
+* Fix a bug where killfork pipes where not properly closed
 
 # v0.8.1 2015-07-24
 

data/Gemfile

@@ -4,4 +4,5 @@ source 'https://rubygems.org'
 
 gemspec name: 'mutant'
 
+gem 'morpher',  git: 'https://github.com/mbj/morpher.git'
 gem 'devtools', git: 'https://github.com/rom-rb/devtools.git'

data/README.md

@@ -191,6 +191,25 @@ Mutation output is grouped by selection groups. Each group contains three sectio
    -----------------------
    ```
 
+Planning a presentation?
+------------------------
+
+Mutation testing lately (not only mutant) seems to attract some attention. So naturally
+people do talks about it at conferences, user groups or other chances. Thx for that!
+
+As I (the author @mbj) am not too happy with some of the facts being presented about
+mutant the last month.
+
+So if you plan to do a presentation: I offer to review your slides / talk - for free off course.
+My intention is NOT to change your bias pro / against this tool. Just to help to fix
+invalid statements about the tool.
+
+Also in many cases a conversation to the author, should help you to imporve the talk
+significantly. One of mutants biggest weaknesses is the bad documentation, but instead of
+assumptions based on the absence of docs, use the tool authors brain to fill the gaps.
+
+Hint, same applies to papers.
+
 Rails
 -------
 

data/config/flay.yml

@@ -1,3 +1,3 @@
 ---
 threshold: 18
-total_score: 1193
+total_score: 1200

data/lib/mutant.rb

@@ -48,6 +48,9 @@ require 'mutant/ast/nodes'
 require 'mutant/ast/named_children'
 require 'mutant/ast/node_predicates'
 require 'mutant/ast/meta'
+require 'mutant/ast/meta/send'
+require 'mutant/ast/meta/optarg'
+require 'mutant/ast/meta/resbody'
 require 'mutant/actor'
 require 'mutant/actor/receiver'
 require 'mutant/actor/sender'

data/lib/mutant/ast/meta.rb

@@ -2,68 +2,6 @@ module Mutant
   module AST
     # Node meta information mixin
     module Meta
-
-      # Metadata for resbody nods
-      class Resbody
-        include NamedChildren, Concord.new(:node)
-
-        children :captures, :assignment, :body
-      end # Resbody
-
-      # Metadata for send nodes
-      class Send
-        include NamedChildren, Concord.new(:node)
-
-        children :receiver, :selector
-
-        INDEX_ASSIGNMENT_SELECTOR            = :[]=
-        ATTRIBUTE_ASSIGNMENT_SELECTOR_SUFFIX = '='.freeze
-
-        # Arguments of mutated node
-        #
-        # @return [Enumerable<Parser::AST::Node>]
-        #
-        # @api private
-        alias_method :arguments, :remaining_children
-
-        # Test if AST node is a valid assignment target
-        #
-        # @return [Boolean]
-        #
-        # @api private
-        def assignment?
-          index_assignment? || attribute_assignment?
-        end
-
-        # Test if AST node is an attribute assignment?
-        #
-        # @return [Boolean]
-        #
-        # @api private
-        def attribute_assignment?
-          !Types::METHOD_OPERATORS.include?(selector) &&
-          selector.to_s.end_with?(ATTRIBUTE_ASSIGNMENT_SELECTOR_SUFFIX)
-        end
-
-        # Test if AST node is an index assign
-        #
-        # @return [Boolean]
-        #
-        # @api private
-        def index_assignment?
-          selector.equal?(INDEX_ASSIGNMENT_SELECTOR)
-        end
-
-        # Test for binary operator implemented as method
-        #
-        # @return [Boolean]
-        #
-        # @api private
-        def binary_method_operator?
-          Types::BINARY_METHOD_OPERATORS.include?(selector)
-        end
-
-      end # Send
     end # Meta
   end # AST
 end # Mutant

data/lib/mutant/ast/meta/optarg.rb

@@ -0,0 +1,26 @@
+module Mutant
+  module AST
+    # Node meta information mixin
+    module Meta
+
+      # Metadata for optional argument nodes
+      class Optarg
+        include NamedChildren, Concord.new(:node)
+
+        UNDERSCORE = '_'.freeze
+
+        children :name, :default_value
+
+        # Test if optarg definition intends to be used
+        #
+        # @return [Boolean]
+        #
+        # @api private
+        def used?
+          !name.to_s.start_with?(UNDERSCORE)
+        end
+      end # Optarg
+
+    end # Meta
+  end # AST
+end # Mutant

data/lib/mutant/ast/meta/resbody.rb

@@ -0,0 +1,15 @@
+module Mutant
+  module AST
+    # Node meta information mixin
+    module Meta
+
+      # Metadata for resbody nodes
+      class Resbody
+        include NamedChildren, Concord.new(:node)
+
+        children :captures, :assignment, :body
+      end # Resbody
+
+    end # Meta
+  end # AST
+end # Mutant

data/lib/mutant/ast/meta/send.rb

@@ -0,0 +1,62 @@
+module Mutant
+  module AST
+    # Node meta information mixin
+    module Meta
+
+      # Metadata for send nodes
+      class Send
+        include NamedChildren, Concord.new(:node)
+
+        children :receiver, :selector
+
+        INDEX_ASSIGNMENT_SELECTOR            = :[]=
+        ATTRIBUTE_ASSIGNMENT_SELECTOR_SUFFIX = '='.freeze
+
+        # Arguments of mutated node
+        #
+        # @return [Enumerable<Parser::AST::Node>]
+        #
+        # @api private
+        alias_method :arguments, :remaining_children
+
+        # Test if AST node is a valid assignment target
+        #
+        # @return [Boolean]
+        #
+        # @api private
+        def assignment?
+          index_assignment? || attribute_assignment?
+        end
+
+        # Test if AST node is an attribute assignment?
+        #
+        # @return [Boolean]
+        #
+        # @api private
+        def attribute_assignment?
+          !Types::METHOD_OPERATORS.include?(selector) &&
+          selector.to_s.end_with?(ATTRIBUTE_ASSIGNMENT_SELECTOR_SUFFIX)
+        end
+
+        # Test if AST node is an index assign
+        #
+        # @return [Boolean]
+        #
+        # @api private
+        def index_assignment?
+          selector.equal?(INDEX_ASSIGNMENT_SELECTOR)
+        end
+
+        # Test for binary operator implemented as method
+        #
+        # @return [Boolean]
+        #
+        # @api private
+        def binary_method_operator?
+          Types::BINARY_METHOD_OPERATORS.include?(selector)
+        end
+
+      end # Send
+    end # Meta
+  end # AST
+end # Mutant

data/lib/mutant/mutator/node/argument.rb

@@ -28,9 +28,7 @@ module Mutant
         # @api private
         def emit_name_mutation
           return if skip?
-          Mutator::Util::Symbol.each(name, self) do |name|
-            emit_name(name)
-          end
+          emit_name(:"#{UNDERSCORE}#{name}")
         end
 
         # Test if argument mutation is skipped

data/lib/mutant/mutator/node/define.rb

@@ -13,11 +13,40 @@ module Mutant
         # @api private
         def dispatch
           emit_arguments_mutations
+          emit_optarg_body_assignments
           emit_body(N_RAISE)
           emit_body(nil)
           emit_body_mutations if body
         end
 
+        # Emit mutations with optional arguments as assignments in method
+        #
+        # @return [undefined]
+        #
+        # @api private
+        def emit_optarg_body_assignments
+          arguments.children.each do |argument|
+            next unless n_optarg?(argument) && AST::Meta::Optarg.new(argument).used?
+
+            emit_body_prepend(s(:lvasgn, *argument))
+          end
+        end
+
+        # Emit valid body ASTs depending on instance body
+        #
+        # @param node [Parser::AST::Node]
+        #
+        # @return [undefined]
+        #
+        # @api private
+        def emit_body_prepend(node)
+          if body
+            emit_body(s(:begin, node, body))
+          else
+            emit_body(node)
+          end
+        end
+
         # Mutator for instance method defines
         class Instance < self
 
@@ -25,6 +54,19 @@ module Mutant
 
           children :name, :arguments, :body
 
+          def dispatch
+            super()
+            emit_remove_method
+          end
+
+          # Remove an instance method
+          #
+          # @return [undefined]
+          #
+          # @api private
+          def emit_remove_method
+            emit(s(:send, nil, :remove_method, s(:sym, name)))
+          end
         end # Instance
 
         # Mutator for singleton method defines

data/lib/mutant/mutator/node/named_value/constant_assignment.rb

@@ -19,7 +19,17 @@ module Mutant
           # @api private
           def dispatch
             mutate_name
-            emit_value_mutations if value
+            emit_value_mutations
+            emit_remove_const
+          end
+
+          # Emit remove_const
+          #
+          # @return [undefined]
+          #
+          # @api private
+          def emit_remove_const
+            emit(s(:send, cbase, :remove_const, s(:sym, name)))
           end
 
           # Emit name mutations

data/lib/mutant/mutator/node/super.rb

@@ -16,7 +16,6 @@ module Mutant
         # @api private
         def dispatch
           emit_singletons
-          emit(N_ZSUPER)
           emit(N_EMPTY_SUPER)
           children.each_index do |index|
             mutate_child(index)

data/lib/mutant/subject/method/instance.rb

@@ -27,7 +27,7 @@ module Mutant
           self
         end
 
-        # Mutator for memoized instance methods
+        # Mutator for memoizable memoized instance methods
         class Memoized < self
           include AST::Sexp
 

data/lib/mutant/version.rb

@@ -1,4 +1,4 @@
 module Mutant
   # Current mutant version
-  VERSION = '0.8.2'.freeze
+  VERSION = '0.8.3'.freeze
 end # Mutant

data/meta/block.rb

@@ -20,8 +20,8 @@ Mutant::Meta::Example.add do
   singleton_mutations
   mutation 'foo'
   mutation 'foo { |a, b| raise }'
-  mutation 'foo { |a, b__mutant__| }'
-  mutation 'foo { |a__mutant__, b| }'
+  mutation 'foo { |a, _b| }'
+  mutation 'foo { |_a, b| }'
   mutation 'foo { |a| }'
   mutation 'foo { |b| }'
   mutation 'foo { || }'
@@ -38,9 +38,9 @@ Mutant::Meta::Example.add do
   mutation 'foo { |(b), c| }'
   mutation 'foo { |(a, b)| }'
   mutation 'foo { |c| }'
-  mutation 'foo { |(a__mutant__, b), c| }'
-  mutation 'foo { |(a, b__mutant__), c| }'
-  mutation 'foo { |(a, b), c__mutant__| }'
+  mutation 'foo { |(_a, b), c| }'
+  mutation 'foo { |(a, _b), c| }'
+  mutation 'foo { |(a, b), _c| }'
   mutation 'foo'
 end
 
@@ -66,6 +66,6 @@ Mutant::Meta::Example.add do
   mutation 'foo { || }'
   mutation 'foo { |a| }'
   mutation 'foo { |(a)| raise }'
-  mutation 'foo { |(a__mutant__)| }'
+  mutation 'foo { |(_a)| }'
   mutation 'foo'
 end

data/meta/casgn.rb

@@ -4,4 +4,14 @@ Mutant::Meta::Example.add do
   mutation 'A__MUTANT__ = true'
   mutation 'A = false'
   mutation 'A = nil'
+  mutation 'remove_const :A'
+end
+
+Mutant::Meta::Example.add do
+  source 'self::A = true'
+
+  mutation 'self::A__MUTANT__ = true'
+  mutation 'self::A = false'
+  mutation 'self::A = nil'
+  mutation 'self.remove_const :A'
 end

data/meta/def.rb

@@ -2,6 +2,7 @@ Mutant::Meta::Example.add do
   source 'def foo; end'
 
   mutation 'def foo; raise; end'
+  mutation 'remove_method :foo'
 end
 
 Mutant::Meta::Example.add do
@@ -11,6 +12,7 @@ Mutant::Meta::Example.add do
   mutation 'def foo; nil; rescue; end'
   mutation 'def foo; self; rescue; end'
   mutation 'def foo; end'
+  mutation 'remove_method :foo'
 
   # Promote rescue resbody bodies
   mutation 'def foo; foo; end'
@@ -41,6 +43,8 @@ Mutant::Meta::Example.add do
 
   # Failing body
   mutation 'def a; raise; end'
+
+  mutation 'remove_method :a'
 end
 
 Mutant::Meta::Example.add do
@@ -60,6 +64,8 @@ Mutant::Meta::Example.add do
   mutation 'def foo; end'
 
   mutation 'def foo; raise; end'
+
+  mutation 'remove_method :foo'
 end
 
 Mutant::Meta::Example.add do
@@ -73,11 +79,30 @@ Mutant::Meta::Example.add do
   mutation 'def foo; end'
 
   # Rename each argument
-  mutation 'def foo(a__mutant__, b); end'
-  mutation 'def foo(a, b__mutant__); end'
+  mutation 'def foo(_a, b); end'
+  mutation 'def foo(a, _b); end'
 
   # Mutation of body
   mutation 'def foo(a, b); raise; end'
+
+  mutation 'remove_method :foo'
+end
+
+Mutant::Meta::Example.add do
+  source 'def foo(a, b = nil); true; end'
+
+  mutation 'def foo(_a, b = nil); true; end'
+  mutation 'def foo(a, b = nil); end'
+  mutation 'def foo; true; end'
+  mutation 'def foo(a, b = nil); raise; end'
+  mutation 'def foo(a, b = nil); nil; end'
+  mutation 'def foo(a, b = nil); false; end'
+  mutation 'def foo(a); true; end'
+  mutation 'def foo(a, b = nil); b = nil; true; end'
+  mutation 'def foo(b = nil); true; end'
+  mutation 'def foo(a, _b = nil); true; end'
+  mutation 'def foo(a, b); true; end'
+  mutation 'remove_method :foo'
 end
 
 Mutant::Meta::Example.add do
@@ -85,6 +110,7 @@ Mutant::Meta::Example.add do
 
   mutation 'def foo(_unused); raise; end'
   mutation 'def foo; end'
+  mutation 'remove_method :foo'
 end
 
 Mutant::Meta::Example.add do
@@ -95,12 +121,13 @@ Mutant::Meta::Example.add do
   mutation 'def foo(_unused = true); raise; end'
   mutation 'def foo(_unused); end'
   mutation 'def foo; end'
+  mutation 'remove_method :foo'
 end
 
 Mutant::Meta::Example.add do
   source 'def foo(a = 0, b = 0); end'
-  mutation 'def foo(a = 0, b__mutant__ = 0); end'
-  mutation 'def foo(a__mutant__ = 0, b = 0); end'
+  mutation 'def foo(a = 0, _b = 0); end'
+  mutation 'def foo(_a = 0, b = 0); end'
   mutation 'def foo(a = 0, b = 1); end'
   mutation 'def foo(a = 0, b = -1); end'
   mutation 'def foo(a = 0, b = self); end'
@@ -113,7 +140,10 @@ Mutant::Meta::Example.add do
   mutation 'def foo(b = 0); end'
   mutation 'def foo(a, b = 0); end'
   mutation 'def foo; end'
+  mutation 'def foo(a = 0, b = 0); a = 0; end'
+  mutation 'def foo(a = 0, b = 0); b = 0; end'
   mutation 'def foo(a = 0, b = 0); raise; end'
+  mutation 'remove_method :foo'
 end
 
 Mutant::Meta::Example.add do
@@ -123,8 +153,10 @@ Mutant::Meta::Example.add do
   mutation 'def foo(); end'
   mutation 'def foo(a = false); end'
   mutation 'def foo(a = nil); end'
-  mutation 'def foo(a__mutant__ = true); end'
+  mutation 'def foo(_a = true); end'
   mutation 'def foo(a = true); raise; end'
+  mutation 'def foo(a = true); a = true; end'
+  mutation 'remove_method :foo'
 end
 
 Mutant::Meta::Example.add do
@@ -158,8 +190,8 @@ Mutant::Meta::Example.add do
   mutation 'def self.foo; end'
 
   # Rename each argument
-  mutation 'def self.foo(a__mutant__, b); end'
-  mutation 'def self.foo(a, b__mutant__); end'
+  mutation 'def self.foo(_a, b); end'
+  mutation 'def self.foo(a, _b); end'
 
   # Mutation of body
   mutation 'def self.foo(a, b); raise; end'

data/meta/super.rb

@@ -9,15 +9,12 @@ Mutant::Meta::Example.add do
   source 'super()'
 
   singleton_mutations
-  # this is zsuper a totally different node than super()
-  mutation 'super'
 end
 
 Mutant::Meta::Example.add do
   source 'super(foo, bar)'
 
   singleton_mutations
-  mutation 'super'
   mutation 'super()'
   mutation 'super(foo)'
   mutation 'super(bar)'

data/mutant.gemspec

@@ -24,10 +24,10 @@ Gem::Specification.new do |gem|
   gem.required_ruby_version = '>= 2.1'
 
   gem.add_runtime_dependency('parser',        '~> 2.2.2')
-  gem.add_runtime_dependency('ast',           '~> 2.0')
+  gem.add_runtime_dependency('ast',           '~> 2.1')
   gem.add_runtime_dependency('diff-lcs',      '~> 1.2')
   gem.add_runtime_dependency('parallel',      '~> 1.3')
-  gem.add_runtime_dependency('morpher',       '~> 0.2.3')
+  gem.add_runtime_dependency('morpher',       '~> 0.2.4')
   gem.add_runtime_dependency('procto',        '~> 0.0.2')
   gem.add_runtime_dependency('abstract_type', '~> 0.0.7')
   gem.add_runtime_dependency('unparser',      '~> 0.2.4')

data/spec/unit/mutant/ast/meta/optarg_spec.rb

@@ -0,0 +1,22 @@
+RSpec.describe Mutant::AST::Meta::Optarg do
+  subject(:object) { described_class.new(node) }
+
+  let(:node)  { s(:optarg, name, value) }
+  let(:name)  { :foo                    }
+  let(:value) { s(:sym, :bar)           }
+
+  its(:name) { should be(:foo) }
+  its(:default_value) { should eql(s(:sym, :bar)) }
+
+  describe '#used?' do
+    subject { object.used? }
+
+    it { should be true }
+
+    context 'when name is prefixed with an underscore' do
+      let(:name) { :_foo }
+      it { should be false }
+    end
+  end
+
+end

data/spec/unit/mutant/subject/method/instance_spec.rb

@@ -144,6 +144,11 @@ RSpec.describe Mutant::Subject::Method::Instance::Memoized do
           object,
           s(:begin,
             s(:def, :foo, s(:args), nil), s(:send, nil, :memoize, s(:args, s(:sym, :foo))))
+        ),
+        Mutant::Mutation::Evil.new(
+          object,
+          s(:begin,
+            s(:send, nil, :remove_method, s(:sym, :foo)), s(:send, nil, :memoize, s(:args, s(:sym, :foo))))
         )
       ]
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mutant
 version: !ruby/object:Gem::Version
-  version: 0.8.2
+  version: 0.8.3
 platform: ruby
 authors:
 - Markus Schirp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-11 00:00:00.000000000 Z
+date: 2015-09-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '2.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: diff-lcs
   requirement: !ruby/object:Gem::Requirement
@@ -72,14 +72,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.3
+        version: 0.2.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.3
+        version: 0.2.4
 - !ruby/object:Gem::Dependency
   name: procto
   requirement: !ruby/object:Gem::Requirement
@@ -279,6 +279,9 @@ files:
 - lib/mutant/actor/sender.rb
 - lib/mutant/ast.rb
 - lib/mutant/ast/meta.rb
+- lib/mutant/ast/meta/optarg.rb
+- lib/mutant/ast/meta/resbody.rb
+- lib/mutant/ast/meta/send.rb
 - lib/mutant/ast/named_children.rb
 - lib/mutant/ast/node_predicates.rb
 - lib/mutant/ast/nodes.rb
@@ -494,6 +497,7 @@ files:
 - spec/unit/mutant/actor/message_spec.rb
 - spec/unit/mutant/actor/receiver_spec.rb
 - spec/unit/mutant/actor/sender_spec.rb
+- spec/unit/mutant/ast/meta/optarg_spec.rb
 - spec/unit/mutant/ast/meta/send_spec.rb
 - spec/unit/mutant/ast/named_children_spec.rb
 - spec/unit/mutant/ast/sexp_spec.rb
@@ -595,7 +599,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Mutation testing tool for ruby under MRI and Rubinius
@@ -610,6 +614,7 @@ test_files:
 - spec/unit/mutant/actor/message_spec.rb
 - spec/unit/mutant/actor/receiver_spec.rb
 - spec/unit/mutant/actor/sender_spec.rb
+- spec/unit/mutant/ast/meta/optarg_spec.rb
 - spec/unit/mutant/ast/meta/send_spec.rb
 - spec/unit/mutant/ast/named_children_spec.rb
 - spec/unit/mutant/ast/sexp_spec.rb