mutant 0.5.20 → 0.5.21

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2423eb3dea806c37511ba8f9e23e20215330d9a5
-  data.tar.gz: b5c6e0e92cc025a1d70f61727567d3ccd64578c7
+  metadata.gz: bb04983424f2bdda11781922b9b9a90d8463fed9
+  data.tar.gz: f5cef219a943e5fbd397eda833de9417bcd22c98
 SHA512:
-  metadata.gz: 0afc928d562d4f8adc32e1b1f7ba6c20544ee1c5e304c60772ab1fe5e7d648549a8e8b3c325ee7d828cc285f7083eb649d0344b90fb81c0b42f60cb78152034b
-  data.tar.gz: a7d05e7b132dc61673c683630de8a503496167521e57e9b7e0c3d86e7049bd979f7201772af5d9e1b3bfc8980731373480725193c6f93afc89aafd084cd023f8
+  metadata.gz: 10a6082273ed23f530a06a28e19cf2aa8d00840b0844753e4bc797605145110d831a2e0b29516b5f0c1b1372ac2a9163ea67f7a7340fc7b13ba955e0dc6ca775
+  data.tar.gz: 3b5acb587ca255095568ac721b8fe733c8e35a1b54d723070a0d92d247bfcc7e3d08a52be4de0bc7925af25233e6e5b2bae7c557c6837dfb9fa373487056b0b9

data/Changelog.md

@@ -1,4 +1,10 @@
-# v0.5.20 2014-06-15
+# v0.5.21 2014-06-15
+
+* Readd mutation of index assignments
+* Remove a bunch of useless mutations to nil.something
+* Readd mutation of index reference arguments
+
+# v0.5.20 2014-06-14
 
 * Remove support for matchers prefixed with ::
 * Fix cases where mutated source diff was empty #198

data/TODO

@@ -10,7 +10,6 @@ Mutations:
   * Replace nil or add "do not touch me object" to literal mutations.
   * Mutate options on Regexp literals
   * Add mutations for dynamic regexp symbol and string literals
-  * Mutate "def foo; bar; end" to "def foo; self; end"?
   * Mutate Block catch "def foo(&block)" and block pass "foo(&block)"
   * Binary operator mutations
   * Add timeout to terminate infinite loops
@@ -22,15 +21,6 @@ Mutations:
 Loader:
   * Make sure loader does not change visibility of injected mutants
 
-Killers:
-  * Move test framework specific stuff to strategy
-  * Add a general master <=> killer IPC interface. So different strategies of isolation
-    (fork, vs jruby runtime creation) will work without big impact.
-
-Strategy:
-  * Aggregate warnings on missing spec files
-  * Provide "expicit files to kill with" strategy
-
 Matcher:
   * Allow matches on attr_reader with literal name argument(s)?
   * Allow matches on define_method with literal name argument?

data/config/flay.yml

@@ -1,3 +1,3 @@
 ---
 threshold: 18
-total_score: 903
+total_score: 906

data/config/reek.yml

@@ -111,7 +111,7 @@ TooManyStatements:
   - Mutant::CLI#parse
   - Mutant::CLI#initialize
   - Mutant::CLI#add_debug_options
-  max_statements: 6
+  max_statements: 7
 UncommunicativeMethodName:
   enabled: true
   exclude:

data/lib/mutant/mutator/node/send.rb

@@ -19,9 +19,11 @@ module Mutant
           :== =>        [:eql?, :equal?]
         )
 
-        INDEX_REFERENCE = :[]
-        INDEX_ASSIGN    = :[]=
-        ASSIGN_SUFFIX   = '='.freeze
+        INDEX_REFERENCE      = :[]
+        INDEX_ASSIGN         = :[]=
+        VARIABLE_ASSIGN      = :'='
+        ASSIGNMENT_OPERATORS = [INDEX_ASSIGN, VARIABLE_ASSIGN].to_set.freeze
+        ATTRIBUTE_ASSIGNMENT = /\A[a-z\d_]+=\z/.freeze
 
       private
 
@@ -33,10 +35,7 @@ module Mutant
         #
         def dispatch
           emit_singletons
-          case selector
-          when INDEX_REFERENCE
-            run(Index::Reference)
-          when INDEX_ASSIGN
+          if selector.equal?(INDEX_ASSIGN)
             run(Index::Assign)
           else
             non_index_dispatch
@@ -77,8 +76,8 @@ module Mutant
         def normal_dispatch
           emit_naked_receiver
           emit_selector_replacement
-          mutate_receiver
           emit_argument_propagation
+          mutate_receiver
           mutate_arguments
         end
 
@@ -101,20 +100,12 @@ module Mutant
         # @api private
         #
         def emit_naked_receiver
-          return unless receiver
-          op_assign      = OP_ASSIGN.include?(parent_type)
-          not_assignable = NOT_ASSIGNABLE.include?(receiver.type)
-          return if op_assign and not_assignable
-          emit(receiver)
+          emit(receiver) if receiver && !NOT_ASSIGNABLE.include?(receiver.type)
         end
 
         # Test for binary operator
         #
-        # @return [true]
-        #   if send is a binary operator
-        #
-        # @return [false]
-        #   otherwise
+        # @return [Boolean]
         #
         # @api private
         #
@@ -124,15 +115,12 @@ module Mutant
 
         # Test for attribute assignment
         #
-        # @return [true]
-        #   if node represetns and attribute assignment
-        #
-        # @return [false]
+        # @return [Boolean]
         #
         # @api private
         #
         def attribute_assignment?
-          !BINARY_OPERATORS.include?(selector) && !UNARY_OPERATORS.include?(selector) && assignment? && !mlhs?
+          arguments.one? && ATTRIBUTE_ASSIGNMENT =~ selector
         end
 
         # Mutate arguments
@@ -156,10 +144,8 @@ module Mutant
         # @api private
         #
         def emit_argument_propagation
-          return unless arguments.one?
           node = arguments.first
-          return if NOT_STANDALONE.include?(node.type)
-          emit(arguments.first)
+          emit(node) if arguments.one? && !NOT_STANDALONE.include?(node.type)
         end
 
         # Emit receiver mutations
@@ -171,7 +157,9 @@ module Mutant
         def mutate_receiver
           return unless receiver
           emit_implicit_self
-          emit_receiver_mutations
+          emit_receiver_mutations do |node|
+            !n_nil?(node)
+          end
         end
 
         # Emit implicit self mutation
@@ -181,45 +169,26 @@ module Mutant
         # @api private
         #
         def emit_implicit_self
-          emit_receiver(nil) if allow_implicit_self?
-        end
-
-        # Test if implicit self is allowed
-        #
-        # @return [Boolean]
-        #
-        # @api private
-        #
-        def allow_implicit_self?
-          n_self?(receiver) &&
-          !KEYWORDS.include?(selector) &&
-          !attribute_assignment? &&
-          !OP_ASSIGN.include?(parent_type)
+          emit_receiver(nil) if n_self?(receiver) && !(
+            KEYWORDS.include?(selector)     ||
+            OP_ASSIGN.include?(parent_type) ||
+            attribute_assignment?
+          )
         end
 
         # Test for assignment
         #
-        # FIXME: This also returns true for <= operator!
-        #
-        # @return [true]
-        #   if node represents attribute / element assignment
-        #
-        # @return [false]
-        #   otherwise
+        # @return [Boolean]
         #
         # @api private
         #
         def assignment?
-          selector.to_s[-1] == ASSIGN_SUFFIX
+          arguments.one? && (ASSIGNMENT_OPERATORS.include?(selector) || attribute_assignment?)
         end
 
-        # Test for mlhs
+        # Test if node is part of an mlhs
         #
-        # @return [true]
-        #   if node is within an mlhs
-        #
-        # @return [false]
-        #   otherwise
+        # @return [Boolean]
         #
         # @api private
         #
@@ -229,11 +198,7 @@ module Mutant
 
         # Test for empty arguments
         #
-        # @return [true]
-        #   if arguments are empty
-        #
-        # @return [false]
-        #   otherwise
+        # @return [Boolean]
         #
         # @api private
         #
@@ -244,4 +209,5 @@ module Mutant
       end # Send
     end # Node
   end # Mutator
+
 end # Mutant

data/lib/mutant/mutator/node/send/attribute_assignment.rb

@@ -2,8 +2,7 @@ module Mutant
   class Mutator
     class Node
       class Send
-
-        # Mutator for sends that correspond to an attribute assignment
+        # Mutator for attribute assignments
         class AttributeAssignment < self
 
         private
@@ -42,7 +41,6 @@ module Mutant
           end
 
         end # AttributeAssignment
-
       end # Send
     end # Node
   end # Mutator

data/lib/mutant/mutator/node/send/index.rb

@@ -7,8 +7,14 @@ module Mutant
         # Base mutator for index operations
         class Index < self
 
-          # Mutator for index references
-          class Reference < self
+          # Mutator for index assignments
+          class Assign < self
+
+            define_named_child(:value, -1)
+
+            INDEX_RANGE = (2..-2).freeze
+
+          private
 
             # Perform dispatch
             #
@@ -17,22 +23,34 @@ module Mutant
             # @api private
             #
             def dispatch
-              emit(receiver)
+              emit_naked_receiver
+              emit_value_mutations
+              emit_index_read
+              emit(value)
+              mutate_indices
             end
 
-          end # Reference
-
-          # Mutator for index assignments
-          class Assign < self
+            # Mutate indices
+            #
+            # @return [undefined]
+            #
+            # @api private
+            #
+            def mutate_indices
+              INDEX_RANGE.begin.upto(children.length + INDEX_RANGE.end).each do |index|
+                delete_child(index)
+                mutate_child(index)
+              end
+            end
 
-            # Perform dispatch
+            # Emit index read
             #
             # @return [undefined]
             #
             # @api private
             #
-            def dispatch
-              emit(receiver)
+            def emit_index_read
+              emit_type(receiver, :[], *children[INDEX_RANGE])
             end
 
           end # Assign

data/lib/mutant/version.rb

@@ -1,4 +1,4 @@
 module Mutant
   # The current mutant version
-  VERSION = '0.5.20'.freeze
+  VERSION = '0.5.21'.freeze
 end # Mutant

data/lib/mutant/zombifier.rb

@@ -65,13 +65,14 @@ module Mutant
 
     # Require file in zombie namespace
     #
-    # @param [String] logical_name
+    # @param [#to_s] logical_name
     #
     # @return [self]
     #
     # @api private
     #
     def require(logical_name)
+      logical_name = logical_name.to_s
       @highjack.original.call(logical_name)
       return unless include?(logical_name)
       @zombified << logical_name

data/meta/op_assgn.rb

@@ -9,7 +9,6 @@ Mutant::Meta::Example.add do
   mutation '@a.b += 0'
   mutation '@a.b += nil'
   mutation '@a.b += self'
-  mutation 'nil.b += 1'
   mutation 'self.b += 1'
   # TODO: fix invalid AST
   #   This should not get emitted as invalid AST with valid unparsed source

data/meta/regex.rb

@@ -15,7 +15,6 @@ Mutant::Meta::Example.add do
   mutation '//' # match all
   mutation '/#{foo}n/'
   mutation '/a\A/'         # match nothing
-  mutation '/#{nil.bar}n/'
   mutation '/#{self.bar}n/'
   mutation '/#{nil}n/'
   mutation '/#{self}n/'

data/meta/send.rb

@@ -49,7 +49,6 @@ Mutant::Meta::Example.add do
   mutation 'foo.gsub(a, self)'
   mutation 'foo.gsub(nil, b)'
   mutation 'foo.gsub(self, b)'
-  mutation 'nil.gsub(a, b)'
   mutation 'self.gsub(a, b)'
 end
 
@@ -64,7 +63,6 @@ Mutant::Meta::Example.add do
   mutation 'self.send(bar)'
   mutation 'foo.send(nil)'
   mutation 'foo.send(self)'
-  mutation 'nil.send(bar)'
 end
 
 Mutant::Meta::Example.add do
@@ -76,7 +74,6 @@ Mutant::Meta::Example.add do
   mutation 'self.bar'
   mutation 'baz'
   # This one could probably be removed
-  mutation 'nil.bar=baz'
 end
 
 Mutant::Meta::Example.add do
@@ -90,14 +87,20 @@ Mutant::Meta::Example.add do
   mutation 'foo.bar'
   mutation 'baz'
   # This one could probably be removed
-  mutation 'nil.bar = baz'
 end
 
 Mutant::Meta::Example.add do
-  source 'foo[bar]=baz'
+  source 'foo[bar] = baz'
 
   singleton_mutations
   mutation 'foo'
+  mutation 'foo[bar]'
+  mutation 'foo[bar] = self'
+  mutation 'foo[bar] = nil'
+  mutation 'foo[nil] = baz'
+  mutation 'foo[self] = baz'
+  mutation 'foo[] = baz'
+  mutation 'baz'
 end
 
 Mutant::Meta::Example.add do
@@ -119,13 +122,6 @@ Mutant::Meta::Example.add do
   mutation 'foo'
 end
 
-Mutant::Meta::Example.add do
-  source 'foo[*bar]'
-
-  singleton_mutations
-  mutation 'foo'
-end
-
 Mutant::Meta::Example.add do
   source 'foo'
 
@@ -137,7 +133,6 @@ Mutant::Meta::Example.add do
 
   singleton_mutations
   mutation 'foo'
-  mutation 'nil.foo'
 end
 
 Unparser::Constants::KEYWORDS.each do |keyword|
@@ -145,7 +140,6 @@ Unparser::Constants::KEYWORDS.each do |keyword|
     source "self.#{keyword}"
 
     singleton_mutations
-    mutation "nil.#{keyword}"
   end
 end
 
@@ -154,7 +148,6 @@ Mutant::Meta::Example.add do
 
   singleton_mutations
   mutation 'foo'
-  mutation 'nil.bar'
   mutation 'self.bar'
 end
 
@@ -164,8 +157,6 @@ Mutant::Meta::Example.add do
   singleton_mutations
   mutation 'self.class'
   mutation 'self.foo'
-  mutation 'nil.class.foo'
-  mutation 'nil.foo'
 end
 
 Mutant::Meta::Example.add do
@@ -181,7 +172,6 @@ Mutant::Meta::Example.add do
   singleton_mutations
   mutation 'self.foo'
   mutation 'foo(nil)'
-  mutation 'nil.foo(nil)'
 end
 
 Unparser::Constants::KEYWORDS.each do |keyword|
@@ -192,7 +182,6 @@ Unparser::Constants::KEYWORDS.each do |keyword|
     mutation "self.#{keyword}(nil)"
     mutation "foo.#{keyword}"
     mutation 'foo'
-    mutation "nil.#{keyword}(nil)"
   end
 end
 
@@ -222,6 +211,44 @@ Mutant::Meta::Example.add do
   mutation 'self / foo'
 end
 
+Mutant::Meta::Example.add do
+  source 'foo[1]'
+
+  singleton_mutations
+  mutation '1'
+  mutation 'foo'
+  mutation 'foo[]'
+  mutation 'self[1]'
+  mutation 'foo[0]'
+  mutation 'foo[2]'
+  mutation 'foo[-1]'
+  mutation 'foo[nil]'
+  mutation 'foo[self]'
+end
+
+Mutant::Meta::Example.add do
+  source 'self.foo[]'
+
+  singleton_mutations
+  mutation 'self.foo'
+  mutation 'self[]'
+  mutation 'foo[]'
+end
+
+Mutant::Meta::Example.add do
+  source 'foo[*bar]'
+
+  singleton_mutations
+  mutation 'foo'
+  mutation 'foo[]'
+  mutation 'foo[nil]'
+  mutation 'foo[self]'
+  mutation 'foo[bar]'
+  mutation 'foo[*self]'
+  mutation 'foo[*nil]'
+  mutation 'self[*bar]'
+end
+
 (Mutant::BINARY_METHOD_OPERATORS - [:==, :eql?]).each do |operator|
   Mutant::Meta::Example.add do
     source "true #{operator} false"

data/mutant.gemspec

@@ -29,7 +29,7 @@ Gem::Specification.new do |gem|
   gem.add_runtime_dependency('morpher',       '~> 0.2.3')
   gem.add_runtime_dependency('procto',        '~> 0.0.2')
   gem.add_runtime_dependency('abstract_type', '~> 0.0.7')
-  gem.add_runtime_dependency('unparser',      '~> 0.1.13')
+  gem.add_runtime_dependency('unparser',      '~> 0.1.14')
   gem.add_runtime_dependency('ice_nine',      '~> 0.11.0')
   gem.add_runtime_dependency('adamantium',    '~> 0.2.0')
   gem.add_runtime_dependency('memoizable',    '~> 0.4.2')

data/spec/integration/mutant/corpus_spec.rb

@@ -97,7 +97,7 @@ describe 'Mutant on ruby corpus' do
       TMP.mkdir unless TMP.directory?
       if repo_path.exist?
         Dir.chdir(repo_path) do
-          system(%w[git pull origin master])
+          system(%w[git pull -f origin master])
           system(%w[git clean -f -d -x])
         end
       else

data/spec/integrations.yml

@@ -31,4 +31,4 @@
   mutation_coverage: true
   mutation_generation: true
   exclude: []
-  expect_coverage: 99.81
+  expect_coverage: 100.0

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mutant
 version: !ruby/object:Gem::Version
-  version: 0.5.20
+  version: 0.5.21
 platform: ruby
 authors:
 - Markus Schirp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-14 00:00:00.000000000 Z
+date: 2014-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -100,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.13
+        version: 0.1.14
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.13
+        version: 0.1.14
 - !ruby/object:Gem::Dependency
   name: ice_nine
   requirement: !ruby/object:Gem::Requirement