mutant 0.5.10 → 0.5.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 84a8405d55414b2cd802d72e2a8fab5a3a2e9383
-  data.tar.gz: e4acca9abe75f892f73c1b830473d17630ec1001
+  metadata.gz: bff75074f1898f689c4215c2a19f14d02863ccc4
+  data.tar.gz: 576dbee5c9743707641a1f3fac543c0c76d85832
 SHA512:
-  metadata.gz: 1ca5f7c4ff72450792d49df2c40d10a45335442d095b54564c8f650bf9218fed4b9821994fa17162d27e4b1e2c1087cfc2f4bf8661e3adf63e73c187e57475d1
-  data.tar.gz: 8a0154fce8d6a39824108c609c2a76f170f5fb855fa8b5cfb4224b91a5528106b41d83500e5af0b67b2d7775ca4a00b24e5ffbe090369efa94c4e9525e0fccc4
+  metadata.gz: 47b0085d022c5e09f1013c824989f2449838bea7b9681b257e9e8ef7641a39fd522dacdf643e20e177422ff8c8a944b9d34a20c5c0f464f68f4458c02b2f1702
+  data.tar.gz: 47f0863f96176f3c90200a4a6ed46c86e31a39de77a8d35a66d7728446b38422288d162e5a0f1a4e54bc2a750ee34f869958e7019048652522d5e15c346e6cf7

data/.rubocop.yml

@@ -4,4 +4,5 @@ AllCops:
   Excludes:
     - 'Gemfile.devtools'
     - 'vendor/**'
+    - 'tmp/**'
     - 'benchmarks/**'

data/Changelog.md

@@ -1,8 +1,19 @@
+# v0.5.11 2014-04-21
+
+Changes:
+
+* Fix crash on while and until without body
+* Better require highjack based zombifier
+* Do not mutate nthref $1 to gvar $0
+* Use faster duplicate guarding hashing AST::Node intances
+* Fix lots of shadowed invalid ASTs
+* Fix undefine initialize warnings, Closes #175
+
 # v0.5.10 2014-04-06
 
 Changes:
 
-* Fix crash without conditionals
+* Fix crash on case without conditional
 * Remove dependency to descendants tracker
 * Add mutation #== => #eql?, #equal?
 * Add mutation #eql? =>  #equal?

data/README.md

@@ -17,6 +17,9 @@ Mutant supports MRI and RBX 1.9 and 2.0, while support for jruby is planned.
 It should also work under any ruby engine that supports POSIX-fork(2) semantics.
 Support for MRI 2.1 is unstable, because this MRI release segfaults on basic metaprogramming mutants dependencies do.
 
+Mutant uses a pure ruby [parser](https://github.com/whitequark/parser) and an [unparser](https://github.com/mbj/unparser)
+to do its magic.
+
 Integrations
 ------------
 

data/Rakefile

@@ -3,12 +3,3 @@
 require 'devtools'
 
 Devtools.init_rake_tasks
-
-Rake.application.load_imports
-task('metrics:mutant').clear
-
-namespace :metrics do
-  task :mutant => :coverage do
-    $stderr.puts 'Mutant self mutation is disable till mutant is fast enough for travis'
-  end
-end

data/bin/mutant

@@ -10,7 +10,7 @@ require 'mutant'
 namespace =
   if ARGV.include?('--zombie')
     $stderr.puts('Running mutant zombified!')
-    Mutant::Zombifier.zombify
+    Mutant.zombify
     Zombie::Mutant
   else
     Mutant

data/config/flay.yml

@@ -1,3 +1,3 @@
 ---
 threshold: 18
-total_score: 804
+total_score: 836

data/config/mutant.yml

@@ -1,2 +1,15 @@
 name: mutant
 namespace: Mutant
+zombify: true
+expect_coverage: 64.99
+ignore_subjects:
+# Mutation causes infinite runtime
+- Mutant::Runner.lookup
+# Suboptimal test selection stragegy (will be fixed soon) causes timeouts on CI
+- Mutant::Zombifier*
+- Mutant::Reporter*
+- Mutant::CLI*
+- Mutant.singleton_subclass_instance
+- Mutant.symbolset
+# Executing this has undefined behavior with the zombifier
+- Mutant.zombify

data/config/reek.yml

@@ -52,6 +52,9 @@ NestedIterators:
   - Mutant::CLI#parse
   - Mutant::Mutator::Util::Array::Element#dispatch
   - Mutant::Reporter::CLI::Printer::Config::Runner#generic_stats
+  - Mutant::RequireHighjack#infect
+  - Mutant::RequireHighjack#desinfect
+  - Parser::Lexer#self.new
   max_allowed_nesting: 1
   ignore_iterators: []
 NilCheck:
@@ -85,7 +88,8 @@ TooManyStatements:
   - Mutant::Reporter::CLI#colorized_diff
   - Mutant::Reporter::CLI::Printer::Config::Runner#run
   - Mutant::Runner#dispatch
-  - Mutant::Zombifier::File#self.find_uncached
+  - Mutant::Zombifier::File#self.find
+  - Mutant::RequireHighjack#infect
   # How mutant does CLI parsing is shit
   - Mutant::CLI#parse
   - Mutant::CLI#initialize
@@ -123,7 +127,7 @@ UncommunicativeVariableName:
   - !ruby/regexp /^.$/
   - !ruby/regexp /[0-9]$/
   - !ruby/regexp /[A-Z]/
-  accept: []
+  accept: ['force_utf32']
 UnusedParameters:
   enabled: true
   exclude: []

data/lib/mutant/constants.rb

@@ -2,19 +2,6 @@
 
 module Mutant
 
-  # Return a frozen set of symbols from string enumerable
-  #
-  # @param [Enumerable<String>]
-  #
-  # @return [Set<Symbol>]
-  #
-  # @api private
-  #
-  def self.symbolset(strings)
-    strings.map(&:to_sym).to_set.freeze
-  end
-  private_class_method :symbolset
-
   # Set of nodes that cannot be on the LHS of an assignment
   NOT_ASSIGNABLE = symbolset %w(
     int float str dstr class module self

data/lib/mutant/mutator/node/conditional_loop.rb

@@ -21,8 +21,9 @@ module Mutant
         #
         def dispatch
           emit_condition_mutations
-          emit_body_mutations
+          emit_body_mutations if body
           emit_body(nil)
+          emit_body(RAISE)
           emit_nil
         end
 

data/lib/mutant/mutator/node/generic.rb

@@ -13,7 +13,7 @@ module Mutant
           :ensure, :redo, :defined?, :regopt, :retry, :arg_expr,
           :kwrestarg, :kwoptarg, :kwarg, :undef, :module, :empty,
           :alias, :for, :xstr, :back_ref, :class,
-          :sclass, :match_with_lvasgn, :match_current_line, :while_post,
+          :sclass, :match_with_lvasgn, :while_post,
           :until_post, :preexe, :postexe, :iflipflop, :eflipflop, :kwsplat,
           :shadowarg
         )

data/lib/mutant/mutator/node/if.rb

@@ -33,7 +33,7 @@ module Mutant
         #
         def mutate_condition
           emit_condition_mutations
-          emit_self(n_not(condition), if_branch, else_branch)
+          emit_self(n_not(condition), if_branch, else_branch) unless condition.type == :match_current_line
           emit_self(N_TRUE,  if_branch, else_branch)
           emit_self(N_FALSE, if_branch, else_branch)
         end

data/lib/mutant/mutator/node/literal/regex.rb

@@ -31,11 +31,11 @@ module Mutant
           # @api private
           #
           def dispatch
-            emit_nil
+            emit_nil unless parent_type == :match_current_line
             children.each_with_index do |child, index|
               mutate_child(index) unless child.type == :str
             end
-            emit_self(s(:str, EMPTY_STRING), options)
+            emit_self(options)
             emit_self(s(:str, NULL_REGEXP_SOURCE), options)
           end
 

data/lib/mutant/mutator/node/match_current_line.rb

@@ -0,0 +1,27 @@
+module Mutant
+  class Mutator
+    class Node
+      # Emitter for perl style match current line node
+      class MatchCurrentLine < self
+
+        handle :match_current_line
+
+        children :regexp
+
+      private
+
+        # Emit mutants
+        #
+        # @return [undefined]
+        #
+        # @api private
+        #
+        def dispatch
+          emit_nil
+          emit_regexp_mutations
+        end
+
+      end # MatchCurrentLine
+    end # Node
+  end # Mutator
+end # Mutant

data/lib/mutant/mutator/node/named_value/variable_assignment.rb

@@ -42,7 +42,7 @@ module Mutant
           def mutate_name
             prefix = MAP.fetch(node.type)
             Mutator::Util::Symbol.each(name, self) do |name|
-              emit_name(prefix + name.to_s)
+              emit_name(:"#{prefix}#{name}")
             end
           end
 

data/lib/mutant/mutator/node/nthref.rb

@@ -19,7 +19,9 @@ module Mutant
         # @api private
         #
         def dispatch
-          emit_number(number - 1)
+          unless number.equal?(1)
+            emit_number(number - 1)
+          end
           emit_number(number + 1)
         end
 

data/lib/mutant/mutator/node/rescue.rb

@@ -8,18 +8,6 @@ module Mutant
 
         handle :rescue
 
-        # Return identity
-        #
-        # @param [Parser::AST::Node] node
-        #
-        # @return [String]
-        #
-        # @api private
-        #
-        def self.identity(node)
-          super(NodeHelpers.s(:kwbegin, node))
-        end
-
       end # Rescue
     end # Node
   end # Mutator

data/lib/mutant/mutator/node/send/attribute_assignment.rb

@@ -0,0 +1,51 @@
+# encoding: utf-8
+
+module Mutant
+  class Mutator
+    class Node
+      class Send
+
+        # Mutator for sends that correspond to an attribute assignment
+        class AttributeAssignment < self
+
+        private
+
+          # Emit mutations
+          #
+          # @return [undefined]
+          #
+          # @api private
+          #
+          def dispatch
+            normal_dispatch
+            emit_attribute_read
+          end
+
+          # Mutate arguments
+          #
+          # @return [undefined]
+          #
+          # @api private
+          #
+          def mutate_arguments
+            remaining_children_indices.each do |index|
+              mutate_child(index)
+            end
+          end
+
+          # Emit attribute read
+          #
+          # @return [undefined]
+          #
+          # @api private
+          #
+          def emit_attribute_read
+            emit_self(receiver, selector.to_s[0..-2].to_sym)
+          end
+
+        end # AttributeAssignment
+
+      end # Send
+    end # Node
+  end # Mutator
+end # Mutant

data/lib/mutant/mutator/node/send/index.rb

@@ -0,0 +1,43 @@
+# encoding: UTF-8
+
+module Mutant
+  class Mutator
+    class Node
+      class Send
+        # Base mutator for index operations
+        class Index < self
+
+          # Mutator for index references
+          class Reference < self
+
+            # Perform dispatch
+            #
+            # @return [undefined]
+            #
+            # @api private
+            #
+            def dispatch
+              emit(receiver)
+            end
+
+          end # Reference
+
+          # Mutator for index assignments
+          class Assign < self
+
+            # Perform dispatch
+            #
+            # @return [undefined]
+            #
+            # @api private
+            #
+            def dispatch
+              emit(receiver)
+            end
+
+          end # Assign
+        end # Index
+      end # Send
+    end # Node
+  end # Mutator
+end # Mutant

data/lib/mutant/mutator/node/send.rb

@@ -22,40 +22,6 @@ module Mutant
         INDEX_ASSIGN    = :[]=
         ASSIGN_SUFFIX   = '='.freeze
 
-        # Base mutator for index operations
-        class Index < self
-
-          # Mutator for index references
-          class Reference < self
-
-            # Perform dispatch
-            #
-            # @return [undefined]
-            #
-            # @api private
-            #
-            def dispatch
-              emit(receiver)
-            end
-
-          end # Reference
-
-          # Mutator for index assignments
-          class Assign < self
-
-            # Perform dispatch
-            #
-            # @return [undefined]
-            #
-            # @api private
-            #
-            def dispatch
-              emit(receiver)
-            end
-
-          end # Assign
-        end # Index
-
       private
 
         # Perform dispatch
@@ -65,6 +31,7 @@ module Mutant
         # @api private
         #
         def dispatch
+          emit_nil
           case selector
           when INDEX_REFERENCE
             run(Index::Reference)
@@ -73,7 +40,6 @@ module Mutant
           else
             non_index_dispatch
           end
-          emit_nil
         end
 
         # Perform non index dispatch
@@ -86,6 +52,8 @@ module Mutant
           case
           when binary_operator?
             run(Binary)
+          when attribute_assignment?
+            run(AttributeAssignment)
           else
             normal_dispatch
           end
@@ -173,7 +141,6 @@ module Mutant
         # @api private
         #
         def mutate_arguments
-          return if arguments.empty?
           emit_self(receiver, selector)
           remaining_children_with_index.each do |node, index|
             mutate_child(index)
@@ -213,7 +180,10 @@ module Mutant
         # @api private
         #
         def emit_implicit_self
-          if receiver.type == :self && !KEYWORDS.include?(selector) && !attribute_assignment?
+          if receiver.type == :self &&
+             !KEYWORDS.include?(selector) &&
+             !attribute_assignment? &&
+             !OP_ASSIGN.include?(parent_type)
             emit_receiver(nil)
           end
         end

data/lib/mutant/mutator/node.rb

@@ -9,18 +9,6 @@ module Mutant
     class Node < self
       include AbstractType, NodeHelpers, Unparser::Constants
 
-      # Return identity of node
-      #
-      # @param [Parser::AST::Node] node
-      #
-      # @return [String]
-      #
-      # @api private
-      #
-      def self.identity(node)
-        Unparser.unparse(node)
-      end
-
       # Define named child
       #
       # @param [Symbol] name
@@ -58,6 +46,10 @@ module Mutant
           children.each_with_index.drop(names.length)
         end
 
+        define_method(:remaining_children_indices) do
+          children.each_index.drop(names.length)
+        end
+
         define_method(:remaining_children) do
           children.drop(names.length)
         end

data/lib/mutant/mutator.rb

@@ -33,18 +33,6 @@ module Mutant
     end
     private_class_method :handle
 
-    # Return identity of object (for deduplication)
-    #
-    # @param [Object] object
-    #
-    # @return [Object]
-    #
-    # @api private
-    #
-    def self.identity(object)
-      object
-    end
-
     # Return input
     #
     # @return [Object]
@@ -92,7 +80,7 @@ module Mutant
     # @api private
     #
     def new?(object)
-      !@seen.include?(identity(object))
+      !@seen.include?(object)
     end
 
     # Add object to guarded values
@@ -104,19 +92,7 @@ module Mutant
     # @api private
     #
     def guard(object)
-      @seen << identity(object)
-    end
-
-    # Return identity for input
-    #
-    # @param [Object] input
-    #
-    # @return [Object]
-    #
-    # @api private
-    #
-    def identity(input)
-      self.class.identity(input)
+      @seen << object
     end
 
     # Dispatch node generations

data/lib/mutant/node_helpers.rb

@@ -18,13 +18,13 @@ module Mutant
     module_function :s
 
     NAN =
-      s(:send, s(:float,  0.0), :/, s(:args, s(:float, 0.0)))
+      s(:send, s(:float,  0.0), :/, s(:float, 0.0))
     INFINITY =
-      s(:send, s(:float,  1.0), :/, s(:args, s(:float, 0.0)))
+      s(:send, s(:float,  1.0), :/, s(:float, 0.0))
     NEW_OBJECT =
       s(:send, s(:const, s(:cbase), :Object), :new)
     NEGATIVE_INFINITY =
-      s(:send, s(:float, -1.0), :/, s(:args, s(:float, 0.0)))
+      s(:send, s(:float, -1.0), :/, s(:float, 0.0))
 
     RAISE             = s(:send, nil, :raise)
 

data/lib/mutant/require_highjack.rb

@@ -0,0 +1,64 @@
+module Mutant
+  # Require highjack
+  class RequireHighjack
+    include Concord.new(:target, :callback)
+
+    # Return original method
+    #
+    # @return [#call]
+    #
+    # @api private
+    #
+    attr_reader :original
+
+    # Run block with highjacked require
+    #
+    # @return [self]
+    #
+    # @api pivate
+    #
+    def run
+      infect
+      yield
+      self
+    ensure
+      desinfect
+    end
+
+    # Infect kernel with highjack
+    #
+    # @return [self]
+    #
+    # @api pivate
+    #
+    def infect
+      callback = @callback
+      @original = target.method(:require)
+      target.module_eval do
+        undef :require
+        define_method(:require) do |logical_name|
+          callback.call(logical_name)
+        end
+        module_function :require
+      end
+    end
+
+    # Imperfectly desinfect kernel from highjack
+    #
+    # @return [self]
+    #
+    # @api private
+    #
+    def desinfect
+      original = @original
+      target.module_eval do
+        undef :require
+        define_method(:require) do |logical_name|
+          original.call(logical_name)
+        end
+        module_function :require
+      end
+    end
+
+  end # RequireHighjack
+end # Mutant

data/lib/mutant/subject/method/instance.rb

@@ -31,7 +31,15 @@ module Mutant
         # @api private
         #
         def prepare
-          scope.send(:undef_method, name)
+          expected_warnings =
+            if name.equal?(:initialize)
+              ["#{__FILE__}:#{__LINE__ + 5}: warning: undefining `initialize' may cause serious problems\n"]
+            else
+              []
+            end
+          WarningExpectation.new(expected_warnings).execute do
+            scope.send(:undef_method, name)
+          end
           self
         end
 

data/lib/mutant/version.rb

@@ -2,5 +2,5 @@
 
 module Mutant
   # The current mutant version
-  VERSION = '0.5.10'.freeze
+  VERSION = '0.5.11'.freeze
 end # Mutant

data/lib/mutant/warning_expectation.rb

@@ -0,0 +1,40 @@
+module Mutant
+  # A class to expect some warning message raising on absence of unexpected warnings
+  class WarningExpectation
+    include Adamantium::Flat, Concord.new(:expected)
+
+    # Error raised on expectation miss
+    class ExpectationError < RuntimeError
+      include Concord.new(:unexpected, :missing)
+
+      # Return exception message
+      #
+      # @return [String]
+      #
+      # @api private
+      #
+      def message
+        "Unexpected warnings: #{unexpected.inspect} missing warnigns: #{missing.inspect}"
+      end
+    end
+
+    # Execute blocks with warning expectations
+    #
+    # @return [self]
+    #
+    # @api private
+    #
+    def execute(&block)
+      warnings = WarningFilter.use do
+        block.call
+      end
+      missing = expected - warnings
+      unexpected = warnings - expected
+      if missing.any? or unexpected.any?
+        fail ExpectationError.new(unexpected, missing)
+      end
+      self
+    end
+
+  end # WarningExpectation
+end # Mutant