musk 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: df87916c30e6fcf75b145d540bf7c337040cc7c4
-  data.tar.gz: b7d8741df91d111578a923447378c0ff81552537
+  metadata.gz: 813d2fc5466547c772986b8bdeb64971e74c247a
+  data.tar.gz: 2fbe6fe8aeeb901933615f154f2da15111321b31
 SHA512:
-  metadata.gz: 08eefa33efe915736f2ecc9328f59239f6a42ccb9ea2a7c9546d70dad8c225aa2a104d8109cca0eef1699d74706003906e80309da940148b1cc8af60d2d38c20
-  data.tar.gz: 24a3b257af512d5f3a75fb52a2b721a6acf4a86a9a648a550692b5495b353da7988971910d474316feece99fcb1ba53413c9fb4f3c24385e02f19a722bd57082
+  metadata.gz: 6621d503cc6ef86046c449c6555c7fc098893507bff5b35b6454cf37d1f723244ae30579906e0c879ef6dfd34f83d1a5c2167cac6142a8b4f4b1579b17956b0f
+  data.tar.gz: 1057bf6d031e4cb183cbdd3c1116a3421e7ffc7bf3d6d531074beec261e94f0640d91d81af8038a732fc077d6073f2d3281696630e6004bed34e486fafd01d17

data/.gitignore

@@ -1,5 +1,7 @@
 *.swp
+.DS_Store
 .ruby-version
 .bundle
 .rspec
-.DS_Store
+coverage
+TODO

data/Gemfile

@@ -1,3 +1,2 @@
-source 'https://rubygems.org'
-
+source "https://rubygems.org"
 gemspec

data/Gemfile.lock

@@ -1,19 +1,30 @@
 PATH
   remote: .
   specs:
-    musk (0.0.1)
-      discogs-wrapper (~> 1.1.4)
-      gli (~> 2.9.0)
-      taglib-ruby (~> 0.6.0)
+    musk (0.0.2)
+      gli (~> 2.9)
+      taglib-ruby (~> 0.6)
 
 GEM
   remote: https://rubygems.org/
   specs:
+    activesupport (4.0.4)
+      i18n (~> 0.6, >= 0.6.9)
+      minitest (~> 4.2)
+      multi_json (~> 1.3)
+      thread_safe (~> 0.1)
+      tzinfo (~> 0.3.37)
+    atomic (1.1.16)
     coderay (1.1.0)
     diff-lcs (1.2.5)
-    discogs-wrapper (1.1.4)
+    docile (1.1.3)
+    factory_girl (4.4.0)
+      activesupport (>= 3.0.0)
     gli (2.9.0)
+    i18n (0.6.9)
     method_source (0.8.2)
+    minitest (4.7.5)
+    multi_json (1.9.2)
     pry (0.9.12.6)
       coderay (~> 1.0)
       method_source (~> 0.8)
@@ -26,13 +37,23 @@ GEM
     rspec-expectations (2.14.5)
       diff-lcs (>= 1.1.3, < 2.0)
     rspec-mocks (2.14.6)
+    simplecov (0.8.2)
+      docile (~> 1.1.0)
+      multi_json
+      simplecov-html (~> 0.8.0)
+    simplecov-html (0.8.0)
     slop (3.5.0)
     taglib-ruby (0.6.0)
+    thread_safe (0.3.1)
+      atomic (>= 1.1.7, < 2)
+    tzinfo (0.3.39)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
+  factory_girl (~> 4.4)
   musk!
-  pry (~> 0.9.12.6)
-  rspec (~> 2.14.1)
+  pry (~> 0.9)
+  rspec (~> 2.14)
+  simplecov (~> 0.8)

data/bin/musk

@@ -1,51 +1,25 @@
 #!/usr/bin/env ruby
 
-require 'taglib'
-require 'gli'
+require "gli"
+require "musk/track_loader"
+require "musk/track_printer"
 
-include GLI::App
+extend GLI::App
 
-desc 'Extract meta-data (tags) from MP3 files'
-arg_name 'path_to_files'
+desc "Extract meta-data (tags) from MP3 files"
+arg_name "path_to_file or path_to_files"
 command :extract do |command|
-  command.action do |global_options, options, args|
-    if args.empty?
-      STDERR.puts 'Undefined path to an MP3 file or files'
+  command.arg_name "format"
+  command.default_value "pretty"
+  command.flag [:f, :format]
+  command.action do |global_options, options, arguments|
+    begin
+      tracks = Musk::TrackLoader.load!(arguments.first)
+      Musk::TrackPrinter.print!(options[:f], tracks)
+    rescue RuntimeError => error
+      STDERR.puts error
       exit 1
     end
-    unless File.directory?(args.first)
-      unless File.file?(args.first)
-        STDERR.puts "Unknown path '#{args.first}' to an MP3 file or files"
-        exit 2
-      end
-      unless File.extname(args.first) == '.mp3'
-        STDERR.puts "Unknown extension '#{File.extname(args.first)}'"
-        exit 2
-      end
-    end
-    tracks = []
-    if File.file?(args.first)
-      tracks << args.first
-    else
-      Dir.glob(File.join(args.first, '**', '*.mp3')) do |track|
-        tracks << track
-      end
-    end
-    tracks.each_with_index do |track, index|
-      TagLib::MPEG::File.open(track) do |file|
-        tag = file.id3v2_tag
-        puts if index > 0
-        printf("%-9s%s\n", 'File:',    track)
-        printf("%-9s%s\n", 'Cover:',   !tag.frame_list('APIC').first.nil?)
-        printf("%-9s%s\n", 'Track:',   tag.frame_list('TRCK').first)
-        printf("%-9s%s\n", 'Title:',   tag.title)
-        printf("%-9s%s\n", 'Artist:',  tag.artist)
-        printf("%-9s%s\n", 'Album:',   tag.album)
-        printf("%-9s%s\n", 'Genre:',   tag.genre)
-        printf("%-9s%s\n", 'Year:',    tag.year)
-        printf("%-9s%s\n", 'Comment:', tag.comment)
-      end
-    end
   end
 end
 

data/lib/musk/format/pretty.rb

@@ -0,0 +1,19 @@
+module Musk
+  module Format
+    class Pretty
+      def self.print(tracks)
+        tracks.each_with_index do |track, index|
+          puts if index > 0
+          printf("%-10s%s\n", "Path:",     track.path)
+          printf("%-10s%s\n", "Title:",    track.title)
+          printf("%-10s%s\n", "Position:", track.position)
+          printf("%-10s%s\n", "Artist:",   track.artist)
+          printf("%-10s%s\n", "Album:",    track.album)
+          printf("%-10s%s\n", "Genre:",    track.genre)
+          printf("%-10s%s\n", "Year:",     track.year)
+          printf("%-10s%s\n", "Comment:",  track.comment)
+        end
+      end
+    end
+  end
+end

data/lib/musk/track.rb

@@ -0,0 +1,18 @@
+module Musk
+  class Track
+    ATTRIBUTES = [:path,
+                  :title,
+                  :position,
+                  :artist,
+                  :album,
+                  :genre,
+                  :year,
+                  :comment]
+
+    attr_accessor *ATTRIBUTES
+
+    def attributes
+      Hash[ATTRIBUTES.map {|a| [a, send("#{a}")]}]
+    end
+  end
+end

data/lib/musk/track_loader.rb

@@ -0,0 +1,46 @@
+require "taglib"
+require "musk/track"
+
+module Musk
+  class TrackLoader
+    def self.supported_formats
+      ["mp3"]
+    end
+
+    def self.supported_extensions
+      supported_formats.map {|f| ".#{f}"}
+    end
+
+    def self.load!(path)
+      unless path and path.length > 0
+        raise "Undefined path to a file or files"
+      end
+      unless File.file?(path) or File.directory?(path)
+        raise "Unknown path '#{path}' to a file or files"
+      end
+      if File.file?(path)
+        unless supported_extensions.include?(File.extname(path))
+          raise "Unknown extension '#{File.extname(path)}'"
+        end
+      end
+      if File.directory?(path)
+        path = File.join(path, "**", "*.{#{supported_formats.join(',')}}")
+      end
+      Dir[path].map do |path|
+        track = Musk::Track.new
+        track.path = path
+        TagLib::MPEG::File.open(path) do |file|
+          tag = file.id3v2_tag
+          track.title    = tag.title
+          track.position = tag.track
+          track.artist   = tag.artist
+          track.album    = tag.album
+          track.genre    = tag.genre
+          track.year     = tag.year
+          track.comment  = tag.comment
+        end
+        track
+      end
+    end
+  end
+end

data/lib/musk/track_printer.rb

@@ -0,0 +1,14 @@
+require "musk/format/pretty"
+
+module Musk
+  class TrackPrinter
+    def self.print!(format, tracks)
+      case format.to_s.to_sym
+      when :pretty
+        Format::Pretty.print(tracks)
+      else
+        raise "Unknown format '#{format}'"
+      end
+    end
+  end
+end

data/lib/musk/version.rb

@@ -0,0 +1,3 @@
+module Musk
+  VERSION = "0.0.2"
+end

data/lib/musk.rb

@@ -1,5 +1,3 @@
-class Musk
-  def self.hi
-    "Hello world!"
-  end
-end
+require "musk/track"
+require "musk/track_loader"
+require "musk/track_printer"

data/musk.gemspec

@@ -1,20 +1,26 @@
+$LOAD_PATH << File.expand_path("../lib", __FILE__)
+
+require "musk/version"
+
 Gem::Specification.new do |s|
-  s.name        = 'musk'
-  s.version     = '0.0.1'
-  s.summary     = 'Your music with the demonic scent of musk'
-  s.description = 'Your music with the demonic scent of musk.'
-  s.homepage    = 'https://github.com/pempel/musk'
-  s.date        = '2014-03-19'
-  s.author      = 'Eugene Pempel'
-  s.email       = 'eugene.pempel@gmail.com'
-  s.license     = 'MIT'
+  s.author      = "Eugene Pempel"
+  s.email       = "eugene.pempel@gmail.com"
+  s.summary     = "Your music with the demonic scent of musk"
+  s.description = "Your music with the demonic scent of musk."
+  s.homepage    = "https://github.com/pempel/musk"
+
+  s.name        = "musk"
+  s.date        = "2014-03-19"
   s.files       = `git ls-files`.split($\)
-  s.executables = `git ls-files -- bin/*`.split($\).map { |f| File.basename(f) }
+  s.executables = `git ls-files -- bin/*`.split($\).map {|f| File.basename(f)}
+  s.license     = "MIT"
+  s.version     = Musk::VERSION
 
-  s.add_runtime_dependency 'gli', '~> 2.9'
-  s.add_runtime_dependency 'taglib-ruby', '~> 0.6'
-  s.add_runtime_dependency 'discogs-wrapper', '~> 1.1'
+  s.add_runtime_dependency "gli", "~> 2.9"
+  s.add_runtime_dependency "taglib-ruby", "~> 0.6"
 
-  s.add_development_dependency 'pry', '~> 0.9'
-  s.add_development_dependency 'rspec', '~> 2.14'
+  s.add_development_dependency "pry", "~> 0.9"
+  s.add_development_dependency "rspec", "~> 2.14"
+  s.add_development_dependency "factory_girl", "~> 4.4"
+  s.add_development_dependency "simplecov", "~> 0.8"
 end

data/spec/bin/musk_spec.rb

@@ -0,0 +1,41 @@
+require "spec_helper"
+
+describe "musk extract" do
+  let(:command) { "bundle exec bin/musk extract" }
+
+  context "called without arguments" do
+    it "should fail with the exit code 1" do
+      stdout, stderr, status = Open3.capture3(command)
+      status.exitstatus.should eq(1)
+    end
+
+    it "should write an error message to STDERR" do
+      stdout, stderr, status = Open3.capture3(command)
+      stderr.should_not be_empty
+    end
+  end
+
+  context "called with 'path_to_tracks'" do
+    it_should_behave_like "a command to print tracks to STDOUT in the pretty format" do
+      let(:expected_command) { command }
+    end
+  end
+
+  context "called with '-f pretty path_to_tracks'" do
+    it_should_behave_like "a command to print tracks to STDOUT in the pretty format" do
+      let(:expected_command) { "#{command} -f pretty" }
+    end
+  end
+
+  context "called with '--format pretty path_to_tracks'" do
+    it_should_behave_like "a command to print tracks to STDOUT in the pretty format" do
+      let(:expected_command) { "#{command} --format pretty" }
+    end
+  end
+
+  context "called with '--format=pretty path_to_tracks'" do
+    it_should_behave_like "a command to print tracks to STDOUT in the pretty format" do
+      let(:expected_command) { "#{command} --format=pretty" }
+    end
+  end
+end

data/spec/lib/musk/format/pretty_spec.rb

@@ -0,0 +1,26 @@
+require "spec_helper"
+
+describe Musk::Format::Pretty do
+  describe ".print(tracks)" do
+    let(:tracks) do
+      [build(:jets_track), build(:kamakura_track)]
+    end
+
+    let(:stdout) do
+      tracks.map do |track|
+        "Path:     #{track.path}\n"\
+        "Title:    #{track.title}\n"\
+        "Position: #{track.position}\n"\
+        "Artist:   #{track.artist}\n"\
+        "Album:    #{track.album}\n"\
+        "Genre:    #{track.genre}\n"\
+        "Year:     #{track.year}\n"\
+        "Comment:  #{track.comment}\n"\
+      end.join("\n")
+    end
+
+    it "should print tracks to STDOUT in the pretty format" do
+      capture_stdout { subject.class.print(tracks) }.should eq(stdout)
+    end
+  end
+end

data/spec/lib/musk/track_loader_spec.rb

@@ -0,0 +1,72 @@
+require "spec_helper"
+
+describe Musk::TrackLoader do
+  describe ".supported_formats" do
+    it "should return ['mp3']" do
+      subject.class.supported_formats.should eq(["mp3"])
+    end
+  end
+
+  describe ".supported_extensions" do
+    it "should return ['.mp3']" do
+      subject.class.supported_extensions.should eq([".mp3"])
+    end
+  end
+
+  describe ".load!(path)" do
+    context "when path.nil?" do
+      it "should raise \"Undefined path to a file or files\"" do
+        error = "Undefined path to a file or files"
+        expect { subject.class.load!(nil) }.to raise_error(error)
+      end
+    end
+
+    context "when path.empty?" do
+      it "should raise \"Undefined path to a file or files\"" do
+        error = "Undefined path to a file or files"
+        expect { subject.class.load!("") }.to raise_error(error)
+      end
+    end
+
+    context "when path is a nonexistent directory" do
+      it "should raise \"Unknown path '{path}' to a file or files\"" do
+        path = File.join(ENV["MUSK_TRACKS_PATH"], "/nonexistent")
+        error = "Unknown path '#{path}' to a file or files"
+        expect { subject.class.load!(path) }.to raise_error(error)
+      end
+    end
+
+    context "when path is an exisiting directory" do
+      it "should create tracks from files in the directory and its subdirectories" do
+        subject.class.load!(ENV["MUSK_TRACKS_PATH"]).should be_tracks([
+          build(:jets_track, :loaded),
+          build(:kamakura_track, :loaded),
+        ])
+      end
+    end
+
+    context "when path is a nonexistent file" do
+      it "should raise \"Unknown path '{path}' to a file or files\"" do
+        path = File.join(ENV["MUSK_TRACKS_PATH"], "/nonexistent.mp3")
+        error = "Unknown path '#{path}' to a file or files"
+        expect { subject.class.load!(path) }.to raise_error(error)
+      end
+    end
+
+    context "when path is an existing file that is unsupported" do
+      it "should raise \"Unknown extension '{extension}'\"" do
+        path = File.join(ENV["MUSK_TRACKS_PATH"], "/track.bad")
+        error = "Unknown extension '.bad'"
+        allow(File).to receive(:file?).with(path).and_return(true)
+        expect { subject.class.load!(path) }.to raise_error(error)
+      end
+    end
+
+    context "when path is an existing file that is supported" do
+      it "should create a track from the file" do
+        path = File.join(ENV["MUSK_TRACKS_PATH"], "/bonobo/jets.mp3")
+        subject.class.load!(path).should be_tracks([build(:jets_track, :loaded)])
+      end
+    end
+  end
+end

data/spec/lib/musk/track_printer_spec.rb

@@ -0,0 +1,22 @@
+require "spec_helper"
+
+describe Musk::TrackPrinter do
+  describe ".print!(format, tracks)" do
+    let(:tracks) { build_list(:track, 2) }
+
+    context "when format is the pretty format" do
+      it "should call Musk::Format::Pretty.print(tracks)" do
+        allow(Musk::Format::Pretty).to receive(:print).with(tracks)
+        subject.class.print!('pretty', tracks)
+        expect(Musk::Format::Pretty).to have_received(:print).with(tracks)
+      end
+    end
+
+    context "when format is an unsupported format" do
+      it "should raise \"Unknown format '{format}'\"" do
+        error = "Unknown format 'unsupported'"
+        expect { subject.class.print!('unsupported', tracks) }.to raise_error(error)
+      end
+    end
+  end
+end

data/spec/lib/musk/track_spec.rb

@@ -0,0 +1,29 @@
+require "spec_helper"
+
+describe Musk::Track do
+  it { should respond_to(:path) }
+  it { should respond_to(:path=) }
+  it { should respond_to(:title) }
+  it { should respond_to(:title=) }
+  it { should respond_to(:position) }
+  it { should respond_to(:position=) }
+  it { should respond_to(:artist) }
+  it { should respond_to(:artist=) }
+  it { should respond_to(:album) }
+  it { should respond_to(:album=) }
+  it { should respond_to(:genre) }
+  it { should respond_to(:genre=) }
+  it { should respond_to(:year) }
+  it { should respond_to(:year=) }
+  it { should respond_to(:comment) }
+  it { should respond_to(:comment=) }
+
+  describe "#attributes" do
+    it "should return a track attributes hash" do
+      track = build(:jets_track)
+      track.attributes.should eq(Hash[
+        Musk::Track::ATTRIBUTES.map {|a| [a, track.send("#{a}")]}
+      ])
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,4 +1,22 @@
-require 'bundler/setup'
-Bundler.setup
+require "simplecov"
 
-require 'musk'
+SimpleCov.start do
+  add_filter ".bundle/"
+  add_filter "spec/"
+end
+
+ENV["MUSK_TRACKS_PATH"] = File.expand_path("../support/tracks", __FILE__)
+
+require "factory_girl"
+require "open3"
+require "musk"
+
+Dir[File.expand_path("../support/**/*.rb", __FILE__)].each do |file|
+  require file
+end
+
+RSpec.configure do |config|
+  config.include FactoryGirl::Syntax::Methods
+  config.include Helpers
+  config.include Matchers
+end

data/spec/support/examples/command_to_print_tracks_to_stdout_in_pretty_format_example.rb

@@ -0,0 +1,9 @@
+shared_examples "a command to print tracks to STDOUT in the pretty format" do
+  it "should print tracks to STDOUT via Musk::Format::Pretty" do
+    path = ENV["MUSK_TRACKS_PATH"]
+    tracks = Musk::TrackLoader.load!(path)
+    stdout, stderr, status = Open3.capture3("#{expected_command} #{path}")
+    stdout.should eq(capture_stdout { Musk::Format::Pretty.print(tracks) })
+    status.exitstatus.should eq(0)
+  end
+end

data/spec/support/factories/tracks.rb

@@ -0,0 +1,32 @@
+FactoryGirl.define do
+  factory :track, class: Musk::Track do
+  end
+
+  factory :jets_track, parent: :track do
+    path File.join(ENV["MUSK_TRACKS_PATH"], "bonobo/jets.mp3")
+    title "Jets"
+    position 6
+    artist "Bonobo"
+    album "The North Borders"
+    genre "Electronic"
+    year 2013
+
+    trait :loaded do
+      comment "0"
+    end
+  end
+
+  factory :kamakura_track, parent: :track do
+    path File.join(ENV["MUSK_TRACKS_PATH"], "emancipator/kamakura.mp3")
+    title "Kamakura"
+    position 4
+    artist "Emancipator"
+    album "Safe In The Steep Cliffs"
+    genre "Electronic"
+    year 2010
+
+    trait :loaded do
+      comment "0"
+    end
+  end
+end

data/spec/support/helpers/capture_stdout_helper.rb

@@ -0,0 +1,14 @@
+require "stringio"
+
+module Helpers
+  def capture_stdout(&block)
+    begin
+      fake = StringIO.new
+      eval("$stdout = fake")
+      block.call
+      fake.string
+    ensure
+      eval("$stdout = STDOUT")
+    end
+  end
+end

data/spec/support/matchers/be_tracks_matcher.rb

@@ -0,0 +1,17 @@
+class BeTracksMatcher
+  include RSpec::Matchers
+
+  def initialize(tracks)
+    @tracks = tracks
+  end
+
+  def matches?(tracks)
+    @tracks.map(&:attributes).should =~ tracks.map(&:attributes)
+  end
+end
+
+module Matchers
+  def be_tracks(tracks = [])
+    BeTracksMatcher.new(tracks)
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: musk
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Eugene Pempel
@@ -39,47 +39,61 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0.6'
 - !ruby/object:Gem::Dependency
-  name: discogs-wrapper
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
-  type: :runtime
+        version: '0.9'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '0.9'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '2.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '2.14'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: factory_girl
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.14'
+        version: '4.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.14'
+        version: '4.4'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.8'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.8'
 description: Your music with the demonic scent of musk.
 email: eugene.pempel@gmail.com
 executables:
@@ -94,9 +108,24 @@ files:
 - README.md
 - bin/musk
 - lib/musk.rb
+- lib/musk/format/pretty.rb
+- lib/musk/track.rb
+- lib/musk/track_loader.rb
+- lib/musk/track_printer.rb
+- lib/musk/version.rb
 - musk.gemspec
-- spec/musk_spec.rb
+- spec/bin/musk_spec.rb
+- spec/lib/musk/format/pretty_spec.rb
+- spec/lib/musk/track_loader_spec.rb
+- spec/lib/musk/track_printer_spec.rb
+- spec/lib/musk/track_spec.rb
 - spec/spec_helper.rb
+- spec/support/examples/command_to_print_tracks_to_stdout_in_pretty_format_example.rb
+- spec/support/factories/tracks.rb
+- spec/support/helpers/capture_stdout_helper.rb
+- spec/support/matchers/be_tracks_matcher.rb
+- spec/support/tracks/bonobo/jets.mp3
+- spec/support/tracks/emancipator/kamakura.mp3
 homepage: https://github.com/pempel/musk
 licenses:
 - MIT

data/spec/musk_spec.rb

@@ -1,9 +0,0 @@
-require 'spec_helper'
-
-describe Musk do
-  describe '.hi' do
-    it 'should return "Hello world!"' do
-      Musk.hi.should eq("Hello world!")
-    end
-  end
-end