museo 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 60bc5ee9b6f4aed605200f5245ca3924836f287b
-  data.tar.gz: 58d82c2f85eeba82f4879eee34f822332d6a94de
+  metadata.gz: 9e891c8a0cc89e8b248947665837dba154b3ef04
+  data.tar.gz: 102b26844c89cbc800331245f904aa9ee06b219c
 SHA512:
-  metadata.gz: 3d7a17efaed956c60bcedf7a90f9a093c31203d466e513c2b537b60363cc75ed0edd77ac44eeea6d9de0c6d075bd69a064a5bc4738d00a43e365b5d9c67dcbc9
-  data.tar.gz: 3038f4dd38797022f8480b70e8ce42b78c508dfcea248ac91566ea2aff65a84737d921cc6e0d5e28cc7a880eabb48548699420bbdede72e0923f8ecae8a2f971
+  metadata.gz: 4d1a3ce1ba8a7fc7d5080d2ab438e6765dc698d6ae66b15d5b2afc811b30344f00af0145b42fefc409ae9a3652ece0c7e17e862d4a747ca3f283f1f19d4974fd
+  data.tar.gz: c653d3c0d92891ec6c0ddc2ba241167e9a85e87facbc8fe1c1d9932ab994e52c25dad7b91011834cde457f13f7ee06213205cba73f0e30633a0ce5c205085e8a

data/README.md

@@ -1,10 +1,10 @@
-# Museo
+# Museo [![Build Status](https://travis-ci.org/danielma/museo.svg?branch=master)](https://travis-ci.org/danielma/museo)
 
-[![Build Status](https://travis-ci.org/danielma/museo.svg?branch=master)](https://travis-ci.org/danielma/museo)
+Museo is a library that provides snapshot testing utilities for Rails (>= 4) views.
 
-Welcome to your new gem! In this directory, you'll find the files you need to be able to package up your Ruby library into a gem. Put your Ruby code in the file `lib/museo`. To experiment with that code, run `bin/console` for an interactive prompt.
+Snapshot testing is a form of regression testing where the output of your views (given a set of state) is written to a file and compared against the historical version during testing. Any time there is a change in the rendered output of your views, Museo will show you the diff and cause your tests to fail. If the changes you see are what you expected, you can remove the previous version of the snapshot and make the new version the canonical output.
 
-TODO: Delete this and the text above, and describe your gem
+It supports Minitest and RSpec (2, 3).
 
 ## Installation
 
@@ -24,7 +24,361 @@ Or install it yourself as:
 
 ## Usage
 
-TODO: Write usage instructions here
+### Configuration
+
+`config/initializers/museo.rb`
+
+```ruby
+Museo.configure do |config|
+  # Configure Museo to use RSpec (automatically set to true if spec directory exists)
+  config.rspec = true
+  
+  # Stub the `render` method inside views
+  config.stub(:render) do |options = {}, block = nil|
+    options[:content] = capture(&block) if block
+    options
+  end
+end
+```
+
+### CLI
+
+The `museo` CLI has 2 commands: `list` and `clear`
+
+```bash
+$ museo help
+Commands:
+  museo clear [MATCHER]  # Clear snapshots that match MATCHER
+  museo help [COMMAND]   # Describe available commands or one specific command
+  museo list [MATCHER]   # List snapshots that match MATCHER
+```
+
+## Getting Started
+
+Museo makes a custom testing command available to your controller tests to save and compare snapshots.
+
+These examples will be written with Minitest, but there are examples below for how to work with RSpec as well.
+
+Let's start with a simple setup and write some snapshot tests.
+
+`app/controllers/products_controller.rb`
+
+```ruby
+class ProductsController < ApplicationController
+  def index
+    @products = Product.all
+  end
+end
+```
+
+`app/views/products/index.html.erb`
+
+```erb
+<h1 class="page-title">Products</h1>
+
+<%= render partial: "product", collection: @products %>
+```
+
+`app/views/products/_product.html.erb`
+
+```erb
+<div class="product">
+  <strong><%= product.name %></strong>
+  <% if product.discounted? %>
+    <div>
+      Price: <strike><%= number_to_currency product.price %></strike>
+      <%= number_to_currency product.discounted_price %>
+    </div>
+    <div><%= product.discount_percentage %><sup>%</sup> off!</div>
+  <% else %>
+    <div>
+      Price: <%= number_to_currency product.price %>
+    </div>
+  <% end %>
+</div>
+```
+
+It looks like this
+
+![Initial State](screenshots/initial-state.png)
+
+Now, let's do some snapshot tests
+
+First, include `Museo::RSpecIntegration` and write your first snapshot
+
+```ruby
+class ProductsController < ActionController::TestCase
+  include Museo::MinitestIntegration
+  
+  describe "GET #index" do
+    snapshot "with no params" do
+      get :index
+    end
+  end
+end
+```
+
+Then run the tests
+
+```bash
+$ bundle exec rspec
+Run options: include {:focus=>true}
+
+All examples were filtered out; ignoring {:focus=>true}
+
+Randomized with seed 36544
+
+ProductsController
+  GET #index
+Updated snapshot for "matches_snapshot_with_no_params.snapshot"
+    matches snapshot: with no params
+
+Top 1 slowest examples (0.04054 seconds, 98.4% of total time):
+  ProductsController GET #index matches snapshot: with no params
+    0.04054 seconds
+
+Finished in 0.04118 seconds (files took 1.41 seconds to load)
+1 example, 0 failures
+
+Randomized with seed 36544
+```
+
+Notice where it says `Updated snapshot for "matches_snapshot_with_no_params.snapshot". This means there was no previous snapshot file and Museo generated a new one.
+
+Museo uses a special layout file that includes the contents of every `content_for` block, so your snapshots will not break for layout changes, but will break for any change of a `content_for` block.
+
+```bash
+$ tree spec/snapshots
+spec/snapshots
+└── ProductsController
+    └── matches_snapshot_with_no_params.snapshot
+
+1 directory, 1 file
+```
+
+Now we have our first snapshot! Let's make some changes to our template and see what happens.
+
+`app/views/products/index.html.erb`
+
+```erb
+<h1 class="title">Products</h1>
+
+<hr />
+
+<%= render partial: "product", collection: @products %>
+```
+
+```bash
+$ bundle exec rspec
+Run options: include {:focus=>true}
+
+All examples were filtered out; ignoring {:focus=>true}
+
+Randomized with seed 60210
+
+ProductsController
+  GET #index
+    matches snapshot: with no params (FAILED - 1)
+
+Failures:
+
+  1) ProductsController GET #index matches snapshot: with no params
+     Failure/Error: DEFAULT_FAILURE_NOTIFIER = lambda { |failure, _opts| raise failure }
+
+       Snapshot did not match
+       Diff:
+       @@ -1,6 +1,8 @@
+        <!-- content_for layout -->
+
+       -<h1 class="page-title">Products</h1>
+       +<h1 class="title">Products</h1>
+       +
+       +<hr />
+
+        <div class="product">
+          <strong>Westworld Season 1 Blu-Ray</strong>
+```
+
+Now we have an error letting us know that our snapshot didn't match.
+
+If the diff is correct, we can clear out the old snapshot and regenerate it using the CLI tool
+
+```bash
+$ bundle exec museo clear ProductsController
+Directory: /Users/danielma/Code/test/museo-example/test/snapshots/ProductsController
+
+matches_snapshot_with_no_params.snapshot
+Removing snapshots
+```
+
+Now that the snapshots are cleared, run the tests again to regenerate the snapshots.
+
+```bash
+$ bundle exec rspec
+Run options: include {:focus=>true}
+
+All examples were filtered out; ignoring {:focus=>true}
+
+Randomized with seed 6462
+
+ProductsController
+  GET #index
+Updated snapshot for "matches_snapshot_with_no_params.snapshot"
+    matches snapshot: with no params
+```
+
+Include your snapshots in your version control repo for accurate history
+
+### How can Museo help?
+
+Let's say you decide to change some logic in your `_product.html.erb` partial. Museo can help you make sure the output is exactly what you expect.
+
+In our `_product.html.erb`, we want to move the block for a non-discounted product above the block for a discounted product. We'll need a logic change.
+
+`app/views/products/_product.html.erb`
+
+```erb
+<div class="product">
+  <strong><%= product.name %></strong>
+  <% if product.discounted? %>
+    <div>
+      Price: <%= number_to_currency product.price %>
+    </div>
+  <% else %>
+    <div>
+      Price: <strike><%= number_to_currency product.price %></strike>
+      <%= number_to_currency product.discounted_price %>
+    </div>
+    <div><%= product.discount_percentage %><sup>%</sup> off!</div>
+  <% end %>
+</div>
+
+```
+
+```bash
+$ bundle exec rspec
+```
+
+This command should include this failure:
+
+```
+Failures:
+
+  1) ProductsController GET #index matches snapshot: with no params
+     Failure/Error: DEFAULT_FAILURE_NOTIFIER = lambda { |failure, _opts| raise failure }
+
+       Snapshot did not match
+       Diff:
+
+
+
+       @@ -7,16 +7,16 @@
+        <div class="product">
+          <strong>Westworld Season 1 Blu-Ray</strong>
+            <div>
+       -      Price: <strike>$40.00</strike>
+       -      $36.00
+       +      Price: $40.00
+            </div>
+       -    <div>10<sup>%</sup> off!</div>
+        </div>
+        <div class="product">
+          <strong>1 Week in Samurai World</strong>
+            <div> 
+       -      Price: $280,000.00
+       +      Price: <strike>$280,000.00</strike>
+       +      $280,000.00
+            </div>
+       +    <div><sup>%</sup> off!</div>
+        </div>
+```
+
+Hmmm, we didn't expect the snapshot to break in this case. We only wanted to change the way the file was written. Looks like the logic in our most recent change is broken.
+
+We can fix it by changing `<% if product.discounted? %>` to `<% unless product.discounted? %>`
+
+`app/views/products/_product.html.erb`
+
+```erb
+<div class="product">
+  <strong><%= product.name %></strong>
+  <% unless product.discounted? %>
+    <div>
+      Price: <%= number_to_currency product.price %>
+    </div>
+  <% else %>
+    <div>
+      Price: <strike><%= number_to_currency product.price %></strike>
+      <%= number_to_currency product.discounted_price %>
+    </div>
+    <div><%= product.discount_percentage %><sup>%</sup> off!</div>
+  <% end %>
+</div>
+```
+
+And now, `bundle exec rspec` passes!
+
+We have successfully made a change in our template without breaking the expected output.
+
+### Advanced Usage
+
+#### Stubbing methods in your views
+
+In some cases, you may not desire to include the output from certain helpers in your snapshots. For example, if you are using the `react_rails` gem, you may not want to include the output from the `react_component` helper.
+
+We can stub this method in the Museo configuration
+
+`config/initializers/museo.rb`
+
+```ruby
+Museo.configure do |config|
+  config.stub(:react_component) do |name, *_|
+    name
+  end
+end
+```
+
+And use the helper in `views/products/index.html.erb`
+
+```erb
+<h1 class="title">Products</h1>
+
+<hr />
+
+<%= render partial: "product", collection: @products %>
+
+<%= react_component "Components.Products", products: @products %>
+```
+
+Now, when we run `bundle exec rspec`, our new snapshots will no longer include the contents of the helper, but only the arguments we returned from our stub block.
+
+```
+Failures:
+
+  1) ProductsController GET #index matches snapshot: with no params
+     Failure/Error: DEFAULT_FAILURE_NOTIFIER = lambda { |failure, _opts| raise failure }
+
+       Snapshot did not match
+       Diff:
+       @@ -20,6 +20,12 @@
+        </div>
+
+
+       +<!--
+       +Stubbed method call: react_component
+       +Components.Products
+       +-->
+       +
+       +
+
+        <!-- end layout -->
+```
+
+This allows us to snapshot views without the output from noisy helpers (eg `render partial:` etc)
+
+## Prior Art
+
+This library was inspired by [Jest Snapshot Testing](https://facebook.github.io/jest/blog/2016/07/27/jest-14.html). It wouldn't be here without the Jest team's hard work.
 
 ## Development
 
@@ -34,5 +388,5 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/museo.
+Bug reports and pull requests are welcome on GitHub at https://github.com/danielma/museo.
 

data/exe/museo

@@ -4,4 +4,4 @@
 require "museo"
 require "museo/cli"
 
-Museo::CLI.new(*ARGV)
+Museo::CLI.start(ARGV)

data/lib/museo.rb

@@ -47,7 +47,7 @@ module Museo
 
     def initialize
       @formatter = Museo::Formatter.new
-      @rspec = false
+      @rspec = File.directory?(Museo.rails_root.join("spec"))
       @generation_disabled = !!ENV["CI"]
     end
 

data/lib/museo/cli.rb

@@ -1,19 +1,9 @@
-module Museo
-  class CLI
-    def initialize(command = nil, *argv)
-      case command.to_s.strip.downcase
-      when "clear"
-        clear(argv.first)
-      when "list"
-        list(argv.first)
-      when ""
-        puts "Please add a command"
-      else
-        puts "Don't know how to do command: #{command}"
-      end
-    end
+require "thor"
 
-    def list(matcher)
+module Museo
+  class CLI < Thor
+    desc "list [MATCHER]", "List snapshots that match MATCHER"
+    def list(matcher = nil)
       directory = find_directory(matcher)
 
       if File.directory?(directory)
@@ -24,7 +14,8 @@ module Museo
       end
     end
 
-    def clear(matcher)
+    desc "clear [MATCHER]", "Clear snapshots that match MATCHER"
+    def clear(matcher = nil)
       list(matcher)
       directory_to_clear = find_directory(matcher)
 

data/lib/museo/rspec_integration.rb

@@ -1,5 +1,5 @@
 module Museo
-  module RspecIntegration
+  module RSpecIntegration
     include TestIntegration
 
     def self.included(base)
@@ -24,10 +24,10 @@ module Museo
     end
 
     def expect_matching_snapshot(example)
-      expect(Snapshot::Rspec.new(self, example.metadata).body).to(
-        eq(Snapshot.sanitize_response(response.body)),
-        "Snapshot did not match",
-      )
+      snapshot = Snapshot::Rspec.new(self, example.metadata)
+      response_body = Snapshot.sanitize_response(response.body)
+
+      expect(response_body).to eq(snapshot.body), "Snapshot did not match"
     end
   end
 end

data/lib/museo/version.rb

@@ -1,3 +1,3 @@
 module Museo
-  VERSION = "0.1.0"
+  VERSION = "0.2.0".freeze
 end

data/museo.gemspec

@@ -19,6 +19,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency "rails", ">= 4", "< 5.1"
+  spec.add_dependency "thor"
   spec.add_development_dependency "appraisal"
   spec.add_development_dependency "rubocop", "~> 0.42"
   spec.add_development_dependency "rspec"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: museo
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Daniel Ma
@@ -30,6 +30,20 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '5.1'
+- !ruby/object:Gem::Dependency
+  name: thor
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement
@@ -195,6 +209,7 @@ files:
 - lib/museo/version.rb
 - lib/tasks/museo_tasks.rake
 - museo.gemspec
+- screenshots/initial-state.png
 homepage: https://github.com/danielma/museo
 licenses: []
 metadata: {}