mumukit-nuntius 0.3.5 → 0.3.6

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    YTczODQ4ZTZlYmEyYTg4YTMyZGE3ZTIwOTgyNTc4MGIwM2U4NDViYQ==
+    YTFmZGNmN2RmOGY2MDNhZjA5NDhmMzAxZmFkNDFiNTkxZjI0NzU0Yg==
   data.tar.gz: !binary |-
-    OTUwNmIwN2M2NTZhZDUzZDEwYmI2Yzc5ZTZiZTA4NTZkNDRlMzZmYw==
+    N2Q3ZWNkNGEyMWNkMjQ5ZTdhMjYwMzg5NTlmYzFlZGFjN2Y1OTlmYQ==
 SHA512:
   metadata.gz: !binary |-
-    NzQ0NDU1ZjFkOGM3MjcwMDc5ZWZkYzFhZGFlZGM3ZGViMzBjYTNhOTk4OTJl
-    MjQxZDZjMDkxZDEyZjNjMmZiZWQzNTA0YjU4NTc5NzYxZDFkZWRlMmRjMjUz
-    OTgyMjUxNjI4ZDRlMWMxNWNhNDFmZDdjYzc1NWFlNDkyZTNmMmU=
+    ZTY3NjVlOGEyZTQ3MDg5NTY0MDQ5NGU4MzQwODg1MTZiZTliNzNiOWQ0MTgw
+    NzM2Y2M5ZDM4NmYzZmFkMWE5ZTllZmU1NTM2YTNiNDQzOTA1MWQyMTg4ZDc3
+    MTI3Y2Q2MmYxODk4Njc2NWVhNTI1ZTYwOTY3MTdmOGYwYWRlNDk=
   data.tar.gz: !binary |-
-    ZjAzODVmYjRkNDNiOGM2MWIxNzY1Nzc1YzZhNTViMWNkNDM0ZDg1MjIwZGFi
-    MjIwYjA2ZWNlNTg1MjQ2YjMwYmY1ZmI5MjVlZTBjOGNiYWU1ZWY5N2NhZDRh
-    NTEzZWMxODNlMmUwZTM0MTY1YzZiM2UwZjcwMzEwMWY1YmY4OWU=
+    ZGM3NzA3YjdlNmU2MzMxYzViZDhlNjE0NzIxNjNhMmJhMWZmZTA4MzBjYWVl
+    YjNjOWNkMTU0Zjc2ZWE5NTgwYWE5ZTJjYjZjMTJhYTkyZjI1YTkyYjk2YjAy
+    MDY2ZDFmYTQ1YTJjZjQ0ZTU3ZjlhNzQwZTY4ODNkMzFhN2MwOWU=

data/lib/mumukit/nuntius/command_consumer.rb

@@ -5,17 +5,31 @@ module Mumukit::Nuntius::CommandConsumer
     def start(name)
       Mumukit::Nuntius::Consumer.start "#{name}-commands" do |_delivery_info, _properties, body|
         begin
-          choose_command(name, body['type']).execute!(body['data'])
+          choose_command(name, body).execute!(body['data'])
+        rescue NoMethodError => e
+          log_exception(name, body, e)
         rescue NameError => e
-          Mumukit::Nuntius::Logger.info "Command #{name}-#{body['type']} does not exists."
+          log_unkown_command(name, body)
         rescue => e
-          Mumukit::Nuntius::Logger.info "Failed to proccess #{choose_command(name, body['type'])}, error was: #{e}"
+          log_exception(name, body, e)
         end
       end
     end
 
-    def choose_command(name, type)
-      "#{name.capitalize}::Command::#{type}".constantize
+    def choose_command(name, body)
+      command_name(name, body).constantize
+    end
+
+    def command_name(name, body)
+      "#{name.capitalize}::Command::#{body['type']}"
+    end
+
+    def log_unkown_command(name, body)
+      Mumukit::Nuntius::Logger.error "#{command_name(name, body)} does not exists."
+    end
+
+    def log_exception(name, body, e)
+      Mumukit::Nuntius::Logger.error "Failed to proccess #{command_name(name, body)}, error was: #{e}"
     end
   end
 end

data/lib/mumukit/nuntius/consumer.rb

@@ -1,6 +1,6 @@
 module Mumukit::Nuntius::Consumer
 
-	class << self
+  class << self
 
     def start(queue_name, &block)
       Mumukit::Nuntius::Logger.info "Attaching to queue #{queue_name}"
@@ -12,7 +12,7 @@ module Mumukit::Nuntius::Consumer
         subscribe queue, channel, &block
       rescue Interrupt => _
         Mumukit::Nuntius::Logger.info "Leaving queue #{queue_name}"
-
+      ensure
         channel.close
         connection.close
       end
@@ -34,5 +34,5 @@ module Mumukit::Nuntius::Consumer
         end
       end
     end
-	end
+  end
 end

data/lib/mumukit/nuntius/version.rb

@@ -1,5 +1,5 @@
 module Mumukit
   module Nuntius
-    VERSION = '0.3.5'
+    VERSION = '0.3.6'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mumukit-nuntius
 version: !ruby/object:Gem::Version
-  version: 0.3.5
+  version: 0.3.6
 platform: ruby
 authors:
 - Agustin Pina
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-29 00:00:00.000000000 Z
+date: 2016-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler