mumukit-inspection 3.2.2 → 3.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7c005d5902532da87f612d5903ece6b7c98bc7a5f2fdcc7f76b281cfd6e3d1e4
-  data.tar.gz: 0c68ea92915d099b433311e0d11ac4844e31a12161cf254d724935190d11c661
+  metadata.gz: feb649a8c2e6d1b9b769beb9cf4ecd42667993067d23e4b8a2c40ae1dba781c2
+  data.tar.gz: 52e00995250243165bff626c312c5a0d5d9d8c52d48f6d24e8f030327a09e871
 SHA512:
-  metadata.gz: 3f99058bb1ac09069318fa6df9d837c976ed892ec932155a238b5a8a006991049e7707f0c1d7aab9078ed68da1abdf58f4d405821a61cbe651a2b990757d89e6
-  data.tar.gz: 316e9fc94470f3acdda0f723ae0b40435713814bcc461218cd96b8d0b80d6db31ba24b0de6ae2af9723389606e168b0f2de35301879dbf0eff42a1fd30e2eca4
+  metadata.gz: 7d06c4c283362b4df27c9e460281b58301846eb2644cd3565d9a60a9ab4e41b5cbf251e15cf2b6c75dbde7a0a34e429af2d2cd63f98f77eab7d9263a41ca4a12
+  data.tar.gz: eeba96816dcbfb20a276fc7df07c88f0c4c20009e16479859c22750025707d917b86a9a015347ec01d39a9047476b41f230021e17e881c7a3a759bf1c897263d

data/lib/locales/en.yml

@@ -80,25 +80,28 @@ en:
   expectation_DeclaresVariable_except: '%{binding} %{must} declare variables distinct from %{target}'
   expectation_DeclaresVariable_like: '%{binding} %{must} declare a variable similar to %{target}'
   expectation_DeclaresVariable_named: '%{binding} %{must} declare a variable %{target}'
-  expectation_DoesNullTest: '%{binding} does null tests'
+  expectation_DoesNilTest: '%{binding} does <i>%{keyword_null}</i> tests'
+  expectation_DoesNullTest: '%{binding} does <i>%{keyword_null}</i> tests'
   expectation_DoesTypeTest: '%{binding} string type tests'
   expectation_HasAssignmentReturn: '%{binding} returns the result of an assignment'
   expectation_HasCodeDuplication: '%{binding} has code duplication'
-  expectation_HasEmptyIfBranches: '%{binding} has empty if branches'
+  expectation_HasEmptyIfBranches: '%{binding} has empty <i>%{keyword_if}</i> branches'
   expectation_HasMisspelledBindings: '%{binding} is misspelled'
   expectation_HasRedundantBooleanComparison: '%{binding} makes unnecesary boolean comparisons'
   expectation_HasRedundantGuards: '%{binding} has unnecessary guards'
-  expectation_HasRedundantIf: '%{binding} has unnecessary ifs'
+  expectation_HasRedundantIf: '%{binding} has unnecessary <i>%{keyword_if}</i>s'
   expectation_HasRedundantLambda: '%{binding} has unnecessary lambdas'
   expectation_HasRedundantLocalVariableReturn: '%{binding} has unnecesary local variables; please try returning the expression directly'
   expectation_HasRedundantParameter: '%{binding} has unnecessary parameters, that can be removed using point-free'
-  expectation_HasRedundantReduction: '%{binding} uses <i>is</i>, but it does not artihmetic.'
+  expectation_HasRedundantReduction: '%{binding} uses <i>%{keyword_is}</i>, but it does not artihmetic.'
   expectation_HasTooShortBindings: '%{binding} is a too short identifier'
+  expectation_HasUnreachableCode: '%{binding} has unreachable code.'
   expectation_HasWrongCaseBindings: '%{binding} does not honor case conventions'
   expectation_IsLongCode: '%{binding} is too long'
   expectation_must: must
   expectation_must_not: must not
-  expectation_ReturnsNull: '%{binding} retuns null, which is a bad practice'
+  expectation_ReturnsNil: '%{binding} retuns <i>%{keyword_null}</i>, which is a bad practice'
+  expectation_ReturnsNull: '%{binding} retuns <i>%{keyword_null}</i>, which is a bad practice'
   expectation_solution: solution
   expectation_TypesAs: '%{binding} %{must} type'
   expectation_TypesAs_named: '%{binding} %{must} type as %{target}'
@@ -111,17 +114,17 @@ en:
   expectation_UsesComprehension: '%{binding} %{must} use comprehensions'
   expectation_UsesConditional: '%{binding} %{must} use conditionals'
   expectation_UsesCut: '%{binding} uses <i>!</li> operator, which is a bad practice'
-  expectation_UsesFail: '%{binding} uses <i>fail</li>, which is a bad practice'
-  expectation_UsesFindall: '%{binding} %{must} use findall'
-  expectation_UsesForall: '%{binding} %{must} use forall'
-  expectation_UsesForeach: '%{binding} %{must} use foreach'
+  expectation_UsesFail: '%{binding} uses <i>%{keyword_fail}</li>, which is a bad practice'
+  expectation_UsesFindall: '%{binding} %{must} use <i>%{keyword_findall}</i>'
+  expectation_UsesForall: '%{binding} %{must} use <i>%{keyword_forall}</i>'
+  expectation_UsesForeach: '%{binding} %{must} use <i>%{keyword_foreach}</i>'
   expectation_UsesGuards: '%{binding} %{must} use guards'
-  expectation_UsesIf: '%{binding} %{must} use if'
+  expectation_UsesIf: '%{binding} %{must} use <i>%{keyword_if}</i>'
   expectation_UsesLambda: '%{binding} %{must} use lambda expressions'
   expectation_UsesNot: '%{binding} %{must} use not'
   expectation_UsesPatternMatching: '%{binding} %{must} use pattern matching'
-  expectation_UsesRepeat: '%{binding} %{must} use repeat'
-  expectation_UsesRepeatOf: '%{binding} %{must} use repeat'
-  expectation_UsesSwitch: '%{binding} %{must} use a switch'
+  expectation_UsesRepeat: '%{binding} %{must} use <i>%{keyword_repeat}</i>'
+  expectation_UsesRepeatOf: '%{binding} %{must} use <i>%{keyword_repeat}</i>'
+  expectation_UsesSwitch: '%{binding} %{must} use a <i>%{keyword_switch}</i>'
   expectation_UsesUnificationOperator: '%{binding} uses the unification operator (=)'
-  expectation_UsesWhile: '%{binding} %{must} use while'
+  expectation_UsesWhile: '%{binding} %{must} use <i>%{keyword_while}</i>'

data/lib/locales/es.yml

@@ -94,11 +94,12 @@ es:
   expectation_DeclaresVariable_named: '%{binding} %{must} declarar una variable %{target}'
   expectation_DiscardsExceptions: '%{binding} está ignorando exceptiones silenciosamiente.'
   expectation_DoesConsolePrint: '%{binding} está realizando impresiones por pantalla.'
-  expectation_DoesNullTest: '%{binding} hace comparaciones contra <i>null</i>'
+  expectation_DoesNilTest: '%{binding} hace comparaciones contra <i>%{keyword_null}</i>'
+  expectation_DoesNullTest: '%{binding} hace comparaciones contra <i>%{keyword_null}</i>'
   expectation_DoesTypeTest: '%{binding} hace comparaciones contra strings'
   expectation_HasAssignmentReturn: '%{binding} devuelve el resultado de una asignación'
   expectation_HasCodeDuplication: '%{binding} tiene código repetido'
-  expectation_HasEmptyIfBranches: '%{binding} tiene ramas de <i>if</i> vacías'
+  expectation_HasEmptyIfBranches: '%{binding} tiene ramas de <i>%{keyword_if}</i> vacías'
   expectation_HasMisspelledBindings: '%{binding} está mal escrito. Revisá la ortografía y procurá no usar abreviaturas'
   expectation_HasMisspelledIdentifiers: '%{binding} está mal escrito. Revisá la ortografía y procurá no usar abreviaturas'
   expectation_HasRedundantBooleanComparison: '%{binding} hace comparaciones booleanas innecesarias'
@@ -107,9 +108,10 @@ es:
   expectation_HasRedundantLambda: '%{binding} tiene lambdas innecesarias'
   expectation_HasRedundantLocalVariableReturn: '%{binding} usa variables locales innecesarias; podés retornar directamente la expresión'
   expectation_HasRedundantParameter: '%{binding} tiene parámetros innecesarios (se pueden eliminar mediante point-free)'
-  expectation_HasRedundantReduction: '%{binding} usa <i>is</i>, pero no realiza cálculos.'
+  expectation_HasRedundantReduction: '%{binding} usa <i>%{keyword_is}</i>, pero no realiza cálculos.'
   expectation_HasTooShortBindings: '%{binding} es un identificador muy corto'
   expectation_HasTooShortIdentifiers: '%{binding} es un identificador muy corto'
+  expectation_HasUnreachableCode: '%{binding} tiene código inalcanzable.'
   expectation_HasWrongCaseBindings: '%{binding} no respeta la convención de nombres'
   expectation_HasWrongCaseIdentifiers: '%{binding} no respeta la convención de nombres'
   expectation_Implements: '%{binding} %{must} implementar intefaces'
@@ -135,6 +137,7 @@ es:
   expectation_Rescues_except: '%{binding} %{must} capturar excepciones diferentes a %{target}'
   expectation_Rescues_like: '%{binding} %{must} capturar excepciones parecidas a %{target}'
   expectation_Rescues_named: '%{binding} %{must} capturar %{target}'
+  expectation_ReturnsNil: '%{binding} retorna null, lo cual es una mala práctica'
   expectation_ReturnsNull: '%{binding} retorna null, lo cual es una mala práctica'
   expectation_solution: la solución
   expectation_TypesAs: '%{binding} %{must} tipar'
@@ -150,19 +153,19 @@ es:
   expectation_UsesCut: '%{binding} usa el operador !, lo cual es una mala práctica'
   expectation_UsesExceptionHandling: '%{binding} %{must} realizar manejo de exceptiones'
   expectation_UsesExceptions: '%{binding} %{must} usar exceptiones'
-  expectation_UsesFail: '%{binding} usa <i>fail</li>, lo cual es una mala práctica'
-  expectation_UsesFindall: '%{binding} %{must} utilizar <i>findall</i>'
-  expectation_UsesForall: '%{binding} %{must} utilizar <i>forall</i>'
-  expectation_UsesForeach: '%{binding} %{must} usar <i>foreach</i>'
+  expectation_UsesFail: '%{binding} usa <i>%{keyword_fail}</li>, lo cual es una mala práctica'
+  expectation_UsesFindall: '%{binding} %{must} utilizar <i>%{keyword_findall}</i>'
+  expectation_UsesForall: '%{binding} %{must} utilizar <i>%{keyword_forall}</i>'
+  expectation_UsesForeach: '%{binding} %{must} usar <i>%{keyword_foreach}</i>'
   expectation_UsesGuards: '%{binding} %{must} usar guardas'
-  expectation_UsesIf: '%{binding} %{must} usar <i>if</i>'
+  expectation_UsesIf: '%{binding} %{must} usar <i>%{keyword_if}</i>'
   expectation_UsesInheritance: '%{binding} %{must} usar herencia'
   expectation_UsesLambda: '%{binding} %{must} emplear expresiones lambda'
   expectation_UsesMixins: '%{binding} %{must} usar mixins'
-  expectation_UsesNot: '%{binding} %{must} utilizar <i>not</i>'
+  expectation_UsesNot: '%{binding} %{must} utilizar <i>%{keyword_not}</i>'
   expectation_UsesPatternMatching: '%{binding} %{must} utilizar pattern matching'
-  expectation_UsesRepeat: '%{binding} %{must} usar <i>repeat</i>'
-  expectation_UsesRepeatOf: '%{binding} %{must} usar un <i>repeat</i> de %{target}'
-  expectation_UsesSwitch: '%{binding} %{must} utilizar un <i>switch</i>'
+  expectation_UsesRepeat: '%{binding} %{must} usar <i>%{keyword_repeat}</i>'
+  expectation_UsesRepeatOf: '%{binding} %{must} usar un <i>%{keyword_repeat}</i> de %{target}'
+  expectation_UsesSwitch: '%{binding} %{must} utilizar un <i>%{keyword_switch}</i>'
   expectation_UsesUnificationOperator: '%{binding} usa el operador de unificación (=)'
-  expectation_UsesWhile: '%{binding} %{must} utilizar un <i>while</i>'
+  expectation_UsesWhile: '%{binding} %{must} utilizar un <i>%{keyword_while}</i>'

data/lib/locales/pt.yml

@@ -24,7 +24,7 @@ pt:
   expectation_DeclaresComputation_except: '%{binding} %{must} declarar cálculos diferentes de %{target}'
   expectation_DeclaresComputation_like: '%{binding} %{must} declarar uma computação semelhante a %{target}'
   expectation_DeclaresComputation_named: '%{binding} %{must} declarar uma computação %{target}'
-  expectation_HasEmptyIfBranches: '%{binding} tem vazio <i>if</i> ramos'
+  expectation_HasEmptyIfBranches: '%{binding} tem vazio <i>%{keyword_if}</i> ramos'
   expectation_DeclaresComputationWithArity0_named: '%{target} %{must} declarar parâmetros zero'
   expectation_DeclaresComputationWithArity1_named: '%{target} %{must} tem um parâmetro'
   expectation_DeclaresComputationWithArity2_named: '%{target} %{must} tem dois parâmetros'
@@ -95,7 +95,8 @@ pt:
   expectation_DeclaresVariable_named: '%{binding} %{must} declarar uma variável %{target}'
   expectation_DiscardsExceptions: '%{binding}  está silenciosamente ignorando exceções.'
   expectation_DoesConsolePrint: '%{binding}  está fazendo impressões na tela.'
-  expectation_DoesNullTest: '%{binding}  faz comparações contra <i>null</i>'
+  expectation_DoesNilTest: '%{binding}  faz comparações contra <i>%{keyword_null}</i>'
+  expectation_DoesNullTest: '%{binding}  faz comparações contra <i>%{keyword_null}</i>'
   expectation_DoesTypeTest: '%{binding}  faz comparações contra strings'
   expectation_HasAssignmentReturn: '%{binding}  retorna o resultado de uma tarefa'
   expectation_HasCodeDuplication: '%{binding}  tem código repetido'
@@ -107,9 +108,11 @@ pt:
   expectation_HasRedundantLambda: '%{binding}  possui lambdas desnecessários'
   expectation_HasRedundantLocalVariableReturn: '%{binding}  usa variáveis ​​locais desnecessárias; você pode retornar a expressão diretamente'
   expectation_HasRedundantParameter: '%{binding}  possui parâmetros desnecessários (pode ser removido por ponto-livre)'
-  expectation_HasRedundantReduction: '%{binding}  usa <i>is</i>, mas não executa cálculos.'
+  expectation_HasRedundantReduction: '%{binding}  usa <i>%{keyword_is}</i>, mas não executa cálculos.'
   expectation_HasTooShortBindings: '%{binding}  é um identificador muito curto'
   expectation_HasTooShortIdentifiers: '%{binding}  é um identificador muito curto'
+  expectation_HasTooShortIdentifiers: '%{binding}  é um identificador muito curto'
+  expectation_HasUnreachableCode: '%{binding} tem código inacessível.'
   expectation_HasWrongCaseBindings: '%{binding}  não respeita a convenção de nomenclatura'
   expectation_HasWrongCaseIdentifiers: '%{binding}  não respeita a convenção de nomenclatura'
   expectation_Implements: '%{binding} %{must} implementar interfaces'
@@ -135,6 +138,7 @@ pt:
   expectation_Rescues_except: '%{binding} %{must} capturar exceções que não sejam %{target}'
   expectation_Rescues_like: '%{binding} %{must} capturar exceções semelhantes a %{target}'
   expectation_Rescues_named: '%{binding} %{must} capture %{target}'
+  expectation_ReturnsNil: '%{binding}  retorna nulo, o que é uma prática ruim'
   expectation_ReturnsNull: '%{binding}  retorna nulo, o que é uma prática ruim'
   expectation_solution: 'a solução'
   expectation_TypesAs: '%{binding} %{must} tem tipo'
@@ -150,20 +154,20 @@ pt:
   expectation_UsesCut: '%{binding}  usa o operador !, que é uma má prática'
   expectation_UsesExceptionHandling: '%{binding} %{must} executar o tratamento de exceção'
   expectation_UsesExceptions: '%{binding} %{must} usar exceções'
-  expectation_UsesFail: '%{binding}  usa <i>fail</li>, o que é uma prática ruim'
-  expectation_UsesFindall: '%{binding} %{must} usar <i>findall</i>'
-  expectation_UsesForall: '%{binding} %{must} usar <i>forall</i>'
-  expectation_UsesForeach: '%{binding} %{must} usar <i>foreach</i>'
+  expectation_UsesFail: '%{binding}  usa <i>%{keyword_fail}</li>, o que é uma prática ruim'
+  expectation_UsesFindall: '%{binding} %{must} usar <i>%{keyword_findall}</i>'
+  expectation_UsesForall: '%{binding} %{must} usar <i>%{keyword_forall}</i>'
+  expectation_UsesForeach: '%{binding} %{must} usar <i>%{keyword_foreach}</i>'
   expectation_UsesGuards: '%{binding} %{must} usar guardas'
-  expectation_UsesIf: '%{binding} %{must} usar <i>if</i>'
+  expectation_UsesIf: '%{binding} %{must} usar <i>%{keyword_if}</i>'
   expectation_UsesInheritance: '%{binding} %{must} usar herança'
   expectation_UsesLambda: '%{binding} %{must} usar expressões lambda'
   expectation_UsesMixins: '%{binding} %{must} usar mixins'
-  expectation_UsesNot: '%{binding} %{must} usar <i>not</i>'
+  expectation_UsesNot: '%{binding} %{must} usar <i>%{keyword_not}</i>'
   expectation_UsesPatternMatching: '%{binding} %{must} usar o padrão de correspondência'
-  expectation_UsesRepeat: '%{binding} %{must} usar <i>repeat</i>'
-  expectation_UsesRepeatOf: '%{binding} %{must} usar uma <i>repeat</i> de %{target}'
-  expectation_UsesSwitch: '%{binding} %{must} usar um switch'
+  expectation_UsesRepeat: '%{binding} %{must} usar <i>%{keyword_repeat}</i>'
+  expectation_UsesRepeatOf: '%{binding} %{must} usar uma <i>%{keyword_repeat}</i> de %{target}'
+  expectation_UsesSwitch: '%{binding} %{must} usar um <i>%{keyword_switch}</i>'
   expectation_UsesUnificationOperator: '%{binding}  usa o operador de unificação (=)'
-  expectation_UsesWhile: '%{binding} %{must} usar um <i>while</i>'
+  expectation_UsesWhile: '%{binding} %{must} usar um <i>%{keyword_while}</i>'
 

data/lib/mumukit/inspection/expectation.rb

@@ -3,7 +3,8 @@ class Mumukit::Inspection::Expectation
   SMELLS = %w(HasAssignmentReturn HasCodeDuplication HasEmptyIfBranches HasMisspelledIdentifiers
               HasRedundantBooleanComparison HasRedundantGuards HasRedundantIf
               HasRedundantLambda HasRedundantLocalVariableReturn HasRedundantParameter
-              HasRedundantReduction HasTooShortIdentifiers HasWrongCaseIdentifiers)
+              HasRedundantReduction HasTooShortIdentifiers HasWrongCaseIdentifiers
+              HasUnreachableCode)
 
   attr_accessor :binding, :inspection
 
@@ -17,8 +18,8 @@ class Mumukit::Inspection::Expectation
     raise "Wrong inspection #{to_h}" unless inspection?
   end
 
-  def translate
-    Mumukit::Inspection::I18n.translate self
+  def translate(keywords = nil)
+    Mumukit::Inspection::I18n.translate self, keywords
   end
 
   def to_h

data/lib/mumukit/inspection/i18n.rb

@@ -1,12 +1,23 @@
 module Mumukit::Inspection::I18n
   class << self
-    def translate(e)
+    DEFAULT_KEYWORDS = {
+      keyword_null: :null,
+      keyword_if: :if,
+      keyword_is: :is,
+      keyword_fail: :fail,
+      keyword_findall: :findall,
+      keyword_forall: :forall,
+      keyword_foreach: :foreach,
+      keyword_not: :not,
+      keyword_repeat: :repeat,
+      keyword_switch: :switch,
+      keyword_while: :while,
+    }
+
+    def translate(e, keywords = nil)
       e = e.as_v2
       key = key_for e.binding, e.inspection
-      ::I18n.t key,
-      binding: t_binding(e.binding),
-      target: t_target(e.inspection),
-      must: t_must(e.inspection)
+      ::I18n.t key, translation_params(e, keywords)
     rescue
       '<unknown expectation>'
     end
@@ -15,6 +26,14 @@ module Mumukit::Inspection::I18n
 
     private
 
+    def translation_params(e, keywords)
+      {
+        binding: t_binding(e.binding),
+        target: t_target(e.inspection),
+        must: t_must(e.inspection)
+      }.merge(DEFAULT_KEYWORDS).merge(keywords || {})
+    end
+
     def key_for(binding, inspection)
       "expectation_#{inspection.type}#{inspection.target ? inspection.target.i18n_suffix : nil }"
     end

data/lib/mumukit/inspection/version.rb

@@ -1,5 +1,5 @@
 module Mumukit
   class Inspection
-    VERSION = '3.2.2'
+    VERSION = '3.3.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mumukit-inspection
 version: !ruby/object:Gem::Version
-  version: 3.2.2
+  version: 3.3.0
 platform: ruby
 authors:
 - Franco Leonardo Bulgarelli
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-30 00:00:00.000000000 Z
+date: 2018-07-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mumukit-core