mumukit-inspection 3.0.0 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c632bc77c35c934230567976f4245f064863ebbf
-  data.tar.gz: 1e0b8b17ccd0570c901b690a307a9b150022e52c
+  metadata.gz: 16b85e325229fb42120ae5e775e911c6b91dd905
+  data.tar.gz: 816a8a4a0eeeec7bbb559dad89bbc760c20b1625
 SHA512:
-  metadata.gz: 76c04bcbe208ea5ab4a149e44936a64b0fd8e4d143afab62f400f6c580562894781601c103895355b974c8dcac6d30f43978866bbc6ef27499bdbf751c7a245a
-  data.tar.gz: c0cb600d925edc37272a0431489f7d765a1d9b3be61f9fa377301fa963c8718a8e67ea92569b38a10a2cfaf80cbeeb95b90bbc8412e1a0af0938e3b2367e5c0c
+  metadata.gz: 00c21772792f17bd89c3cc3686f0f04021688d9b394b42d5fc1a394f1b40d41c739956d7ebb0f5322a7b5b92878eccdfaf02e65abae040153c9d9418bb42e2da
+  data.tar.gz: fcc93162cc048e4ab76a75a93aec934c31e8ed536f799af8e521101e2d2db0aeca6d200ed67a6f5df0b7916d91dbcf91f2955a9c666bfed96cd9eb96c37867ae

data/lib/mumukit/inspection/expectation.rb

@@ -1,4 +1,10 @@
 class Mumukit::Inspection::Expectation
+
+  SMELLS = %w(HasAssignmentReturn HasCodeDuplication HasMisspelledIdentifiers
+              HasRedundantBooleanComparison HasRedundantGuards HasRedundantIf
+              HasRedundantLambda HasRedundantLocalVariableReturn HasRedundantParameter
+              HasRedundantReduction HasTooShortIdentifiers HasWrongCaseIdentifiers)
+
   attr_accessor :binding, :inspection
 
   def initialize(binding, inspection)
@@ -20,23 +26,27 @@ class Mumukit::Inspection::Expectation
   end
 
   def self.guess_type(expectation)
-    if expectation[:inspection] =~ /(Not\:)?Has.*/
+    if expectation[:inspection] =~ /(Not\:)?Has.*/ && !has_smell?(expectation[:inspection])
       V0
     else
       V2
     end
   end
 
+  def self.has_smell?(smell)
+    SMELLS.include? smell
+  end
+
   def self.parse(expectation)
     guess_type(expectation).new(
       expectation[:binding],
-      Mumukit::Inspection.parse(expectation[:inspection])).tap &:check!
+      Mumukit::Inspection.parse(expectation[:inspection]))
   end
 
   class V0 < Mumukit::Inspection::Expectation
     INSPECTIONS = %w(HasBinding HasTypeDeclaration HasTypeSignature HasVariable HasArity HasDirectRecursion
                      HasComposition HasComprehension HasForeach HasIf HasGuards HasConditional HasLambda HasRepeat HasWhile
-                     HasUsage)
+                     HasUsage HasAnonymousVariable HasNot HasForall HasFindall)
 
 
     def binding?

data/lib/mumukit/inspection/version.rb

@@ -1,5 +1,5 @@
 module Mumukit
   class Inspection
-    VERSION = '3.0.0'
+    VERSION = '3.0.1'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mumukit-inspection
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.0.1
 platform: ruby
 authors:
 - Franco Leonardo Bulgarelli
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-14 00:00:00.000000000 Z
+date: 2017-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mumukit-core