mumuki-php-runner 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a8a44729b686db8ec1bee4e049aa6ed466e80a764c2d199c3cdc37c4c6c49fe0
-  data.tar.gz: 8ebe718ca780b84b09eccc38b5aba09ec751ac3462452c08a36b72e6309545c1
+  metadata.gz: e8e53aafc19ead748877758997dde14238f71cb2049e786d432e616571c9d106
+  data.tar.gz: 966ec97d251cfe9111b8249fe2583970434f14fdd9c32658f02b3d06410b4fb1
 SHA512:
-  metadata.gz: b7cba2ac3824aacfd7bd82c346377f174ba6f77fab1415d05713ce3aaf9806d80d3696b39ab80b9b1f787d46613a750778f42ba614d075ff466d9bd871918a71
-  data.tar.gz: 0772718ef25c9fb8c98f2798127b6f2fe240083f71d7ca2c39e167d32cc7e5ca5e51730c7440dce303c51d24da64382db6bb643c3bd50479828ce4e5b4a25891
+  metadata.gz: 897e4a8a031a71d22d773259de72d92f6273316f8d02eb00de96c9f655921a43fee2ea7aece4ce20a3c57322587c81e4adfe63633da6202fbff2d06a1f8d7d26
+  data.tar.gz: 5373842d85ce7a476bf68235ee29050585046642c9c27f40ca7f88fc5a29e58b95dc5dcf02835f6d9df6d21206792cbc8413e4f83f7ae5589a67f83f6498de76

data/lib/expectations_hook.rb

@@ -0,0 +1,41 @@
+require 'mulang/php'
+
+class PhpExpectationsHook < Mumukit::Templates::MulangExpectationsHook
+  SEPARATOR = '==> JSON dump:'
+
+  include_smells true
+
+  def language
+    'Mulang'
+  end
+
+  def mulang_code(request)
+    result = request.result[:ast]
+
+    Mulang::Code.new(mulang_language, to_mulang_ast(result))
+  end
+
+  def to_mulang_ast(output)
+    unless output.include? SEPARATOR
+      return ['Unable to get Mulang AST - Command failed!', :errored]
+    end
+
+    json = output.split(SEPARATOR).last
+    ast = JSON.parse json, symbolize_names: true
+
+    Mulang::PHP.parse(ast)
+  rescue => e
+    raise Mumukit::CompilationError, e
+  end
+
+  def default_smell_exceptions
+    LOGIC_SMELLS + FUNCTIONAL_SMELLS + OBJECT_ORIENTED_SMELLS
+  end
+
+  def domain_language
+    {
+      minimumIdentifierSize: 3,
+      jargon: []
+    }
+  end
+end

data/lib/metadata_hook.rb

@@ -4,7 +4,7 @@ class PhpMetadataHook < Mumukit::Hook
       language: {
         name: 'php',
         icon: {type: 'devicon', name: 'php'},
-        version: 'v1.0.0',
+        version: 'v1.1.0',
         extension: 'php',
         ace_mode: 'php'
       },

data/lib/php_runner.rb

@@ -2,11 +2,13 @@ require 'mumukit'
 
 Mumukit.runner_name = 'php'
 Mumukit.configure do |config|
-  config.docker_image = 'mumuki/mumuki-php-worker:1.1'
+  config.docker_image = 'mumuki/mumuki-php-worker:1.4'
 end
 
 require_relative './version'
 require_relative './metadata_hook'
 require_relative './php_file_hook'
+require_relative './precompile_hook'
 require_relative './test_hook'
+require_relative './expectations_hook'
 require_relative './query_hook'

data/lib/precompile_hook.rb

@@ -0,0 +1,45 @@
+class PhpPrecompileHook < PhpFileHook
+  BATCH_SEPARATOR = "\n/* ---Mumuki-Batch-Separator--- */\n"
+  RESULTS_SEPARATOR = "\n/* ---Mumuki-Results-Separator--- */\n"
+
+  def command_line(filename)
+    "run-tests-and-get-ast #{filename}"
+  end
+
+  def compile(request)
+    return request unless request[:query].nil?
+
+    file = super request
+    struct request.to_h.merge result: run!(file)
+  end
+
+  def compile_file_content(request)
+    compile_test_content(request) + BATCH_SEPARATOR + compile_ast_content(request)
+  end
+
+  def post_process_file(_file, result, status)
+    parts = result.split RESULTS_SEPARATOR
+
+    { test: parts.first, ast: parts.last }
+  end
+
+  def compile_test_content(request)
+    <<-EOF
+<?php
+declare(strict_types=1);
+
+#{request.extra}
+#{request.content}
+
+use PHPUnit\\Framework\\TestCase;
+
+final class #{PhpTestHook::TEST_NAME}Test extends TestCase {
+#{request.test.lines.map {|it| '  ' + it}.join}
+}
+    EOF
+  end
+
+  def compile_ast_content(request)
+    "<?php\n#{request[:content]}"
+  end
+end

data/lib/test_hook.rb

@@ -1,18 +1,16 @@
-class PhpTestHook < PhpFileHook
-  structured true
-
+class PhpTestHook < Mumukit::Defaults::TestHook
   TEST_NAME = 'AAAMumukiTestCaseAAA'
   PASSED_REGEXP = /[✔☢] ([^\n]+)/
   FAILED_REGEXP = /✘ ([^\n]+)\n *\│\n *│ ([^イ]+│ \n   )/
 
-  def command_line(filename)
-    "phpunit --testdox #{filename}"
-  end
+  def run!(request)
+    result = request.result[:test]
 
-  def post_process_file(file, result, status)
-    return [result.strip, :errored] unless result.include? TEST_NAME
+    unless result.include? TEST_NAME
+      return [mask_tempfile_references(result.strip), :errored]
+    end
 
-    super file, result, status
+    [to_structured_result(result)]
   end
 
   def to_structured_result(result)
@@ -22,22 +20,6 @@ class PhpTestHook < PhpFileHook
     passed_tests.concat(failed_tests)
   end
 
-  def compile_file_content(req)
-    <<-EOF
-<?php
-declare(strict_types=1);
-
-#{req.extra}
-#{req.content}
-
-use PHPUnit\\Framework\\TestCase;
-
-final class #{TEST_NAME}Test extends TestCase {
-#{req.test.lines.map {|it| '  ' + it}.join}
-}
-EOF
-  end
-
   private
 
   def to_passed_result(regexp_groups)
@@ -50,4 +32,8 @@ EOF
 
     [regexp_groups.first, 'failed', reason]
   end
+
+  def mask_tempfile_references(string)
+    string.gsub /\/tmp\/tmp\.\w+/, 'solution.php'
+  end
 end

data/lib/version.rb

@@ -1,3 +1,3 @@
 module PhpVersionHook
-  VERSION = '1.0.0'
+  VERSION = '1.1.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mumuki-php-runner
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Rodrigo Alfonso
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-27 00:00:00.000000000 Z
+date: 2018-08-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mumukit
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.21'
+- !ruby/object:Gem::Dependency
+  name: mulang-php
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.1'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -101,9 +115,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- lib/expectations_hook.rb
 - lib/metadata_hook.rb
 - lib/php_file_hook.rb
 - lib/php_runner.rb
+- lib/precompile_hook.rb
 - lib/query_hook.rb
 - lib/test_hook.rb
 - lib/version.rb