mumuki-domain 9.3.0 → 9.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b78b493d9f7e6314a746e22d17fe33c140dada6e77a9af84da850098180a1677
-  data.tar.gz: 9ed9017804d844c8a24540dcdf5c32d4ad78d8a28b186e3df1dbd83b845ff5cd
+  metadata.gz: ddd0081f4ed25d268fe17c327be9b5b343a21b2491eb737db4ee837fb16eead8
+  data.tar.gz: 7e34398bd300598d749d628af5ae31a49985ff62f8dda2ce2598169197cacc2d
 SHA512:
-  metadata.gz: 84faddd371cc851bbb08155cddb140dd6a17eaa3920f73cf235950d3321f07be4dd4f44325708b582904ee4d1eac2b5c426be3afb7b82e566834d87686eec3b2
-  data.tar.gz: 93cf6080fba52bffbe3d7fafd4a3ed0121f55accaa8b1c7950e9512a4f409b9031288b51998ab7caff22ac161fd4c0d4c9fb663f369cafb00a42afcfe6ad5732
+  metadata.gz: 87e8fbb20f42949df631f2696c1d10a0c40744b7f84a1c7b705e525a8f2120a1e1ce5a58231a9bb9c2faa4987bd031eba01d3eb01a3e407f7202c4469eaeda72
+  data.tar.gz: 9196ae6c744c474853ffb027cf86f015546539ef994f83c62f27199123e54dbda3372fbd141a22f86c349270a0d14b1e6cdf3fdda47f3476bc6cd594ceb6e742

data/app/models/concerns/with_pg_lock.rb

@@ -0,0 +1,19 @@
+module WithPgLock
+  ##
+  # Lock PG table, reload model and execute callback if
+  # criterion is met
+  #
+  def with_pg_lock(callback, criterion = proc { true })
+    # Some notes:
+    #
+    # * nowait is a postgre specific option and may not work with other databases
+    # * nowait will raise an exception if the lock can not be acquired
+    # * we are using a double check lock pattern to reduce lock acquisition
+    with_lock('for update nowait') do
+      reload
+      callback.call if criterion.call
+    end if criterion.call
+  rescue
+    nil
+  end
+end

data/app/models/concerns/with_reminders.rb

@@ -1,5 +1,6 @@
 module WithReminders
   extend ActiveSupport::Concern
+  include WithPgLock
 
   def build_reminder
     mailer = UserMailer.new
@@ -18,23 +19,13 @@ module WithReminders
   end
 
   # Try to send a reminder, by acquiring a database lock for update
-  # the aproppriate record. This object can't be updated as long as
+  # the appropriate record. This object can't be updated as long as
   # the reminder is being sent.
   #
   # This method is aimed to be sent across multiple servers or processed concurrently
   # and still not send duplicate mails
   def try_remind_with_lock!
-    # Some notes:
-    #
-    # * nowait is a postgre specific option and may not work with other databases
-    # * nowait will raise an exception if the lock can not be acquired
-    # * we are using a double check lock pattern to reduce lock acquisition
-    with_lock('for update nowait') do
-      reload
-      remind! if should_remind?
-    end if should_remind?
-  rescue
-    nil
+    with_pg_lock proc { remind! }, proc { should_remind? }
   end
 
   private

data/app/models/exam_authorization_request.rb

@@ -21,7 +21,7 @@ class ExamAuthorizationRequest < ApplicationRecord
   def icon
     case status.to_sym
     when :pending
-      { class: 'info-circle', type: 'info' }
+      { class: 'hourglass', type: 'info' }
     when :approved
       { class: 'check-circle', type: 'success' }
     when :rejected

data/app/models/exam_registration.rb

@@ -1,4 +1,5 @@
 class ExamRegistration < ApplicationRecord
+  include WithPgLock
   include WithTimedEnablement
   include TerminalNavigation
 
@@ -16,6 +17,8 @@ class ExamRegistration < ApplicationRecord
 
   alias_attribute :name, :description
 
+  scope :should_process, -> { where(processed: false).where(arel_table[:end_time].lt(Time.now)) }
+
   def authorization_criterion
     @authorization_criterion ||= ExamRegistration::AuthorizationCriterion.parse(authorization_criterion_type, authorization_criterion_value)
   end
@@ -40,11 +43,21 @@ class ExamRegistration < ApplicationRecord
     registrees.where.not(id: Notification.notified_users_ids_for(self, self.organization))
   end
 
+  # Try to process authorization request, by acquiring a database lock for update
+  # the appropriate record.
+  #
+  # This method is aimed to be sent across multiple servers or processed concurrently
+  # and still not send duplicate mails
   def process_requests!
+    with_pg_lock proc { process_authorization_requests! }, proc { !processed? }
+  end
+
+  def process_authorization_requests!
     authorization_requests.each do |it|
       process_request! it
       it.try_authorize!
     end
+    update! processed: true
   end
 
   def authorization_request_for(user)

data/db/migrate/20210512200453_add_processed_flag_to_exam_registration.rb

@@ -0,0 +1,5 @@
+class AddProcessedFlagToExamRegistration < ActiveRecord::Migration[5.1]
+  def change
+    add_column :exam_registrations, :processed, :boolean, default: false
+  end
+end

data/lib/mumuki/domain/version.rb

@@ -1,5 +1,5 @@
 module Mumuki
   module Domain
-    VERSION = '9.3.0'
+    VERSION = '9.4.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mumuki-domain
 version: !ruby/object:Gem::Version
-  version: 9.3.0
+  version: 9.4.0
 platform: ruby
 authors:
 - Franco Leonardo Bulgarelli
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-05-13 00:00:00.000000000 Z
+date: 2021-06-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -291,6 +291,7 @@ files:
 - app/models/concerns/with_name.rb
 - app/models/concerns/with_notifications.rb
 - app/models/concerns/with_number.rb
+- app/models/concerns/with_pg_lock.rb
 - app/models/concerns/with_preferences.rb
 - app/models/concerns/with_profile.rb
 - app/models/concerns/with_progress.rb
@@ -666,6 +667,7 @@ files:
 - db/migrate/20210318194559_add_dates_to_certificate_program.rb
 - db/migrate/20210318195238_rename_certificate_dates.rb
 - db/migrate/20210330175706_create_exam_registration_user_join_table.rb
+- db/migrate/20210512200453_add_processed_flag_to_exam_registration.rb
 - lib/mumuki/domain.rb
 - lib/mumuki/domain/area.rb
 - lib/mumuki/domain/engine.rb