mumuki-domain 7.4.0 → 7.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 565a262560be1187382a14821310b252774ddd2cfbff5b1ec27f4740009274a8
-  data.tar.gz: f81fcb7e631f8f4e1a88526a95a7152bb854c9cc8beea26cf0342574f68413e3
+  metadata.gz: 68dc581849f150d3c0a958f3a1df2b25b4959b3ee71a595364cf2ac7533fbd25
+  data.tar.gz: dc6a6e467c80e08d035ccc70c7ace81ffdabb41088564350220f76706738332a
 SHA512:
-  metadata.gz: 1f47711214119a25152f602e342ad9934d5e5e72253580639704353bdd9337aeba0899ad975c75d139363f5dfb13ed4574673df381d99896c766e14a9b79abc4
-  data.tar.gz: aab1d74be634268a51719ee81d9a3977ea0412b5b645a8e5b29909b75b690ad2deac25bed2e2872312dfa8b63c48fcf0b5516bd9731fcb50b7dd644d8c2c7fbd
+  metadata.gz: d852df438a75e07817d1b01769559faf0a68b7c892a4423b7ee0a97a04153439388904b544a19562597015c2f613596a8236d87205aedaf86304d9141f7992ea
+  data.tar.gz: aeb1db5771206c8de35da5e9d03395f5029ce7dcec4d5b643d65365f4d1ef01e5159ffc66038bc056300bc9f9f103549ff029bcbb7b22c08fc2b47270b7aecb8

data/app/models/concerns/contextualization.rb

@@ -25,7 +25,7 @@ module Contextualization
 
     delegate :visible_success_output?, to: :exercise
     delegate :output_content_type, to: :language
-    delegate :should_retry?, :to_submission_status, :completed?, *Mumuki::Domain::Status::Submission.test_selectors, to: :submission_status
+    delegate :should_retry?, :to_submission_status, :completed?, :solved?, *Mumuki::Domain::Status::Submission.test_selectors, to: :submission_status
     delegate :inspection_keywords, to: :exercise
   end
 
@@ -44,11 +44,7 @@ module Contextualization
   end
 
   def results_body_hidden?
-    (passed? && !visible_success_output?) || exercise.choice? || manual_evaluation_pending?
-  end
-
-  def result_preview
-    result.truncate(100) unless passed?
+    (passed? && !visible_success_output?) || exercise.choice? || manual_evaluation_pending? || skipped?
   end
 
   def visible_status
@@ -68,7 +64,7 @@ module Contextualization
   end
 
   def failed_expectation_results
-    expectation_results.to_a.select { |it| it[:result].failed? }
+    expectation_results.to_a.select { |it| it[:result].failed? }.uniq
   end
 
   def expectation_results_visible?

data/app/models/concerns/submittable/solvable.rb

@@ -1,7 +1,7 @@
 module Solvable
   def submit_solution!(user, attributes={})
     assignment, _ = find_assignment_and_submit! user, attributes[:content].to_mumuki_solution(language)
-    try_solve_discussions(user) if assignment.passed?
+    try_solve_discussions(user) if assignment.solved?
     assignment
   end
 

data/app/models/stats.rb

@@ -1,7 +1,7 @@
 class Stats
   include ActiveModel::Model
 
-  attr_accessor :passed, :passed_with_warnings, :failed, :pending
+  attr_accessor :passed, :passed_with_warnings, :failed, :pending, :skipped
 
   def submitted
     passed + passed_with_warnings + failed
@@ -16,7 +16,7 @@ class Stats
   end
 
   def self.from_statuses(statuses)
-    Stats.new(statuses.inject({passed: 0, passed_with_warnings: 0, failed: 0, pending: 0}) do |accum, status|
+    Stats.new(statuses.inject({passed: 0, passed_with_warnings: 0, failed: 0, pending: 0, skipped: 0}) do |accum, status|
       accum[status.group.to_sym] += 1
       accum
     end)

data/lib/mumuki/domain/status/submission/skipped.rb

@@ -5,10 +5,6 @@ module Mumuki::Domain::Status::Submission::Skipped
     true
   end
 
-  def self.passed?
-    true
-  end
-
   def self.iconize
     {class: :success, type: 'check-circle'}
   end

data/lib/mumuki/domain/status/submission/submission.rb

@@ -23,8 +23,6 @@ module Mumuki::Domain::Status::Submission
     self
   end
 
-  # Tells if a new, different submission should be tried.
-  # True for `failed`, `errored` and `passed_with_warnings`
   def should_retry?
     false
   end
@@ -38,6 +36,10 @@ module Mumuki::Domain::Status::Submission
   end
 
   def completed?
-    passed?
+    solved?
+  end
+
+  def solved?
+    passed? || skipped?
   end
 end

data/lib/mumuki/domain/version.rb

@@ -1,5 +1,5 @@
 module Mumuki
   module Domain
-    VERSION = '7.4.0'
+    VERSION = '7.4.1'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mumuki-domain
 version: !ruby/object:Gem::Version
-  version: 7.4.0
+  version: 7.4.1
 platform: ruby
 authors:
 - Franco Leonardo Bulgarelli
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-02 00:00:00.000000000 Z
+date: 2020-04-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails