multiview 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 650c7df341ee5b96e1a2fda99e8d026c2aad2f2f
-  data.tar.gz: eba95cc7ffc902f9df1357c41a2b157fe236c0bb
+  metadata.gz: 1e132d129c25fffcfa989a0dba045156cfe3bd6d
+  data.tar.gz: f959713516300b1a16987e233707fadb0bff4c0f
 SHA512:
-  metadata.gz: 145978eaf69e93ede41a767433073879ed7cf1eb97948150a14d8f7de800e1a6dc9ea760b867d4faa7fa8fd5e952f3a4fcba98224f176a894d7e2b5cfa678f2a
-  data.tar.gz: 694c768525e76b4433b178fcffc3389fa5c9e99fea4af6f0db05fd81588e239c82901b40b048efa173b7cc20c4b4b89b85d1c955c03cc60268d229e18d9a8ba9
+  metadata.gz: 9a27e21c6b8cba2ebbf3041cb99c2e92aaa56b0f7b24a6086d584172fcd027502e2f6869cb57cec6121be56ae5af4da83fb7f74dd84dcd0df0b34db548818602
+  data.tar.gz: c909c6820c06a9d87dc820d92e8ea872962becb9cd48aa12a966ecd53976ff0d2b3d47ed35586e34fe2cc3d8e74555898d70e0651d53b97bc2c1ebeacc4248e8

data/README.md

@@ -74,12 +74,16 @@ class ApplicationController < ActionController::Base
     # $multiview.redispatch(self, params[:controller], params[:action])
 
     # if exist V3::XxxController, should to call V3::XxxController
-    # if not, should to call XxxController
+    # if not, should to call XxxController and prepend v3 views path
+    # when you just want to change something for views, you should not to redefined a controller for the version
     # $multiview.redispatch(self, params[:controller], params[:action], 'v3')
   end
 end
 ```
 
+Limitation: We only overwrite those action about already defined.
+
+
 ### Dispatch request by middleware
 
 ```
@@ -108,6 +112,11 @@ end
 config.middleware.insert_before Rails.application.routes, MultiviewMiddleware
 ```
 
+Limitation: Depend Rails.application.routes.recognize_path, if you have some specific routes, might it cannot work.
+
+Anyway, it soloved that problem of `before_action`
+
+
 
 ## Development
 

data/lib/multiview/manager.rb

@@ -5,7 +5,7 @@ module Multiview
     # Params:
     #   config: {controller_path: version
     def initialize(versions_map)
-      @versions_map = versions_map
+      @versions_map = versions_map.symbolize_keys
     end
 
     def dispatch(env, controller_path, action_name, version = nil)
@@ -57,6 +57,5 @@ module Multiview
       Rails.logger.warn("[Multiview] Prepend view path app/views/#{version}")
       controller.prepend_view_path(Rails.root.join("app/views/#{version}"))
     end
-
   end
 end

data/lib/multiview/version.rb

@@ -1,3 +1,3 @@
 module Multiview
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/lib/multiview.rb

@@ -1,5 +1,9 @@
 require "multiview/version"
 
+require 'active_support'
+require 'active_support/core_ext/module/remove_method'
+require 'active_support/core_ext'
+
 module Multiview
   require 'multiview/manager'
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: multiview
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Jon Xie
@@ -121,7 +121,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.2
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Support multiple versions for Rails view.