multiparameter_attributes_handler 0.0.1 → 0.0.2

data/README.rdoc

@@ -18,27 +18,50 @@ when set to 24th June 2004, will generate
    }
     
 ActiveRecord understands this and converts these key/value pairs into a date
-object that is passed to thing.last_record=
+object that is passed to thing.last_read=
 
 === A solution without ActiveRecord
 
-Multiparameter Attributes Handler allows other objects to do the same. In 
-particular, ActiveResource models.
+Multiparameter Attributes Handler allows other objects to do the same.
 
-It does this by modifying the way attributes= works. So for the above example,
-the values passed down the attributes= chain gets converted to:
+    thing_params = MultiparameterAttributesHandler.manipulate_all(params[:thing])
 
-   'thing' => {
+This creates a last_read key with a time object derived from the values
+
+    thing_params == {
         "last_read(1i)" => "2004", 
         "last_read(2i)" => "6", 
         "last_read(3i)" => "24",
         "last_read"     => Time.local('2004', '6', '24')
-   }
+    }
 
-So for a ActiveResource Thing, this functionality is added like this:
+So for a ActiveResource Thing, this functionality can be added by over-riding
+the attributes setter:
 
     class Thing < ActiveResource::Base
-      include MultiparameterAttributesHandler
+      def attributes=(params)
+        super MultiparameterAttributesHandler.manipulate_all(params)
+      end
+    end
+
+However, as the params splitting and rebuilding is happening in the views and
+controller space, it might well make more sense to do the manipulation in the
+controller:
+
+    class ThingsController < ApplicationController
+
+      ....
+
+      def update
+        @thing = Thing.find(params[:id])
+        @property.update_attributes thing_params
+        redirect_to @property
+      end
+
+      private
+      def thing_params
+        MultiparameterAttributesHandler.manipulate_all(params[:thing])
+      end
     end
 
 === Only setter affected
@@ -47,34 +70,20 @@ Note that this gem provides handling of the parameters received from the form
 submission. For the form helpers to work, they need to passed a date or time
 to the form.
 
-One solution is to over-ride the getter in the model. So for the Thing example
-above, the complete solution would look like this:
+One solution is to override the getter in the model. So for the Thing example
+above:
 
     require 'date'
     class Thing < ActiveResource::Base
-      include MultiparameterAttributesHandler
 
       def last_read
-        Date.parse(super)
+        Time.parse(super)
       end
     end 
 
 Rails form date helpers will then work for last_read:
 
-    date_select(:thing, :last_read)
-
-And in the controller's create and update methods:
-
-    thing.attributes = params[:thing]
-
-Or
-
-    Thing.new(params[:thing])
-
-Or
-
-    thing.update_attributes(params[:thing])
-
+    datetime_select(:thing, :last_read)
 
 === Installation
 

data/lib/multiparameter_attributes_handler.rb

@@ -2,8 +2,8 @@ require_relative 'multiparameter_attributes_handler/manipulator'
 require_relative 'multiparameter_attributes_handler/multiparameter_attributes_handler_error'
 module MultiparameterAttributesHandler
   
-  def attributes=(new_attributes)
-    super Manipulator.new(new_attributes).output
+  def self.manipulate_all(hash)
+    Manipulator.new(hash).output
   end
     
 end

data/lib/multiparameter_attributes_handler/version.rb

@@ -1,10 +1,27 @@
 module MultiparameterAttributesHandler
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end
 
 # History
 # =======
 # 
+# 0.0.2: Modified usage so that developer decides where manipulation happens
+# ---------------------------------------------------------------------------
+# 
+# Previously, it was assumed that the functionality would be applied to a model's
+# attributes= method, as this is where most params values are sent (eventually).
+# 
+# After some experimentation and consideration, it was realised that this is
+# too restrictive. It also became apparent that the manipulation may need to 
+# happen in the controller rather than the model. Especially in Rails 4 where
+# strong_parameters will already be manipulating the params.
+# 
+# Therefore, the functionality was repackaged so it could be used anywhere. 
+# 
+# This change in usage will also make it easier to create single method usage
+# in the future: where rather than manipulating all multiparameter attributes,
+# it will be possible to specify which attributes to manipulate.
+# 
 # 0.0.1: First gem
 # ----------------
 # 

data/test/thing.rb

@@ -1,16 +1,16 @@
 require_relative '../lib/multiparameter_attributes_handler'
 
-class Parent
-  attr_accessor :attributes
-end
-
-
-class Thing < Parent
+class Thing
+  
+  attr_reader :attributes
   
-  include MultiparameterAttributesHandler
   
   def initialize
     
   end
+  
+  def attributes=(params)
+    @attributes = MultiparameterAttributesHandler.manipulate_all(params)
+  end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: multiparameter_attributes_handler
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors: