multidispatch 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d975637a4c55f40bdf6a33590aa958cffdbf0aa3
-  data.tar.gz: 9a077af69a97c8ced3fc0ff08be393079464aa17
+  metadata.gz: 8f12abed938c65400d74580c619b6402c71ff3a8
+  data.tar.gz: c46add3d7435b03edad192c00b4e2f3558363c54
 SHA512:
-  metadata.gz: dc40bf40542e8ab5cffa4cf1eb918a9be09b9bea5292d0c0840c41b659f411c364a015cb8a317741c622c99b15b891ced694457e9b7c076f435e31c7cb6b8e57
-  data.tar.gz: a5bbe28efda4a1d9bc0d68d5cc87819daa0e7db3cef8270fd46e1dc84aa1f58ad52d4339488519cf407880e2986af96f41621168ff28c0a83572dece96b156ef
+  metadata.gz: 862b044e7ff7f49a7738d0b2eddeb3f1c3416a9d4cd676ace183dc690828d9df3da6442b7a33ffa434e474ac9408ce023963247729ef881717fbc4bcd50bff83
+  data.tar.gz: 154fcc15d9e6dff7344c8093c9b59212029dbcc575881f5a775dad50f4f00b4f6446e1ba6bf1d6b56c0c0e288297263d5555adafebf4ad3b37152568484f6377

data/.travis.yml

@@ -0,0 +1,6 @@
+language: ruby
+rvm:
+  - "1.9.2"
+  - "1.9.3"
+  - jruby-19mode
+  - rbx-19mode

data/Gemfile

@@ -1,4 +1,5 @@
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in ruby-multidispatch.gemspec
+gem 'coveralls', :require => false
 gemspec

data/README.md

@@ -1,6 +1,10 @@
 multidispatch
 ==================
 
+[![Gem Version](https://badge.fury.io/rb/multidispatch.png)](http://badge.fury.io/rb/multidispatch)
+[![Build Status](https://travis-ci.org/noomorph/multidispatch.png)](https://travis-ci.org/noomorph/multidispatch)
+[![Coverage Status](https://coveralls.io/repos/noomorph/multidispatch/badge.png)](https://coveralls.io/r/noomorph/multidispatch)
+
 Very basic multidispatch in **Ruby** using natural syntax.
 Currently supports overloads by count of mandatory parameters.
 So, it solves only one problem. Converts the following code:

data/Rakefile

@@ -1,2 +1,9 @@
 #!/usr/bin/env rake
 require "bundler/gem_tasks"
+require 'rspec/core/rake_task'
+
+RSpec::Core::RakeTask.new(:spec)
+
+task :default => :spec do
+  system "gem build multidispatch.gemspec"
+end

data/lib/multidispatch/interceptor.rb

@@ -0,0 +1,23 @@
+class Multidispatch::Interceptor
+  attr_accessor :store
+
+  def initialize(store = nil)
+    @store = store
+  end
+
+  def intercept(method)
+    return if @store.locked? # prevent recursion
+
+    store = @store
+    store.set(method.owner, method.name)
+    store.lock!
+
+    method_body = lambda do |*args|
+      method = store.get(self.class, method.name, args.count)
+      method.bind(self).call(*args)
+    end
+
+    method.owner.class_eval { define_method method.name, method_body }
+    store.release!
+  end
+end

data/lib/multidispatch/version.rb

@@ -1,3 +1,3 @@
 module Multidispatch
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/lib/multidispatch.rb

@@ -1,4 +1,5 @@
 require "multidispatch/store"
+require "multidispatch/interceptor"
 require "multidispatch/version"
 
 module Multidispatch
@@ -8,18 +9,11 @@ module Multidispatch
   end
 
   module ClassMethods
-    @@store = Store.new
+    @@interceptor = Interceptor.new(Store.new)
 
-    def method_added(name)
-      return if @@store.locked? # prevent recursion
-      @@store.set(self, name)
-
-      @@store.lock!
-      define_method(name) do |*args|
-        method = @@store.get(self.class, name, args.count)
-        method.bind(self).call(*args)
-      end
-      @@store.release!
+    def method_added(method_name)
+      @@interceptor.intercept(instance_method(method_name))
     end
   end
+
 end

data/spec/multidispatch_interceptor_spec.rb

@@ -0,0 +1,47 @@
+describe Multidispatch::Interceptor do
+  context "when store is locked" do
+    before { subject.store = double(:locked? => true, :set => nil) }
+
+    it "should not save method to store" do
+      subject.intercept(nil)
+      expect(subject.store).to_not have_received(:set)
+    end
+  end
+
+  context "when store has no lock" do
+    class Foo; def foo; end end
+
+    before do
+      subject.store = double({
+        :locked? => false,
+        :lock! => nil,
+        :set => nil,
+        :release! => nil
+      })
+      @foo = Foo.instance_method(:foo)
+    end
+
+    it "should save method to store" do
+      subject.intercept(@foo)
+      expect(subject.store).to have_received(:set).with(Foo, :foo)
+    end
+
+    it "should lock store before re-defining method" do
+      subject.intercept(@foo)
+      expect(subject.store).to have_received(:lock!)
+    end
+
+    it "should re-define owner class method" do
+      klass = double(:class_eval => nil)
+      subject.intercept(double(:owner => klass, :name => "method"))
+
+      expect(klass).to have_received(:class_eval)
+    end
+
+    it "should release store after re-defining method" do
+      subject.intercept(@foo)
+      expect(subject.store).to have_received(:release!)
+    end
+
+  end
+end

data/spec/multidispatch_spec.rb

@@ -4,45 +4,38 @@ describe Multidispatch do
   it "should have self.included method" do
     subject.method(:included).should_not be_nil
   end
-end
-
-describe Multidispatch::Store do
 
-  context "when released" do
-    it "can be locked" do
-      expect { subject.lock! }.to change { subject.locked? }.from(nil).to(true)
-    end
+  it "should extend in self.included method" do
+    class IsExtended; end
+    subject.included(IsExtended)
 
-    it "has no effect to release" do
-      expect { subject.release! }.not_to change { subject.locked? }
-    end
-
-    context "when method added" do
-      before { @the_method = subject.set(Hash, :inspect) }
+    modules = IsExtended.singleton_class.included_modules
+    modules.should include(Multidispatch::ClassMethods)
+  end
+end
 
-      it { @the_method.should be_instance_of(UnboundMethod) }
-      its(:store) { should == {"Hash" => {inspect: {0 => @the_method}}} }
+describe Multidispatch::ClassMethods do
+  it "defines variable `interceptor`" do
+    subject.class_variable_defined?(:@@interceptor).should be_true
+  end
 
-      it "get() returns it" do
-        subject.get(Hash, :inspect, 0).should == @the_method
-      end
-    end
-    
+  it "`interceptor` is Multidispatch::Interceptor" do
+    i = subject.send :class_variable_get, :@@interceptor
+    i.should be_instance_of(Multidispatch::Interceptor)
   end
+  
+  it "should not extend class that does not include it" do
+    class DoesNotInclude
+    end
 
-  context "when locked" do
-    before { subject.lock! }
+    DoesNotInclude.method(:method_added).should_not == subject
+  end
 
-    it "can be released" do
-      expect { subject.release! }.to change { subject.locked? }.from(true).to(nil)
+  it "should extend class that includes it" do
+    class Includes
+      extend Multidispatch::ClassMethods
     end
-    
-    context "when try to add method" do
-      before { @the_method = subject.set(Object, :some_method) }
 
-      it { @the_method.should be_nil }
-      its(:store) { should == {} }
-    end
+    Includes.method(:method_added).owner.should == subject
   end
-
 end

data/spec/multidispatch_store_spec.rb

@@ -0,0 +1,40 @@
+describe Multidispatch::Store do
+
+  context "when released" do
+    it "can be locked" do
+      expect { subject.lock! }.to change { subject.locked? }.from(nil).to(true)
+    end
+
+    it "has no effect to release" do
+      expect { subject.release! }.not_to change { subject.locked? }
+    end
+
+    context "when method added" do
+      before { @the_method = subject.set(Hash, :inspect) }
+
+      it { @the_method.should be_instance_of(UnboundMethod) }
+      its(:store) { should == {"Hash" => {:inspect => {0 => @the_method}}} }
+
+      it "get() returns it" do
+        subject.get(Hash, :inspect, 0).should == @the_method
+      end
+    end
+    
+  end
+
+  context "when locked" do
+    before { subject.lock! }
+
+    it "can be released" do
+      expect { subject.release! }.to change { subject.locked? }.from(true).to(nil)
+    end
+    
+    context "when try to add method" do
+      before { @the_method = subject.set(Object, :some_method) }
+
+      it { @the_method.should be_nil }
+      its(:store) { should == {} }
+    end
+  end
+
+end

data/spec/spec_helper.rb

@@ -1,5 +1,7 @@
 require 'bundler/setup'
 require 'multidispatch'
+require 'coveralls'
+Coveralls.wear!
 
 RSpec.configure do |config|
   config.treat_symbols_as_metadata_keys_with_true_values = true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: multidispatch
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Iaroslav Sergieiev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-02 00:00:00.000000000 Z
+date: 2013-10-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -61,12 +61,14 @@ extra_rdoc_files: []
 files:
 - .gitignore
 - .rspec
+- .travis.yml
 - Gemfile
 - LICENSE
 - LICENSE.txt
 - README.md
 - Rakefile
 - lib/multidispatch.rb
+- lib/multidispatch/interceptor.rb
 - lib/multidispatch/store.rb
 - lib/multidispatch/version.rb
 - multidispatch.gemspec
@@ -74,7 +76,9 @@ files:
 - sample/main.rb
 - sample/morning.rb
 - spec/integration_spec.rb
+- spec/multidispatch_interceptor_spec.rb
 - spec/multidispatch_spec.rb
+- spec/multidispatch_store_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/noomorph/ruby-multidispatch
 licenses:
@@ -103,5 +107,7 @@ summary: Very basic multidispatch in Ruby using natural def syntax. Currently su
   only overloads by count of mandatory parameters.
 test_files:
 - spec/integration_spec.rb
+- spec/multidispatch_interceptor_spec.rb
 - spec/multidispatch_spec.rb
+- spec/multidispatch_store_spec.rb
 - spec/spec_helper.rb