multi_sms 0.0.4 → 0.0.5

data/lib/multi_sms/providers/sms_provider.rb

@@ -7,9 +7,9 @@ module Providers
     end
 
   private
-    # def method_missing(m, *args, &block)
-    #   # self.class.const_get(:API_VERSION)
-    # end
+    def method_missing(m, *args, &block)
+      self.class.const_get(:API_VERSION)
+    end
   end
 
 end

data/lib/multi_sms/version.rb

@@ -1,3 +1,3 @@
 module MultiSms
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/lib/multi_sms.rb

@@ -13,6 +13,7 @@ end
 
 module MultiSms
 
+  class ConfigError < RuntimeError; end
   # When the authentication can't be done
   class AuthError < RuntimeError; end
   # Raised when the API server isn't working
@@ -41,7 +42,7 @@ module MultiSms
     #
     # Example:
     #   MultiSms.config do |c|
-    #     c.foo = :bar
+    #     c.default_provider = "Elk"
     #   end
     #
     #   MultiSms.config.foo # => :bar
@@ -51,7 +52,9 @@ module MultiSms
     end
 
     def send(country_code, parameters)
+      raise ConfigError, "MultiSms needs a default provider configured." unless config.default_provider.instance_of?(String)
       verify_parameters(parameters, [:from, :message, :to])
+
       provider = get_provider country_code
       provider.send(parameters)
     end
@@ -67,6 +70,7 @@ module MultiSms
     def get_provider(country_code)
       name = config.providers[country_code.to_s]
       name = config.default_provider unless name
+
       provider = "Providers::#{name}".split('::').inject(Object) {|o,c| o.const_get c}
       provider.new
     end

data/spec/multi_sms_spec.rb

@@ -1,24 +1,49 @@
 require 'spec_helper'
 describe MultiSms do
 
-  before do
-    MultiSms.config do |config|
-      config.providers = {"46" => "Elk", "47" => "Twilio"}
+  context "with a default provider" do
+    before do
+      MultiSms.config do |config|
+        config.providers = {"46" => "Elk", "47" => "Twilio"}
+        config.default_provider = "Twilio"
+      end
     end
-  end
 
-  it "should respond to providers" do
-    MultiSms.providers.should eql ["Clickatell", "Elk", "Twilio"]
-  end
+    it "should raise and exception if #to is missing" do
+      expect{MultiSms.send 46, from: "fake", message: "fake"}.to raise_error(MultiSms::MissingParameter)
+    end
+
+    it "should raise and exception if #from is missing" do
+      expect{MultiSms.send 46, to: "fake", message: "fake"}.to raise_error(MultiSms::MissingParameter)
+    end
+
+    it "should raise and exception if #message is missing" do
+      expect{MultiSms.send 46, to: "fake", from: "fake"}.to raise_error(MultiSms::MissingParameter)
+    end
+
+    it "should respond to providers" do
+      MultiSms.providers.should eql ["Clickatell", "Elk", "Twilio"]
+    end
+
+    it "should get provider based on swedish country code" do
+      provider = MultiSms.get_provider 46
+      provider.should be_an_instance_of Providers::Elk
+    end
+
+    it "should get provider based on norweigan country code" do
+      provider = MultiSms.get_provider 47
+      provider.should be_an_instance_of Providers::Twilio
+    end
+
+    it "should not pick default_provider for unconfigured country codes" do
+      provider = MultiSms.get_provider 45
+      provider.should be_an_instance_of Providers::Twilio
+    end
 
-  it "should get provider based on swedish country code" do
-    provider = MultiSms.get_provider 46
-    provider.should be_an_instance_of Providers::Elk
   end
 
-  it "should get provider based on norweigan country code" do
-    provider = MultiSms.get_provider 47
-    provider.should be_an_instance_of Providers::Twilio
+  it "should raise and exception if no default provider is configured" do
+    expect{MultiSms.send 46, to: "fake", from: "fake", message: "fake"}.to raise_error(MultiSms::ConfigError)
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: multi_sms
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
   prerelease: 
 platform: ruby
 authors:
@@ -230,7 +230,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3977358969120352856
+      hash: 2945269217158432553
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -239,7 +239,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3977358969120352856
+      hash: 2945269217158432553
 requirements: []
 rubyforge_project: multi_sms
 rubygems_version: 1.8.24