mtik 3.0.4 → 3.0.5

data/CHANGELOG.txt

@@ -1,3 +1,8 @@
+2010-04-23 (23 APR 2010)  VERSION 3.0.5  Aaron D. Gifford (http://www.aarongifford.com)
+ * Double bug-fix (typo fix and logic fix) to request.rb thanks to Allan Eising and 
+   Søren Daugaard.  Thank you both for the patch!
+ * Added a brief sanity-check in request.rb to help spotlight logic errors.
+
 2010-04-09 (09 APR 2010)  VERSION 3.0.4  Aaron D. Gifford (http://www.aarongifford.com)
  * Bug fix to lib/mtik.rb thanks to Allan Eising to the command validation regular
    expression to permit the '-' character in a command.  Thanks!

data/VERSION.txt

@@ -1 +1 @@
-3.0.4
+3.0.5

data/lib/mtik/request.rb

@@ -157,16 +157,20 @@ class MTik::Request < Array
 
   ## Utility method for packing an unsigned integer as
   ## a binary byte string of variable length
-  def self.bytepack(num)
+  def self.bytepack(num, size)
     s = String.new
-    if RUBY_VERSIION >= '1.9.0'
+    if RUBY_VERSION >= '1.9.0'
       s.force_encoding(Encoding::BINARY)
     end
     x = num < 0 ? -num : num  ## Treat as unsigned
-    while x > 0
-      s += (x & 0xff).chr
+    while size > 0
+      size -= 1
+      s = (x & 0xff).chr + s
       x >>= 8
     end
+    raise RuntimeError.new(
+      "Number #{num} is too large to fit in #{size} bytes."
+    ) if x > 0
     return s
   end
 
@@ -180,13 +184,13 @@ class MTik::Request < Array
     if str.length < 0x80
       return str.length.chr + str
     elsif str.length < 0x4000
-      return bytepack(str.length | 0x8000) + str
+      return bytepack(str.length | 0x8000, 2) + str
     elsif str.length < 0x200000
-      return bytepack(str.length | 0xc00000) + str
+      return bytepack(str.length | 0xc00000, 3) + str
     elsif str.length < 0x10000000
-      return bytepack(str.length | 0xe0000000) + str
+      return bytepack(str.length | 0xe0000000, 4) + str
     elsif str.length < 0x0100000000
-      return 0xf0.chr + bytepack(str.length) + str
+      return 0xf0.chr + bytepack(str.length, 5) + str
     else
       raise RuntimeError.new(
         "String is too long to be encoded for " +

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 3
   - 0
-  - 4
-  version: 3.0.4
+  - 5
+  version: 3.0.5
 platform: ruby
 authors: 
 - Aaron D. Gifford
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-04-09 00:00:00 -06:00
+date: 2010-04-23 00:00:00 -06:00
 default_executable: 
 dependencies: []