mt-lang 0.4.21 → 0.4.22

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 78cefa537b068c8eb6d28d4b9111448c60e837bcaaddc82400b3b7f00ca6bbb8
-  data.tar.gz: 3ceff08e45e74f22ef4fe2f3a7eee31dd11a7943e5f8596766e792741c366cdf
+  metadata.gz: 60f503669467624ebec5461f2f5fb5c3dae9216718b4c445f182323b90e9f505
+  data.tar.gz: d5ace59e3fdadbe3a7ea75f740d0d1d2953088d1799b42e9e6899c900e50595a
 SHA512:
-  metadata.gz: 4b7fc7883e1fd86961012b35f7a91da1f996eaade75d2799863991d37acae57ab41360cc783ecbca5afc792b7a6455a25b638003ea0ffa9b456e7ece1a3395da
-  data.tar.gz: 259f4a718acace0f4c3ce07fcb01f458fc7bef4ea23798ac16458eb2ffc7b63688fa05fea53a553260d33bc9e031f768ada4b7f98effc803e5099f9c976a7d03
+  metadata.gz: e74f76c097577a41ccc21462f7ede0d2c2a77f84f883e0ca3026b6b3f966e4b87ba3cfc91eca5dc16165edbc50a6f2bcff6be7ef6be751a1ba95f86b472b6e00
+  data.tar.gz: 652e7de9f0afd01aeac1358af1c47a2a19bce244ec53838b5cfc65b103d44cafea61210d01ca766bf390d4b649268d50d6ac2c057ce40e09f64e25b24c4a3d76

data/docs/language-manual.md

@@ -1553,6 +1553,7 @@ The auto-fix column corresponds to `mtc lint --fix`.
 | `shadow` | warning | — | Local binding shadows an outer binding with the same name |
 | `trailing-list-comma` | hint | yes | Trailing comma in call argument list is redundant |
 | `unreachable-code` | warning | — | Code after a guaranteed terminator cannot execute |
+| `redundant-unsafe` | hint | — | `unsafe` block contains no unsafe operations and can be removed |
 | `unused-import` | warning | yes | Import alias is never referenced |
 | `unused-local` | warning | — | Local binding is never referenced |
 | `unused-param` | warning | — | Parameter is never referenced |

data/lib/milk_tea/base.rb

@@ -3,7 +3,7 @@
 require "pathname"
 
 module MilkTea
-  VERSION = "0.4.21"
+  VERSION = "0.4.22"
 
   def self.root
     @root ||= Pathname.new(File.expand_path("../..", __dir__))

data/lib/milk_tea/tooling/linter/visitors.rb

@@ -209,6 +209,7 @@ module MilkTea
             check_prefer_try(statement.expression, statement.arms)
           end
         when AST::UnsafeStmt
+          check_redundant_unsafe(statement)
           @unsafe_depth += 1
           with_scope { visit_statement_list(statement.body) }
           @unsafe_depth -= 1
@@ -314,6 +315,7 @@ module MilkTea
             check_prefer_or_pattern(expression.arms, body_of: ->(arm) { arm.value })
           end
         when AST::UnsafeExpr
+          check_redundant_unsafe(expression)
           @unsafe_depth += 1
           visit_expression(expression.expression)
           @unsafe_depth -= 1
@@ -362,6 +364,21 @@ module MilkTea
           nil
         end
       end
+      def check_redundant_unsafe(node)
+        return unless @sema_facts
+        return if @sema_facts.required_unsafe_lines.include?(node.line)
+
+        @warnings << Warning.new(
+          path: @path,
+          line: node.line,
+          column: node.column,
+          length: "unsafe".length,
+          code: "redundant-unsafe",
+          message: "unsafe block contains no unsafe operations and can be removed",
+          severity: :hint,
+        )
+      end
+
       def visit_type_argument(argument)
         visit_expression(argument.value) if argument.respond_to?(:value)
       end

data/lib/milk_tea/tooling/linter.rb

@@ -22,17 +22,17 @@ module MilkTea
       borrow-and-mutate
       constant-condition
       dead-assignment
-      duplicate-if-condition
       directional-ffi-arg
       doc-tag
+      duplicate-if-condition
       event-capacity
       line-too-long
       loop-single-iteration
       missing-return
       noop-compound-assignment
-      platform-api-drift
-      owning-release-leak
       owning-release-double
+      owning-release-leak
+      platform-api-drift
       prefer-conditional-expression
       prefer-inline-if
       prefer-inline-methods
@@ -51,6 +51,7 @@ module MilkTea
       redundant-null-check
       redundant-return
       redundant-type-annotation
+      redundant-unsafe
       reserved-primitive-name
       self-assignment
       self-comparison

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mt-lang
 version: !ruby/object:Gem::Version
-  version: 0.4.21
+  version: 0.4.22
 platform: ruby
 authors:
 - Long (Teefan) Tran
@@ -630,7 +630,7 @@ metadata:
   homepage_uri: https://teefan.github.io/mt-lang/
   source_code_uri: https://github.com/teefan/mt-lang
 post_install_message: |
-  Milk Tea 0.4.21 installed!
+  Milk Tea 0.4.22 installed!
 
   System requirements:
     - A C compiler (gcc or clang) must be available on PATH