msgpack 1.2.7 → 1.2.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c7d0ed046cdf407e2d23286375ec7b544cc35044f3bd4ee9835eeaa0b4aa172f
-  data.tar.gz: 76eeff0a8e1caa4f81628caa825104911e497a6caa472e2c6945b52f816d2f7d
+  metadata.gz: f31e84bcc8d6fef7755049b694d836b576e33610959fc0ae03fc10fa3ceb223b
+  data.tar.gz: 408fecaf30c2e422ece1efea43ca0fd986d77fce5345c1f6a98678ac2b7efcd1
 SHA512:
-  metadata.gz: 6b1f71db6217e6285c90f5329af40d89ddf8a305e5ea71ea479cb0b930fd88f886be28a1109aea2c48e4a2dd52930e4a28dcfc299d64f6d574d7a5f451f385af
-  data.tar.gz: 96f4af2162e098d1c7469359e4c1034f47762f88a02c904c2d04ce32fa80e2a74004d2e343ae142deb955566891844648be420b46dcb02e86f5e94fd4abd72cc
+  metadata.gz: e09bc22eef0cc0878d9a057cc0b168ad3b4bd9f7c315460f37dc0dfc05bc76fa47c418adc82a4f3477228652501682748969ccd530bbf4a9c24293cfa508aef2
+  data.tar.gz: aa4b29c967d98cfb1216c7ed7669c5459ae245abc225b6bf726badd44edde1156002f8aed958f39ee41e388c2b3a3b4f70e85fc0aaf27e2971d0b87b91da8e33

data/ChangeLog

@@ -1,3 +1,8 @@
+2019-03-11 version 1.2.8:
+
+* Fix a regression that MessagePack#unpack raises error if IO is assigned as the (only) argument
+* Improve compatibility that MessagePack#pack returns nil if IO is assigned as 2nd argument
+
 2019-03-01 version 1.2.7:
 
 * Add Packer#write_bin and Packer#write_bin_header methods

data/doclib/msgpack.rb

@@ -12,7 +12,7 @@ module MessagePack
   #   @param obj [Object] object to be serialized
   #   @param io [IO]
   #   @param options [Hash]
-  #   @return [IO]
+  #   @return [nil]
   #
   # See Packer#initialize for supported options.
   #
@@ -31,7 +31,7 @@ module MessagePack
   #   @param obj [Object] object to be serialized
   #   @param io [IO]
   #   @param options [Hash]
-  #   @return [IO]
+  #   @return [nil]
   #
   # See Packer#initialize for supported options.
   #

data/ext/java/org/msgpack/jruby/Buffer.java

@@ -179,6 +179,10 @@ public class Buffer extends RubyObject {
     return skipCommon(ctx, length, true);
   }
 
+  public boolean hasIo() {
+    return io != null;
+  }
+
   @JRubyMethod(name = "to_s", alias = {"to_str"})
   public IRubyObject toS(ThreadContext ctx) {
     ensureReadMode();

data/ext/java/org/msgpack/jruby/Factory.java

@@ -54,7 +54,7 @@ public class Factory extends RubyObject {
     return Packer.newPacker(ctx, extensionRegistry(), hasSymbolExtType, args);
   }
 
-  @JRubyMethod(name = "unpacker", optional = 1)
+  @JRubyMethod(name = "unpacker", optional = 2)
   public Unpacker unpacker(ThreadContext ctx, IRubyObject[] args) {
     return Unpacker.newUnpacker(ctx, extensionRegistry(), args);
   }

data/ext/java/org/msgpack/jruby/Packer.java

@@ -229,6 +229,9 @@ public class Packer extends RubyObject {
 
   @JRubyMethod(name = "full_pack")
   public IRubyObject fullPack(ThreadContext ctx) {
+    if (buffer.hasIo()) {
+      return null;
+    }
     return toS(ctx);
   }
 

data/lib/msgpack.rb

@@ -20,15 +20,16 @@ require "msgpack/core_ext"
 
 module MessagePack
   DefaultFactory = MessagePack::Factory.new
+  DEFAULT_EMPTY_PARAMS = {}.freeze
 
   def load(src, param = nil)
     unpacker = nil
 
     if src.is_a? String
-      unpacker = DefaultFactory.unpacker param
+      unpacker = DefaultFactory.unpacker param || DEFAULT_EMPTY_PARAMS
       unpacker.feed src
     else
-      unpacker = DefaultFactory.unpacker src, param
+      unpacker = DefaultFactory.unpacker src, param || DEFAULT_EMPTY_PARAMS
     end
 
     unpacker.full_unpack

data/lib/msgpack/version.rb

@@ -1,5 +1,5 @@
 module MessagePack
-  VERSION = "1.2.7"
+  VERSION = "1.2.8"
 
   # NOTE for msgpack-ruby maintainer:
   # Check these things to release new binaryes for new Ruby versions (especially for Windows):

data/spec/msgpack_spec.rb

@@ -168,4 +168,47 @@ describe MessagePack do
       end
     end
   end
+
+  context 'when the source is na IO-like object' do
+    require 'tempfile'
+    require 'stringio'
+
+    it 'work with IO destination object as 2nd argument of MessagePack.pack' do
+      Tempfile.create("pack-test") do |io|
+        return_value = MessagePack.pack(utf8enc('hello world'), io)
+        return_value.should be_nil
+
+        io.rewind
+        io.read.force_encoding(Encoding::ASCII_8BIT).should eq("\xABhello world".force_encoding(Encoding::ASCII_8BIT))
+      end
+    end
+
+    it 'work with IO-like StringIO destination object as 2nd argument of MessagePack.pack' do
+      io = StringIO.new
+      return_value = MessagePack.pack(utf8enc('hello world'), io)
+      return_value.should be_nil
+
+      io.rewind
+      io.read.force_encoding(Encoding::ASCII_8BIT).should eq("\xABhello world".force_encoding(Encoding::ASCII_8BIT))
+    end
+
+    it 'work with IO source object as source of MessagePack.unpack' do
+      Tempfile.create("unpack-test") do |io|
+        MessagePack.pack(utf8enc('hello world'), io)
+        io.rewind
+
+        return_value = MessagePack.unpack(io)
+        return_value.should eq(utf8enc('hello world'))
+      end
+    end
+
+    it 'work with IO-like StringIO object of MessagePack.unpack' do
+      io = StringIO.new
+      MessagePack.pack(utf8enc('hello world'), io)
+      io.rewind
+
+      return_value = MessagePack.unpack(io)
+      return_value.should eq(utf8enc('hello world'))
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: msgpack
 version: !ruby/object:Gem::Version
-  version: 1.2.7
+  version: 1.2.8
 platform: ruby
 authors:
 - Sadayuki Furuhashi
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-01 00:00:00.000000000 Z
+date: 2019-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler